Project

General

Profile

Actions

Bug #9644

closed

Double-free in crypto tests on failure

Added by Jason King about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tests
Start date:
2018-07-06
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

Upstream of Joyent OS-6924.

During the testing of OS-6325, it was discovered that if the get_hsession_by_mech function fails (such as due to an unsupported mechanism), it will free the crypto_op_t struct, which will then get freed again at the end of test_encrypt_common.

Actions #1

Updated by Electric Monk about 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 3c4342ab5aea1aeb83d0d4e34d215f0e113daba1

commit  3c4342ab5aea1aeb83d0d4e34d215f0e113daba1
Author: Jason King <jason.king@joyent.com>
Date:   2018-07-12T23:39:37.000Z

    9644 Double-free in crypto tests on failure
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Mike Zeller <mike.zeller@joyent.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Andrew Stormont <astormont@racktopsystems.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Gordon Ross <gwr@nexenta.com>

Actions

Also available in: Atom PDF