Project

General

Profile

Actions

Bug #9657

closed

sendfile(3ext): off and EINVAL are not documented properly

Added by Marcel Telka over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
manpage - manual pages
Start date:
2018-07-16
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

There are two minor issues in the sendfile(3ext) man pages:

  1. It is documented that the offset is updated on success only, but the actual implementation updates the off parameter even on failure.
  2. The sendfile(3ext) will fail with EINVAL in a case we attempt to send bytes past end of file (IOW, fewer bytes were transferred than were requested).

The man page for sendfile(3ext) should be updated to cover both undocumented cases above.

Actions #2

Updated by Marcel Telka over 3 years ago

  • Status changed from In Progress to Pending RTI
Actions #3

Updated by Electric Monk over 3 years ago

  • Status changed from Pending RTI to Closed
  • % Done changed from 0 to 100

git commit d3811b6fb7218c4fd6a4ecc171217022e137b5dc

commit  d3811b6fb7218c4fd6a4ecc171217022e137b5dc
Author: Marcel Telka <marcel@telka.sk>
Date:   2018-07-20T15:46:02.000Z

    9657 sendfile(3ext): off and EINVAL are not documented properly
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF