Project

General

Profile

Actions

Bug #9670

open

nfs: FATTR4_FILES_XXX used multiple times in rfs4_op_readdir

Added by Vitaliy Gusev about 4 years ago.

Status:
New
Priority:
Normal
Assignee:
Category:
nfs - NFS server and client
Start date:
2018-07-23
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

NFS server part.

In usr/src/uts/common/fs/nfs/nfs4_srv_readdir.c, lines: 514-520, 744-749, 754-759.

Code looks like:

          if (ar &
            (FATTR4_FILES_AVAIL_MASK |
            FATTR4_FILES_FREE_MASK |
            FATTR4_FILES_TOTAL_MASK |
            FATTR4_FILES_AVAIL_MASK |
            FATTR4_FILES_FREE_MASK |
            FATTR4_FILES_TOTAL_MASK)) 

Macro constants used multiple times in this expression:
2x FATTR4_FILES_AVAIL_MASK,
2x FATTR4_FILES_FREE_MASK and
2x FATTR4_FILES_TOTAL_MASK.

It seems like a typo-ed NFS4_FS_ATTR_MASK macro from nfs4_attr.h:171

Found by Gergő Mihály Doma <> in https://www.illumos.org/rb/r/436/

No data to display

Actions

Also available in: Atom PDF