illumos gate

Jonathan's testing notes:

I tested the proposed fix against all versions of 32-bit, 32-bit largefile, and 64-bit, and confirmed that the patch fixes the 32-bit largefile case while unaffecting the other cases. I performed a full smartos-live build with the change, and mounted the modified 32-bit and 64-bit libc.so.1 as well as fts.h into a joyent_20180730T090356Z chroot.

I used both NetBSD pax (the source of the original bug report) as well as a small test case I wrote while verifying this bug.

#include <sys/types.h>
#include <sys/stat.h>
#include <fts.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

static FTS *ftsp = NULL;
static FTSENT *ftent = NULL;
static int ftsopts = 0;

int
main()
{
    char *patharr[2];

    patharr[0] = strdup("/var/tmp");
    patharr[1] = NULL;

    if ((ftsp = fts_open(patharr, ftsopts, NULL)) == NULL) {
        perror("fts_open");
        exit(1);
    }

    for (;;) {
        if ((ftent = fts_read(ftsp)) == NULL)
            break;

        printf("%s = %d\n", ftent->fts_name, ftent->fts_info);
    }
}