Project

General

Profile

Actions

Bug #9712

closed

libstand: netif.c variable set but not used

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2018-08-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

Build without warning suppression did reveal:

    /code/illumos-gate/usr/src/boot/lib/libstand/netif.c: In function 'netif_select':
    /code/illumos-gate/usr/src/boot/lib/libstand/netif.c:93:12: error: variable 'unit_done' set but not used [-Werror=unused-but-set-variable]
      int d, u, unit_done, s;
                ^~~~~~~~~
    cc1: all warnings being treated as errors

Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 27d539f2d4b4c40e9fc667f8b1319ed290c6e4b3

commit  27d539f2d4b4c40e9fc667f8b1319ed290c6e4b3
Author: Toomas Soome <tsoome@me.com>
Date:   2018-08-09T15:05:58.000Z

    9712 libstand: netif.c variable set but not used
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Sebastian Wiedenroth <sebastian.wiedenroth@skylime.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF