Project

General

Profile

Actions

Bug #9725

closed

getent has unused variables and implicit function declarations

Added by Peter Tribble over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
cmd - userland programs
Start date:
2018-08-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage
Gerrit CR:

Description

In usr/src/cmd/getent/Makefile, we see

CERRWARN += -_gcc=-Wno-unused-variable
CERRWARN += -_gcc=-Wno-implicit-function-declaration

which is masking the following errors:

dogetnetmask.c: In function 'dogetnetmask':
dogetnetmask.c:73: error: implicit declaration of function 'getnetmaskbyaddr' [-Wimplicit-function-declaration]

dogetnetmask.c: In function 'putnetmask':
dogetnetmask.c:44: error: unused variable 'p' [-Wunused-variable]

dogetsp.c: In function 'dogetsp':
dogetsp.c:44: error: unused variable 'uid' [-Wunused-variable]
dogetsp.c:43: error: unused variable 'ptr' [-Wunused-variable]

Actions #1

Updated by Electric Monk over 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 2c5ec7a875dcd76853e6618614e990f1e8cdd56d

commit  2c5ec7a875dcd76853e6618614e990f1e8cdd56d
Author: Peter Tribble <peter.tribble@gmail.com>
Date:   2018-08-13T18:57:38.000Z

    9725 getent has unused variables and implicit function declarations
    Reviewed by: Sebastian Wiedenroth <wiedi@frubar.net>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF