Project

General

Profile

Bug #9764

loader.efi: 'efi_mmap' is used uninitialized

Added by Toomas Soome over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2018-08-24
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

With warnings enabled:

    ../memmap.c: In function 'efi_getsmap':
    ../memmap.c:84:9: warning: 'efi_mmap' is used uninitialized in this function [-Wuninitialized]
      status = BS->GetMemoryMap(&size, efi_mmap, &key, &desc_size, NULL);
      ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This should not really be an issue because we do pass size = 0 to query for map size, but better play safe there and set efi_mmap to NULL.

#1

Updated by Electric Monk over 2 years ago

  • % Done changed from 90 to 100
  • Status changed from In Progress to Closed

git commit 522e4551ca5d7b72fe4d4af1ff92521ab19842c7

commit  522e4551ca5d7b72fe4d4af1ff92521ab19842c7
Author: Toomas Soome <tsoome@me.com>
Date:   2018-08-28T18:53:02.000Z

    9764 loader.efi: 'efi_mmap' is used uninitialized
    Reviewed by: Marcel Telka <marcel@telka.sk>
    Reviewed by: Alexander Pyhalov <apyhalov@gmail.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF