Project

General

Profile

Bug #9766

loader: 'mbi' may be used uninitialized

Added by Toomas Soome over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2018-08-24
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

gcc warning:

    ../../../common/multiboot2.c: In function 'multiboot2_exec':
    ../../../common/multiboot2.c:1297:3: warning: 'mbi' may be used uninitialized in this function [-Wmaybe-uninitialized]
       efi_free_loadaddr((vm_offset_t)mbi, EFI_SIZE_TO_PAGES(size));
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Better initialize mbi.

#1

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 322e343b7c538c565d91cb11d00fbe6266834e28

commit  322e343b7c538c565d91cb11d00fbe6266834e28
Author: Toomas Soome <tsoome@me.com>
Date:   2018-08-28T23:41:21.000Z

    9766 loader: 'mbi' may be used uninitialized
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.co.uk>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF