Project

General

Profile

Bug #9773

loader.efi: parity and stop bits switches are missing default case

Added by Toomas Soome over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2018-08-27
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

Build error after warnings enabled:

    ../comconsole.c: In function 'comc_asprint_mode':
    ../comconsole.c:330:2: warning: enumeration value 'DefaultParity' not handled in switch [-Wswitch]
      switch (sp->parity) {
      ^~~~~~
    ../comconsole.c:330:2: warning: enumeration value 'MarkParity' not handled in switch [-Wswitch]
    ../comconsole.c:330:2: warning: enumeration value 'SpaceParity' not handled in switch [-Wswitch]
    ../comconsole.c:338:2: warning: enumeration value 'DefaultStopBits' not handled in switch [-Wswitch]
      switch (sp->stopbits) {
      ^~~~~~
    ../comconsole.c:338:2: warning: enumeration value 'OneFiveStopBits' not handled in switch [-Wswitch]

To fix, implement Mark, Odd and Space parity, add 1.5 stop bits support and while there, 5 and 6 data bits support - translate hw setting to environment variable and vice versa.

#1

Updated by Toomas Soome over 2 years ago

  • Status changed from Pending RTI to In Progress
#2

Updated by Toomas Soome over 2 years ago

  • Description updated (diff)
#3

Updated by Electric Monk over 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit cbae61951b3562e1b0233a21ac0b7d871a31e4f8

commit  cbae61951b3562e1b0233a21ac0b7d871a31e4f8
Author: Toomas Soome <tsoome@me.com>
Date:   2018-10-25T12:47:28.000Z

    9773 loader.efi: parity and stop bits switches are missing default case
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Garrett D'Amore <garrett@damore.org>

Also available in: Atom PDF