remove bogus casts from PCI_CAP_PUTx and PCI_XCAP_PUTx definitions
The macros PCI_CAP_PUTx() and PCI_XCAP_PUTx() as defined in pci_cap.h cast the value returned by pci_cap_put() to an uint of the same size as the value passed. This completely bogus as pci_cap_put() only returns DDI_FAILURE or DDI_SUCCESS through an int.
Updated by Hans Rosenfeld about 1 year ago
Testing: This has been in illumos-joyent since early 2018. The testing I've done back then consisted of just a build and boot with this change. As no callers of the changed macros in gate use the returned values I didn't bother doing a wsdiff or any other checks.
Updated by Electric Monk about 1 year ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit d4990cfc1b590b32a5100dd746688eb2e1b9901f Author: Hans Rosenfeld <email@example.com> Date: 2020-02-19T13:30:19.000Z 9794 remove bogus casts from PCI_CAP_PUTx and PCI_XCAP_PUTx definitions Reviewed by: Patrick Mooney <firstname.lastname@example.org> Reviewed by: Jerry Jelinek <email@example.com> Reviewed by: Mike Gerdts <firstname.lastname@example.org> Reviewed by: Matthias Scheler <email@example.com> Approved by: Robert Mustacchi <firstname.lastname@example.org>