Project

General

Profile

Actions
Copy link

Bug #9796

closed

want support for PCI BAR size >= 4G

Added by Hans Rosenfeld about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Hans Rosenfeld
Category:
-
Start date:
2018-09-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

Some nVIDIA GPUs have map all their RAM into a single BAR, which may be 16G. The code in i86pc/io/pci/pci_boot.c just ignores those BARs, which it really shouldn't.

Actions
Copy link
 #1

Updated by Hans Rosenfeld about 5 years ago

I ran this code on my test machine and verified that all the devices are still there and the prtconf -v output didn't change. I also checked that the memory lists in pci_bus_res still look sane. I checked that a system with two GPUs each with a 16GB BAR would work as expected.

Actions
Copy link
 #2

Updated by Electric Monk almost 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit b5cf5bc277244cdacc06d213322ec98e76ef8d89

commit  b5cf5bc277244cdacc06d213322ec98e76ef8d89
Author: Hans Rosenfeld <hans.rosenfeld@joyent.com>
Date:   2018-09-26T19:30:14.000Z

    9796 want support for PCI BAR size >= 4G
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Andy Fiddaman <omnios@citrus-it.net>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Approved by: Garrett D'Amore <garrett@damore.org>

Actions
Copy link

Also available in: Atom PDF