Project

General

Profile

Feature #9807

FPU related cpuid checks shouldn't be Intel only

Added by Robert Mustacchi about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
kernel
Start date:
2018-09-09
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:

Description

Right now we have a number of cpuid related checks that are checking for support for features like BMI, AVX2, etc. These are set to be Intel only, which should change since AMD also supports these features.

To test this, I verified that we now detect the following instruction sets in a combination of isainfo and ::x86_featureset:
  • xsaveopt
  • xsavec
  • xsaves
  • adx
  • rdseed
  • bmi1
  • bmi2
  • avx2

SMAP and SMEP are also coming along for the ride.

History

#1

Updated by Electric Monk about 1 year ago

  • Status changed from New to Closed

git commit 74ac317bda4d359a4ab9c3a0e6bbb6464e0225f1

commit  74ac317bda4d359a4ab9c3a0e6bbb6464e0225f1
Author: Robert Mustacchi <rm@joyent.com>
Date:   2018-09-19T15:16:49.000Z

    9807 FPU related cpuid checks shouldn't be Intel only
    9808 AMD EPYC doesn't need *save_ctxt FP exceptions
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: John Levon <john.levon@joyent.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>

Also available in: Atom PDF