ses topo module should use topo_mod_clean_str()
The commit below introduced a new libtopo module API for cleaning up strings ready from hardware: topo_mod_clean_str()
commit 6d65bee7bcc62b2d9bdfde6610561ce76c92a908 Author: Rob Johnston <firstname.lastname@example.org> Date: Wed Aug 22 10:47:22 2018 -0700 9459 Implement topo module to enumerate dimms from smbios Reviewed by: Yuri Pankov <email@example.com> Reviewed by: Igor Kozhukhov <firstname.lastname@example.org> Approved by: Richard Lowe <email@example.com>
The ses topo module implements a function disk_auth_clean() that effectively duplicates this functionality. To reduce code duplication, disk_auth_clean() should be removed and places that called it should be modified to call topo_mod_clean_str().
Updated by Rob Johnston almost 2 years ago
Took topo snapshots (using fmtopo) on multiple machines in the joyent lab and on mu OI workstation at home and verified that the FRU identity strings read from the drives were cleaned, where necessary of trailing and leading whitespace and illegal characters were converted to "-".
Updated by Electric Monk almost 2 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
commit cbb9248e66a77c6382c6f48aebae5fd0ee60fa69 Author: Rob Johnston <firstname.lastname@example.org> Date: 2018-09-18T16:57:51.000Z 9835 ses topo module should use topo_mod_clean_str() Reviewed by: Yuri Pankov <email@example.com> Reviewed by: Igor Kozhukhov <firstname.lastname@example.org> Approved by: Dan McDonald <email@example.com>