Project

General

Profile

Bug #9867

pbchk exception_lists only work from top srcdir

Added by John Levon about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Start date:
2018-10-04
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

oi:mandoc $ grep mandoc /root/illumos-gate/exception_lists/cstyle 
usr/src/cmd/mandoc
oi:mandoc $ pwd
/root/illumos-gate/usr/src/cmd/mandoc
oi:mandoc $ git pbchk -c cstyle | head
C style:
html.c: 128: missing space between keyword and paren
html.c: 139: unparenthesized return expression
html.c: 268: unparenthesized return expression
html.c: 273: unparenthesized return expression
html.c: 288: unparenthesized return expression
html.c: 301: unparenthesized return expression
html.c: 311: unparenthesized return expression
html.c: 340: unparenthesized return expression
html.c: 342: unparenthesized return expression
oi:mandoc $ cd $SRC/../../
oi:illumos-gate $ git pbchk -c cstyle | head
oi:illumos-gate $ 

This is because we're passing a relative file path into the exclude function in git-pbchk.py

History

#1

Updated by Electric Monk about 1 year ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

git commit 38e36c53e77317894c59b3460770bf73f6707578

commit  38e36c53e77317894c59b3460770bf73f6707578
Author: John Levon <john.levon@joyent.com>
Date:   2018-10-16T15:19:46.000Z

    9867 pbchk exception_lists only work from top srcdir
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF