Actions
Bug #9867
closed
pbchk exception_lists only work from top srcdir
Start date:
2018-10-04
Due date:
% Done:
100%
Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:
Description
oi:mandoc $ grep mandoc /root/illumos-gate/exception_lists/cstyle usr/src/cmd/mandoc oi:mandoc $ pwd /root/illumos-gate/usr/src/cmd/mandoc oi:mandoc $ git pbchk -c cstyle | head C style: html.c: 128: missing space between keyword and paren html.c: 139: unparenthesized return expression html.c: 268: unparenthesized return expression html.c: 273: unparenthesized return expression html.c: 288: unparenthesized return expression html.c: 301: unparenthesized return expression html.c: 311: unparenthesized return expression html.c: 340: unparenthesized return expression html.c: 342: unparenthesized return expression oi:mandoc $ cd $SRC/../../ oi:illumos-gate $ git pbchk -c cstyle | head oi:illumos-gate $
This is because we're passing a relative file path into the exclude function in git-pbchk.py
Updated by Electric Monk almost 5 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
git commit 38e36c53e77317894c59b3460770bf73f6707578
commit 38e36c53e77317894c59b3460770bf73f6707578
Author: John Levon <john.levon@joyent.com>
Date: 2018-10-16T15:19:46.000Z
9867 pbchk exception_lists only work from top srcdir
Reviewed by: Yuri Pankov <yuripv@yuripv.net>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions