Project

General

Profile

Actions

Bug #9887

closed

pkinit_crypto_openssl.c: warnings from newer gcc

Added by Andy Fiddaman over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2018-10-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

There are three warnings generated by gcc7 on OmniOS when building krb5/preauth/pkinit against OpenSSL 1.1

./pkinit_crypto_openssl.c: In function 'pkinit_choose_tokens':
../pkinit_crypto_openssl.c:3865:24: error: comparison between pointer and integer [-Werror]
             while (*cp != NULL) {
                        ^~
../pkinit_crypto_openssl.c: In function 'pkinit_open_session':
../pkinit_crypto_openssl.c:4109:36: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
     CK_SESSION_HANDLE tmpsession = NULL;
                                    ^~~~
../pkinit_crypto_openssl.c: In function 'pkinit_process_td_trusted_certifiers':
../pkinit_crypto_openssl.c:6627:6: error: this 'else' clause does not guard...  -Werror=misleading-indentation]
      else
      ^~~~
../pkinit_crypto_openssl.c:6629:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
   sk_X509_NAME_push(sk_xn, xn);
   ^~~~~~~~~~~~~~~~~

The last error does not show up when building against OpenSSL 1.0 since sk_X509_NAME_push is a macro in 1.0 which expands to a blank line followed by some statements - the blank line resets gcc's guard check.

Actions #2

Updated by Andy Fiddaman over 2 years ago

  • Status changed from New to Pending RTI
  • % Done changed from 0 to 100
Actions #3

Updated by Electric Monk over 2 years ago

  • Status changed from Pending RTI to Closed

git commit 3f8dd771c0f9c6553982e4dbcc5c221b5dcf2489

commit  3f8dd771c0f9c6553982e4dbcc5c221b5dcf2489
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2018-10-11T19:39:39.000Z

    9887 pkinit_crypto_openssl.c: warnings from newer gcc
    Reviewed by: Yuri Pankov <yuri.pankov@nexenta.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Jason King <jason.king@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions

Also available in: Atom PDF