Project

General

Profile

Bug #9889

Bug #9885: zoneadm takes ages to do something on a system with many snapshots

libbe reads defaults too often

Added by Andy Fiddaman over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Andy Fiddaman
Category:
lib - userland libraries
Start date:
2018-10-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

When enumerating filesystems and snapshots, libbe reads the /etc/default/be file every time the callback is entered. It should cache this.

# truss -flea -t open beadm list 2>&1 | grep -c /etc/default/be
20991
LD_LIBRARY_PATH=. truss -flea -t open beadm list 2>&1 | grep -c /etc/default/be
truss -flea -t open beadm list 2>&1 | grep -c /etc/default/be
6
#2

Updated by Andy Fiddaman over 2 years ago

  • Status changed from New to Pending RTI
  • % Done changed from 0 to 100
#3

Updated by Electric Monk over 2 years ago

  • Status changed from Pending RTI to Closed

git commit abc102c3e125a6b08c1d5b54449c08b53b45978a

commit  abc102c3e125a6b08c1d5b54449c08b53b45978a
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2018-10-17T13:57:09.000Z

    9889 libbe reads defaults too often
    Reviewed by: Dominik Hassler <hadfl@omniosce.org>
    Reviewed by: Igor Kozhukhov <igor@dilos.org>
    Reviewed by: Jim Klimov <jim@cos.ru>
    Reviewed by: Andy Stormont <astormont@racktopsystems.com>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Also available in: Atom PDF