Project

General

Profile

Actions

Feature #9892

closed

Bug #9885: zoneadm takes ages to do something on a system with many snapshots

Most consumers of be_list() do not need snapshots

Added by Andy Fiddaman about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
lib - userland libraries
Start date:
2018-10-12
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

In particular, on a system with many BE snapshots this slows down most beadm and bootadm operations significantly, see #9885

Actions #1

Updated by Andy Fiddaman about 3 years ago

Testing a fix:

omni# for f in `seq 1 3`; do
for> time beadm list -H > /dev/null
for> done
beadm list -H > /dev/null  5.89s user 45.26s system 99% cpu 51.159 total
beadm list -H > /dev/null  5.85s user 44.89s system 99% cpu 50.756 total
beadm list -H > /dev/null  5.91s user 45.10s system 99% cpu 51.019 total
omni# export LD_LIBRARY_PATH=/l

omni# for f in `seq 1 3`; do
time /l/beadm list -H > /dev/null
done
./beadm list -H > /dev/null  0.00s user 0.08s system 87% cpu 0.092 total
./beadm list -H > /dev/null  0.00s user 0.08s system 87% cpu 0.092 total
./beadm list -H > /dev/null  0.00s user 0.08s system 88% cpu 0.090 total
Actions #3

Updated by Andy Fiddaman about 3 years ago

  • Status changed from New to In Progress
  • % Done changed from 80 to 100

Pending RTI

Actions #4

Updated by Electric Monk about 3 years ago

  • Status changed from In Progress to Closed

git commit a897f28bdf15b072de311fba1dadf86da4f4b420

commit  a897f28bdf15b072de311fba1dadf86da4f4b420
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2018-10-17T13:58:08.000Z

    9892 Most consumers of be_list() do not need snapshots
    Reviewed by: Dominik Hassler <hadfl@omniosce.org>
    Reviewed by: Garrett D'Amore <garrett@damore.org>
    Reviewed by: Jim Klimov <jim@cos.ru>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Approved by: Gordon Ross <gordon.w.ross@gmail.com>

Actions

Also available in: Atom PDF