Project

General

Profile

Feature #9899

cw(1onbld) should shadow more compilation

Added by Rich Lowe almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
2018-10-15
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:

Description

At present, cw(1onbld) doesn't shadow any compilation that invokes the link-editor. Even if sources are specified. This means simple commands compiled simply (gcc cat.c -o cat) are not shadowed.

We should change it such that any invocation involving a non-object file should be shadowed.

History

#1

Updated by Electric Monk almost 2 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

git commit d0843a33a8ba49c316537132aa23e7df6d6fc64b

commit  d0843a33a8ba49c316537132aa23e7df6d6fc64b
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2018-10-22T20:13:24.000Z

    9899 cw(1onbld) should shadow more compilation
    9888 cw shouldn't use __unused
    Reviewed by: Toomas Soome <tsoome@me.com>
    Reviewed by: Dan McDonald <danmcd@joyent.com>
    Reviewed by: Yuri Pankov <yuripv@yuripv.net>
    Approved by: Gordon Ross <gwr@nexenta.com>

#2

Updated by Electric Monk over 1 year ago

git commit 88e61e85cc7078a2b481258cf9441eeee7ff548d

commit  88e61e85cc7078a2b481258cf9441eeee7ff548d
Author: Richard Lowe <richlowe@richlowe.net>
Date:   2019-01-31T01:37:40.000Z

    9899 cw(1onbld) should shadow more compilation
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

Also available in: Atom PDF