illumos gate

gcc 8 build of ip module is complaining:

../../common/inet/ip/ip_squeue.c: In function 'ip_squeue_add_ring':
../../common/inet/ip/ip_squeue.c:511:19: error: cast between incompatible function types from 'mac_receive_t' {aka 'struct msgb * (*)(void *, int)'} to 'mblk_t * (*)(void *, size_t)' {aka 'struct msgb * (*)(void *, long unsigned int)'} [-Werror=cast-function-type]
  rx_ring->rr_rx = (ip_mac_rx_t)mrfp->mrf_receive;
                   ^

Investigating the issue revealed that this is the link between ip and mac modules, and we are in fact relying on type mac_receive_t and the implementation of mac_soft_ring_poll() function.
There is apparent bug, the ip module is using size_t for bytes_to_pickup while mac_soft_ring_poll is defined to int mac_soft_ring_poll, but the mac_soft_ring_poll() is using argument to compare other variables of type size_t. Therefore mac_soft_ring_poll() should in fact be defined as mac_soft_ring_poll(mac_soft_ring_t *ringp, size_t bytes_to_pickup). Also the ip module is calling this function with argument with type of size_t.