Actions
Bug #9941
closed
Noise from cfgadm plugins
Start date:
2018-10-31
Due date:
% Done:
100%
Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:
External Bug:
Description
The sata, ib and usb cfgadm plugins generate output noise when an unknown option is provided to cfgadm -l, for example:
omni# cfgadm -l -o test sata3/0 cfga_msg: NULL msgp cfga_msg: NULL msgp cfga_msg: NULL msgp cfga_msg: NULL msgp cfga_msg: NULL msgp cfga_msg: NULL msgp cfga_msg: NULL msgp cfga_msg: NULL msgp cfga_msg: NULL msgp cfga_msg: NULL msgp cfga_msg: NULL msgp cfgadm: Hardware specific failure: Hardware specific option not supported zsh: exit 1 cfgadm -l -o test sata3/0
or a real world case:
# cfgadm -al -o show_FCP_dev cfga_msg: NULL msgp cfga_msg: NULL msgp ... repeated many times ... cfga_msg: NULL msgp cfga_msg: NULL msgp Ap_Id Type Receptacle Occupant Condition c3 fc connected unconfigured unknown c4 fc connected unconfigured unknown
This is because the modules call `cfga_help(NULL, ...)` which never succeeds as a NULL first argument is not supported. Other plugins such as scsi do not do this.
Updated by Andy Fiddaman almost 4 years ago
Testing notes¶
After the patch from reviewboard:
omni# cfgadm -l -o test sata3/0 cfgadm: Hardware specific failure: Hardware specific option not supported omni# cfgadm -al -o show_FCP_dev cfgadm: Configuration administration not supported
Updated by Andy Fiddaman almost 4 years ago
- Status changed from New to Pending RTI
- % Done changed from 80 to 100
Updated by Electric Monk almost 4 years ago
- Status changed from Pending RTI to Closed
git commit cf25223258f3cd568605b3e10c1432e5e93b2c5e
commit cf25223258f3cd568605b3e10c1432e5e93b2c5e
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date: 2018-11-06T19:23:00.000Z
9941 Noise from cfgadm plugins
Reviewed by: Toomas Soome <tsoome@me.com>
Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions