Project

General

Profile

Actions
Copy link

Bug #9942

closed

zone secflags are not initialized correctly

Added by John Levon almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Levon
Category:
-
Start date:
2018-10-31
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage
Gerrit CR:
External Bug:

Description

As per Joyent OS-7339:

zone_create() currently has:

5134 secflags_zero(&zone0.zone_secflags.psf_lower);
5135 secflags_zero(&zone0.zone_secflags.psf_effective);
5136 secflags_zero(&zone0.zone_secflags.psf_inherit);
5137 secflags_fullset(&zone0.zone_secflags.psf_upper);

which appears to be a copy and paste error. Let's use psecflags_default().

It doesn't appear to matter much as zoneadmd will update the sec flags, but...

Actions
Copy link
 #1

Updated by Electric Monk almost 5 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

git commit 2918c4a32d09a835c1eba8b0b02fe1dcb7a83175

commit  2918c4a32d09a835c1eba8b0b02fe1dcb7a83175
Author: John Levon <john.levon@joyent.com>
Date:   2018-11-21T20:07:44.000Z

    9936 atomic ops in syscall_mstate() induce significant overhead
    9942 zone secflags are not initialized correctly
    Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
    Reviewed by: Andy Fiddaman <andy@omniosce.org>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Richard Lowe <richlowe@richlowe.net>

Actions
Copy link

Also available in: Atom PDF