Actions
Bug #9954
closed
loader: always set media size from partition.
Start date:
2018-11-05
Due date:
% Done:
100%
Estimated time:
(Total: 0.00 h)
Difficulty:
Medium
Tags:
Gerrit CR:
External Bug:
Description
The disk access is validated by using partition table definitions, therefore
we have no need for if statements, just set the disk size.
Of course the partition table itself may be incorrect/inconsistent, but if
so, we are in trouble anyhow.
Testing done: this patch has been on loader branch since march 15 2017, it has been in every image I have built since. No related issues reported. Also this one + next major biosdisk patch (due to dependency tree) have specifically been tested in some “weird” behaving systems and finally, I did commit it in FreeBSD Current https://svnweb.freebsd.org/base?view=revision&revision=340215
Updated by
Updated by Electric Monk about 4 years ago
- Status changed from In Progress to Closed
git commit 124619e5421ff751660c822c15c320ddf7800a5a
commit 124619e5421ff751660c822c15c320ddf7800a5a
Author: Toomas Soome <tsoome@me.com>
Date: 2018-11-09T15:05:56.000Z
9954 loader: always set media size from partition.
Reviewed by: C Fraire <cfraire@me.com>
Reviewed by: Andy Fiddaman <andy@omniosce.org>
Approved by: Dan McDonald <danmcd@joyent.com>
Actions