Project

General

Profile

Actions

Bug #9954

closed

loader: always set media size from partition.

Added by Toomas Soome over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2018-11-05
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The disk access is validated by using partition table definitions, therefore
we have no need for if statements, just set the disk size.

Of course the partition table itself may be incorrect/inconsistent, but if
so, we are in trouble anyhow.

Testing done: this patch has been on loader branch since march 15 2017, it has been in every image I have built since. No related issues reported. Also this one + next major biosdisk patch (due to dependency tree) have specifically been tested in some “weird” behaving systems and finally, I did commit it in FreeBSD Current https://svnweb.freebsd.org/base?view=revision&revision=340215


Subtasks 1 (0 open1 closed)

Bug #9956: loader: create separate lists for fd, cd and hd, merge bioscd with biosdiskClosedToomas Soome2018-11-05

Actions
Actions

Also available in: Atom PDF