Project

General

Profile

Actions

Bug #9957

closed

mate-about-me can't change user password

Added by Alexander Pyhalov about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Category:
-
Target version:
-
Start date:
2018-11-06
Due date:
% Done:

0%

Estimated time:
Difficulty:
Medium
Tags:
needs-triage

Description

When user clicks 'change password' button in mate-about-me application, dialog hangs.

The reason is that mate-about-me tries to launch /usr/bin/passwd and interact with it via stdin/stdout, but our passwd uses pam to get user password.
PAM tries to read password from terminal and either fails to open it or reads it from /dev/tty, where it's unexpected from mate-about-me.

To fix it we should launch passwd in virtual terminal and communicate with it via master fd of the terminal.

Actions #1

Updated by Alexander Pyhalov about 4 years ago

Additional issue is that mate-about-me tries to react on all possible errors, and so can fail to diagnose error when gets some unknown message from passwd. To fix this we should teach it common pam_authtok_check.so.1 errors.
They are:

The first %d characters of the password must contain at least N
           alphabetic character(s)
           numeric or special character(s)
           digit(s)
           uppercase alpha character(s)
           lowercase alpha character(s)
Whitespace characters are not allowed.
Too many consecutively repeating characters
The first %d characters of the old and new passwords must differ by at least %d positions.
dictionary database open failure
password is based on a dictionary word
password is based on a reversed dictionary word
Password in history list 

Actions #2

Updated by Alexander Pyhalov about 4 years ago

  • Status changed from New to Resolved

Should be fixed by

From 07130f83730ccb9f9c8e0030cf260864e20e3b38 Mon Sep 17 00:00:00 2001
From: Alexander Pyhalov <apyhalov@gmail.com>
Date: Mon, 19 Nov 2018 17:08:01 +0300
Subject: [PATCH] 9957 mate-about-me can't change user password

Upstream PRs were created:
https://github.com/mate-desktop/mate-control-center/pull/383
https://github.com/mate-desktop/mate-control-center/pull/386
https://github.com/mate-desktop/mate-control-center/pull/387

Actions

Also available in: Atom PDF