Project

General

Profile

Bug #9966

svccfg cleanup crashes on empty manifestfiles property group

Added by Andy Fiddaman about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Andy Fiddaman
Category:
cmd - userland programs
Start date:
2018-11-08
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
Gerrit CR:

Description

bloody# svccfg cleanup
bloody# svccfg -s filesystem/local delpg manifestfiles
bloody# svccfg -s filesystem/local addpg manifestfiles framework
bloody# svccfg cleanup
Delete service svc:/system/filesystem/local as there are no supporting manifests
zsh: IOT instruction (core dumped)  svccfg cleanup

core 'core' of 526:     svccfg cleanup
 fe8170c5 _lwp_kill (1, 6, 0, 1, fed52000, fed305b1) + 15
 fe7a8e6b raise    (6, fee90018, fe777b00, fed52000) + 2b
 fed24257 umem_do_abort (fed52000, 0, 8038b68, fed2671a, fed305b1, fed30833) + 2b
 fed242dd umem_err_recoverable (fed305b1, fed30833, 8038cb4, fed307f1, 83164e8, 827fe68) + 5a
 fed2671a process_free (8038cb4, 1, 0, 0) + bf
 fed26839 umem_malloc_free (8038cb4, 8299cc8, 827fd48, fe93d30f) + 1a
 080779ca lscf_service_cleanup (1, 8038cb4, 275, fe943958) + 8b0
 fe9442bd scf_walk_fmri (8285ac8, 0, 0, 14, 807711a, 1) + 976
 0805c7b0 engine_cleanup (0, 2f, 8038d78, 8085b94) + 40
 08085f85 yyparse  (8298648, 3a10b7f8, 0, 8038e48) + 5c8
 0805d555 engine_exec (8298648, 8093ad8, 800, 0) + 34
 0805c1d7 main     (8038ddc, fe892388, 8038e18, 805bd58, 2, 8038e44) + 144
 0805bd58 _start_crt (2, 8038e44, fefd0d40, 0, 0, 0) + 97
 0805bc2a _start   (2, 8038f58, 8038f5f, 0, 8038f67, 8038f7a) + 1a

> ::umem_status
Status:         ready and active
Concurrency:    32
Logs:           (inactive)
Message buffer:
free(8038cb4): invalid or corrupted buffer
stack trace:
libumem.so.1'umem_err_recoverable+0x4a
libumem.so.1'process_free+0xbf
libumem.so.1'umem_malloc_free+0x1a
svccfg'lscf_service_cleanup+0x8b0
libscf.so.1'scf_walk_fmri+0x976
svccfg'engine_cleanup+0x40
svccfg'yyparse+0x5c8
svccfg'engine_exec+0x34
svccfg'main+0x144
svccfg'_start_crt+0x97
svccfg'_start+0x1a
#2

Updated by Andy Fiddaman about 2 years ago

Testing notes:

before:

bloody# svccfg cleanup
bloody# svccfg -s filesystem/local delpg manifestfiles
bloody# svccfg -s filesystem/local addpg manifestfiles framework
bloody# svccfg cleanup
Delete service svc:/system/filesystem/local as there are no supporting manifests
zsh: IOT instruction (core dumped)  svccfg cleanup

after:

bloody:illumos:master% pfexec svccfg import /lib/svc/manifest/system/filesystem/local-fs.xml
bloody:illumos:master% svcadm refresh filesystem/local
bloody:illumos:master% svccfg cleanup
bloody:illumos:master%
bloody:illumos:master% svccfg -s filesystem/local delpg manifestfiles
bloody:illumos:master% svccfg -s filesystem/local addpg manifestfiles framework
bloody:illumos:master% ./svccfg cleanup
Delete service svc:/system/filesystem/local as there are no supporting manifests
bloody:illumos:master%
#3

Updated by Andy Fiddaman about 2 years ago

  • Status changed from In Progress to Pending RTI
  • % Done changed from 80 to 100
#4

Updated by Electric Monk about 2 years ago

  • Status changed from Pending RTI to Closed

git commit 8571aeda0618a9b2db4736e7fd3461be6959c42e

commit  8571aeda0618a9b2db4736e7fd3461be6959c42e
Author: Andy Fiddaman <omnios@citrus-it.co.uk>
Date:   2018-11-13T01:52:31.000Z

    9966 svccfg cleanup crashes on empty manifestfiles property group
    Reviewed by: Andrew Stormont <andyjstormont@gmail.com>
    Reviewed by: Gergő Mihály Doma <domag02@gmail.com>
    Reviewed by: Toomas Soome <tsoome@me.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF