Project

General

Profile

Bug #9976

boot1.efi: unused functions in zfs_module.c

Added by Toomas Soome about 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bootloader
Start date:
2018-11-11
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:
needs-triage

Description

Warnings enabled:

    In file included from ../zfs_module.c:37:0:
    /code/illumos-gate/usr/src/boot/lib/libstand/zfs/zfsimpl.c:2571:1: error: 'zfs_list_dataset' defined but not used [-Werror=unused-function]
     zfs_list_dataset(const spa_t *spa, uint64_t objnum/*, int pos, char *entry*/)
     ^~~~~~~~~~~~~~~~
    /code/illumos-gate/usr/src/boot/lib/libstand/zfs/zfsimpl.c:2519:1: error: 'zfs_lookup_dataset' defined but not used [-Werror=unused-function]
     zfs_lookup_dataset(const spa_t *spa, const char *name, uint64_t *objnum)
     ^~~~~~~~~~~~~~~~~~
    /code/illumos-gate/usr/src/boot/lib/libstand/zfs/zfsimpl.c:1258:1: error: 'spa_find_by_name' defined but not used [-Werror=unused-function]
     spa_find_by_name(const char *name)
     ^~~~~~~~~~~~~~~~
    /code/illumos-gate/usr/src/boot/lib/libstand/zfs/zfsimpl.c:366:1: error: 'nvlist_print' defined but not used [-Werror=unused-function]
     nvlist_print(const unsigned char *nvlist, unsigned int indent)
     ^~~~~~~~~~~~
    cc1: all warnings being treated as errors

Since we can not do anything about those warnings, we will use compiler flag to disable them.

History

#1

Updated by Toomas Soome about 1 year ago

  • Description updated (diff)
#2

Updated by Electric Monk about 1 year ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 50a7e957ddabb06ba5d141a0642036371031110d

commit  50a7e957ddabb06ba5d141a0642036371031110d
Author: Toomas Soome <tsoome@me.com>
Date:   2018-11-15T22:30:09.000Z

    9976 boot1.efi: unused functions in zfs_module.c
    Reviewed by: Robert Mustacchi <rm@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Also available in: Atom PDF