Project

General

Profile

Feature #9978

env: set gcc 7 as shadow compiler and do not run lint

Added by Toomas Soome 8 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
tools - gate/build tools
Start date:
2018-11-13
Due date:
% Done:

100%

Estimated time:
Difficulty:
Bite-size
Tags:

Description

Since we do have illumos patched gcc 7, and we did clean up our source for gcc6 & gcc 7, and we would very much like to kill the lint, lets start by setting gcc7 as shadow compiler and remove -l from nightly flags.

This means we would not provide default lint build and we do ensure we maintain clean gcc 7 build till the primary compiler switch.


Related issues

Related to illumos gate - Bug #10011: stop building and shipping lint librariesIn Progress2019-01-25

Actions
Related to illumos gate - Feature #9996: use GCC 7 as default primary compilerClosed2018-11-21

Actions

History

#1

Updated by Joshua Clulow 8 months ago

As part of making this change, we'll need to update some of our guidance and documentation:

Presumably this is intended to reflect a project level policy change; i.e., that we won't require lint-clean builds any longer. If we move ahead with that, we'll want to update some of the RTI documentation; e.g.,

Finally, if we are changing the policy here, what happened with the investigation into smatch to replace lint for the handful of checks we do still care about? As I recall, the most prominent check we want to retain through other means is:

  • ignoring a return value without an explicit (void) cast

The smatch thread on the developer list is here: https://illumos.topicbox.com/groups/developer/T9a62d9da8534acdd-M0b91003b8e5da7cff718cd45

#2

Updated by Joshua Clulow 8 months ago

  • Related to Bug #10011: stop building and shipping lint libraries added
#3

Updated by Joshua Clulow 8 months ago

I have removed the aforementioned references to lint from the guides on the wiki.

#4

Updated by Electric Monk 8 months ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit f9008f8deff5da21c46ffed5dff700071bcf884e

commit  f9008f8deff5da21c46ffed5dff700071bcf884e
Author: Toomas Soome <tsoome@me.com>
Date:   2018-11-27T23:31:30.000Z

    9978 env: set gcc 7 as shadow compiler and do not run lint
    Reviewed by: Joshua M. Clulow <josh@sysmgr.org>
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Joshua M. Clulow <josh@sysmgr.org>

#5

Updated by Joshua Clulow 8 months ago

  • Related to Feature #9996: use GCC 7 as default primary compiler added

Also available in: Atom PDF