Project

General

Profile

Actions
Copy link

Bug #9990

closed

loader.efi: check the presence of WaitForKey

Added by Toomas Soome over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toomas Soome
Category:
bootloader
Start date:
2018-11-19
Due date:
% Done:

100%

Estimated time:
Difficulty:
Medium
Tags:
Gerrit CR:

Description

The issue found in FreeBSD. Note the original FreeBSD fix is slightly different, but the code idea is still the same. (and I'll fix upstream soon).

When the EFI implementation (like U-Boot) does not support WaitForKey, we can emulate efi_cons_poll(0 with a flag and caching the last key read with ReadKeyStroke. This fixes the loader.efi countdown timer on Pine64 (and other U-Boot + EFI using platforms).

https://svnweb.freebsd.org/base?view=revision&revision=r305026

Actions
Copy link
 #1

Updated by Electric Monk over 3 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100

git commit 416f8d72824083126c8e231fbb5f4b3a8249ace8

commit  416f8d72824083126c8e231fbb5f4b3a8249ace8
Author: Toomas Soome <tsoome@me.com>
Date:   2018-11-30T02:08:01.000Z

    9990 loader.efi: check the presence of WaitForKey
    Reviewed by: John Levon <john.levon@joyent.com>
    Approved by: Dan McDonald <danmcd@joyent.com>

Actions
Copy link

Also available in: Atom PDF