Project

General

Profile

Bug #9367

Updated by Toomas Soome almost 4 years ago

issue found by gcc 7 build: 
 <pre> 
     ../n1.c: In function 'main': 
     ../n1.c:148:17: error: comparison between pointer and zero character constant [-Werror=pointer-compare] 
          if (argv[0] != '\0') { 
                      ^~ 
     ../n1.c:148:9: note: did you mean to dereference the pointer? 
          if (argv[0] != '\0') { 
              ^ 
     ../n1.c:184:20: error: comparison between pointer and zero character constant [-Werror=pointer-compare] 
         if (&argv[0][2] != '\0' && strlen(&argv[0][2]) >= 2 && &argv[0][3] != '\0') 
                         ^~ 
     ../n1.c:184:8: note: did you mean to dereference the pointer? 
         if (&argv[0][2] != '\0' && strlen(&argv[0][2]) >= 2 && &argv[0][3] != '\0') 
             ^ 
     ../n1.c:184:71: error: comparison between pointer and zero character constant [-Werror=pointer-compare] 
         if (&argv[0][2] != '\0' && strlen(&argv[0][2]) >= 2 && &argv[0][3] != '\0') 
                                                                            ^~ 
     ../n1.c:184:59: note: did you mean to dereference the pointer? 
         if (&argv[0][2] != '\0' && strlen(&argv[0][2]) >= 2 && &argv[0][3] != '\0') 
                                                                ^ 
     ../n1.c:201:28: error: comparison between pointer and zero character constant [-Werror=pointer-compare] 
         if (getenv("TROFFMACS") != '\0') { 
                                 ^~ 
     ../n1.c:201:8: note: did you mean to dereference the pointer? 
         if (getenv("TROFFMACS") != '\0') { 
             ^ 
     cc1: all warnings being treated as errors 
 </pre> 

 For testing, i have used this doc to learn about register use: 

 https://www.gnu.org/software/groff/manual/html_node/Setting-Registers.html 


 So I did call:  
 <pre> 
 nroff -ra2 -man ypwhich.1 | less 
 </pre> 

 And I did add \na just after DESCRIPTION, so the expected outcome was to have ‘2’ printed after the description — and indeed, it was there: 

 <pre> 
      ypwhich -x 


 DESCRIPTION 
      2 
 </pre> 

 The register ‘a’ was created, set to have a value and was usable. 

Back