Project

General

Profile

Bug #13049

Updated by Patrick Mooney almost 2 years ago

Currently, the cstyle script does not handle the FreeBSD license headers as they are attached to files from that code base. 
 For example: 
 <pre> 
 uts/i86pc/io/vmm/vmm.c: 1: improper first line of block comment 
 uts/i86pc/io/vmm/vmm.c: 1: missing blank after open comment 
 uts/i86pc/io/vmm/vmm.c: 4: extra space between function name and left paren 
 uts/i86pc/io/vmm/vmm.c: 21: extra space between function name and left paren 
 uts/i86pc/io/vmm/vmm.c: 24: extra space between function name and left paren 
 </pre> 

 It would be nice if cstyle could be taught to tolerate such headers so we can remove things like bhyve from the exception lists and bring them into compliance. 

 The headers in question look like this: 
 <pre> 
 /*- 
  * SPDX-License-Identifier: BSD-2-Clause-FreeBSD 
  * 
  * Copyright (c) 2011 NetApp, Inc. 
  * All rights reserved. 
  * 
  * Redistribution and use in source and binary forms, with or without 
  * modification, are permitted provided that the following conditions 
  * are met: 
  * 1. Redistributions of source code must retain the above copyright 
  *      notice, this list of conditions and the following disclaimer. 
  * 2. Redistributions in binary form must reproduce the above copyright 
  *      notice, this list of conditions and the following disclaimer in the 
  *      documentation and/or other materials provided with the distribution. 
  * 
  * THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND 
  * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE 
  * ARE DISCLAIMED.    IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE 
  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL 
  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS 
  * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) 
  * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT 
  * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY 
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF 
  * SUCH DAMAGE. 
  * 
  * $FreeBSD$ 
  */ 
 </pre> 

 Tolerating the @/*-@ comment opening style will allow the rest of the cstyle mechanisms to work properly.

Back