Project

General

Profile

Activity

From 2014-12-18 to 2015-01-16

2015-01-16

03:02 PM Bug #453: ZPOOL_CONFIG_ASHIFT not set correctly for drives with large sector size
Hi Eric,
What about your Openindiana release ?
My binary file is only working with 0.151.1.9 (also called b129) , Z...
Jose Mestre
02:25 PM Bug #5531: NULL pointer dereference in dsl_prop_get_ds()
Review available at: https://reviews.csiden.org/r/153/ Justin Gibbs
08:59 AM Bug #3621: ZFS LU stuck in the offlining state
Latest crashdump can be found from http://www.mui.fi/vmdump.0 Markus Kovero
08:07 AM Bug #3621 (Feedback): ZFS LU stuck in the offlining state
I referred to illumos kernel version in hipster. However, even though problem has become much less frequent, it still... Markus Kovero
08:59 AM Bug #5079: panicstr = stmf_svc: I/O deadman hit
Latest crashdump can be found from http://www.mui.fi/vmdump.0 original url's no longer have old dumps. Markus Kovero
08:06 AM Bug #5079: panicstr = stmf_svc: I/O deadman hit
Unfortunately, problem still exists in illumos-f8554bb, although it happens much less frequently than before. I'm upl... Markus Kovero
02:38 AM Bug #5542: devfsadm fails to set usb child device permissions per /etc/minor_perm
I've eliminated at least one possible source of issues by making the following change to /etc/logindevperm:
#/dev/...
Warren V
01:53 AM Bug #5542: devfsadm fails to set usb child device permissions per /etc/minor_perm
Also, I'm not sure why input@5 is being mounted as 755, instead of 666. The only minor_perm entry with 755 is for the... Warren V
01:43 AM Bug #5542 (New): devfsadm fails to set usb child device permissions per /etc/minor_perm
Upon installing a USB HID device (using ugen), the following /devices entries are seen:
root@sanbox:/devices/pci@0...
Warren V
02:20 AM Bug #5514 (Closed): hat_unload_callback passes the wrong length to segvn_hat_unload_callback
"git commit a6a74e0e62d62ff750cd4b790be5eacc99c3bb8c":https://github.com/illumos/illumos-gate/commit/a6a74e0e62d62ff7... Electric Monk
02:20 AM Bug #5498 (Closed): kmem_reap does one xcall per page
"git commit a6a74e0e62d62ff750cd4b790be5eacc99c3bb8c":https://github.com/illumos/illumos-gate/commit/a6a74e0e62d62ff7... Electric Monk

2015-01-15

07:18 PM Bug #5541 (Closed): queue(3) man page is needed
This is in the usr/src/uts/common/sys/queue.h file:... Marcel Telka
07:19 AM Bug #5520: GRUB Error 21 booting from USB stick on Dell BIOS
So, it turned out that the USB stick I tried that patch out on works with it, but when I try some other Kingston DT3s... Alex Wilson
01:35 AM Feature #4923 (Closed): want preadv and pwritev
"git commit fca543ca45b12c44a243625bce68b645ba8ed791":https://github.com/illumos/illumos-gate/commit/fca543ca45b12c44... Electric Monk

2015-01-14

08:08 PM Bug #5509 (Pending RTI): nfsauth_cache_get() could spend a lot of time walking exi_cache
Marcel Telka
07:05 PM Bug #5539 (In Progress): -Wunused-variable trips up ipsecesp
Nightlies don't catch this for some reason, but compiling in usr/src/uts/*/ipsecesp reveals this error:... Dan McDonald
03:34 PM Bug #5519 (Closed): zfs-diagnosis: Memory leak in zpool_find_load_time()
"git commit 69a6f7175eaa5e5a2a38a92e6e522062e898f570":https://github.com/illumos/illumos-gate/commit/69a6f7175eaa5e5a... Electric Monk
11:17 AM Bug #5519 (Pending RTI): zfs-diagnosis: Memory leak in zpool_find_load_time()
Marcel Telka
03:34 PM Bug #5518 (Closed): Memory leaks in libzfs import implementation
"git commit 078266a5aafa880521ea55488ef3d676f35e908e":https://github.com/illumos/illumos-gate/commit/078266a5aafa8805... Electric Monk
11:17 AM Bug #5518 (Pending RTI): Memory leaks in libzfs import implementation
Marcel Telka
12:43 PM Bug #5538: Kernel panic on SAS disk failure
cf. #5208 for other people reporting this issue. Rich Ercolani
12:29 PM Bug #5538 (New): Kernel panic on SAS disk failure
Our storage server suddenly reboots after a disk fails and is removed from the zpool. We encountered these crashes m... Frank Schreuder
10:16 AM Bug #5537 (New): Hot device removal on mpt_sas not handled gracefully
Hot-connecting drive to system and hot removal (without mounting or otherwise using the device), results in a barely ... Keith Hall

2015-01-13

11:26 PM Bug #5375 (Closed): utmpd(1M) core dumps when WTMPX_UPDATE_FREQ is zero
"git commit 0d435d6202242b0a06dc4bc41a1117591a9405f8":https://github.com/illumos/illumos-gate/commit/0d435d6202242b0a... Electric Monk
07:15 PM Bug #5536 (New): BPF: destroying held mutex in bpfclose()
Line 554 in file /illumos-gate/usr/src/uts/common/io/bpf/bpf.c:
@
554 mutex_enter(&d->bd_lock);
555 mutex_destro...
Serghei Samsi
06:13 PM Bug #5535 (Closed): libelf should check for e_phoff overflow
libelf needs to guard against an e_phoff that is sufficiently large as to overflow when checking that the apparent lo... Rich Lowe
09:55 AM Bug #5534 (New): Single device pool I/O suspended, zpool export hangs indefinitely
I currently have a single disk pool named backup which is just there to "zfs receive" from the main 8 disk SAS pool.
...
Keith Hall
09:16 AM Bug #5533 (In Progress): LOADPRIVDATA macro could return NULL on memory stress
During memory stress condition,
cron service is dumping core multiple times.
...
Serghei Samsi
09:00 AM Bug #5532 (New): Unneeded bcopy() during scrub
According to profiler, bcopy() inside vdev_mirror_scrub_done() may consume up to 10% of CPU time when scrubbing. As I... Alexander Motin
03:51 AM Bug #5497 (Closed): lock contention on arcs_mtx
"git commit 244781f10dcd82684fd8163c016540667842f203":https://github.com/illumos/illumos-gate/commit/244781f10dcd8268... Electric Monk
01:38 AM Bug #5531 (Closed): NULL pointer dereference in dsl_prop_get_ds()
As reported in: https://gist.github.com/pfmooney/8ca6e4b05c078de42524
I obtained the crash dump from pmooney on IR...
Matthew Ahrens

2015-01-12

09:20 PM Bug #5208: Edge case in mpt_sas causing panic
I've also just (monday early morning) been hit by this.
hardware
----------------
LSI SAS 9201-16i
BIOS version ...
Jorge Schrauwen
08:44 PM Bug #5530 (New): return typo in zfs_smb_acl_mgmt()
As by Marcel Telka:
> > http://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libzfs/common/libzfs_dataset.c...
Serghei Samsi
08:42 PM Bug #5529: missed zcmd_free_nvlists() after zcmd_write_src_nvlist() in libzfs
Also, the return value at line 4110 is wrong. We should definitely return something different than NULL here. Marcel Telka
08:35 PM Bug #5529 (New): missed zcmd_free_nvlists() after zcmd_write_src_nvlist() in libzfs
>
> Another example:
>
> http://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libzfs/common/libzfs_dataset....
Serghei Samsi
07:49 PM Bug #5383 (Closed): 5234 breaks build on sparc
"git commit 6ca738233e59efaafdd9083077d19ca19802b6ba":https://github.com/illumos/illumos-gate/commit/6ca738233e59efaa... Electric Monk
03:36 PM Bug #5528 (In Progress): devid_str_free() should be used for devid_get_minor_name() too
Marcel Telka
03:22 PM Bug #5528 (Closed): devid_str_free() should be used for devid_get_minor_name() too
In the devid_get(3devid) man page there is this:... Marcel Telka
03:04 PM Bug #5527: ::spa_space fails with mdb: couldn't find member dd_phys of type struct zfs`dsl_dir'
Review available at: https://reviews.csiden.org/r/152/ Justin Gibbs
02:58 PM Bug #5527: ::spa_space fails with mdb: couldn't find member dd_phys of type struct zfs`dsl_dir'
% mdb /dev/ksyms /dev/kmem
Loading modules: [ unix genunix specfs dtrace mac cpu.generic uppc apix scsi_vhci zfs mpt...
Justin Gibbs
02:54 PM Bug #5527 (Closed): ::spa_space fails with mdb: couldn't find member dd_phys of type struct zfs`dsl_dir'
Justin Gibbs
03:45 AM Bug #5526 (Closed): One more gcc warning for cmd/power
On the SPARC platform, one more gcc warning for cmd/power appears:
@
handlers.c: In function 'ztop':
handlers.c:...
Gary Mills
02:52 AM Bug #5524 (Closed): Update prototypes to 2015
"git commit c9ab4856df62d6551317f963d6be1cfc56a72ed1":https://github.com/illumos/illumos-gate/commit/c9ab4856df62d655... Electric Monk
12:08 AM Bug #5524 (Closed): Update prototypes to 2015
Robert Mustacchi
02:52 AM Feature #5525 (Closed): Update hwdata - 20150111
"git commit a5749a83c6e3fe55b6590fe96667ef2d1881d776":https://github.com/illumos/illumos-gate/commit/a5749a83c6e3fe55... Electric Monk
12:15 AM Feature #5525 (Closed): Update hwdata - 20150111
Update pci.ids and usb.ids to latest. Robert Mustacchi
12:08 AM Bug #5516 (Closed): perl problems in libbsm/auditxml
"git commit 81d662ee1fa70e2f91e1d6fa52d3621146c10d61":https://github.com/illumos/illumos-gate/commit/81d662ee1fa70e2f... Electric Monk

2015-01-11

12:59 PM Bug #5523 (New): add default option -errfmt for sunpro in Makefile.master and uts/Makefile.uts
when using sunstudio as a shadow compiler, it would be nice to get both
_warning:_ and _error:_ messages instead of ...
Richard PALO
02:11 AM Bug #5507 (Closed): libelf may overflow data buffer when translating data to memory representation
"git commit 98cadd320d4521e7438bc624f89adef498589add":https://github.com/illumos/illumos-gate/commit/98cadd320d4521e7... Electric Monk
02:11 AM Bug #5510 (Closed): elfdump doesn't print the member header before pr_reg
"git commit 3f3aaf4e95972f6d6393cbff0a4652f4ee2c0dbf":https://github.com/illumos/illumos-gate/commit/3f3aaf4e95972f6d... Electric Monk

2015-01-10

11:11 PM Bug #4872: system crash after nlm_gc hits bogus mutex
https://reviews.csiden.org/r/23/ Marcel Telka
09:02 PM Bug #5522 (New): LZ4_uncompress_unknownOutputSize crash
I'm running latest SmartOS (20150108T111855Z) and I've encountered this crash (the full information is attached):
...
Alexandru Pirvulescu
07:25 PM Bug #5521 (New): zfs hold with empty tag prints the wrong error message
The hold ioctl handler returns EINVAL in one of two
cases:
# the hold tag is empty (new)
# user wanted to put a ...
Josef Sipek
09:28 AM Bug #5520: GRUB Error 21 booting from USB stick on Dell BIOS
Rich Ercolani wrote:
> May or may not be related to https://smartos.org/bugview/ROGUE-4 ?
I think the most they p...
Alex Wilson
08:00 AM Bug #5520: GRUB Error 21 booting from USB stick on Dell BIOS
May or may not be related to https://smartos.org/bugview/ROGUE-4 ? Rich Ercolani
12:00 AM Bug #5520 (Closed): GRUB Error 21 booting from USB stick on Dell BIOS
So I've seen this now on:
* Dell PE R710, latest BIOS and previous release
* Dell PE 2950, latest BIOS
* Dell PE R...
Alex Wilson

2015-01-09

06:27 PM Feature #5313 (Closed): Allow I/Os to be aggregated across ZIO priority classes
"git commit fe319232d24f4ae183730a5a24a09423d8ab4429":https://github.com/illumos/illumos-gate/commit/fe319232d24f4ae1... Electric Monk
06:19 PM Bug #5519 (Closed): zfs-diagnosis: Memory leak in zpool_find_load_time()
The zpool_find_load_time() function is called on every iteration here in zfs_fm_recv():... Marcel Telka
03:42 PM Bug #5218: posix definition of NULL
I'm testing this change on the SPARC platform. So far, I've found hundreds of warnings from the gcc compiler and tho... Gary Mills
02:30 PM Bug #5518 (Closed): Memory leaks in libzfs import implementation
There are various memory leaks in libzfs import implementation. Steps to reproduce:... Marcel Telka
07:57 AM Bug #5516: perl problems in libbsm/auditxml
No, adt_xlate.c wasn't generated correctly, this seems better:... Richard PALO
07:40 AM Bug #5516 (Closed): perl problems in libbsm/auditxml
Noticed a wad of perl warnings in nightly.log concerning lib/libbsm/auditxml:... Richard PALO
07:20 AM Bug #5257: svccfg setenv: unable to have spaces in environment variable value
Similar (maybe the same), but definetely related issue is described here:
https://www.mail-archive.com/smf-discuss...
Marcel Telka
06:52 AM Bug #5504: crash: kernel heap corruption detected
Multiple crashes on different systems have now happened to me, any takers?
kernel memory allocator:
buffer freed to ...
Gernot Strasser

2015-01-08

08:20 PM Bug #5382: pvn_getpages handles lengths <= PAGESIZE just fine
It's a cleanup. Given the pretty small amount of documentation of the VFS, anyone dealing with any filesystem more o... Josef Sipek
05:09 PM Bug #5382: pvn_getpages handles lengths <= PAGESIZE just fine
Changing all file systems to replace this pattern:... Gordon Ross
08:15 PM Bug #5384: pvn_getpages may assert in valid scenarios
Sadly, there is no real documentation for the vm/vfs/vn code. Since pvn_getpages is called by just about every files... Josef Sipek
05:03 PM Bug #5384: pvn_getpages may assert in valid scenarios
This could also be considered a bug in the caller, depending on what we believe the expected operation of pvn_getpag... Gordon Ross
06:19 PM Feature #5313: Allow I/Os to be aggregated across ZIO priority classes
This change was largely motivated by a client workload consisting of 100MB to 1GB files being written to a 10 drive R... Justin Gibbs
06:08 PM Bug #5494 (Closed): libndmp memory leaks when setting a property
"git commit f093add7b63e274f746dd55365f052cded44cc16":https://github.com/illumos/illumos-gate/commit/f093add7b63e274f... Electric Monk
06:06 PM Bug #4518: lockd: Cannot establish NLM service over <file desc. 9, protocol udp>
We've been looking at these issues at Delphix, and have discovered that there are two similar-looking issues. The fi... Paul Dagnelie
05:56 PM Bug #5515 (Closed): dataset user hold doesn't reject empty tags
Dataset user holds can't handle empty tag names, but they don't actually reject them.... Josef Sipek
04:55 PM Bug #5514 (Closed): hat_unload_callback passes the wrong length to segvn_hat_unload_callback
hat_unload_callback() is supposed to call the specified callback on each range that is unloaded. The only consumer of... Matthew Ahrens
01:43 PM Bug #5513 (New): KM_NORMALPRI should be documented in kmem_alloc(9f) and kmem_cache_create(9f) man pages
We do have support for the KM_NORMALPRI flag in illumos for very long time now, but this flag is not documented yet i... Marcel Telka

2015-01-07

11:47 PM Bug #5512 (New): Memory leak in ecpp(7d)
On every boot I see these small memory leaks:... Marcel Telka
09:03 PM Bug #5511 (Closed): stat.h(3head) manpage #define typo
15:52 <alanc> another trivial typo for the newbie queue: http://illumos.org/man/3head/stat.h needs a 's/@define/#defi... Josef Sipek
06:30 PM Bug #5510 (Closed): elfdump doesn't print the member header before pr_reg
There are a couple of missing variable initializations in elfdump. The most important one is that dump_prgregset pa... Rich Lowe
05:26 PM Bug #3804: pyzfs is old, unused, unmaintained and broken
I think OmniOS relies on this stuff still. Not sure about anyone else. It makes sense to collaborate with DanMcD on... Garrett D'Amore
04:30 PM Bug #5509 (Closed): nfsauth_cache_get() could spend a lot of time walking exi_cache
The exi_cache is a part of the exportinfo structure. It holds the auth_cache entries. These entries allows the NFS se... Marcel Telka
04:09 AM Bug #5508 (Closed): move segvn #defines into seg_vn.c
seg_vn.c uses a couple of #defines for code clarity. These #defines are in pvn.h even though seg_vn.c is the only us... Josef Sipek

2015-01-06

11:31 PM Bug #5412 (Closed): Mention -S option when zfs inherit fails on quota
"git commit 5ff8cfa92ec8ea0f8593ad21aa2a04829b0ef5ea":https://github.com/illumos/illumos-gate/commit/5ff8cfa92ec8ea0f... Electric Monk
11:31 PM Bug #5410 (Closed): Document -S option to zfs inherit
"git commit 5ff8cfa92ec8ea0f8593ad21aa2a04829b0ef5ea":https://github.com/illumos/illumos-gate/commit/5ff8cfa92ec8ea0f... Electric Monk
11:15 PM Feature #5283: SunSSH client kex algorithms incompatible with OpenSSH 6.7 server by default
Preston Marshall wrote:
> It looks like this is going to require adding support for some key exchange algorithms in ...
Lauri Tirkkonen
10:44 PM Feature #5283: SunSSH client kex algorithms incompatible with OpenSSH 6.7 server by default
It looks like this is going to require adding support for some key exchange algorithms in SunSSH, which I'm not sure ... Preston Marshall
07:25 PM Bug #5056 (Closed): ZFS deadlock on db_mtx and dn_holds
"git commit bc9014e6a81272073b9854d9f65dd59e18d18c35":https://github.com/illumos/illumos-gate/commit/bc9014e6a8127207... Electric Monk
01:49 AM Bug #5507 (Closed): libelf may overflow data buffer when translating data to memory representation
If a section is of a size that is not a multiple of its section size, libelf may overflow the buffer allocated to hol... Rich Lowe

2015-01-05

11:45 PM Bug #5397: pfiles slow with many open sockets
Created webrev (also attached)
http://us-east.manta.joyent.com/bahamas10/public/webrev/5397-pfiles/index.html
Dave Eddy
11:44 PM Bug #5397: pfiles slow with many open sockets
Richard PALO wrote:
> Dave Eddy wrote:
> > tested and working (on SmartOS) following the instructions here: https:/...
Dave Eddy
04:23 PM Bug #5397: pfiles slow with many open sockets
Dave Eddy wrote:
> tested and working (on SmartOS) following the instructions here: https://wiki.smartos.org/display...
Richard PALO
04:49 PM Feature #5506 (New): cstyle: warn about #if enumerating ISA defines
It is quite easy to blindly end up with code that looks like:... Josef Sipek
06:46 AM Bug #5505: hald is not SMF aware.
I believe there are a few of us working on ridding the gate of dbus/hal as soon as it is feasible.
You may in the me...
Richard PALO

2015-01-04

09:18 PM Bug #5505 (New): hald is not SMF aware.
The man page for hald reads:... Evgeny Litvinenko
05:36 AM Bug #5397: pfiles slow with many open sockets
tested and working (on SmartOS) following the instructions here: https://wiki.smartos.org/display/DOC/Building+SmartO... Dave Eddy

2015-01-01

08:56 PM Bug #5383: 5234 breaks build on sparc
I'll take this one.
Gary Mills
08:14 PM Bug #5504 (New): crash: kernel heap corruption detected
running Smartos on latests bits i got a crashdump while scrubbing a pool containing filesystems with big blocks:
k...
Gernot Strasser
02:41 PM Bug #5503 (New): zpool list -v displays invalid EXPANDSZ for unavailable pools
When pools are unavailable their vdevs are also unavailable which means that vdev_max_asize remains at the default ze... Steven Hartland
02:37 PM Bug #5502 (New): zpool list and zpool status disagree on pool state
There's inconsistencies between zpool list and zpool status which are both described as displaying the pool <state> h... Steven Hartland

2014-12-31

05:48 PM Bug #5491 (Closed): libipadm`i_ipadm_init_ifs() calls free() on bogus memory address
"git commit ad69a33458cf73ee14857d57799cf686946e0b88":https://github.com/illumos/illumos-gate/commit/ad69a33458cf73ee... Electric Monk
05:02 PM Bug #5445 (Closed): Add more visibility via arcstats; specifically arc_state_t stats and differentiate between "data" and "metadata"
"git commit 4076b1bf41cfd9f968a33ed54a7ae76d9e996fe8":https://github.com/illumos/illumos-gate/commit/4076b1bf41cfd9f9... Electric Monk
03:15 PM Bug #5501: Version of sqlite included in illumos is ancient
you can try to do it by yourself first :) with upgrade/migration procedure.
i'm not sure it will be easy for end use...
Igor Kozhukhov
02:24 PM Bug #5501: Version of sqlite included in illumos is ancient
"How to convert between sqlite2 and sqlite3 database" http://blog.mypapit.net/2012/10/1823.html
Seems simple enough.
Andrew Stormont
02:20 PM Bug #5501: Version of sqlite included in illumos is ancient
I know it's going to take some work but I still think it's worth doing. We will need to come up with a migration str... Andrew Stormont
02:18 PM Bug #5501 (Feedback): Version of sqlite included in illumos is ancient
you can't upgrade sqlite to v3 because SVC based on V2 and can't use V3
also - you can't upgrade local SVC db from V...
Igor Kozhukhov
02:09 PM Bug #5501 (Feedback): Version of sqlite included in illumos is ancient
It should be upgraded to v3. There are known concurrency issues with the version we're shipping. Andrew Stormont
02:05 PM Feature #5500 (New): Want support for generating config files from SMF
It would be great to have something a bit like stencils which are a new feature in Solaris 11. See https://blogs.ora... Andrew Stormont

2014-12-30

07:06 PM Bug #5499 (New): broken reference to removed file /usr/sbin/rpc.nisd_resolv
usr/src/cmd/ypcmd/ypserv_resolv.c contain reference to removed file /usr/sbin/rpc.nisd_resolv:... Igor Kozhukhov
07:00 PM Bug #5498 (Closed): kmem_reap does one xcall per page
We see performance problems due to kmem_reap() of ZFS's zio buf caches. The kmem_reap() causes a lot of cross-calls t... Matthew Ahrens
06:32 PM Bug #5497 (Closed): lock contention on arcs_mtx
This patch attempts to reduce lock contention on the current arc_state_t
mutexes. These mutexes are used liberally t...
Matthew Ahrens
09:31 AM Bug #5496 (New): NULL pointer dereference in zfs:zap_leaf_lookup+4c caused by zfs recv of zvol replication stream
This is happening on smartos, but I suspect the issue to be general, so I log the bug with illumos. I apologize in ca... Nils Goroll
04:11 AM Bug #5400: remove __P macros
To be clear, I removed support for compiling with a legacy K&R C compiler (not ANSI compliant). I didn't remove supp... Garrett D'Amore
04:10 AM Bug #5400: remove __P macros
This macro was mostly removed from illumos as part of my effort to remove the support for legacy K&R C. I believe th... Garrett D'Amore
04:08 AM Bug #5403: remove warlock support
Indeed there is:
https://github.com/gdamore/illumos-core/pull/131
This work was contributed to illumos-core by ...
Garrett D'Amore
03:20 AM Bug #5495 (New): fcinfo can't display emulex at target mode 16G speed

"fcinfo hba-port" can't display target mode FC coonection speed, need modify file uts/common/io/comstar/port/fct/...
John Huang
03:11 AM Bug #5408 (Closed): managing ZFS cache devices requires lots of RAM
"git commit 89c86e32293a30cdd7af530c38b2073fee01411c":https://github.com/illumos/illumos-gate/commit/89c86e32293a30cd... Electric Monk

2014-12-29

09:06 PM Bug #4518: lockd: Cannot establish NLM service over <file desc. 9, protocol udp>
I have the same issue. I upgraded the OS (SmartOS) to the latest build (20141212T011737Z), and suddenly none of my NF... Paul Orlando
02:01 PM Bug #5468: Missing dependencies in lib/Makefile
Without the libc dependency it seems to be pulling in the host version of these libraries. I'm also building on a ma... Andrew Stormont
01:35 PM Bug #5468: Missing dependencies in lib/Makefile
I believe that it's not necessary to include libc in dependancy lists of this file; there is an explicit .WAIT target... Gary Mills
01:39 PM Bug #5483: Pool hang & system panic because of single disk failure
::stack output from the dump on the r151012 crash... Chip Schweiss
12:32 PM Bug #5494 (Closed): libndmp memory leaks when setting a property
libumem discovered following memory leaks in libndmp when setting NDMP property:... Jan Kryl
11:45 AM Bug #5492: Panic possibly in iscsi initiator
Whether it's causal or coincidence - this also appears in the log prior to the crash
Dec 28 06:07:35 box scsi: [ID...
Keith Hall

2014-12-28

05:59 PM Bug #5468: Missing dependencies in lib/Makefile
A few that you've missed:
- libdladm depends on libpool
- librestart depends on libpool
- libdtrace depends on l...
Andrew Stormont
02:22 PM Feature #5493 (New): zfs sync=delayed
As discussed here: http://comments.gmane.org/gmane.os.illumos.zfs/4085, I would like to propose a fourth option to zf... Attila Nagy
11:17 AM Bug #5492 (New): Panic possibly in iscsi initiator
Hi,
I'm relatively new to this so please bear with me.
attached is a crashdump from my system which panic'd ear...
Keith Hall
02:07 AM Bug #5463 (Feedback): Unused local typedef
Yes, moving the include statement fixed the problem. They must have been economizing on conditionals. There were ac... Gary Mills

2014-12-27

10:43 PM Bug #5491 (Closed): libipadm`i_ipadm_init_ifs() calls free() on bogus memory address
... Yuri Pankov
06:05 PM Bug #3846 (Closed): canonicalize_file_name() needs a man page
"git commit 820218f30a3ad84d92aa2970dcac9eb5cf69aaa9":https://github.com/illumos/illumos-gate/commit/820218f30a3ad84d... Electric Monk
06:05 PM Feature #5458 (Closed): Intro(9F) s/Solaris/illumos
"git commit f85a6f389e74896ee3d46e89d843dbd2dde60c6d":https://github.com/illumos/illumos-gate/commit/f85a6f389e74896e... Electric Monk
06:05 PM Bug #4617 (Closed): condvar(9f): Missing documentation for cv_reltimedwait() and cv_reltimedwait_sig()
"git commit f85a6f389e74896ee3d46e89d843dbd2dde60c6d":https://github.com/illumos/illumos-gate/commit/f85a6f389e74896e... Electric Monk
06:05 PM Bug #3841 (Closed): strnstr() needs a man page
"git commit 195b26986e3c19e916bf0991a1af7ae87d43010b":https://github.com/illumos/illumos-gate/commit/195b26986e3c19e9... Electric Monk
06:05 PM Bug #3827 (Closed): clearenv() needs a manpage
"git commit 89b9271284be1a4e3e3053d7bc12f9bbf8145b06":https://github.com/illumos/illumos-gate/commit/89b9271284be1a4e... Electric Monk
06:05 PM Bug #3826 (Closed): fcloseall() needs a manpage
"git commit ce83b99835cc4643ab0fefd88dea62427d9ced5e":https://github.com/illumos/illumos-gate/commit/ce83b99835cc4643... Electric Monk
06:05 PM Feature #5459 (Closed): libc(3lib) s/Solaris/illumos
"git commit f6ed5ca267d42d2a060f8447acdeb647ef077b6d":https://github.com/illumos/illumos-gate/commit/f6ed5ca267d42d2a... Electric Monk
06:05 PM Bug #3825 (Closed): memmem() needs a manpage
"git commit f6ed5ca267d42d2a060f8447acdeb647ef077b6d":https://github.com/illumos/illumos-gate/commit/f6ed5ca267d42d2a... Electric Monk
06:05 PM Bug #3824 (Closed): ppoll() needs a manpage
"git commit 088940da40dfd58e4a00927addc99837dbefaa6d":https://github.com/illumos/illumos-gate/commit/088940da40dfd58e... Electric Monk
06:05 PM Bug #5460 (Closed): utimensat() and futimens() need manual pages
"git commit 03c1ea085b2a65a7bf9c001ba8502eb10725ea52":https://github.com/illumos/illumos-gate/commit/03c1ea085b2a65a7... Electric Monk
06:05 PM Bug #1372 (Closed): kvmstat needs a man page
"git commit ec7588a4ab9972aa7d50fd5f3b5ccdef4079952a":https://github.com/illumos/illumos-gate/commit/ec7588a4ab9972aa... Electric Monk
06:05 PM Bug #5464 (Closed): missing ffs() and fsl() family of manual pages
"git commit e232d9863a8486cf94eaa4bc06c2e9ff52bf3140":https://github.com/illumos/illumos-gate/commit/e232d9863a8486cf... Electric Monk
06:05 PM Bug #5475 (Closed): Need manuals for get_nprocs() and get_nprocs_conf()
"git commit d2b9ba291ef0d1dc8807b6d46996674c723924d0":https://github.com/illumos/illumos-gate/commit/d2b9ba291ef0d1dc... Electric Monk
06:05 PM Bug #5476 (Closed): need manuals for getprogname(3C) and setprogname(3C)
"git commit b65dd972486b1f5913d705d2a0cb9c3fb189a9e0":https://github.com/illumos/illumos-gate/commit/b65dd972486b1f59... Electric Monk
06:05 PM Bug #5477 (Closed): Need manual pages for new pthreads robust related functions
"git commit ad0ef8fd06d1ac28108685495a9ba1244a20a5ca":https://github.com/illumos/illumos-gate/commit/ad0ef8fd06d1ac28... Electric Monk
06:05 PM Bug #5478 (Closed): need smt_pause(3C)
"git commit d3864341aacc6a2ecc95960d23ac0e49f1f538fa":https://github.com/illumos/illumos-gate/commit/d3864341aacc6a2e... Electric Monk
06:05 PM Bug #5479 (Closed): Need missing *at family manual pages
"git commit 1fcc078ae7c0a359a9274d2a5a90547aceb213a6":https://github.com/illumos/illumos-gate/commit/1fcc078ae7c0a359... Electric Monk
06:05 PM Bug #5474 (Closed): missing various string family manuals
"git commit bad51a906c423d0d7ab33fcc1a4e317d789e3c49":https://github.com/illumos/illumos-gate/commit/bad51a906c423d0d... Electric Monk
04:31 PM Bug #5486 (Closed): leaked buffer in ndmp_base64_decode()
"git commit 8b87c15576a5138f88a969448b43561bf5968c09":https://github.com/illumos/illumos-gate/commit/8b87c15576a5138f... Electric Monk
04:31 PM Bug #5485 (Closed): Missing const qualifiers for strings in libndmp
"git commit 8b87c15576a5138f88a969448b43561bf5968c09":https://github.com/illumos/illumos-gate/commit/8b87c15576a5138f... Electric Monk
02:32 PM Bug #5432 (Closed): zoneadm install could fix zonepath permissions automatically
"git commit b6831eafa2ec2cb283f783b06ee86bf79d5a17c3":https://github.com/illumos/illumos-gate/commit/b6831eafa2ec2cb2... Electric Monk
07:34 AM Bug #5463: Unused local typedef
you could perhaps add instead on the typedef @__attribute__((__unused__))@
instead of the CERRWARN.
I'm curious, tho...
Richard PALO
12:43 AM Bug #5490 (Closed): fix CBC mode leakage for sunssh encryption
Bayard Bell
12:36 AM Feature #5489 (Closed): sunssh support for curve25519-sha2@libssh.org key exchange
Bayard Bell
12:34 AM Feature #5488 (Closed): sunssh support for sha2 dh key group exchange
Bayard Bell

2014-12-26

11:09 PM Bug #5487 (New): libcurses needs to be carefully unifdef'd
Just like what was done to libm. Andrew Stormont
10:56 PM Bug #5463: Unused local typedef
The code in fcntl.h looks okay to me. I wonder if it has something to do with the include being on line 536 in tgetc... Andrew Stormont
10:30 PM Feature #5470: libz should be part of illumos
Agreed. It should be part of illumos. Andrew Stormont
08:36 PM Bug #5486 (Closed): leaked buffer in ndmp_base64_decode()
Buffer for holding decoded string isn't properly freed in error branches in ndmp_base64_decode() Jan Kryl
05:33 PM Bug #5485 (Pending RTI): Missing const qualifiers for strings in libndmp
Jan Kryl
12:46 PM Bug #5485 (In Progress): Missing const qualifiers for strings in libndmp
Jan Kryl
12:45 PM Bug #5485 (Closed): Missing const qualifiers for strings in libndmp
Missing const qualifiers for strings in libndmp make using the library more complicated than it needs to be. One has ... Jan Kryl
04:38 PM Bug #5483: Pool hang & system panic because of single disk failure
I have another dump from another system with the same failure mode. Seems disk failures crash the system more often ... Chip Schweiss
04:50 AM Bug #5484 (New): zpool upgrade with unavailable pool causes assert violation
When running zpool upgrade on a system with an unavailable pool it results in an assert violation as it tries to acce... Steven Hartland

2014-12-24

11:49 PM Bug #5483: Pool hang & system panic because of single disk failure
Gonna guess you're hitting some combination of #4310 and ...I forget the other bug number, depending on which bits ar... Rich Ercolani
03:06 PM Bug #5483: Pool hang & system panic because of single disk failure
Correction on the dump url:
ftp://ftp.nrg.wustl.edu/pub/zfs/io_hung_20141223
Chip Schweiss
02:59 PM Bug #5483 (New): Pool hang & system panic because of single disk failure
A single disk failure on a raidz3 pool caused i/o to hang eventually panicking the system.
The disk failed by goi...
Chip Schweiss

2014-12-23

11:22 PM Bug #3244 (Closed): utmpd.c: fix uninitialized variable, ret_val and other gcc warnings
"git commit fd64a0d03455fdb3bbf710e77f2a2f6d08d3cf6c":https://github.com/illumos/illumos-gate/commit/fd64a0d03455fdb3... Electric Monk
11:22 PM Bug #5473 (Closed): typo in mbsrtowcs.3c
"git commit a5261312fc4eed6b5595eca994c6cfec602829cd":https://github.com/illumos/illumos-gate/commit/a5261312fc4eed6b... Electric Monk
07:14 PM Bug #5473 (Closed): typo in mbsrtowcs.3c
Under NAME, 'mbsnrtwocs' should be mbsnrtowcs. Lauri Tirkkonen
10:54 PM Bug #5482 (Closed): CVE-2014-7844, CVE-2004-2771 - more mailx(1) woes
"git commit 5422785d352a2bb398daceab3d1898a8aa64d006":https://github.com/illumos/illumos-gate/commit/5422785d352a2bb3... Electric Monk
10:07 PM Bug #5482 (Closed): CVE-2014-7844, CVE-2004-2771 - more mailx(1) woes
mailx(1) is vulnerable to several CVEs. We've adapted the various defenses pointed out here: http://seclists.org/oss-... Robert Mustacchi
10:54 PM Bug #5481 (Closed): CVE-2012-1750 mailx(1) tilde expansion vulnerability
"git commit 5422785d352a2bb398daceab3d1898a8aa64d006":https://github.com/illumos/illumos-gate/commit/5422785d352a2bb3... Electric Monk
10:07 PM Bug #5481 (Closed): CVE-2012-1750 mailx(1) tilde expansion vulnerability
mailx's default configuration allows for escape commands to be executed in non-interactive mode. The issues is that t... Robert Mustacchi
10:54 PM Bug #5480 (Closed): CVE-2012-3165 mailx(1) buffer overflow vulnerability
"git commit 196c7f05d2deba7404e90ad67f3861185c78ca2d":https://github.com/illumos/illumos-gate/commit/196c7f05d2deba74... Electric Monk
10:07 PM Bug #5480 (Closed): CVE-2012-3165 mailx(1) buffer overflow vulnerability
Address CVE-2012-3165 for mailx(1). mailx(1) does not properly handle its buffer allocations and allows for arbitrary... Robert Mustacchi
09:35 PM Bug #5479 (Closed): Need missing *at family manual pages
This includes: fchmodat(2), linkat(2), mkdirat(2), mkfifoat(3C), mknodat(2), readlinkat(2), symlinkat(2). Robert Mustacchi
09:26 PM Bug #5478 (Closed): need smt_pause(3C)
We need a manual page for smt_pause(3C). Robert Mustacchi
09:25 PM Bug #5477 (Closed): Need manual pages for new pthreads robust related functions
We need manual pages for pthread_mutexattr_getrobust(3C), pthread_mutexattr_setrobust(3C), and pthread_mutex_consiste... Robert Mustacchi
09:24 PM Bug #5476 (Closed): need manuals for getprogname(3C) and setprogname(3C)
We're missing documentation on getprogname(3C) and setprogname(3C). Robert Mustacchi
09:23 PM Bug #5475 (Closed): Need manuals for get_nprocs() and get_nprocs_conf()
Both get_nprocs(3c) and get_nprocs_conf(3C) are missing manual pages. Robert Mustacchi
09:22 PM Bug #5474 (Closed): missing various string family manuals
This includes stpcyp(), stpncpy(), strcasestr(), strcasestr_l(), strchrnul(), strdupa(), strndup(), and strndupa(). Robert Mustacchi
09:57 AM Bug #5472 (New): zpool.cache not updated for root pools
Not sure if this one due to a restriction on illumos not present in FreeBSD but we've found on a number of occasions ... Steven Hartland
09:10 AM Bug #5471 (New): Offset validation in zvol_read and zvol_write off by one
The checks against uio_loffset in zvol_read and zvol_write are off by one, they should be uio_loffset > volsize inste... Steven Hartland

2014-12-22

10:48 PM Bug #5461: #pragma align before the declaration
i'd like to help with test on SPARC with gcc44 build
Igor Kozhukhov
08:14 PM Bug #5461: #pragma align before the declaration
If it works on SPARC, I can certainly try on x86 for you. I'm confident it'll work on both (more confident about x86... Rich Lowe
06:41 PM Bug #5461 (Feedback): #pragma align before the declaration
I expect that you are right, but your suggestion is testable, at least on the x86 platform. I can only do a build on... Gary Mills
08:12 PM Bug #5468: Missing dependencies in lib/Makefile
At one point I had patches that made this better, and were likely very similar to yours (I didn't look).
All I did w...
Rich Lowe
04:47 PM Bug #5468 (Feedback): Missing dependencies in lib/Makefile
I'm attaching a patch file that shows the dependancies I've added to the Makefile. I only fixed some targets, though... Gary Mills
02:10 AM Bug #5455: Unrecognized option -massume-32bit-callers
Okay, it's still necessary. Can we ask the GNU people again to upstream the necessary code in gcc? Otherwise, we'll... Gary Mills
01:47 AM Bug #5456: Unknown attribute __unused__
Here's a bit of the source for common/bzip2/compress.c:
@
239 static
240 void sendMTFValues ( EState* s ...
Gary Mills
01:32 AM Feature #5470 (Feedback): libz should be part of illumos
The problem here is that many illumos commands and libraries link with libz, but libz only exists on the build host. ... Gary Mills

2014-12-21

11:47 PM Bug #5469: Undefined contract_init_fork_template
Alternatively, you should use the adjunct proto area and build those external dependencies and that way you'll have t... Robert Mustacchi
11:16 PM Bug #5469 (New): Undefined contract_init_fork_template
Building illumos on a Solaris 11.2 build host resulted in several instances of this error:
@
Undefined first re...
Gary Mills
11:23 PM Bug #5455: Unrecognized option -massume-32bit-callers
Yes this is necessary. I implemented this because otherwise the implementation of system calls on SPARC will not wor... Rich Lowe
01:51 AM Bug #5455: Unrecognized option -massume-32bit-callers
for this option need port patch from gcc44 to gcc48x
but need take a look binaries and identify if we need this patc...
Igor Kozhukhov
01:44 AM Bug #5455 (New): Unrecognized option -massume-32bit-callers
A build with gcc 4.8.2 fails with this error:
@
gcc: error: unrecognized command line option '-massume-32bit-call...
Gary Mills
11:20 PM Bug #5456: Unknown attribute __unused__
Yeah, nothing should be using the attribute directly, everyone should be using __GNU_UNUSED.
If something is usi...
Rich Lowe
02:01 AM Bug #5456: Unknown attribute __unused__
we have defined macro in file uts/common/sys/ccompile.h... Igor Kozhukhov
01:55 AM Bug #5456 (New): Unknown attribute __unused__
A build with the Studio 12.2 produces this error:
@
"../../../common/bzip2/compress.c", line 244: attribute "__u...
Gary Mills
11:19 PM Bug #5461: #pragma align before the declaration
I'm 99% sure that the real problem is the (unnecessary) declaration in the vm_dep.h's for both platforms.
The reas...
Rich Lowe
01:51 PM Bug #5461 (Closed): #pragma align before the declaration
When building in usr/src/uts/sun4u/unix with gcc 4.8.2, the following error appears:
@
../../common/vm/vm_pagelis...
Gary Mills
11:14 PM Bug #5466 (Closed): LocalConsumer.h is missing
duplicate of #4719 Rich Lowe
10:29 PM Bug #5466 (Closed): LocalConsumer.h is missing
A build with java 1.7 installed on the build host resulted in many of these errors:
@
/usr/java/bin/javac -g -d
...
Gary Mills
11:08 PM Bug #5468 (Closed): Missing dependencies in lib/Makefile
I'm doing this build on a T2000, which has 32 virtual CPUs. I've seen dozens of dmake processes running simultaneous... Gary Mills
10:45 PM Bug #5467 (New): Not declared at this scope
A build with gcc 4.8.2 resulted in this error in usr/src/lib/sun_fc:
@
../common/Sun_fcAdapterCreateWWN.cc:46:30:...
Gary Mills
10:20 PM Bug #5465 (Closed): CFLAGS missing from BUILD.SO in lib/Makefile.lib
A build with gcc 4.8.2 on the SPARC platform produces this error message:
@
Undefined first referenced
symbol...
Gary Mills
07:36 PM Bug #5464 (Closed): missing ffs() and fsl() family of manual pages
While we have a manual page for ffs(), we do not have one for ffsl(), ffsll(), fls(), flsl(), and flsll(). Robert Mustacchi
04:31 PM Feature #5458: Intro(9F) s/Solaris/illumos
Or we could simply s/Solaris//, the "DDI/DKI" lines aren't prefixed with OS name as well. Yuri Pankov
05:42 AM Feature #5458 (Closed): Intro(9F) s/Solaris/illumos
Robert Mustacchi
03:40 PM Bug #5383 (Feedback): 5234 breaks build on sparc
The solution here is more conditional code to eliminate Linux core file processing on the SPARC platform. The patch ... Gary Mills
03:18 PM Bug #5463 (Feedback): Unused local typedef
When building with gcc 4.8.2, this error appears:
@
In file included from /dpool/export/home/mills/Downloads/code...
Gary Mills
02:51 PM Bug #5462 (New): Symbol assfail3 may not exist on build host
When building in usr/src/cmd/sgs/tools/sparc with gcc 4.8.2 on a Solaris 11.2 host, this error appears:
@
Undefin...
Gary Mills
05:44 AM Bug #5460 (Closed): utimensat() and futimens() need manual pages
These functions come in the infamous manual page gap, we should add manual pages for them. Robert Mustacchi
05:43 AM Feature #5459 (Closed): libc(3lib) s/Solaris/illumos
Robert Mustacchi
03:52 AM Bug #5457: Variably modified at file scope
i have more places with updates:... Igor Kozhukhov
02:58 AM Bug #5457 (Closed): Variably modified at file scope
gcc 4.8.2 produced the following error message while it was building in usr/src/uts/sun4u/unix:
@
In file include...
Gary Mills
01:10 AM Bug #5454 (New): Operation may be undefined
gcc 4.8.2 reported one peculiar error in usr/src/lib/libshell . Here's the message:
@
In file included from ../c...
Gary Mills

2014-12-20

11:20 PM Bug #5453 (New): Value computed is not used
gcc 4.8.2 issues several error messages like this one:
@
../nss/gethostent_r.c: In function 'gethostent_r':
/dpo...
Gary Mills
10:15 PM Bug #5451: Many variables set but not used
we have to remove gcc warnings and i'm working on it with 'cmd' components(very slow process by one person).
no need...
Igor Kozhukhov
08:31 PM Bug #5451: Many variables set but not used
Is there a way to add options that satisfy both the 4.4 and 4.8 compilers? Otherwise, the correct solution is to fix... Gary Mills
07:17 PM Bug #5451: Many variables set but not used
please pay attention:
CERRWARN += -_gcc=-Wno-unused-but-set-variable
will break gcc44 build
Igor Kozhukhov
07:14 PM Bug #5451 (New): Many variables set but not used
gcc 4.8.2 generates a large number of these warnings in building illumos. This is a specific example:
@
../stabs...
Gary Mills
10:04 PM Bug #5452 (New): Parameters set but not used
gcc 4.8.2 reports many of this type of error:
@
../../../sun4/io/rootnex.c: In function 'rootnex_ctlops_peekpoke'...
Gary Mills
06:35 PM Bug #5375 (In Progress): utmpd(1M) core dumps when WTMPX_UPDATE_FREQ is zero
Shruti Sampat
03:10 PM Bug #5396: fix longjmp clobbering errors
There are actually four locations that exhibit this bug:
@
usr/src/tools/cscope-fast
usr/src/lib/libcurses
usr/...
Gary Mills
09:03 AM Bug #3999 (Closed): libld extended section handling is broken
Robert Mustacchi
07:40 AM Bug #5158 (Closed): sed dumps core in new multibyte code
"git commit aa64fa16549f13233681f4b40e50fb5b1c18a97c":https://github.com/illumos/illumos-gate/commit/aa64fa16549f1323... Electric Monk
01:03 AM Bug #5450: illumos doesn't boot on KVM on AMD on CentOS 7
Additonal information.
I have tried many illumos distributions, including Hipster, vanilla OI, opensolaris, SmartO...
Bob Beverage
12:46 AM Bug #5450 (New): illumos doesn't boot on KVM on AMD on CentOS 7
On a KVM host running kernel 3.10.0-123.13.2.el7.x86_64 (and many others) an Illumos based guest will not boot. The ... Bob Beverage
12:10 AM Bug #5444 (Closed): cannot exec from hsfs since 5405
"git commit 277b8dcb887b89d7465085652bc00d7842be2792":https://github.com/illumos/illumos-gate/commit/277b8dcb887b89d7... Electric Monk

2014-12-19

09:21 PM Bug #5449 (New): illumos find doesn't expand "{}" in -exec if it is prefixed by some characters
There is the following inconsistency in GNU find and illumos find behavior:
$ mkdir 1
$ /usr/bin/find 1 -exec ech...
Alexander Pyhalov
07:56 PM Bug #5376 (Closed): arc_kmem_reap_now() should not result in clearing arc_no_grow
"git commit 2ec99e3e987d8aa273f1e9ba2b983557d058198c":https://github.com/illumos/illumos-gate/commit/2ec99e3e987d8aa2... Electric Monk
02:59 PM Bug #5448 (Rejected): sed core dumps on y command
Yuri Pankov
02:33 PM Bug #5448: sed core dumps on y command
Duplicates #5158. Yuri Pankov
02:30 PM Bug #5448 (Rejected): sed core dumps on y command
$ echo 'test' | /usr/bin/sed -e y,a,A,
Segmentation Fault (core dumped)
$ uname -a
SunOS buildzone.oi-build.r61...
Alexander Pyhalov
12:31 PM Feature #5447 (New): want dladm modify-vnic
Would be nice to be able to change eg. mac address or vid of a vnic link without having to destroy and re-create it. Lauri Tirkkonen

2014-12-18

11:53 PM Bug #5446: Installer fails to recognize LSI 9211 firmware greater than r18
Now I'm getting "Unsupported 64 bit prefetch memory on PCI-PCI bridge [0/1/1]" at boot time with >4G enabled. The mes... Warren V
11:32 PM Bug #5446: Installer fails to recognize LSI 9211 firmware greater than r18
Mainboard is a Supermicro X10SLM-F.
Above 4G decode was disabled during installation. It's the BIOS default to hav...
Warren V
09:53 PM Bug #5446: Installer fails to recognize LSI 9211 firmware greater than r18
We've been hearing reports of general problems with mpt_sas FW > 18.
I also wonder, maybe, if #5017 (not in r15101...
Dan McDonald
08:36 PM Bug #5446 (New): Installer fails to recognize LSI 9211 firmware greater than r18
When installing OmniOS r151012, controller recognition fails for LSI 9211 cards using r19 and r20 controller firmware... Warren V
04:56 AM Bug #5422 (Closed): preserve AVL invariants in dn_dbufs
"git commit a846f19d279fdfb0e0d63f78ccaf0205a88274d2":https://github.com/illumos/illumos-gate/commit/a846f19d279fdfb0... Electric Monk
03:50 AM Bug #5445 (Closed): Add more visibility via arcstats; specifically arc_state_t stats and differentiate between "data" and "metadata"
We should start exporting the arc_state_t statistics via the arcstats interface.
Proper page caching is critical t...
Matthew Ahrens
 

Also available in: Atom