Project

General

Profile

Activity

From 2015-04-30 to 2015-05-29

2015-05-29

10:14 PM Bug #5679: be_sort_list(): Possible null pointer dereference
As a start, I've reviewed all the illumos source, looking for instances where a realloc() failure is not handled by t... Gary Mills
09:57 PM Bug #5970 (New): Many source files don't handle realloc() failure
The realloc() function normally returns a pointer to the new memory area. If it fails because memory is not availabl... Gary Mills
04:56 PM Bug #5969: update illumos-gate to use python2.7
http://cr.dilos.org/cr/il-5969/
Igor Kozhukhov
02:58 PM Bug #5969 (Closed): update illumos-gate to use python2.7
need update illumos-gate to use python.27 Igor Kozhukhov
03:11 PM Bug #1778 (Closed): Assertion failed: rn->rn_nozpool == B_FALSE, file ../common/libzfs_import.c, line 1077, function zpool_open_func
"git commit bd0f709169e67f4bd34526e186a7c34f595f0d9b":https://github.com/illumos/illumos-gate/commit/bd0f709169e67f4b... Electric Monk
03:11 PM Bug #4348 (Closed): Assertion failed: rn->rn_nozpool == B_FALSE, file ../common/libzfs_import.c, line 1080, function zpool_open_func
"git commit bd0f709169e67f4bd34526e186a7c34f595f0d9b":https://github.com/illumos/illumos-gate/commit/bd0f709169e67f4b... Electric Monk
03:10 PM Bug #5945 (Closed): zfs_ioc_send_space must ensure that fromsnap refers to a snapshot
"git commit 24218bebb460e4015fac2c9f2cec1902eddbcd7b":https://github.com/illumos/illumos-gate/commit/24218bebb460e401... Electric Monk
03:10 PM Bug #5946 (Closed): zfs_ioc_space_snaps must check that firstsnap and lastsnap refer to snapshots
"git commit 24218bebb460e4015fac2c9f2cec1902eddbcd7b":https://github.com/illumos/illumos-gate/commit/24218bebb460e401... Electric Monk
08:49 AM Bug #5968 (New): libilb'ilb_close() misses mutex_unlock in some places
/illumos-gate/usr/src/lib/libilb/common/ilb_comm.c:
Lines 131,146 should unlock mutex hi->hi_lock.
@118ilb_status...
Serghei Samsi

2015-05-28

09:39 PM Bug #5967 (Closed): Invalid multiline string in zfs-tests/tests/functional/cli_root/zpool_create/zpool_create_features_004_neg
... Yuri Pankov
09:37 PM Bug #5966 (Closed): zfs-tests/tests/functional/acl/nontrivial/zfs_acl_chmod_rwx_002_pos incorrectly uses typeset builtin
... Yuri Pankov
08:13 PM Bug #5965 (Closed): native svc.configd doesn't need audit support
Andrew Stormont
03:09 PM Bug #5964 (Closed): mkostemp() and mkostemps() need prototypes in stdlib.h
Duplicate of #5187 Dan McDonald
02:48 AM Bug #5964 (Closed): mkostemp() and mkostemps() need prototypes in stdlib.h
Subject says it all. I was compiling someone else's software, and it found that we support these (probably via libto... Dan McDonald
04:23 AM Bug #5679: be_sort_list(): Possible null pointer dereference
Gary Mills wrote:
> Is there any reason to fix this bug? The realloc() call on that line is unlikely to fail becaus...
Marcel Telka
02:36 AM Bug #5963: rmis should be removed from arcstat manpage
See here for a potential fix: https://reviews.csiden.org/r/193/ Prakash Surya
02:30 AM Bug #5963 (Closed): rmis should be removed from arcstat manpage
The "rmis" field of arcstat is no longer valid, it should be removed from arcstat's manpage. Prakash Surya

2015-05-27

07:41 PM Bug #5679: be_sort_list(): Possible null pointer dereference
Is there any reason to fix this bug? The realloc() call on that line is unlikely to fail because it extends the spac... Gary Mills
06:16 PM Bug #4418 (Closed): svc.startd crash with a long instance name and more than one dependency
"git commit 09f79f7c66b85f056db11f58210dc6182c9b1aef":https://github.com/illumos/illumos-gate/commit/09f79f7c66b85f05... Electric Monk
03:46 PM Bug #5962 (Closed): clean target fails in usr/src/common/avs
Simple problem: the makefile defines a clobber target but doesn't define a clean target. Andrew Stormont
02:52 PM Bug #5909 (Closed): zfs_ioc_promote does not check new name length for shared snapshots
"git commit cb5842f8b0caaad0ed53535bd77042e933fdbafe":https://github.com/illumos/illumos-gate/commit/cb5842f8b0caaad0... Electric Monk
02:29 PM Bug #5870 (Closed): dmu_recv_end_check() leaks origin_head hold if error happens in drc_force branch
"git commit beddaa9ce797b9deaafc22b4f156d23f9b45c32d":https://github.com/illumos/illumos-gate/commit/beddaa9ce797b9de... Electric Monk
02:15 PM Bug #5912 (Closed): full stream can not be force-received into a dataset if it has a snapshot
"git commit 5bae108fe2364722de3aa86e04966a0d33fd027a":https://github.com/illumos/illumos-gate/commit/5bae108fe2364722... Electric Monk
02:13 PM Bug #5961 (Closed): Fix stack overflow in zfs_create_fs
"git commit c701fde6911c957e71b37aac4daf672bd828f4d7":https://github.com/illumos/illumos-gate/commit/c701fde6911c957e... Electric Monk
12:14 PM Bug #5961 (Closed): Fix stack overflow in zfs_create_fs
Do not put zfsvfs_t on the stack. Its size of 7656 bytes consumes too much stack. Allocate it
temporarily instead.
...
Matthew Ahrens
02:11 PM Bug #5669 (Closed): altroot not set in zpool create when specified with -o
"git commit c423721f9bcd45c2409ef7b73fc103ac2889f9e9":https://github.com/illumos/illumos-gate/commit/c423721f9bcd45c2... Electric Monk
02:10 PM Bug #5438 (Closed): zfs_blkptr_verify should continue after zfs_panic_recover
"git commit 5897eb49ccde82d19214b71984f57935e7e313d1":https://github.com/illumos/illumos-gate/commit/5897eb49ccde82d1... Electric Monk
01:33 PM Bug #5958: rpc/xdr.h forces stdio.h on you
The reason for stdio_tag.h is for libraries that want to define a function as accepting an arg of type FILE, i.e. for... Gordon Ross
12:03 PM Bug #5958: rpc/xdr.h forces stdio.h on you
Why it would be better to include stdio_tag.h instead of stdio.h to get the FILE?
BTW, I do not see the FILE defin...
Marcel Telka
02:22 AM Bug #5958 (New): rpc/xdr.h forces stdio.h on you
rpc/xdr.h needs the stdio FILE typedef, which it gets by including stdio.h
It would be better if it included stdio_t...
Gordon Ross
01:18 PM Bug #1778: Assertion failed: rn->rn_nozpool == B_FALSE, file ../common/libzfs_import.c, line 1077, function zpool_open_func
The code has the following comment:... George Wilson
11:33 AM Bug #5926 (Rejected): insert buffer between zfs send's read from disk and write to fd
Matthew Ahrens
11:31 AM Bug #5960 (Closed): zfs recv should prefetch indirect blocks
While running 'zfs recv' we noticed that every 128th 8K block required a read. We were seeing that restore_write() wa... Matthew Ahrens
09:26 AM Bug #5959 (Closed): clean up per-dataset feature count code
A ZFS feature flags (large blocks) tracks its refcounts as the number of datasets that have ever used the feature. Se... Matthew Ahrens

2015-05-26

07:16 PM Bug #5956: orientate is not a word
I love illumos for lessons of English :-) Igor Pashev
05:09 PM Bug #5956 (Closed): orientate is not a word
There are a few occurrences of "orientate" or "orientated" in our code base (comments mostly). In American English, ... Garrett D'Amore
07:02 PM Bug #5957 (New): File locking should be read-preferring
During "the discussion":http://thread.gmane.org/gmane.comp.standards.posix.austin.general/10846 in the Austin Group I... Marcel Telka
05:34 PM Bug #5955 (Closed): pat_sync is clever enough to check for X86FSET_PAT
"git commit 58865bb7f764a6ca11f3057bee77153724ebb239":https://github.com/illumos/illumos-gate/commit/58865bb7f764a6ca... Electric Monk
04:58 PM Bug #5955 (Closed): pat_sync is clever enough to check for X86FSET_PAT
pat_sync() already checks for X86FSET_PAT so there's no need to check before calling it. Josef Sipek
05:34 PM Bug #5954 (Closed): ffs(3c) manpage is a little confusing
"git commit 3698b9760f5a9315a5040e7606f7db7aaa3e1ffb":https://github.com/illumos/illumos-gate/commit/3698b9760f5a9315... Electric Monk
04:55 PM Bug #5954 (Closed): ffs(3c) manpage is a little confusing
The ffs(3c) manpage says the same thing for ffs and fls. This is obviously wrong/misleading. Josef Sipek
04:53 PM Bug #5953 (New): zfs sharenfs property can result in incorrect sharetab
I've seen this as far back as Nexenta Core Platform 3, but I was shocked to see it on SmartOS:... Nahum Shalman
03:04 PM Bug #5947 (Closed): NULL is not a character in asm10k.c
"git commit bb2183e0683124f79bf4b91cf4d48201e752109e":https://github.com/illumos/illumos-gate/commit/bb2183e0683124f7... Electric Monk
03:04 PM Bug #5852 (Closed): remove SFW* from the gate's Makefiles
"git commit cdf815bb84cfaf9b71a4c5a51616e2da60c68bfc":https://github.com/illumos/illumos-gate/commit/cdf815bb84cfaf9b... Electric Monk
08:57 AM Bug #5952 (New): dd should be able to suppress printing status information
From GNU dd manpage:... Adam Števko

2015-05-25

05:14 PM Bug #5944 (Closed): Related to 5943 (please merge)
Copied to #5943. Marcel Telka
05:12 PM Bug #5943: grub fails to boot when too many boot environments are present
Copied from #5944:
This is related to bug 5943 and includes instructions how to reproduce. I'm not seeing a way to...
Marcel Telka
12:22 PM Bug #5945: zfs_ioc_send_space must ensure that fromsnap refers to a snapshot
See https://reviews.csiden.org/r/225/ Andriy Gapon
12:21 PM Bug #5946: zfs_ioc_space_snaps must check that firstsnap and lastsnap refer to snapshots
See https://reviews.csiden.org/r/225/ Andriy Gapon
11:27 AM Bug #5950: assertion failed for thread 0x7fffff152a40, thread-id 1: object_count == usedobjs (0x447 == 0x435), file ../zdb.c, line 1922
core dump parse:... Igor Kozhukhov
11:21 AM Bug #5950 (New): assertion failed for thread 0x7fffff152a40, thread-id 1: object_count == usedobjs (0x447 == 0x435), file ../zdb.c, line 1922
i have mirrored zpool data6 with 2x3TB sata drives attached to LSI 9211-8i
zdb failed with assertion:...
Igor Kozhukhov
06:34 AM Feature #5949: arc4random_addrandom() seems to be missing from arc4random(3C) suite
You can see in the OpenBSD commit history for "stdlib.h":http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/include/stdlib.... Joshua M. Clulow
05:09 AM Feature #5949: arc4random_addrandom() seems to be missing from arc4random(3C) suite
can you provide me with the references so that upstream libevent (and other dependent packages)
can take note...
...
Richard PALO
04:54 AM Feature #5949 (Rejected): arc4random_addrandom() seems to be missing from arc4random(3C) suite
We have neither @arc4random_stir()@, nor @arc4random_addrandom()@, entirely on purpose. OpenBSD removed these interf... Joshua M. Clulow
04:34 AM Feature #5949 (Rejected): arc4random_addrandom() seems to be missing from arc4random(3C) suite
apparently libevent (v2) expects arc4random_addrandom() if arc4random()/arc4random_buf() are provided.
So it would...
Richard PALO
12:25 AM Bug #5910: libnisdb won't build with modern GCC
Oops, I was looking at the wrong function. entriesFromLDAPthread() does indeed return a void pointer. The original ... Gary Mills

2015-05-24

08:02 PM Bug #5910: libnisdb won't build with modern GCC
The functions returns a void pointer. NULL shuts the compiler up but I'm not sure if it really is the right thing to... Andrew Stormont
07:26 PM Bug #5910: libnisdb won't build with modern GCC
That line:
+ return (NULL);
at the end of your change to usr/src/lib/libnisdb/db_mindex3.cc can't be right. NU...
Gary Mills
05:36 AM Bug #5948: drmach_init should support 12 cpus (not a power of 2)
(! this should be in illumos-gate, not openindiana... sorry) Richard PALO
05:10 AM Bug #5948 (New): drmach_init should support 12 cpus (not a power of 2)
[from discuss@]
Happy to have now a clone of our server board (supermicro H8SGL-F) for a
workstation, naturally wi...
Richard PALO
12:41 AM Bug #4879: Memory leak in protoString()
This omission is easy to fix, although testing it won't be so easy. Is it worth fixing? The protoString function is... Gary Mills

2015-05-23

05:41 PM Bug #5947 (Closed): NULL is not a character in asm10k.c
This simple patch is self-explanatory:... Richard PALO

2015-05-22

03:10 PM Bug #5211: 'fmadm repaired <record>' do not work with fault.fs.zfs.pool
Igor Kozhukhov wrote:
> [...]
Hi,
i can reproduce the problem using joyent_20150403T090417Z.
Fault class : fa...
Franz Skale
12:29 PM Bug #5946 (Closed): zfs_ioc_space_snaps must check that firstsnap and lastsnap refer to snapshots
At present @zfs_ioc_space_snaps()@ does not do much validation for @firstsnap@ and @lastsnap@ names, nor does it chec... Andriy Gapon
11:47 AM Bug #5945 (Closed): zfs_ioc_send_space must ensure that fromsnap refers to a snapshot
Currently neither @zfs_ioc_send_space@ nor @dmu_send_estimate@ check that @fromsnap@ is a snapshot name and @fromds@... Andriy Gapon

2015-05-21

07:46 AM Feature #2665: sd.conf should be able to override physical-block-size

Karena banyaknya serum korea kw murah dan berdampak buruk pada wajah maka kami membuat perbedaan serum korea ori da...
serum korea grosir kosmetik
07:26 AM Bug #5944: Related to 5943 (please merge)
Josten, there should be the Edit link on the bug page pointing to https://www.illumos.org/issues/5943/edit. You need ... Marcel Telka
03:36 AM Bug #5515 (Closed): dataset user hold doesn't reject empty tags
"git commit 752fd8dabccac68d6d09f82f3bf3561e055e400b":https://github.com/illumos/illumos-gate/commit/752fd8dabccac68d... Electric Monk

2015-05-20

06:44 PM Bug #5944: Related to 5943 (please merge)
Repeat step 3 until issue occurs. Josten L
06:40 PM Bug #5944 (Closed): Related to 5943 (please merge)
This is related to bug 5943 and includes instructions how to reproduce. I'm not seeing a way to add these reproductio... Josten L
04:59 PM Bug #5943: grub fails to boot when too many boot environments are present
will be better provide limit in config file, because it's not failed on my env with more boot env.
Igor Kozhukhov
04:56 PM Bug #5943 (New): grub fails to boot when too many boot environments are present
When too many boot environments are present (it is not clear how many is "too many", or whether the value is constant... Rich Lowe
04:43 AM Bug #5423: poll.h incompatible with gcc -std=c99
But shouldn't the system's own poll.h be not broken by C99 mode? Or is your argument that the interface exposed by po... Geoff Adams
12:42 AM Feature #5942 (Closed): integrate dmake
We're the only real consumer of dmake, and the only people likely to maintain an open copy (since nobody else uses it... Rich Lowe

2015-05-19

11:11 PM Bug #5941 (New): The rfscallnames_v4 array should contain less entries
The rfscallnames_v4 array should contain only the first and second entries: "RFS4_NULL" and "RFS4_COMPOUND". Everyth... Marcel Telka
10:45 PM Bug #5940 (New): Missing release_lockowner NFSv4 client stats
There is missing release_lockowner NFSv4 client stats.
To reproduce run the following two commands:...
Marcel Telka
10:34 PM Bug #5939 (New): NFS_ACL version 4 leftovers should be removed
The NFS_ACL protocol is an add-on protocol to NFS protocol to allow the ACL operations over the old NFSv2/v3 protocol... Marcel Telka
08:49 PM Bug #5931 (Closed): after svccfg import is killed, subsequent import fails
"git commit 254c049a4a15a87ed9928075be57535f41ae4c29":https://github.com/illumos/illumos-gate/commit/254c049a4a15a87e... Electric Monk
03:32 PM Bug #5818 (Closed): zfs {ref}compressratio is incorrect with 4k sector size
"git commit 81cd5c555f505484180a62ca5a2fbb00d70c57d6":https://github.com/illumos/illumos-gate/commit/81cd5c555f505484... Electric Monk
02:57 PM Bug #5638: SYSTEM hang
Summary:
We have some issues with the current version of OmniOS concerning the installation on the internal CF-car...
Frank B.
02:06 PM Bug #4442: t_bind() does not return negotiated qlen for /dev/tcp
Sachidananda Urs wrote:
> I thought, ret.qlen would have the negotiated qlen, and for tcp valid range is 1-429496729...
Marcel Telka
03:27 AM Bug #4442: t_bind() does not return negotiated qlen for /dev/tcp
Hi Marcel,
I thought, ret.qlen would have the negotiated qlen, and for tcp valid range is 1-4294967295. And though...
Sachidananda Urs
01:38 PM Bug #5938 (New): tmpfs locks processes in paging loop when there's no swap partition
I'm attaching three files: mapfile_reorder, mapfile-vers-jvm_dtrace, and vm.def. I took this from the openjdk7 buil... Dan McDonald
04:36 AM Bug #5928 (Closed): htable_walk strays into the VA hole
"git commit 8c1d5be330d8ad770aaaa74b0da6cac9139842af":https://github.com/illumos/illumos-gate/commit/8c1d5be330d8ad77... Electric Monk
04:34 AM Bug #3599 (Closed): dtrace_dynvar tail calls can blow stack
"git commit d47448f09aae3aa1a87fc450a0c44638e7ce7b51":https://github.com/illumos/illumos-gate/commit/d47448f09aae3aa1... Electric Monk
04:34 AM Bug #5930 (Closed): fasttrap_pid_enable() panics when prfind() fails in forking process
"git commit 9df7e4e12eb093557252d3bec029b5c382613e36":https://github.com/illumos/illumos-gate/commit/9df7e4e12eb09355... Electric Monk
12:22 AM Bug #5937 (Closed): sockaddr_in6 synopsis incorrect
"git commit 8412fdadc46d5bd0355a53fda7bda83e60803108":https://github.com/illumos/illumos-gate/commit/8412fdadc46d5bd0... Electric Monk

2015-05-18

09:37 PM Bug #5937 (Closed): sockaddr_in6 synopsis incorrect
It references the wrong header file. Should be netinet/in.h, there is no netinet/in6.h. Robert Mustacchi
07:56 PM Bug #3773: Dell BMC on R520 stops responding after bge driver loads
Ken Mays wrote:
> See: https://www.illumos.org/issues/3446
> Ref: http://kebe.com/~danmcd/webrevs/5719_5720_only/
...
Igor Kozhukhov
05:11 PM Bug #5934: localedef needs a native build
This was discovered as a part of working on 5935. Robert Mustacchi
05:08 AM Bug #5934 (Closed): localedef needs a native build
While working on improving libavl, I discovered that we never produce a native localedef against the target machine. ... Robert Mustacchi
05:10 AM Feature #5936 (Closed): AVL trees should be part of the DDI
As a counterpart to 5935 which adds libavl as a public, committed, library, we should add it to the DDI to allow driv... Robert Mustacchi
05:09 AM Feature #5935 (Closed): libavl should be a public interface
libavl should be a documented and committed interface. Robert Mustacchi
05:04 AM Feature #5933 (Closed): Makefile.man should take care of directory creation
Today the directories for manual pages such as man3c, etc. are all created by Targetdirs. Instead, we should just hav... Robert Mustacchi

2015-05-17

06:19 PM Bug #4442: t_bind() does not return negotiated qlen for /dev/tcp
Sachidananda Urs wrote:
> It matches your reproducer program output, i.e negotiated qlen is 1000, and the transport ...
Marcel Telka
06:04 PM Bug #4442: t_bind() does not return negotiated qlen for /dev/tcp
Marcel,
Man page says:...
Sachidananda Urs

2015-05-16

06:55 PM Bug #5815 (Closed): libzpool's panic function doesn't set global panicstr, ::status not as useful
"git commit fae6347731c9d3f46b26338313b0422927f29cf6":https://github.com/illumos/illumos-gate/commit/fae6347731c9d3f4... Electric Monk
06:54 PM Bug #5816 (Closed): mdb '::status' truncates assertion messages
"git commit 255ca53cb863784f137aca02aa15c67d8dce73de":https://github.com/illumos/illumos-gate/commit/255ca53cb863784f... Electric Monk
05:20 PM Feature #5885 (Closed): want a dcmd for going from netstack id to nestack_t
"git commit 589efa9501f3347f21e60905a96ca39427169e10":https://github.com/illumos/illumos-gate/commit/589efa9501f3347f... Electric Monk
05:20 PM Feature #5884 (Closed): want zid2zone
"git commit 589efa9501f3347f21e60905a96ca39427169e10":https://github.com/illumos/illumos-gate/commit/589efa9501f3347f... Electric Monk
05:20 PM Bug #5883 (Closed): race in netstack_unregister and zone creation
"git commit 589efa9501f3347f21e60905a96ca39427169e10":https://github.com/illumos/illumos-gate/commit/589efa9501f3347f... Electric Monk

2015-05-15

11:47 PM Bug #5893 (Closed): igmp timout logic induces panic
"git commit f5db8fb084e8d3d9f551ce34defa3c80d56edebc":https://github.com/illumos/illumos-gate/commit/f5db8fb084e8d3d9... Electric Monk
10:42 PM Bug #5931 (Closed): after svccfg import is killed, subsequent import fails
I've been debugging some issues where mdata:execute times out and SMF kills the contract while "svccfg import" is run... Robert Mustacchi
10:42 PM Bug #5840 (Closed): cmd/ypcmd build failed without usr/lib/libsocket.so on build host
"git commit e7619b69689d6a40a07425ef14002f2ab4d724d9":https://github.com/illumos/illumos-gate/commit/e7619b69689d6a40... Electric Monk
10:26 PM Bug #5930 (Closed): fasttrap_pid_enable() panics when prfind() fails in forking process
We saw a panic with the following stack trace:... Robert Mustacchi
10:05 PM Bug #5929 (Resolved): stale v_path slows vfs lookups
I was observing unusually slow (200ms/call) getcwd performance while perusing the illumos sources on my build box. (V... Robert Mustacchi
10:00 PM Bug #5928 (Closed): htable_walk strays into the VA hole
It would appear that hat_swapout() (or potentially just htable_walk()) does not cope terribly well when there is memo... Robert Mustacchi
09:56 PM Feature #5927: RFC 7539 support in EF
We already actually have ChaCha20 in libc and in common/crypto, so it should be fairly straightforward to plug it int... Robert Mustacchi
01:47 PM Feature #5927 (New): RFC 7539 support in EF
The illumos encryption framework allows relatively easy addition of new ciphers and hashes.
The ChaCha20 cipher an...
Dan McDonald
09:54 PM Feature #5897 (Closed): improve comments for svc.startd
"git commit 2ba6d2b94a398caab9e751c277f0acbd1cc22c77":https://github.com/illumos/illumos-gate/commit/2ba6d2b94a398caa... Electric Monk
09:54 PM Bug #5896 (Closed): svccfg import returns before service can be used by svcadm
"git commit 2ba6d2b94a398caab9e751c277f0acbd1cc22c77":https://github.com/illumos/illumos-gate/commit/2ba6d2b94a398caa... Electric Monk
08:34 PM Bug #5815: libzpool's panic function doesn't set global panicstr, ::status not as useful
Oh... nevermind. You're talking about explicit calls to panic().
The changes look fine. Sorry, it's been a long...
Gordon Ross
04:19 PM Feature #5888 (Closed): need ::scalehrtime dcmd
"git commit f7b98820db2e767eb246fc6aef8f740f838f03c6":https://github.com/illumos/illumos-gate/commit/f7b98820db2e767e... Electric Monk
04:19 PM Feature #5889 (Closed): want ::x86_featureset
"git commit 29f78cfa374064141c78641a37afda71a6408269":https://github.com/illumos/illumos-gate/commit/29f78cfa37406414... Electric Monk
04:19 PM Feature #5891 (Closed): want to be able to see x86 control regs with kmdb
"git commit 799823bbed51a695d01e13511bbb1369980bb714":https://github.com/illumos/illumos-gate/commit/799823bbed51a695... Electric Monk
04:19 PM Feature #5890 (Closed): Enable Intel SMEP support when available
"git commit 799823bbed51a695d01e13511bbb1369980bb714":https://github.com/illumos/illumos-gate/commit/799823bbed51a695... Electric Monk
04:18 PM Feature #5894 (Closed): Want big theory statement on MAC's data path
"git commit bc44a9330a5eaab897440aebd5b17691ec2c1d0a":https://github.com/illumos/illumos-gate/commit/bc44a9330a5eaab8... Electric Monk
12:30 AM Bug #5926 (Rejected): insert buffer between zfs send's read from disk and write to fd
To improve performance of "zfs send", we can decouple the reading of data off disk from the writing of the data to th... Matthew Ahrens
12:28 AM Bug #5925 (Closed): zfs receive -o origin=
Allow an incremental send stream to be received as a clone, even if the stream does not mark it as a clone. Matthew Ahrens

2015-05-14

05:17 PM Bug #4567 (Closed): Long RPC messages could confuse kernel and cause panic
"git commit 3b3b7026bde850c59ef70bb86cf2ca9e8d8011fc":https://github.com/illumos/illumos-gate/commit/3b3b7026bde850c5... Electric Monk
10:36 AM Bug #3661: Sync mDNS with upstream
Being outdated is causing problems for building CUPS too, as kDNSServiceFlagsShareConnection is missing.
Peter Tribble
12:05 AM Bug #5924 (New): System deadlocked in htable_steal_active
A VM with 2 GB of memory became unresponsive and eventually panicked due to ZFS deadman timer firing. While extractin... Alexander Kolbasov

2015-05-13

11:55 PM Bug #5923 (New): Panic on ht->ht_lock_cnt == 0 assertion in htable_release
One of the systems running end of December 2014 based bits of Illumos panicked with assertion failure:
ht->ht_lock...
Alexander Kolbasov
08:27 PM Bug #4567 (Pending RTI): Long RPC messages could confuse kernel and cause panic
Marcel Telka
02:02 PM Bug #4567: Long RPC messages could confuse kernel and cause panic
Code review: https://www.illumos.org/rb/r/53/ Marcel Telka
04:39 PM Bug #5920: mpt_sas panic when a SAS cable is disconnected
I did some additional testing. It appears the panic is triggered because the pool instantly has too many offline dis... Chip Schweiss
10:18 AM Feature #5922 (Closed): Want support for building with -fstack-protector
Stack smashing protection (in the form of gcc's -fstack-protector and family) is the default in the latest version of... Alex Wilson
08:55 AM Bug #5638: SYSTEM hang

the error is still there.
even after disabled SpeedStep.
Nor any idea ???
cat /etc/release
OmniOS v11 ...
Frank B.

2015-05-12

10:23 PM Bug #1691: zfs diff hardlinks problem
Michael Keller wrote:
> I find the current behaviour plain wrong because the user thinks that zdiff shows paths but ...
Albert Lee
09:30 PM Bug #3783 (Closed): Flow control is needed in rpcmod when the NFS server is unable to keep up with the network
"git commit 2695d4f4d1e2a6022c8a279d40c3cb750964974d":https://github.com/illumos/illumos-gate/commit/2695d4f4d1e2a602... Electric Monk
07:27 PM Bug #3783 (Pending RTI): Flow control is needed in rpcmod when the NFS server is unable to keep up with the network
Marcel Telka
09:18 PM Bug #5921 (Closed): Want a netbios_enable parameter in sharectl_smb
Want a new sharectl parameter for smb:... Gordon Ross
07:43 PM Bug #4567: Long RPC messages could confuse kernel and cause panic
*Root cause:*
We received very long write request:...
Marcel Telka
07:02 PM Feature #5819 (Closed): want dumpadm(1m) option to print estimated dump size
"git commit 7d593912b33208f97b6a9b5aa18d6bc0227c8a67":https://github.com/illumos/illumos-gate/commit/7d593912b33208f9... Electric Monk
01:32 PM Bug #5920 (New): mpt_sas panic when a SAS cable is disconnected
On a system with multiple LSI-9206-8e adapters all on firmware version 19, if any single cable is pulled the mpt_sas ... Chip Schweiss

2015-05-11

08:15 PM Bug #5840 (In Progress): cmd/ypcmd build failed without usr/lib/libsocket.so on build host
Igor Kozhukhov
02:45 PM Bug #5423: poll.h incompatible with gcc -std=c99
On the web, I've seen the same question asked about Linux. The underlying reason in both cases is that sigset_t is n... Gary Mills
02:07 PM Bug #5918: Memory leak when zfs_destroy_snaps_nvl fails
You could do a '::sysbp _exit' and run your test case from inside the mdb instead of adding the sleep(). Yuri Pankov
09:41 AM Bug #5918: Memory leak when zfs_destroy_snaps_nvl fails
I executed the sample program with the following command... Jan Schlien
08:59 AM Bug #5918 (New): Memory leak when zfs_destroy_snaps_nvl fails
The sample program attached simulates a failing snapshot destroy.
When executed, mdb shows the leak:...
Jan Schlien
12:23 PM Bug #5919 (New): svccfg import returns before service can be used by svcadm
Описание
On a heavily loaded system we've seen many cases where we get a message that's effectively:
svcadm: sv...
oleg poshpa
04:12 AM Feature #5917 (Closed): User-mode SMB server
Development of the SMB server kernel code can be accelerated
significantly by allowing the code to run in user space...
Gordon Ross
03:53 AM Feature #5916 (Closed): make libsqlite a real shared lib
The embedded copy of sqlite 2.8.15 used by svccfgd, idmapd, and smbd, is
currently built as a relocatable object an...
Gordon Ross

2015-05-10

02:12 AM Bug #5840: cmd/ypcmd build failed without usr/lib/libsocket.so on build host
The problem in this case was in the Makefile: it was missing `-L' link options that point to library locations in the... Gary Mills

2015-05-09

05:03 PM Bug #5269 (Closed): zpool import slow
"git commit 12380e1e701fda28c9e9f32d01cafb54af279eb5":https://github.com/illumos/illumos-gate/commit/12380e1e701fda28... Electric Monk

2015-05-08

10:20 PM Bug #5840: cmd/ypcmd build failed without usr/lib/libsocket.so on build host
Gary Mills wrote:
> I'll take this one. Omissions from the Makefile cause this problem. I know how to fix them.
...
Igor Kozhukhov
09:48 PM Bug #5840: cmd/ypcmd build failed without usr/lib/libsocket.so on build host
I'll take this one. Omissions from the Makefile cause this problem. I know how to fix them.
Gary Mills
07:44 PM Bug #5915 (New): msgpullup(9f) behaves as if len is always -1
Because of the following piece of code in the *msgpullup*(9f) implementation, the function ignores the passed value o... Marcel Telka
03:54 PM Bug #5612 (Closed): lpadmin dumps core in getlist
"git commit 00208914d51cd2f8ec864d0b732aa94a0e13a2ed":https://github.com/illumos/illumos-gate/commit/00208914d51cd2f8... Electric Monk
03:42 PM Bug #5899 (Closed): panic on bad mutex in smb_event_wait()
"git commit 856399cf160942495309c59ac7a9541834573cd3":https://github.com/illumos/illumos-gate/commit/856399cf16094249... Electric Monk
03:42 PM Bug #5900 (Closed): read-raw, write-raw are dead code
"git commit 380bdfdf3b87cbfda20ccdf5d4fa7c129623622b":https://github.com/illumos/illumos-gate/commit/380bdfdf3b87cbfd... Electric Monk
03:42 PM Bug #1663 (Closed): Non-empty directories can be marked delete on close in CIFS, but not actually deleted
"git commit 5496c1178a1a48006226450b13c2df195831794c":https://github.com/illumos/illumos-gate/commit/5496c1178a1a4800... Electric Monk
03:42 PM Bug #5901 (Closed): SMB clients get errors trying to delete non-empty directories
"git commit 5496c1178a1a48006226450b13c2df195831794c":https://github.com/illumos/illumos-gate/commit/5496c1178a1a4800... Electric Monk
09:26 AM Bug #5901: SMB clients get errors trying to delete non-empty directories
See https://github.com/huang96962/illumos-gate/commit/d6e25becda22cd0069ad001c61792dc18f03bae5 John Huang
03:42 PM Bug #5902 (Closed): Unable to take ownership, view permissions, or delete files...
"git commit 961125f22fcbbcf361c897aaf3f8be5b1dbceefe":https://github.com/illumos/illumos-gate/commit/961125f22fcbbcf3... Electric Monk
03:42 PM Bug #5904 (Closed): unable to save/modify files on CIFS share from Windows 7
"git commit 1fb4a876cbadf3a151ab8a149be6956199e83e22":https://github.com/illumos/illumos-gate/commit/1fb4a876cbadf3a1... Electric Monk
03:42 PM Bug #5903 (Closed): SMB server breaks an oplock on after an attribute (only) open
"git commit fb699f1e35c673b043b5de07040056cd5cb0b50e":https://github.com/illumos/illumos-gate/commit/fb699f1e35c673b0... Electric Monk
02:42 PM Bug #5898 (Closed): SO_RCVTIMEO broken for AF_UNIX
"git commit 412cc9e98decfe9afa3ce4f414bc04fd83c9f856":https://github.com/illumos/illumos-gate/commit/412cc9e98decfe9a... Electric Monk
07:14 AM Bug #5914 (New): pipe generates inodes with ino > 4G
The pipe() syscall generates inode pairs with an arbitrary inode number. This number is simply generated by increment... Arne Jansen

2015-05-07

10:36 PM Bug #3783: Flow control is needed in rpcmod when the NFS server is unable to keep up with the network
Code review: https://www.illumos.org/rb/r/49/ Marcel Telka
01:48 PM Bug #5913 (New): audit_syslog does not correctly parse exec events and spams the log file as a result.
The audit_syslog(5) plugin does not parse all events correctly. This results in not logging the event if configured t... Steven Williamson
12:34 PM Bug #2740 (Closed): zfs_rmnode() fails to clean up znodes
Closing per request. Yuri Pankov
11:54 AM Bug #2740: zfs_rmnode() fails to clean up znodes
Cannot reproduce this bug anymore. Probably fixed due to #4950
I think we can close this issue.
Simon Klinkert

2015-05-06

12:49 PM Bug #5912: full stream can not be force-received into a dataset if it has a snapshot
Proposed fix: https://reviews.csiden.org/r/220/ Andriy Gapon
12:37 PM Bug #5912 (Closed): full stream can not be force-received into a dataset if it has a snapshot
A full stream can not be force-received into a dataset if it has a snapshot.
That behavior is not consistent with th...
Andriy Gapon
12:21 PM Bug #5909: zfs_ioc_promote does not check new name length for shared snapshots
Proposed fix: https://reviews.csiden.org/r/219/ Andriy Gapon

2015-05-05

11:12 PM Bug #5753 (Closed): libnsl: set_up_connection() over TCP does not adhere the specified timeout
"git commit 7e89328164e4b89906924cf4e0387ea13a77631b":https://github.com/illumos/illumos-gate/commit/7e89328164e4b899... Electric Monk
09:07 PM Bug #5911 (Closed): ZFS "hangs" while deleting file
Sometimes ZFS appears to hang while deleting a file. It is actually making slow progress at the file deletion, but o... Matthew Ahrens
06:36 PM Bug #5651 (Closed): Missing header file sys/fs/s5ino.h referenced in /usr/src/cmd/acct/diskusg.c
"git commit 12844f5a6e6a4f8cb472dc421b8263103c55bd43":https://github.com/illumos/illumos-gate/commit/12844f5a6e6a4f8c... Electric Monk
05:32 PM Bug #5878 (Closed): Additional lint fixes for sunstudio12.1 and more modern OpenSSL
"git commit 37bbd7cc85ebfd31fbf68569b8b098e5448c9ce9":https://github.com/illumos/illumos-gate/commit/37bbd7cc85ebfd31... Electric Monk
05:32 PM Bug #4744 (Closed): remove traces of /var/sadm/system/admin/default_java
"git commit 4d0eb50e691de4c20b1dd9976ad6839fede8a42d":https://github.com/illumos/illumos-gate/commit/4d0eb50e691de4c2... Electric Monk
05:32 PM Bug #4743 (Closed): Fix deprecated /usr/j2se usage in slp and remove from filesystem(5) manpage
"git commit 4d0eb50e691de4c20b1dd9976ad6839fede8a42d":https://github.com/illumos/illumos-gate/commit/4d0eb50e691de4c2... Electric Monk
05:32 PM Bug #4742 (Closed): update manifests for javadoc7
"git commit 4d0eb50e691de4c20b1dd9976ad6839fede8a42d":https://github.com/illumos/illumos-gate/commit/4d0eb50e691de4c2... Electric Monk
05:32 PM Feature #4719 (Closed): update gate build environment to [open]jdk7
"git commit 4d0eb50e691de4c20b1dd9976ad6839fede8a42d":https://github.com/illumos/illumos-gate/commit/4d0eb50e691de4c2... Electric Monk
02:25 PM Feature #4498: update to ACPI version 6.x
i'd like to see update with directory tree what was provided by Yury P.
he provided changes for new directory struct...
Igor Kozhukhov
02:17 PM Feature #4498: update to ACPI version 6.x
Changeset from illumos-joyent: https://github.com/joyent/illumos-joyent/commit/435bba8aa5d73ccd0b9ec7c79e28bec795904992 Andrew Stormont
12:35 PM Bug #5612: lpadmin dumps core in getlist
I'll take this one. The problem was that getlist() was attempting to write to a static string, a string in read-only... Gary Mills
11:31 AM Bug #5910 (Closed): libnisdb won't build with modern GCC
libnisdb is suffering from the following issues which cause problems with newer versions of GCC:
- in nis_parse_ld...
Andrew Stormont
10:44 AM Bug #5909 (Closed): zfs_ioc_promote does not check new name length for shared snapshots
Or, more specifically, this should be a job of @dsl_dataset_promote_check()@.
Right now, if a clone has a longer nam...
Andriy Gapon
12:45 AM Bug #5908 (New): asy should not adjust line control or speed on attach
The @asy@ driver exposes each @COM@ port in an x86 system for use by usermode software (e.g. login sessions, etc). O... Joshua M. Clulow

2015-05-04

11:53 PM Bug #5907 (Closed): xdrmblk_getpos() is unreliable
The xdrmblk_getpos() implementation does not work as expected and it could easily panic the system, if not used caref... Marcel Telka
09:53 PM Bug #3914 (Closed): ill_frag_hash_tbl not allocated for loopback interfaces
"git commit f949c3862e64cd157f2a1aeefd0da08100f76173":https://github.com/illumos/illumos-gate/commit/f949c3862e64cd15... Electric Monk
09:14 PM Bug #5906 (New): beadm destroy fails when running from live image
When running from a live image (i.e. there is no current running boot environment), beadm will fail with "No such BE.... Dan Vatca
04:40 PM Bug #5905: wrong dn_maxblkid on dnode received to large_block dataset
I just did another test as well:
root@test:/home/tsoome# zpool create tank c3t2d0
root@test:/home/tsoome# beadm c...
Toomas Soome
04:05 PM Bug #5905: wrong dn_maxblkid on dnode received to large_block dataset
Matthew Ahrens wrote:
> I'm having a little trouble understanding the steps you took to get into this situation. Ca...
Toomas Soome
03:10 PM Bug #5905: wrong dn_maxblkid on dnode received to large_block dataset
I'm having a little trouble understanding the steps you took to get into this situation. Can you specify which zfs c... Matthew Ahrens
11:48 AM Bug #5905 (New): wrong dn_maxblkid on dnode received to large_block dataset
I have cloned the dataset recordsize=128k to another pool and new recordsize is 1M, I *think* I received to 1M datase... Toomas Soome
06:33 AM Bug #4866: arc_meta eats up all the ram and kills the system
it looks like the problem weas related to configuration (it was copied from other machine running Nexenta) - after fr... Dawid Stawiarski

2015-05-03

01:29 PM Bug #5555: mislabelled entries in syslog
I'm not sure. I'd have thought labelling should be left up to syslog entirely. Andrew Stormont
12:41 PM Bug #5555: mislabelled entries in syslog
I'm seeing the same thing with the stock syslog daemon:... Gary Mills

2015-05-02

03:00 AM Bug #5904 (Closed): unable to save/modify files on CIFS share from Windows 7
A Windows 7 client sends us write requests that we think are invalid because the request size is longer than 64k and ... Gordon Ross
02:55 AM Bug #5903 (Closed): SMB server breaks an oplock on after an attribute (only) open
The SMB oplock protocol (cache delegations) is complicated. We were needlessly revoking cache state (sending an "opl... Gordon Ross
02:49 AM Bug #5902: Unable to take ownership, view permissions, or delete files...
Server credentials were missing some Unix privileges that should be in place when the Windows privileges include "tak... Gordon Ross
02:46 AM Bug #5902 (Closed): Unable to take ownership, view permissions, or delete files...
When connected to the server as a user with administrative privileges, one should be able to "take ownership" of file... Gordon Ross
02:42 AM Bug #5901 (Closed): SMB clients get errors trying to delete non-empty directories
At the protocol level, we see that the client was allowed to set the "delete on close" flag on a directory when that ... Gordon Ross
02:36 AM Bug #5900 (Closed): read-raw, write-raw are dead code
The SMB1 "read_raw" and "write_raw" commands have always been optional,
and no recent Windows clients use them anymo...
Gordon Ross
02:28 AM Bug #5899: panic on bad mutex in smb_event_wait()
This is a fix we did back in Nov 2013.
There was an ordering problem in tear-down of the "events" support
and th...
Gordon Ross
02:23 AM Bug #5899: panic on bad mutex in smb_event_wait()
[ Analysis from Bayard Bell ]
The mutex does seem to be bad, but we can nevertheless link this to a thread, which ...
Gordon Ross
02:21 AM Bug #5899 (Closed): panic on bad mutex in smb_event_wait()
Here's the panic info and back-trace:... Gordon Ross
01:53 AM Bug #5898: SO_RCVTIMEO broken for AF_UNIX
We tracked this down to socktpi.c sotpi_recvmsg()
where it computes the timeout to pass to kstrgetmsg.
The fix is p...
Gordon Ross
01:47 AM Bug #5898 (Closed): SO_RCVTIMEO broken for AF_UNIX
After we changed the SMB server to use AF_UNIX sockets for SMB "named pipes", we noticed that recv calls on these soc... Gordon Ross
01:03 AM Feature #5897 (Closed): improve comments for svc.startd
As a companion to 5896, I wrote up a long blog entry on better understanding SMF which should be translated into a bl... Robert Mustacchi
12:55 AM Bug #5896 (Closed): svccfg import returns before service can be used by svcadm
On a heavily loaded system we've seen many cases where we get a message that's effectively:... Robert Mustacchi

2015-05-01

06:20 PM Bug #5879 (Closed): Additional check_rtime exceptions needed for non-OI illumos-gate compilation
"git commit cf2fa554171e6c444f2d90f4a58aea8926c7ffae":https://github.com/illumos/illumos-gate/commit/cf2fa554171e6c44... Electric Monk
05:41 PM Bug #5895 (Closed): mdb_alloc() succeeds for 4294967295 bytes in 32-bit process
While debugging a 32-bit dmod, I discovered it was calling mdb_alloc() with a size_t whose value had been decremented... David Pacheco
03:37 PM Bug #4518: lockd: Cannot establish NLM service over <file desc. 9, protocol udp>
Code review: https://www.illumos.org/rb/r/13/ Marcel Telka
03:37 PM Bug #5761: nfs4_prot.x should be updated for RFC 7531
Code review: https://www.illumos.org/rb/r/21/ Marcel Telka
03:36 PM Bug #5841: NFSv3 writes underneath mounted filesystem to directory
Code review: https://www.illumos.org/rb/r/31/ Marcel Telka
03:35 PM Bug #5753: libnsl: set_up_connection() over TCP does not adhere the specified timeout
Code review: https://www.illumos.org/rb/r/37/ Marcel Telka
03:35 PM Bug #5753 (Pending RTI): libnsl: set_up_connection() over TCP does not adhere the specified timeout
Marcel Telka
03:24 PM Bug #5851: usr/lib/pool/poold has incorrect run path after 4719
I've update https://www.illumos.org/rb/r/34/ with a version using runpath with a new variable JAVA_HOME
for specifyi...
Richard PALO
02:12 PM Feature #3233: zfs send should be receivable on other filesystems
We've rewritten the code substantially and tested for quite some time.It works pretty well, but has a few known esote... Arne Jansen
01:22 AM Bug #5763 (Closed): missing va_end() on return from __fini_daemon_priv()
"git commit 75598e109dfb54c4a0364e1544f5aff609d2c978":https://github.com/illumos/illumos-gate/commit/75598e109dfb54c4... Electric Monk
12:14 AM Bug #4492 (Closed): zone hung in down state, stuck in ilb_stack_fini
"git commit d17b05b6ba5ce4569b13b250fe44164219de8c53":https://github.com/illumos/illumos-gate/commit/d17b05b6ba5ce456... Electric Monk

2015-04-30

10:04 PM Feature #5894 (Closed): Want big theory statement on MAC's data path
This condense all of the knowledge accumulated as part of the overlay performance investigations into a big theory st... Robert Mustacchi
09:35 PM Bug #5651: Missing header file sys/fs/s5ino.h referenced in /usr/src/cmd/acct/diskusg.c
Actually,all of the sys/fs headers included in this file don't exist. There's no error message because diskusg.c is ... Gary Mills
08:38 PM Bug #5893 (Closed): igmp timout logic induces panic
We have two (at least) dumps in thoth in which igmp_slowtimo() has been invoked after the corresponding ip stack has ... Robert Mustacchi
08:29 PM Bug #5892 (New): CPU caps can throttle performance more than intended
From Brendan's original analysis:
CPU caps throttle performance more than intended. I suspect this may be due to t...
Robert Mustacchi
06:23 PM Feature #5891 (Closed): want to be able to see x86 control regs with kmdb
This adds a new dmod ::crregs that adds the ability to inspect the control registers. It only functions under kmdb. Robert Mustacchi
06:23 PM Feature #5890 (Closed): Enable Intel SMEP support when available
We should enable support for Intel's supervisor mode execution protection (SMEP) when it exists in the underlying pla... Robert Mustacchi
06:23 PM Feature #5889 (Closed): want ::x86_featureset
The x86_featureset it a bitmap vector that can often be a bit cumbersome to manually translate it into the appropriat... Robert Mustacchi
06:23 PM Feature #5888 (Closed): need ::scalehrtime dcmd
Increasingly in the system, timestamps are being recorded as TSCs (e.g., t_hrtime) – but this leaves them unscaled. S... Robert Mustacchi
05:02 PM Feature #5887 (Closed): want bootfs
This is the follow up to 5886 which provides a file system, bootfs, which can be used to see these boot-time objects ... Robert Mustacchi
05:01 PM Feature #5886 (Closed): want ability to provide additional objects at boot
It would be useful if there were a mechanism to provide the system with additional (arbitrary) objects at boot and ex... Robert Mustacchi
04:55 PM Feature #5885 (Closed): want a dcmd for going from netstack id to nestack_t
It'd be useful to have a dmod that can convert from a netstack id to the netstack itself. Robert Mustacchi
04:55 PM Feature #5884 (Closed): want zid2zone
It'd be useful to have a dcmd that can go from a zoneid_t to the corresponding zone_t. Robert Mustacchi
04:55 PM Bug #5883 (Closed): race in netstack_unregister and zone creation
Bill hit this again. I did a fresh analysis not looking at what we currently had.
Our stack looks like:...
Robert Mustacchi
04:34 PM Bug #5882 (Closed): Temporary pool names
This is an import of the temporary pool names functionality from ZoL:
https://github.com/zfsonlinux/zfs/commit/e22...
Richard Yao
03:09 PM Bug #4426 (Closed): mci_rw_lock white-hot under load
"git commit 3bb0cb708b0d9e3882b52efcf67a78f2a39baf90":https://github.com/illumos/illumos-gate/commit/3bb0cb708b0d9e38... Electric Monk
02:00 PM Bug #5461: #pragma align before the declaration
This certainly seems like a better solution than mine. Please proceed.
Gary Mills
10:59 AM Bug #5461: #pragma align before the declaration
The code builds fine with these changes (the removal of vm_cpu_data0 from vm_dep.h). I haven't tested the build yet ... Andrew Stormont
01:10 PM Bug #5881 (Closed): taskq.c: maxall vs. maxalloc in comments
Here in usr/src/uts/common/os/taskq.c the 'maxall' should be changed to 'maxalloc' to avoid confusion:... Marcel Telka
04:37 AM Bug #5596 (Closed): tar doesn't properly wait for its children
"git commit c536b1f93b31eba539c635a91be8ee2ab0fcb15a":https://github.com/illumos/illumos-gate/commit/c536b1f93b31eba5... Electric Monk
 

Also available in: Atom