illumos gate

2017-07-21

07:35 PM Bug #8521 (Closed): nvlist memory leak in get_clones_stat() and spa_load_best()

Yuri reported this to the mailing list:
doing a `reboot -d` on current illumos-gate HEAD gives the following "::fi... Prakash Surya

02:39 PM Feature #6234 (Closed): nvme should support polled I/O

"git commit 4ac9cfccca470985479d54f113ab420ee8215120":https://github.com/illumos/illumos-gate/commit/4ac9cfccca470985... Electric Monk

01:40 PM Bug #8520 (Closed): lzc_rollback_to should support rolling back to origin

lzc_rollback_to() should support rolling back to a clone's origin.
The current checks in zfs_ioc_rollback() would no... Andriy Gapon

01:32 PM Bug #8373: TXG_WAIT in ZIL commit path

https://github.com/openzfs/openzfs/pull/428 Andriy Gapon

04:43 AM Bug #7577 (Closed): mountd support to run on a fixed port

Gordon Ross

02:00 AM Bug #7577: mountd support to run on a fixed port

"git commit 2c3ccf749587e2b956c37993a8446f163fbfad57":https://github.com/illumos/illumos-gate/commit/2c3ccf749587e2b9... Electric Monk

04:43 AM Bug #7569 (Closed): statd support to run on a fixed port

Gordon Ross

02:00 AM Bug #7569: statd support to run on a fixed port

"git commit e72ff08d3b44e4e2f89e0ec84680f40062be00d5":https://github.com/illumos/illumos-gate/commit/e72ff08d3b44e4e2... Electric Monk

02:00 AM Feature #8330 (Closed): Add svc_tp_create_addr to libnsl

"git commit dec98d2aa2912b1fbd0abd2574307a695b566692":https://github.com/illumos/illumos-gate/commit/dec98d2aa2912b1f... Electric Monk

02:00 AM Bug #7287: smb pam module not picking up libsmb from proto area

"git commit 82584a069e2e3824df112a1249fa7818c01f9d49":https://github.com/illumos/illumos-gate/commit/82584a069e2e3824... Electric Monk

2017-07-20

06:09 PM Bug #8451 (Closed): cstyle: Remove space-tab sequences in usr/src/head

"git commit 6e270ca825f06ec0e2d77db462b83074ec585f2f":https://github.com/illumos/illumos-gate/commit/6e270ca825f06ec0... Electric Monk

05:48 PM Feature #8519 (Closed): Add ns_name_pton2 to libresolv2 mapfile

A missing ns_name_pton2 (__ns_name_pton2) SUNWPrivate interface is added for this issue. The library function was ori... C Fraire

05:34 PM Feature #8518 (Closed): Allow using system-generated IAID/DUID for all DHCPv4

By default, for an IPv4 interface that is not in an IP network multipathing (IPMP) group, that is not IP over InfiniB... C Fraire

05:10 PM Bug #8517: Add ipadm and nwam options to allow designating a DHCP address as the primary interface

Oops, this was meant to be a feature. C Fraire

04:04 PM Bug #8517 (Closed): Add ipadm and nwam options to allow designating a DHCP address as the primary interface

ifconfig has the following option:
primary
Defines the interface as the primary. ... C Fraire

03:32 PM Bug #8450 (Closed): UCODE_MAX_SIZE is too small for modern microcode

"git commit 36ee0868e847bc76173d0402abf2d9df271ad623":https://github.com/illumos/illumos-gate/commit/36ee0868e847bc76... Electric Monk

02:57 PM Bug #8516 (Feedback): Suppress gcc errors with -Wno- in Makefile for usr/src/cmd

While building illumos-gate usr/src/cmd with gcc-4.9.4, two types of gcc errors appeared that were difficult to corre... Gary Mills

09:50 AM Feature #8515 (Closed): remove audiovia97

audiovia97 is 32-bit only driver for hardware one can hardly find; as commented by Garrett D'Amore:
"So the audiov... Toomas Soome

08:03 AM Feature #2745: Allow filtering of properties on zfs receive

Hi,
Is the src code of what has been ported to nexenta available so that it just needs to be compiled to work unde... O F

07:23 AM Feature #8514: Reimport mDNSResponder-625.41.2 with include guards, and update documentation

C Fraire wrote:
> It would be helpful for continual synchronization of libdns_sd et al to Apple's version (and code ... Toomas Soome

2017-07-19

09:17 PM Bug #7530: Non-admin users unable to mount SMB shares

Any reason you haven't submitted this change for integration? Andrew Stormont

05:59 PM Bug #8496 (Closed): Multiple cores per socket does not work on Cloudstack KVM setup

"git commit 73789e670fa73c1961b0449d97b3be10fe3c28ac":https://github.com/illumos/illumos-gate/commit/73789e670fa73c19... Electric Monk

05:59 PM Bug #7915 (Closed): checks in l2arc_evict could use some cleaning up

"git commit 267ae6c3a88d2fc39276af66caafa978b0935b82":https://github.com/illumos/illumos-gate/commit/267ae6c3a88d2fc3... Electric Monk

03:40 PM Feature #8514 (New): Reimport mDNSResponder-625.41.2 with include guards, and update documentation

It would be helpful for continual synchronization of libdns_sd et al to Apple's version (and code review thereof) if ... C Fraire

02:55 PM Feature #7388: Support -h <hostname> for ipadm DHCP

Instead of using /etc/defaultdomain, which was clarified as being NIS-only, the patch was changed to add an ADOPT_DOM... C Fraire

03:46 AM Bug #8512: libstand won't build with GCC 7.1

This looks like a duplicate of #8500. Yuri Pankov

2017-07-18

10:27 PM Bug #8513: make: incomplete function cast in libbsd

Webrev: http://cr.illumos.org/~webrev/andy_js/8513/ Andrew Stormont

10:24 PM Bug #8513 (New): make: incomplete function cast in libbsd

Issue identified by GCC 7.1 Andrew Stormont

10:12 PM Bug #8512: libstand won't build with GCC 7.1

Webrev: http://cr.illumos.org/~webrev/andy_js/8512/ Andrew Stormont

10:07 PM Bug #8512 (Closed): libstand won't build with GCC 7.1

GCC 7.1 generates references to __divmoddi4 and __udivmoddi4 which need to be supplied by libstand. Andrew Stormont

09:41 PM Bug #8511 (New): mpt_sas driver no longer supports CD/DVD/BD (SCSI type 5) SATA devices

The log contains the following errors for all CD/DVD SATA devices:
Jul 17 16:49:12 omnios scsi: [ID 243001 kern.... Marcel Kroontje

09:02 PM Bug #8510: pcmcia: typo in pcmcia_prop_op

Webrev: http://cr.illumos.org/~webrev/andy_js/8510/ Andrew Stormont

08:30 PM Bug #8510 (New): pcmcia: typo in pcmcia_prop_op

An asterisk was used instead of an ampersand. Andrew Stormont

02:45 PM Bug #8449 (Closed): mdb inserts spurious newlines in wrapped input lines

"git commit 448027eb5d1a94f6ed4660dc460928b2d3b0ff11":https://github.com/illumos/illumos-gate/commit/448027eb5d1a94f6... Electric Monk

02:35 PM Bug #8509: ld has a trouble linking c++ code built by GCC 7.1

Webrev: http://cr.illumos.org/~webrev/andy_js/8509/ Andrew Stormont

02:01 PM Bug #8509 (In Progress): ld has a trouble linking c++ code built by GCC 7.1

Our handling for gnu.linkonce sections doesn't seem forgiving enough for GCC 7.1. The workaround is to loosen our ch... Andrew Stormont

04:15 AM Bug #8508 (Closed): Mounting a zpool on 32-bit platforms panics

Mounting a zpool on a 32-bit system triggers a panic in spa_history_log_version() due to a type format mismatch for Z... Justin Hibbits

01:50 AM Bug #8507 (Closed): dladm show-link segfaults if you specify too many fields

If you specify the same field more than once it causes a segfault:... Robert Mustacchi

01:22 AM Feature #8506 (Closed): ping name service warnings should only happen once

When we originally introduced the ping name services lookup warnings in 6211, we opted to warn once a minute. But in ... Robert Mustacchi

01:20 AM Feature #8505 (Closed): netstat should warn when name services are slow

As we've seen in cases like 6211 and 8503, when name services are not working, understanding what's going on in the s... Robert Mustacchi

01:19 AM Feature #8504 (Closed): traceroute should warn when name services are slow

As we've seen in cases like 6211 and 8503, when name services are not working, understanding what's going on in the s... Robert Mustacchi

01:18 AM Bug #8503 (Closed): snoop seems to delay packets doing DNS resolution

When running snoop without the "-r" option (which disables DNS lookups), it appears to do synchronous DNS lookups for... Robert Mustacchi

01:14 AM Bug #8502 (Closed): illumos#7955 broke delegated datasets when libshare is not present

The code in @lib/libzfs/common/libzfs_mount.c@ already basically handles the case when libshare is not installed. We ... Robert Mustacchi

01:11 AM Bug #8501 (Closed): ixgbe has uninitialized kstat fields

ixgbe creates a kstat based on the ixgbe_stat structure – but this structure has several fields that are only initial... Robert Mustacchi

2017-07-16

12:23 PM Feature #7584: Improve 'zpool labelclear' command

Here is the latest patch available so far. Ganael Laplanche

2017-07-15

08:58 AM Feature #7584: Improve 'zpool labelclear' command

FYI, a pull request is available here :
https://github.com/openzfs/openzfs/pull/424
with ongoing discussions + ... Ganael Laplanche

08:05 AM Bug #8500 (Closed): loader: need __divmoddi4 and __udivmoddi4

The gcc 7 is generating code using __divmoddi4 and __udivmoddi4.
Toomas Soome

07:50 AM Bug #8499 (Closed): ficl: this statement may fall through

The issue revealed by gcc 7 build:... Toomas Soome

07:45 AM Bug #8498 (Closed): ficl: variable 'count' might be clobbered by 'longjmp' or 'vfork'

Issue revealed by gcc 7 build:... Toomas Soome

07:37 AM Bug #8497 (Closed): ficl: ficlStackCheckNospill should be static inline

The problem revealed by gcc 7 build. The ficlStackCheckNospill is declared inline and without static, gcc 7 will inje... Toomas Soome

12:32 AM Bug #8496 (Closed): Multiple cores per socket does not work on Cloudstack KVM setup

When illumos is booted with a SMP configuration (multiple cores per socket) on a cloudstack kvm (linux kvm + qemu), i... Prashanth Sreenivasa

2017-07-14

10:08 PM Feature #8409 (Closed): Want MSG_NOSIGNAL to prevent SIGPIPE

"git commit f67b7b8d4cffb2612609ecbca47fc3d9e1d65d8a":https://github.com/illumos/illumos-gate/commit/f67b7b8d4cffb261... Electric Monk

10:05 PM Bug #8490 (Closed): Remove Sun/Solaris references from FMA messages

"git commit 756113e7507f01b9cb05e158cdba5c36df84e23e":https://github.com/illumos/illumos-gate/commit/756113e7507f01b9... Electric Monk

06:02 PM Bug #8457 (Closed): libstmf: psStmfProp and psStmfPropVal may be used uninitialized

"git commit 8fd2e913f04a71b9e820a088819d5b3d5205945b":https://github.com/illumos/illumos-gate/commit/8fd2e913f04a71b9... Electric Monk

04:26 PM Bug #8495 (New): nvmeadm does not seem to handle EUI64 namespace identifiers properly

While testing with a Micron card nvmeadm was unable to handle the EUI64 namespace identifier and started throwing err... Moinak Ghosh

04:11 PM Bug #8494 (New): NVMe driver should handle Firmware Reset status code

While testing with a Micron NVMe card I started getting errors from nvmeadm when changing the LBA format even though ... Moinak Ghosh

04:01 PM Bug #8040: NFSv4 client: 3-way deadlock between nfs4_bio(), nfs4_do_delegreturn(), and nfs4_flush_pages()

In short, this is a deadlock between taking resources:... Vitaliy Gusev

02:59 PM Bug #8478 (Closed): mac: suggest parentheses around '&&' within '||'

"git commit 76fb654b00249d6aa041522127c9503d69667164":https://github.com/illumos/illumos-gate/commit/76fb654b00249d6a... Electric Monk

02:38 PM Bug #8493 (Closed): kmem_move taskq appears to be inducing significant system latency

Note this is a change that logically combines Joyent's OS-4162 and OS-4949. The analysis from both tickets is include... Robert Mustacchi

02:26 PM Feature #8492 (Closed): AVX512 dis - legacy logical instructions

These existing instructions need EVEX prefix handling.
VPAND, VPANDN
VANDPD, VANDPS, VANDNPD, VANDNPS
VPORD,... Robert Mustacchi

2017-07-13

09:11 PM Bug #8460 (Closed): emlxs: passing argument discards volatile qualifier

"git commit 6b511167e8d56a74b24bdddf2937e6453ae54d1a":https://github.com/illumos/illumos-gate/commit/6b511167e8d56a74... Electric Monk

04:44 PM Bug #8419 (Rejected): Should not require four-space indents on function arg continuation lines

It appears I'm in the minority with concerns about these c-style changes.
Closing.
https://illumos.topicbox.com/gro... Gordon Ross

02:55 PM Bug #8462 (Closed): idmap: door_retried may be used uninitialized

"git commit 6c6416a920fdc28f97768efc3ce10124f1cb30f4":https://github.com/illumos/illumos-gate/commit/6c6416a920fdc28f... Electric Monk

02:32 PM Bug #8491 (Closed): uberblock on-disk padding to reserve space for smoothly merging zpool checkpoint & MMP in ZFS

The zpool checkpoint feature in DxOS added a new field in the uberblock.
The Multi-Modifier Protection Pull Reques... Serapheim Dimitropoulos

02:30 PM Bug #8490: Remove Sun/Solaris references from FMA messages

NOTE: Ideally, these files would be generated by an event registry. Alas, that appears to be offline/unavailable fo... Dan McDonald

02:25 PM Bug #8490 (Closed): Remove Sun/Solaris references from FMA messages

Reported internally at Joyent as OS-6167 and OS-6179, these two can combine into one large patch of .po files in the ... Dan McDonald

10:59 AM Bug #8489 (New): nfs4: server should warn if '/var/nfs/v4_state' doesn't exist

*/var/nfs/v4_state* and */var/nfs/v4_oldstate* are used to keep nfs4-client states.
nfs4-client states are us... Vitaliy Gusev

10:33 AM Feature #7584: Improve 'zpool labelclear' command

Hi everyone,
Finally, here is an improved version of the patch that builds
successfully on Illumos (that was appa... Ganael Laplanche

05:38 AM Bug #8488 (New): mdb: idm module doesn't need a copy of kernel's inet_ntop

mdb's idm module has a copy of kernel's inet_ntop (which does pad the IPv4 addresses with 0's), there doesn't seem to... Yuri Pankov

04:44 AM Bug #8421 (Closed): loader: chain load relocate data declaration is bad

"git commit 7b2aa5025b5cb19357aa7a3fb2d5630190d0c552":https://github.com/illumos/illumos-gate/commit/7b2aa5025b5cb193... Electric Monk

03:24 AM Bug #8487 (Closed): cfgadm_plugins/shp: memory leak in cfga_get_condition()

... Yuri Pankov

03:21 AM Bug #8486 (Closed): libdiskmgt: memory leak in slice_get_stats()

... Yuri Pankov

01:07 AM Bug #8485 (Closed): Remove set but unused variables in usr/src/cmd

GCC-4.9.4, and probably later versions, identifies variables that are set but not otherwise used in source files, wit... Gary Mills

12:35 AM Feature #8345 (Closed): want macros for SCSI WWN buffer lengths

"git commit 8b95ebbdc26a86f5cb0a11d23e49efed22600aa6":https://github.com/illumos/illumos-gate/commit/8b95ebbdc26a86f5... Electric Monk

12:35 AM Feature #8348 (Closed): mptsas_handle_topo_change() can return without locks held

"git commit 8221efec02725289918c06a850adcd7393394c8b":https://github.com/illumos/illumos-gate/commit/8221efec02725289... Electric Monk

12:35 AM Feature #8347 (Closed): mpt_sas needs to set bridge-port property for SATA devices

"git commit 8221efec02725289918c06a850adcd7393394c8b":https://github.com/illumos/illumos-gate/commit/8221efec02725289... Electric Monk

12:35 AM Feature #8346 (Closed): SES topology information needs to search STP Bridge ports

"git commit 8221efec02725289918c06a850adcd7393394c8b":https://github.com/illumos/illumos-gate/commit/8221efec02725289... Electric Monk

2017-07-12

04:26 AM Bug #8451 (Pending RTI): cstyle: Remove space-tab sequences in usr/src/head

Marcel Telka

12:35 AM Bug #8482 (Closed): usr/src/cmd/sgs/Makefile not quite correct after 8413

"git commit 2ec538a056d6d1e4285fb12d3921883339b6a1d0":https://github.com/illumos/illumos-gate/commit/2ec538a056d6d1e4... Electric Monk

2017-07-11

08:01 PM Bug #8484 (Closed): Implement aggregate sum and use for arc counters

In pursuit of improving performance on multi-core systems, we should
implements fanned out counters and use them to ... Prakash Surya

05:01 PM Bug #8458 (Closed): auditd_plugins: temp_minfree may be used uninitialized

"git commit 64ea2d201af526474ca5d8c66dc5e9aaab6d7ab4":https://github.com/illumos/illumos-gate/commit/64ea2d201af52647... Electric Monk

02:49 PM Feature #8330: Add svc_tp_create_addr to libnsl

The work submitted for RTI is a compromize between "no changes in libnsl" and "substantial changes in libnsl".
Where... Gordon Ross

02:06 AM Feature #8330: Add svc_tp_create_addr to libnsl

Why do we need to add a new function to @libnsl(3nsl)@ that would save us two lines of code only?
Detailed analysi... Marcel Telka

12:09 AM Feature #8330 (In Progress): Add svc_tp_create_addr to libnsl

Gordon Ross

02:24 PM Bug #8482: usr/src/cmd/sgs/Makefile not quite correct after 8413

To illustrate the issue, this simple makefile (when run with dmake and DMAKE_MAX_JOBS (or -j) > 1) shows it will star... Jason King

08:38 AM Bug #6111: zfs send should ignore datasets created after the ending snapshot

I have just discovered this change when I updated to FreeBSD 11, and I have to say that it breaks behaviour I relied ... Duane Leslie

02:47 AM Bug #8451: cstyle: Remove space-tab sequences in usr/src/head

Review: https://www.illumos.org/rb/r/623/ Marcel Telka

12:07 AM Bug #7577 (Pending RTI): mountd support to run on a fixed port

Gordon Ross

12:07 AM Bug #7569 (Pending RTI): statd support to run on a fixed port

Gordon Ross

2017-07-10

10:32 PM Bug #8482 (Closed): usr/src/cmd/sgs/Makefile not quite correct after 8413

When upstreaming Joyent OS-6188, a slight change was requested during review to usr/src/cmd/sgs/Makefile. However t... Jason King

05:57 PM Bug #8339 (Closed): col: misleading-indentation

"git commit d1e7d21548ce47b73fb16ec24a71987ddef57a0e":https://github.com/illumos/illumos-gate/commit/d1e7d21548ce47b7... Electric Monk

03:59 PM Bug #8481 (Closed): nvmeadm: nvme_dskname() string handling is buggy

There are two issues in nvme_dskname(). First, it is assumed that the output of di_dim_path_dev() either returns NULL... Hans Rosenfeld

03:56 PM Bug #8480 (Closed): nvmeadm should ignore 0-sized namespaces by default

Some NVMe devices come with some extra namespaces that use an invalid block size. nvmeadm will list them as 0-sized, ... Hans Rosenfeld

03:52 PM Bug #8479 (Closed): nvmeadm doesn't handle namespaces with EUI64

There's an issue with nvmeadm and namespaces having an EUI64. While nvmeadm can list them, it doesn't accept them as ... Hans Rosenfeld

01:55 PM Bug #8478: mac: suggest parentheses around '&&' within '||'

Webrev: http://cr.illumos.org/~webrev/andy_js/8478/ Andrew Stormont

01:43 PM Bug #8478 (Closed): mac: suggest parentheses around '&&' within '||'

This might not have any negative effect, but it's easily fixable, so lets fix it. Andrew Stormont

01:15 PM Bug #8429 (Closed): getallifaddrs dereferences invalid pointer causing SIGSEGV

"git commit 51c62b7bcb67b1e65d7e2773b20f465cf58b91b2":https://github.com/illumos/illumos-gate/commit/51c62b7bcb67b1e6... Electric Monk

01:09 PM Bug #8459 (Closed): i86pc: pci_tools.c variable might be clobbered

"git commit 1ee1bcba6f9a17099e11b5bb0d1eeab71c729aa3":https://github.com/illumos/illumos-gate/commit/1ee1bcba6f9a1709... Electric Monk

05:23 AM Bug #8477 (Closed): Assertion failed in vdev_state_dirty(): spa_writeable(spa)

Illumos 4080[1] allows "zpool clear" to work on readonly pools: i don't think this is the intended behaviour, we shou... Ezomori Nozomu

03:04 AM Feature #7938: disable LBA weighting on files and SSDs

Yuri Pankov wrote:
> James, are you still working on this?
Yes -- thanks for ping. Got busy with work. Patch is d... James Blachly

2017-07-09

01:33 PM Bug #8465: aggressive-loop-optimizations error in rt2860.c

I was hoping somebody would say that! I do want to fix the real bug, the one in the code. Last time I looked at the... Gary Mills

07:48 AM Bug #8465: aggressive-loop-optimizations error in rt2860.c

Please fix the real bug in the code instead of hacking the Makefile.
(The real bug is: When i = 35 you are accessi... Marcel Telka

2017-07-08

08:32 PM Bug #8452 (Closed): nightly(1onbld): Remove documentation for obsolete environment variables

"git commit 9a3f4540bd00a778a90414f9b90382ca540c91a4":https://github.com/illumos/illumos-gate/commit/9a3f4540bd00a778... Electric Monk

07:16 PM Bug #8452 (Pending RTI): nightly(1onbld): Remove documentation for obsolete environment variables

Marcel Telka

05:35 PM Bug #8465: aggressive-loop-optimizations error in rt2860.c

That's sensible. My only concern is including the version specific stuff in the Makefiles, which I'd rather not do b... Andrew Stormont

05:25 PM Bug #8465: aggressive-loop-optimizations error in rt2860.c

Gcc-4.4.4 will accept the -Wno-aggressive-loop-optimizations flag, but doesn't do anything with it. That's because g... Gary Mills

04:58 PM Bug #8465: aggressive-loop-optimizations error in rt2860.c

I agree with your analysis; the code looks fine. I am really not keen on putting fancy logic like this into the Make... Andrew Stormont

05:20 PM Bug #8476 (New): Non-blocking reads of terminal differ from S10XU8 and documentation

The attached test program should count up until a key is pressed. Then it counts down. Another key, counts up again... Jeff Woolsey

04:09 PM Bug #8475 (New): usr/src/boot should to use correct PATH to tools

i can see different PATH to GNU tools for loader build and they should be updated.
example:... Igor Kozhukhov

02:15 AM Bug #8474 (New): inet_ntop's addrlen argument should be socklen_t

To be standard compatible, and it will allow us to drop @smb_inet_ntop@, at least.
Currently, userland (libnsl for... Yuri Pankov

2017-07-07

10:20 PM Feature #8472 (Closed): Want docs for iports, tgtmaps, and friends

It'd be nice if we had some amount of documentation for more modern SCSI device interfaces, even if they're far from ... Robert Mustacchi

05:10 PM Bug #8470 (New): connect(3socket) should document timeout values

connect(3socket) documents that it can time out:... David Pacheco

04:58 PM Bug #8413 (Closed): Missing build dependencies when generating message catalogs

"git commit 9e01f10930c6fb3a8dd337cd38ed7b8e3d49a80b":https://github.com/illumos/illumos-gate/commit/9e01f10930c6fb3a... Electric Monk

04:17 PM Bug #8469 (New): dsm_serverid is leaked from dhcp_smach_s/dhcp_smach_t by free_smach

From an mdb of a core from:... C Fraire

03:48 PM Bug #8437 (Closed): dlmgmt_setzoneid() doesn't enforce uniqueness

"git commit b2519362c825a494fb6e93549e2e32a425011563":https://github.com/illumos/illumos-gate/commit/b2519362c825a494... Electric Monk

02:41 PM Feature #5980 (In Progress): in-kernel inet_ntop should format IPv4 addresses like userland one

Yuri Pankov

01:44 PM Bug #4380 (In Progress): iscsiadm usage message should be other side of privilege checks

Yuri Pankov

2017-07-06

09:54 PM Bug #3729: getifaddrs must learn to stop worrying and love the other address families

This was backed out because consumers have come to depend on this bug.
Namely libuv, while "multi-platform" had a ... Sebastian Wiedenroth

04:13 PM Bug #8466 (Closed): fix for 8268 forgot to actually ignore the namespaces with bad block size

"git commit 31c62b2533ba735118d04f02c094e23b6a18086c":https://github.com/illumos/illumos-gate/commit/31c62b2533ba7351... Electric Monk

12:06 PM Bug #8466 (Closed): fix for 8268 forgot to actually ignore the namespaces with bad block size

The changeset for bug #8268 adds a check for invalid block size but does not set ns_ignore = B_TRUE. Moinak Ghosh

01:27 PM Bug #8268: NVMe driver needs to ignore namespaces that specify an unused LBA Format

Thanks for confirming, I posted a webrev for review.
That nvmeadm output looks like we should hide ignored namespa... Hans Rosenfeld

12:14 PM Bug #8268: NVMe driver needs to ignore namespaces that specify an unused LBA Format

Okay I managed to confuse myself and then figure it out:
1) While testing your changeset I just hand edited the fi... Moinak Ghosh

10:41 AM Bug #8268: NVMe driver needs to ignore namespaces that specify an unused LBA Format

I'm not sure I follow your logic. In nvme_attach(), the check for ns_ignore comes before doing anything with blkdev. ... Hans Rosenfeld

06:39 AM Bug #8268: NVMe driver needs to ignore namespaces that specify an unused LBA Format

Sorry I got caught up with other things. Yes, my original patch didn't work and I moved the code block down. Your upd... Moinak Ghosh

01:08 AM Feature #7938: disable LBA weighting on files and SSDs

James, are you still working on this? Yuri Pankov

2017-07-05

09:44 PM Feature #3753: Add zfs receive property support (zfs recv -o)

Hi,
Nexenta has already implemented this feature. It is really great. Someone on the omnios mailinglist told me it... O F

06:58 PM Bug #8067: zdb should be able to dump literal embedded block pointer

"git commit 4923c69fddc0887da5604a262585af3efd82ee20":https://github.com/illumos/illumos-gate/commit/4923c69fddc0887d... Electric Monk

06:58 PM Bug #8126 (Closed): ztest assertion failed in dbuf_dirty due to dn_nlevels changing

"git commit dcb6872c565819ac88acbc2ece999ef241c8b982":https://github.com/illumos/illumos-gate/commit/dcb6872c565819ac... Electric Monk

06:29 PM Bug #8456 (Closed): libipsecutil: variable might be clobbered by longjmp

"git commit 80ad54c9895f9953b06c6f78e52ecf6493aa21d6":https://github.com/illumos/illumos-gate/commit/80ad54c9895f9953... Electric Monk

03:31 PM Bug #8465 (Closed): aggressive-loop-optimizations error in rt2860.c

In building illumos-gate with gcc-4.9.4 under Hipster, the following error appeared:... Gary Mills

03:31 PM Bug #5167 (Closed): git-pbchk fails to detect parent branch

"git commit 28e2b3ad0b14867ee7f3383890f6658e6e9448a1":https://github.com/illumos/illumos-gate/commit/28e2b3ad0b14867e... Electric Monk

05:38 AM Bug #8464 (Closed): audioconvert: cannot convert 'std::nullptr_t' to 'char' in assignment

Build error from gcc 6:... Toomas Soome

05:22 AM Bug #8463 (Closed): common/acl: 'resultcount' may be used uninitialized in this function

Build error from gcc 6:... Toomas Soome

05:13 AM Bug #8462 (Closed): idmap: door_retried may be used uninitialized

Build error from gcc 6:... Toomas Soome

05:07 AM Bug #8461 (Closed): fcip: 'tok_buf_size' may be used uninitialized in this function

Build issue from gcc 6:... Toomas Soome

04:55 AM Bug #8460 (Closed): emlxs: passing argument discards volatile qualifier

Build error from gcc 6:... Toomas Soome

04:39 AM Bug #8459 (Closed): i86pc: pci_tools.c variable might be clobbered

Build error from gcc 6:... Toomas Soome

2017-07-04

10:07 PM Bug #8458 (Closed): auditd_plugins: temp_minfree may be used uninitialized

Build error from gcc 6:... Toomas Soome

10:02 PM Bug #8457 (Closed): libstmf: psStmfProp and psStmfPropVal may be used uninitialized

Build error from gcc 6:... Toomas Soome

09:58 PM Bug #8456 (Closed): libipsecutil: variable might be clobbered by longjmp

Build error from gcc 6:... Toomas Soome

08:52 PM Feature #8455 (Closed): Simple post-mortem reporter for amd64 loader.efi

FreeBSD update https://svnweb.freebsd.org/base?view=revision&revision=r306090
The uefi loader has the problem that... Toomas Soome

05:06 PM Feature #4703 (Closed): would like xargs support for -P

"git commit 04427e3bf236c18cc532680b957267ee70b1037d":https://github.com/illumos/illumos-gate/commit/04427e3bf236c18c... Electric Monk

2017-07-03

04:51 PM Bug #8454 (Closed): libzpool build fails if no LINTLIB after 7431

build of libzpool failed if we have no LINTLIB target build
easy fix is:... Igor Kozhukhov

2017-07-02

11:34 AM Bug #7354: std::locale("") does not work properly

Illumos-site seems has been fixed: https://illumos.topicbox.com/groups/developer/discussions/Td23a09ce01f2967f
Sti... Julian Wiesener

11:17 AM Bug #7354: std::locale("") does not work properly

That problem is way older than illumos and has been repoted multiple time since 2004. Afaik there had been a few that... Julian Wiesener

04:37 AM Bug #8453 (New): a lot of 3xnet man pages seem to duplicate 3nsl

as the above, looking at .3xnet pages, they seem to be a candidates for garbage collect. Yuri Pankov

04:11 AM Bug #8452: nightly(1onbld): Remove documentation for obsolete environment variables

Review: https://www.illumos.org/rb/r/611/ Marcel Telka

04:03 AM Bug #8452 (Closed): nightly(1onbld): Remove documentation for obsolete environment variables

The nightly environment variables TOOLS_ROOT, TEAMWARE, and CHECK_DMAKE are documented in the nightly(1onbld) man pag... Marcel Telka

02:50 AM Bug #8451 (Closed): cstyle: Remove space-tab sequences in usr/src/head

We need to remove the space-tab sequences from all header files in @usr/src/head@ that are checked using the @cstyle(... Marcel Telka

2017-06-30

04:57 PM Bug #8438 (Closed): panic in vnode_valid_pn

"git commit 8902f61a33bdc50fa8815c0a787c286591fe12ef":https://github.com/illumos/illumos-gate/commit/8902f61a33bdc50f... Electric Monk

04:54 PM Bug #8373: TXG_WAIT in ZIL commit path

I was wrong about the ARC throttling having an effect on ZIL writes.
Because the ZIL write tx does not have any hold... Andriy Gapon

02:51 PM Bug #8425 (Closed): boot: create_ramdisk needs cleanup

"git commit 87bdc12930bfa66277c45510e399f8a01e06c376":https://github.com/illumos/illumos-gate/commit/87bdc12930bfa662... Electric Monk

12:00 AM Bug #3167 (Closed): kernel panic in apix:apic_timer_init

"git commit a51869cd883cf8c992f8920c767bb4b5939f3006":https://github.com/illumos/illumos-gate/commit/a51869cd883cf8c9... Electric Monk

2017-06-29

11:56 PM Bug #6901 (Closed): Multibyte regexec could be supported

To check that I'm not imagining things, I've added some printfs to regex routines and did a very simple test case wit... Yuri Pankov

11:02 PM Bug #6901: Multibyte regexec could be supported

I think the reporter is reading the code wrong, see how @regexec.c@ includes @engine.c@ several times, after setting ... Yuri Pankov

11:12 PM Bug #8416 (Closed): abd.h is not C++ friendly

"git commit 5e2a074725cb7c16ea1c6554da11ab4d6b4e7aee":https://github.com/illumos/illumos-gate/commit/5e2a074725cb7c16... Electric Monk

11:12 PM Bug #7910 (Closed): l2arc_write_buffers() may write beyond target_sz

"git commit 16a7e5ac116c85d965007a5f201104b564e82210":https://github.com/illumos/illumos-gate/commit/16a7e5ac116c85d9... Electric Monk

11:12 PM Bug #8378 (Closed): crash due to bp in-memory modification of nopwrite block

"git commit b7edcb940884114e61382937505433c4c38c0278":https://github.com/illumos/illumos-gate/commit/b7edcb940884114e... Electric Monk

11:12 PM Bug #8377 (Closed): Panic in bookmark deletion

"git commit 42418f9e73f0d007aa87675ecc206c26fc8e073e":https://github.com/illumos/illumos-gate/commit/42418f9e73f0d007... Electric Monk

11:12 PM Bug #7600 (Closed): zfs rollback should pass target snapshot to kernel

"git commit 77b171372ed21642e04c873ef1e87fe2365520df":https://github.com/illumos/illumos-gate/commit/77b171372ed21642... Electric Monk

11:12 PM Bug #8430 (Closed): dir_is_empty_readdir() doesn't properly handle error from fdopendir()

"git commit ba6e7e6505150388de6dc6a88741164118a421bf":https://github.com/illumos/illumos-gate/commit/ba6e7e6505150388... Electric Monk

11:12 PM Bug #8426 (Closed): mark immutable buffer arguments as such in abd.h

"git commit 9b195260e22529ac0e2580faaf89402420589c1c":https://github.com/illumos/illumos-gate/commit/9b195260e22529ac... Electric Monk

10:53 PM Bug #8318 (Closed): i40e polling panics on debug after 7865

"git commit 338749cb338b2e6a9942d1b744e92ba283f2cd01":https://github.com/illumos/illumos-gate/commit/338749cb338b2e6a... Electric Monk

10:15 PM Bug #8195 (Closed): calendar: misleading-indentation

the calendar got removed by "7948 Remove old calendar utility" Toomas Soome

10:13 PM Bug #8195 (Feedback): calendar: misleading-indentation

Toomas Soome

10:04 PM Bug #7948 (Closed): Remove old calendar utility

"git commit 719b66656b90abb6bcea4b0287075b2eaabb2de6":https://github.com/illumos/illumos-gate/commit/719b66656b90abb6... Electric Monk

10:02 PM Bug #8440 (Closed): loader: Don't bother to set target for SEEK_END

"git commit 1f2db76761b7bc2a0aa953a41cb1585a54b35666":https://github.com/illumos/illumos-gate/commit/1f2db76761b7bc2a... Electric Monk

07:32 AM Bug #8440 (Closed): loader: Don't bother to set target for SEEK_END

While there also collapase SEEK_END into default case in lseek.

https://svnweb.freebsd.org/base?view=revision&... Toomas Soome

08:39 PM Bug #8450 (Closed): UCODE_MAX_SIZE is too small for modern microcode

The modern x86 microcode files are getting larger than they historically have been. Today there are two different lim... Robert Mustacchi

08:38 PM Bug #8449 (Closed): mdb inserts spurious newlines in wrapped input lines

mdb inserts a (silent) newline into input buffers that exceed a line. As a result, if one attempts to cut-and-paste a... Robert Mustacchi

06:26 PM Bug #8439 (Closed): tools version of mandoc fails to build on pre-6790 systems

"git commit 8808b6ca868080736fca7df57b963793e6024266":https://github.com/illumos/illumos-gate/commit/8808b6ca86808073... Electric Monk

05:08 PM Bug #8387 (Closed): ps(1) should mention the -e behavior in more places

"git commit b51c78890d70a7955894b29cf2e174a6b98e53b2":https://github.com/illumos/illumos-gate/commit/b51c78890d70a795... Electric Monk

04:24 PM Bug #8437: dlmgmt_setzoneid() doesn't enforce uniqueness

webrev: http://us-east.manta.joyent.com/rpz/public/webrev/gate/8437/index.html
The @zoneid != GLOBAL_ZONE@ has no ... Ryan Zezeski

03:29 AM Bug #8437: dlmgmt_setzoneid() doesn't enforce uniqueness

Reproducing this on OmniOS was a bit different than SmartOS because the gate code doesn't allow setting properties du... Ryan Zezeski

04:15 PM Feature #8448 (Closed): uts: pci_autoconfig should test for BIOS

In case of UEFI system, we do not have BIOS data available. Toomas Soome

04:14 PM Feature #8447 (Closed): uts: acpica_check_bios_date() instead of bios-free, use efi-systab

In case of UEFI system, we do not have BIOS data available. Replace the "bios-free" property check with check for "ef... Toomas Soome

04:14 PM Feature #8446 (Closed): uts: pci_check_bios() should check for BIOS

In case of UEFI system, we do not have BIOS data available. Toomas Soome

04:13 PM Feature #8445 (Closed): uts: pci_bios_get_irq_routing() should check for BIOS

In case of UEFI system, we do not have BIOS data available. Toomas Soome

04:13 PM Feature #8444 (Closed): uts: set_console_mode() should check for BIOS

In case of UEFI system, we do not have BIOS data available. Toomas Soome

04:12 PM Feature #8443 (Closed): uts: progressbar_init() should check for BIOS

In case of UEFI system, we do not have BIOS data available. Toomas Soome

04:11 PM Feature #8442 (Closed): uts: startup_bios_disk() should check for BIOS

In case of UEFI system, we do not have BIOS data available. Toomas Soome

04:10 PM Feature #8441 (Closed): uts: apic_probe_common() should check for BIOS

In case of UEFI system, we do not have BIOS data available. Toomas Soome

2017-06-28

11:02 PM Bug #8439 (Closed): tools version of mandoc fails to build on pre-6790 systems

new mandoc version wants endian.h, and we fail to build native version of mandoc on systems without 6790. Yuri Pankov

09:11 PM Bug #8433 (Closed): vmxnet3: warnings about not supported properties don't help anything

"git commit 5ceaf02ccc1885ec3499b7d79f2a80ce1325b4d8":https://github.com/illumos/illumos-gate/commit/5ceaf02ccc1885ec... Electric Monk

08:12 PM Bug #8438 (Closed): panic in vnode_valid_pn

When the wad for 8376 was put together, one of the necessary changes, "OS-3991":https://smartos.org/bugview/OS-3991, ... Patrick Mooney

07:47 PM Bug #8437 (Closed): dlmgmt_setzoneid() doesn't enforce uniqueness

As reported in great detail by "OS-1457":https://smartos.org/bugview/OS-1457, the @dlmgmt_setzoneid()@ function doesn... Ryan Zezeski

06:38 PM Bug #8435 (Closed): zpool.1m and zfs.1m: minor cleanup

This commit is a result of re-read while porting zpool.1m to ZFSonLinux.
See https://github.com/zfsonlinux/zfs/com... George Melikov

05:40 PM Bug #5167 (In Progress): git-pbchk fails to detect parent branch

hijacking the ticket to cherry-pick fix from illumos-nexenta. Yuri Pankov

03:40 PM Bug #8434 (New): dladm(1M) should mention vrrp support

The usage message for dladm mentions support for dladm create-vnic -m vrrp -V <id>. We should make sure that this is ... Robert Mustacchi

03:24 PM Bug #1198 (Closed): date formats contain spaces where not expected

"git commit 5206305f06cf80338a34e00287f3336069e1198b":https://github.com/illumos/illumos-gate/commit/5206305f06cf8033... Electric Monk

03:24 PM Bug #7962 (Closed): strxfrm() fails for certain characters

"git commit f862e02cb8d597e430ef5067be483718a65c3370":https://github.com/illumos/illumos-gate/commit/f862e02cb8d597e4... Electric Monk

03:09 PM Bug #6019 (Closed): sleep can't be infinite

"git commit bec2e3ffadac8d3536ea115d636d06c7b561623a":https://github.com/illumos/illumos-gate/commit/bec2e3ffadac8d35... Electric Monk

03:09 PM Bug #8212 (Closed): manpages contain obsolete references

"git commit bec2e3ffadac8d3536ea115d636d06c7b561623a":https://github.com/illumos/illumos-gate/commit/bec2e3ffadac8d35... Electric Monk

03:09 PM Bug #8228 (Closed): cstyle: Remove space-tab sequences in /* All Rights Reserved */

"git commit b4203d757c7c247e39c94c09a94021a3a8121062":https://github.com/illumos/illumos-gate/commit/b4203d757c7c247e... Electric Monk

03:09 PM Feature #8309 (Closed): libbsm should support AUE_sudo audit event

"git commit 73177167911de9eef96901d8f6d3cb6be7c67574":https://github.com/illumos/illumos-gate/commit/73177167911de9ee... Electric Monk

03:09 PM Bug #8428 (Closed): 8367 breaks cmlb module install on sparc

"git commit 5549034d757a8b1a23f3957d95e4e9e440c44ebf":https://github.com/illumos/illumos-gate/commit/5549034d757a8b1a... Electric Monk

04:48 AM Bug #2850 (Closed): Russian locale does not need am/pm

Rereading this 5 years later, and it still doesn't make much sense. If you don't need the am/pm, simply don't use %p... Yuri Pankov

04:19 AM Bug #4613 (Closed): Many functions in cmn_err.h aren't documented.

I think we have everything that this describes already documented, please reopen if we are still missing anything.
... Yuri Pankov

2017-06-27

10:22 PM Bug #8433 (Closed): vmxnet3: warnings about not supported properties don't help anything

and are actually annoying, doing a simple @dlstat -i1@ spews a lot of noise like below to the log, and what's worse, ... Yuri Pankov

02:14 PM Bug #8427 (Closed): update nvme theory statement for 7296

"git commit 0b466603bce1aab6133ee3b3c8fb941d5c83bf16":https://github.com/illumos/illumos-gate/commit/0b466603bce1aab6... Electric Monk

02:14 PM Bug #8268 (Closed): NVMe driver needs to ignore namespaces that specify an unused LBA Format

"git commit 621738e24ed094c80643e1cd8d545241ae1978b1":https://github.com/illumos/illumos-gate/commit/621738e24ed094c8... Electric Monk

05:11 AM Bug #7962 (In Progress): strxfrm() fails for certain characters

proposing the temporary fix until upstream data is updated. Yuri Pankov

05:11 AM Bug #1198 (In Progress): date formats contain spaces where not expected

proposing the temporary fix until upstream data is updated. Yuri Pankov

12:27 AM Bug #8432 (New): zpool(1M) and zfs(1M) need to better describe allowed characters in dataset names

currently, zpool(1M) has the following:... Yuri Pankov

2017-06-26

08:25 PM Bug #8424 (Closed): usr/src/tools/mandoc should take advantage of NATIVE_ADJUNCT

"git commit 10f4f8a67e909a279f956222b089093a60da6bf9":https://github.com/illumos/illumos-gate/commit/10f4f8a67e909a27... Electric Monk

08:24 PM Bug #8418 (Closed): zfs_prop_get_table() call in zfs_validate_name() is a no-op

"git commit e09ba01dcda5e24964b8632718777b39166d86e4":https://github.com/illumos/illumos-gate/commit/e09ba01dcda5e249... Electric Monk

07:46 PM Bug #8418 (Pending RTI): zfs_prop_get_table() call in zfs_validate_name() is a no-op

Marcel Telka

05:42 PM Bug #3729: getifaddrs must learn to stop worrying and love the other address families

"git commit f67cf39ba88ad7c4bee81445cc7a7468e0289f01":https://github.com/illumos/illumos-gate/commit/f67cf39ba88ad7c4... Electric Monk

04:14 PM Bug #8430 (Closed): dir_is_empty_readdir() doesn't properly handle error from fdopendir()

we should close dirfd if fdopendir() fails. Serapheim Dimitropoulos

04:12 PM Bug #8429: getallifaddrs dereferences invalid pointer causing SIGSEGV

Webrev: http://cr.illumos.org/~webrev/andy_js/8429/ Andrew Stormont

04:05 PM Bug #8429 (Closed): getallifaddrs dereferences invalid pointer causing SIGSEGV

Found this when booting with the datalink-management service disabled -- which I don't recommend. Andrew Stormont

03:47 PM Bug #8428 (In Progress): 8367 breaks cmlb module install on sparc

my mistake.. Yuri Pankov

03:37 PM Bug #8428 (Closed): 8367 breaks cmlb module install on sparc

no cmlb module build.
in file:
usr/src/uts/sparc/cmlb/Makefile
removed line:
-ROOTMODULE = $(ROOT_MISC_DIR)/$(M... Igor Kozhukhov

03:21 PM Bug #8391: mr_sas controller lockup on Dell H330

Michael Loftis wrote:
> Juergen Gotteswinter wrote:
> > Your description sounds more like the usual effects of SATA... Michael Loftis

03:19 PM Bug #8391: mr_sas controller lockup on Dell H330

Juergen Gotteswinter wrote:
> Your description sounds more like the usual effects of SATA Disks hooked up to a SAS H... Michael Loftis

12:38 PM Bug #8391: mr_sas controller lockup on Dell H330

Your description sounds more like the usual effects of SATA Disks hooked up to a SAS HBA. Juergen Gotteswinter

02:21 PM Feature #6431 (Closed): document FreeBSD regex extensions

"git commit 7edb9f69d2426b044fa60c7a168c9eaeb12f1884":https://github.com/illumos/illumos-gate/commit/7edb9f69d2426b04... Electric Monk

01:47 PM Feature #7431 (Closed): ZFS Channel Programs

"git commit dfc115332c94a2f62058ac7f2bce7631fbd20b3d":https://github.com/illumos/illumos-gate/commit/dfc115332c94a2f6... Electric Monk

12:26 PM Bug #8427 (Closed): update nvme theory statement for 7296

When we changed nvme to use single-message MSI(-X) interrupts for the initial interrupt we didn't update the theory s... Hans Rosenfeld

10:48 AM Bug #8426: mark immutable buffer arguments as such in abd.h

https://github.com/openzfs/openzfs/pull/413 Andriy Gapon

10:44 AM Bug #8426 (Closed): mark immutable buffer arguments as such in abd.h

abd_copy_from_buf and abd_cmp_buf do not modify their void *buf arguments, so qualify them with const.
abd_copy_from... Andriy Gapon

2017-06-25

08:25 AM Bug #8425 (Closed): boot: create_ramdisk needs cleanup

Work by Josef 'Jeff' Sipek <jeffpc@josefsipek.net>:
boot: remove hsfs support from create_ramdisk
bootadm itself ... Toomas Soome

2017-06-24

04:35 PM Bug #7766 (Closed): want uintptr32_t in sys/types32.h

"git commit 2bfbf3e38cde3935b773e2d8deacd336d5f69172":https://github.com/illumos/illumos-gate/commit/2bfbf3e38cde3935... Electric Monk

04:35 PM Feature #6235 (Closed): want NVMe management utility

"git commit 3d9b1a2a543845425f021c3f896a07b1deff87c9":https://github.com/illumos/illumos-gate/commit/3d9b1a2a54384542... Electric Monk

04:29 PM Bug #8420 (Closed): loader.efi: EFI_MEMORY_DESCRIPTOR and EFI_BLOCK_IO_MEDIA need padding

"git commit feff18a41e45afb02478e67d56fad5027334f115":https://github.com/illumos/illumos-gate/commit/feff18a41e45afb0... Electric Monk

2017-06-23

09:14 PM Bug #8388 (Closed): Too many errrrrrrrors

"git commit 4cad604c8f7a70d13a2b3235019bd05a137bdc3b":https://github.com/illumos/illumos-gate/commit/4cad604c8f7a70d1... Electric Monk

06:56 PM Bug #8424 (Closed): usr/src/tools/mandoc should take advantage of NATIVE_ADJUNCT

Upstream of Joyent OS-5604[https://smartos.org/bugview/OS-5604]. Work by Jerry Jelinek.
mandoc now uses libz, and... Jason King

05:40 PM Feature #8423 (Closed): Implement large_dnode pool feature

8423 Implement large_dnode pool feature
8199 multi-threaded dmu_object_alloc()
ZoL issues:
Improved ... Matthew Ahrens

04:53 PM Bug #8418: zfs_prop_get_table() call in zfs_validate_name() is a no-op

Review: https://www.illumos.org/rb/r/599/ Marcel Telka

11:22 AM Feature #8422 (Closed): uts: basic UEFI support for illumos

Just another bit in the chain. Add the basic definitions and populate the information based on MB2 info. Perhaps it i... Toomas Soome

09:33 AM Bug #8421 (Closed): loader: chain load relocate data declaration is bad

The coverity finding from freebsd; see also https://reviews.freebsd.org/D11321.
The BIOS chain loading is using th... Toomas Soome

09:27 AM Bug #8419: Should not require four-space indents on function arg continuation lines

The reason for having so much code not conforming to cstyle is about the fact that we are normally fixing the style a... Toomas Soome

2017-06-22

10:37 PM Feature #8344 (Closed): libc ulwp walker should use CTF for uberdata offsets

"git commit e0ee3ced1741d2c52b01a4527f8504cb24701b58":https://github.com/illumos/illumos-gate/commit/e0ee3ced1741d2c5... Electric Monk

08:18 PM Bug #8419: Should not require four-space indents on function arg continuation lines

I think I disagree with your premise here; all forms allowed by the style guide are (or should be, there could be bug... Paul Dagnelie

07:39 PM Bug #8419: Should not require four-space indents on function arg continuation lines

Proposed fix: Allow either four-space or tab indent for function arg continuation lines.
Gordon Ross

05:25 PM Bug #8419 (Rejected): Should not require four-space indents on function arg continuation lines

I'm taking issue with the 2nd part of the description in #6459
> Additionally, if a function has a very long heade... Gordon Ross

07:58 PM Bug #8420 (Closed): loader.efi: EFI_MEMORY_DESCRIPTOR and EFI_BLOCK_IO_MEDIA need padding

The problem is revealed in 32-bit version; unfortunately the specification is not really too clear either. Fix confir... Toomas Soome

06:36 PM Feature #7388: Support -h <hostname> for ipadm DHCP

A missing ns_name_pton2 (__ns_name_pton2) SUNWPrivate interface is added for this issue. The library function was ori... C Fraire

05:22 PM Bug #6459: cstyle doesn't detect opening braces on the same line as function header

Unfortunately, the 2nd part of this bug description:
> Additionally, if a function has a very long header, it is s... Gordon Ross

01:27 PM Bug #8418 (Closed): zfs_prop_get_table() call in zfs_validate_name() is a no-op

The following line in @zfs_validate_name()@ is just a no-op and it should be removed:... Marcel Telka