Project

General

Profile

Activity

From 2018-11-04 to 2018-12-03

2018-12-03

07:56 PM Bug #10014: bootadm: menu_free() is accessing freed memory
Toomas tested this by running @bootadm list-menu@. Joshua Clulow
06:43 PM Feature #9987 (Closed): loader.efi: add version support
"git commit 7d1eae8c55720848a7a807e8b76f4b8c7e339af3":https://github.com/illumos/illumos-gate/commit/7d1eae8c55720848... Electric Monk
02:33 PM Bug #9975 (Closed): loader.efi: unused variable 'err'
"git commit 2b811402e28c1eea57dd7a5e98c7f1c72637ffd9":https://github.com/illumos/illumos-gate/commit/2b811402e28c1eea... Electric Monk
02:22 PM Bug #10002 (Closed): librcm: bitwise comparison always evaluates to false
"git commit f111a354011b4b6a93d3b8d94aa06a982d8c7686":https://github.com/illumos/illumos-gate/commit/f111a354011b4b6a... Electric Monk
12:22 PM Feature #10040 (Closed): loader: gfx use GOP Blt() function in visual_io callbacks
Use (UEFI) Blt() in hope it will perform better. The BIOS version will draw directly on framebuffer. Toomas Soome
12:19 PM Feature #10039 (Closed): loader: build rules for new font setup
use common font management, implement font load and switch code in loader Toomas Soome
12:17 PM Feature #10038 (Closed): loader: replace gop and vesa with framebuffer
implement one single command to manage the framebuffer console Toomas Soome
12:16 PM Feature #10037 (Closed): loader: add illumos.png logo
Add sample illumos logo. Toomas Soome
12:15 PM Feature #10036 (Closed): ficl: add fb-putimage
Add word:
fb-putimage (addr size | flag ) -- put image from named file
At this time, we only draw at lower right ...
Toomas Soome
12:12 PM Feature #10035 (Closed): loader: add alpha blending for gfx_fb
To draw text on image, we need alpha blending. Toomas Soome
12:11 PM Feature #10034 (Closed): loader: use term-drawrect for menu frame
Update the loader scripts to draw the menu Toomas Soome
12:07 PM Feature #10033 (Closed): ficl: add simple gfx words
add words:
fb-setpixel ( x y ) -- light pixel at given coordinates
fb-line (x0 y0 x1 y1 wd ) -- draw the stright li...
Toomas Soome
11:57 AM Feature #10032 (Closed): loader: implement tem utf-8 support
As the tem is available, we need to make it to support to display utf-8 byte streams. Toomas Soome
11:55 AM Feature #10031 (Closed): loader: import tem for loader console
We need better terminal emulator in loader. Using the one from our kernel will allow to create consistent console flo... Toomas Soome
11:53 AM Feature #10030 (Closed): import pnglite into usr/src/common/pnglite
Add pnglite code to put png files on display Toomas Soome
11:48 AM Feature #10029 (Closed): common/font: create shared font.c
Pick up uts/common/font/font.c and build shared font handling code from it. Will be shared between the boot loader an... Toomas Soome
11:45 AM Feature #10028 (Closed): loader: implement framebuffer console
Create common (linear framebuffer based) graphical local console with our own terminal emulator.
The UEFI does pro...
Toomas Soome
07:11 AM Bug #10027 (Closed): loader: common/ufsread: variable 'indbuf' set but not used
Build error with warnings enabled:... Toomas Soome

2018-12-02

08:27 PM Feature #10026 (Closed): common/sha1: update for loader build
Adjust usr/src/common/sha1 code to make it possible to build from loader (standalone) context. This will make it poss... Toomas Soome
09:06 AM Bug #10025 (Closed): qede: rename OFFSETOF to offsetof and remove local definitions
We do have the compact definitions already, cleaning up the qede a bit. Toomas Soome
07:52 AM Bug #9731 (Closed): uts: update sys/queue.h
"git commit 85280f08e3cfa2e404951ad6817bbb974b576858":https://github.com/illumos/illumos-gate/commit/85280f08e3cfa2e4... Electric Monk
07:35 AM Bug #9731: uts: update sys/queue.h
h2. Testing Addendum
I have checked out a current copy of "oi-userland":https://github.com/OpenIndiana/oi-userland...
Joshua Clulow

2018-12-01

07:35 AM Bug #10024 (Closed): loader: set command_errmsg to NULL after printing it out
When handling CMD_CRIT error set command_errmsg to NULL after we dump it out,
so that it does not result in err...
Toomas Soome
07:13 AM Bug #10023 (Closed): loader: command_bcache is using %d with unsigned data
Change %d to %u. Toomas Soome
05:51 AM Bug #9818 (Closed): xhci_transfer_get_tdsize can return values that are too large
"git commit 2aba3acda67326648fd60aaf2bfb4e18ee8c04ed":https://github.com/illumos/illumos-gate/commit/2aba3acda6732664... Electric Monk
05:51 AM Feature #8550 (Closed): increase xhci bulk transfer sgl count
"git commit 2aba3acda67326648fd60aaf2bfb4e18ee8c04ed":https://github.com/illumos/illumos-gate/commit/2aba3acda6732664... Electric Monk
05:51 AM Bug #9817 (Closed): xhci needs to always set slot context
"git commit 2aba3acda67326648fd60aaf2bfb4e18ee8c04ed":https://github.com/illumos/illumos-gate/commit/2aba3acda6732664... Electric Monk
05:51 AM Feature #9816 (Closed): Multi-TRB xhci transfers should use event data
"git commit 2aba3acda67326648fd60aaf2bfb4e18ee8c04ed":https://github.com/illumos/illumos-gate/commit/2aba3acda6732664... Electric Monk

2018-11-30

11:12 PM Bug #10000 (Closed): loader: stop using ../zfs/libzfs.h but instead use libzfs.h
"git commit 3d4c0714448bf50d3c38268aa5fab56fef0ee496":https://github.com/illumos/illumos-gate/commit/3d4c0714448bf50d... Electric Monk
11:12 PM Bug #10007 (Closed): loader: remove bcache marker code
"git commit 9a637b377bec2a77cf25efdc06a6e8bc8f129a69":https://github.com/illumos/illumos-gate/commit/9a637b377bec2a77... Electric Monk
11:12 PM Bug #10009 (Closed): btxld: handle versioning better
"git commit b59f980dbdb21de19e1c25db4b9b9d558ab69def":https://github.com/illumos/illumos-gate/commit/b59f980dbdb21de1... Electric Monk
10:27 PM Feature #9981 (Closed): loader: add set-module-path to support scripting the module load path change
"git commit f2aacf291ef503fdf8ae4e69995bee851d6d10ae":https://github.com/illumos/illumos-gate/commit/f2aacf291ef503fd... Electric Monk
10:07 PM Bug #10008 (Closed): libstand: gets.c cstyle cleanup
"git commit a55281a71f076f3e82e8f0be3ff77769788df7a1":https://github.com/illumos/illumos-gate/commit/a55281a71f076f3e... Electric Monk
10:04 PM Bug #10008: libstand: gets.c cstyle cleanup
Note that this is @wsdiff@ clean. Joshua Clulow
09:24 PM Bug #9962 (Closed): zil_commit should omit cache thrash
"git commit cab3a55e158118937e07d059c46f1bc14d1f254d":https://github.com/illumos/illumos-gate/commit/cab3a55e15811893... Electric Monk
06:18 PM Bug #10022 (New): hidden symbols should be seen as local when converting objcaps to symcaps
When converting object capabilities to symbol capabilities, we have to decide on symbol visibility earlier than would... Rich Lowe
06:16 PM Bug #10021 (New): Hidden symbols in group sections shouldn't reduce under ld -r -Breduce
You should not refer to a section in a group from outside the group from a local symbol.
When using ld -r, the group...
Rich Lowe
01:10 PM Bug #10020 (Closed): cmd-crypto: macro expands to multiple statements
Issue found by gcc 8 build:... Toomas Soome
01:06 PM Bug #10019 (Closed): libsldap: macro expands to multiple statements
Issue found by gcc 8 build:... Toomas Soome
12:59 PM Bug #10018 (Closed): libkmf: macro expands to multiple statements
Issue found by gcc 8 build:... Toomas Soome
12:55 PM Bug #10017 (Closed): libilb: macro expands to multiple statements
Issue found by gcc 8 build:... Toomas Soome
12:47 PM Bug #10016 (Closed): bnxe: macro expands to multiple statements
Issue found by gcc 8 build:... Toomas Soome
12:21 PM Bug #10015 (Closed): nfs: macro expands to multiple statements
Issue found by gcc 8 build:... Toomas Soome
06:12 AM Bug #10011: stop building and shipping lint libraries
These packages in OpenIndiana itself also contain lint libraries:... Joshua Clulow
02:10 AM Bug #9990 (Closed): loader.efi: check the presence of WaitForKey
"git commit 416f8d72824083126c8e231fbb5f4b3a8249ace8":https://github.com/illumos/illumos-gate/commit/416f8d7282408312... Electric Monk

2018-11-29

03:15 PM Feature #9950 (Closed): Need support for Intel I219 v6-v9
"git commit 5bb0bdfe588c5df0f63ff8ac292cd608a5f4492a":https://github.com/illumos/illumos-gate/commit/5bb0bdfe588c5df0... Electric Monk

2018-11-28

05:25 PM Feature #9950: Need support for Intel I219 v6-v9
To test this, I did testing on one of the new parts itself as well as regression tested a combination of different e1... Robert Mustacchi
04:42 PM Bug #10014 (Closed): bootadm: menu_free() is accessing freed memory
Issue pointed by John Levon. We can not use STAILQ_FOREACH for freeing the list. Toomas Soome
04:01 PM Bug #10013 (Closed): bootadm: list_menu_entry() is missing else
Somehow the else is lost from chained if statements. Toomas Soome
05:52 AM Bug #10012 (New): vioblk should not accept an all-zero serial number
While I still believe @blkdev@ should provide device ID fabrication and in-label persistence (as @sd@, @xdf@, @cmdk@,... Joshua Clulow

2018-11-27

11:33 PM Feature #9978 (Closed): env: set gcc 7 as shadow compiler and do not run lint
"git commit f9008f8deff5da21c46ffed5dff700071bcf884e":https://github.com/illumos/illumos-gate/commit/f9008f8deff5da21... Electric Monk
11:28 PM Feature #9978: env: set gcc 7 as shadow compiler and do not run lint
I have removed the aforementioned references to @lint@ from the guides on the wiki. Joshua Clulow
10:36 PM Bug #10011 (In Progress): stop building and shipping lint libraries
We build and ship various lint libraries. So that we can completely remove our dependency on the ancient and proprie... Joshua Clulow
05:33 PM Feature #9963 (Closed): Seperate tunable for disabling ZIL vdev flush
"git commit f8fdf6812567ce1a3b76a6bee2ee3f04bd3fcaca":https://github.com/illumos/illumos-gate/commit/f8fdf6812567ce1a... Electric Monk
10:01 AM Bug #10010 (Closed): libsmbns: macro expands to multiple statements
Issue found by gcc 8 build:... Toomas Soome

2018-11-26

04:19 PM Bug #9967: dflt_termios and base_termios need update
"git commit a239e970c64e3cf36327bef7b63193d0e6a25544":https://github.com/illumos/illumos-gate/commit/a239e970c64e3cf3... Electric Monk
02:22 AM Bug #9967 (Closed): dflt_termios and base_termios need update
"git commit 39cc040ff7c0c62aae858381f21d0567dd60042e":https://github.com/illumos/illumos-gate/commit/39cc040ff7c0c62a... Electric Monk
04:19 PM Bug #9903 (Closed): qinfo: add typed members
"git commit 5e1743f0d6a1d79ccc247d50153ad830fa07768b":https://github.com/illumos/illumos-gate/commit/5e1743f0d6a1d79c... Electric Monk
03:55 PM Bug #9972: assertion failed: ht->ht_valid_cnt >= 0, file: ../../i86pc/vm/htable.c, line: 1204
Investigation found that the x86_hm_exit() must be done before htable_release to avoid a potential for deadlocking wi... Joyce McIntosh
02:52 PM Bug #10009 (Closed): btxld: handle versioning better
btxld is tool to build btx engine to BIOS loader and to attach the embedded version. The current attach code is a bit... Toomas Soome
11:47 AM Bug #10008 (Closed): libstand: gets.c cstyle cleanup
Clean up the style. Toomas Soome
02:22 AM Feature #9991 (Closed): loader: optimize for size
"git commit 6daabf26a113f7ed649c4995afca2ddad12c662b":https://github.com/illumos/illumos-gate/commit/6daabf26a113f7ed... Electric Monk
02:22 AM Bug #9959 (Closed): pthread_mutex_init should initialize mutex appropriately for robust mutex_init
"git commit 6da2547363ddbd247ee9513db83b05a31bca31af":https://github.com/illumos/illumos-gate/commit/6da2547363ddbd24... Electric Monk
02:22 AM Bug #9993 (Closed): zil writes can get delayed in zio pipeline
"git commit 2258ad0b755b24a55c6173b1e6bb6188389f72dd":https://github.com/illumos/illumos-gate/commit/2258ad0b755b24a5... Electric Monk
02:22 AM Bug #9999 (Closed): loader: Consolidate three copies of ZFS commands into a central location.
"git commit 4450d42479b62d9a48049d644ff47b97009d9da2":https://github.com/illumos/illumos-gate/commit/4450d42479b62d9a... Electric Monk
02:22 AM Bug #9995 (Closed): cxgbe t4_devo_attach() should initialize ->sfl
"git commit bbb9d5d65bf8372aae4b8821c80e218b8b832846":https://github.com/illumos/illumos-gate/commit/bbb9d5d65bf8372a... Electric Monk
02:22 AM Bug #9994 (Closed): cxgbe t4nex: Handle get_fl_payload() alloc failures
"git commit bbb9d5d65bf8372aae4b8821c80e218b8b832846":https://github.com/illumos/illumos-gate/commit/bbb9d5d65bf8372a... Electric Monk
01:10 AM Bug #9982 (Closed): libstand: exit on EOF in ngets
"git commit 50e197fe6be9f132133f0a154925441a1f1411b6":https://github.com/illumos/illumos-gate/commit/50e197fe6be9f132... Electric Monk

2018-11-25

08:44 AM Bug #10007 (Closed): loader: remove bcache marker code
https://svnweb.freebsd.org/base?view=revision&revision=340857
Nuke out buffer overflow safety marker code, it dupl...
Toomas Soome

2018-11-23

08:22 PM Bug #10006 (New): zfs receive crashes when writing to USB memory stick -- possibly a software timing loop bug
When trying to install Omniosce to a USB memory stick, zfs receive crashes with the following errors: "SCSI transport... John Bowers

2018-11-22

08:00 PM Bug #10005: Cannot Fix pool misconfiguration because other top level device is raidz.
Turns out there was either a regression or a missing Patch back on OI 2018.04 that allowed me to add the device witho... Till Wegmüller
05:31 PM Bug #10005: Cannot Fix pool misconfiguration because other top level device is raidz.
After reading into the Original implementation blog post from delphix. Could it be that a Resilver blocks the device ... Till Wegmüller
04:48 PM Bug #10005 (New): Cannot Fix pool misconfiguration because other top level device is raidz.
Hello
I had a slight mishap. Instead of typing
zpool add bkpool spare c18t0d0
I typed
zpool add bkpool c18t...
Till Wegmüller
06:26 PM Bug #10003: /bin/dd skip= does not use seek( ) as promised in manual
Marcel Telka wrote:
> Note: @iseek@ should work as expected.
Yes, except, if the input does not support seek, it ...
Toomas Soome
05:59 PM Bug #10003: /bin/dd skip= does not use seek( ) as promised in manual
Note: @iseek@ should work as expected. Marcel Telka
01:31 PM Bug #10003 (New): /bin/dd skip= does not use seek( ) as promised in manual
... Toomas Soome
02:51 PM Bug #10004 (New): Segmentation fault in /usr/sbin/format when performing verify on disk larger than 2Tb
On OpenIndiana Hipster 201810, /usr/sbin/format segfaults when performing an analyze>verify operation on a disk large... Granville Moore
11:59 AM Bug #10001: creating duplicate vnics is possible, and breaks dladm
Tested in tribblix m20 and m20.5, and omnitribblix m20.5 - all fail, so this confirms it's a problem with vanilla ill... Peter Tribble
08:27 AM Bug #10002 (Closed): librcm: bitwise comparison always evaluates to false
Issue found by gcc 8 build:... Toomas Soome
07:26 AM Feature #7784: uts: console input should support Unicode
John Howard wrote:
> Should be renamed to "uts: console input should support Unicode".
>
> Unicode Consortium & I...
Toomas Soome
05:12 AM Feature #7784: uts: console input should support Unicode
Should be renamed to "uts: console input should support Unicode".
Unicode Consortium & ISO defines the codepoint a...
John Howard

2018-11-21

10:18 PM Bug #9942 (Closed): zone secflags are not initialized correctly
"git commit 2918c4a32d09a835c1eba8b0b02fe1dcb7a83175":https://github.com/illumos/illumos-gate/commit/2918c4a32d09a835... Electric Monk
10:18 PM Bug #9936 (Closed): atomic ops in syscall_mstate() induce significant overhead
"git commit 2918c4a32d09a835c1eba8b0b02fe1dcb7a83175":https://github.com/illumos/illumos-gate/commit/2918c4a32d09a835... Electric Monk
09:38 PM Bug #10001: creating duplicate vnics is possible, and breaks dladm
... Jaakko Linnosaari
09:37 PM Bug #10001: creating duplicate vnics is possible, and breaks dladm
From syslog:... Jaakko Linnosaari
08:57 PM Bug #10001: creating duplicate vnics is possible, and breaks dladm
... Rich Lowe
08:41 PM Bug #10001 (In Progress): creating duplicate vnics is possible, and breaks dladm
A user on IRC reports:... Rich Lowe
12:38 PM Bug #10000 (Closed): loader: stop using ../zfs/libzfs.h but instead use libzfs.h
FreeBSD update:
https://svnweb.freebsd.org/base?view=revision&revision=336085

Remove LOADER_ZFS_SUPPORT defin...
Toomas Soome
11:56 AM Bug #9999 (Closed): loader: Consolidate three copies of ZFS commands into a central location.
Update from FreeBSD with a bit of local changes because our BE code is a bit different in loader:
FreeBSD update: ...
Toomas Soome
11:01 AM Feature #9998 (Closed): uts: font rendering should support 16/24/32bit depths
Add callbacks to support more depths in font rendering. Also note, since we do not have information about colors, we ... Toomas Soome
09:29 AM Bug #9997 (Closed): Import iconv modules from g11n consolidation
Historically iconv modules lived in g11n consolidation, which is now almost not maintained. We'd likely want to impor... Alexander Pyhalov
08:26 AM Feature #9996 (New): use GCC 7 as default primary compiler
Once #9978 is integrated, our default compilation settings will be using GCC 7 as a shadow compiler in addition to th... Joshua Clulow
08:01 AM Bug #7119: boot should be more resilient to physical path to bootfs changing
> But, since we are scanning all block devices anyhow, we should register all disks with pool GUID so we can import m... Joshua Clulow
07:58 AM Bug #7119: boot should be more resilient to physical path to bootfs changing
Joshua Clulow wrote:
> As it turns out, with a mirrored @rpool@ this is more complicated. I'll need to extend @vdev...
Toomas Soome
07:43 AM Bug #7119: boot should be more resilient to physical path to bootfs changing
As it turns out, with a mirrored @rpool@ this is more complicated. I'll need to extend @vdev_disk_open()@ with some ... Joshua Clulow
01:55 AM Bug #7119: boot should be more resilient to physical path to bootfs changing
It turns out I was running @zpool status@ as an unprivileged user, which means it is unable to check or update the @v... Joshua Clulow
07:56 AM Feature #9931 (Closed): kmdb: add diag-device as input/output device
Joshua Clulow
07:56 AM Feature #9930: uts: kmdb should use "diag-device" when set
"git commit 8e9dfb97a84bbf797669c3ee2aabcc48b9ee13ff":https://github.com/illumos/illumos-gate/commit/8e9dfb97a84bbf79... Electric Monk

2018-11-20

11:20 PM Feature #9931: kmdb: add diag-device as input/output device
I think this is really just part of #9930, which I should really have noticed before I put that one back. I'm going ... Joshua Clulow
10:44 PM Feature #9930 (Closed): uts: kmdb should use "diag-device" when set
"git commit dbad7380d7852483de489e640f3a64b386115d59":https://github.com/illumos/illumos-gate/commit/dbad7380d7852483... Electric Monk
10:42 PM Feature #9930: uts: kmdb should use "diag-device" when set
h3. Testing Notes
h4. Regression Testing
In a BIOS (not UEFI) virtual machine with both a framebuffer (VGA) and...
Joshua Clulow
08:17 PM Bug #9995 (Closed): cxgbe t4_devo_attach() should initialize ->sfl
We should TAILQ_INIT() ->sfl in t4_devo_attach(). Patch from Chelsio. John Levon
06:52 PM Bug #9994 (Closed): cxgbe t4nex: Handle get_fl_payload() alloc failures
An update from Chelsio is needed as follows:
"get_fl_payload is modified such that it doesn't leave any iq and fl
...
John Levon
03:24 PM Bug #9993 (Closed): zil writes can get delayed in zio pipeline
Looking at the data from a dtrace script that shows the cumulative time
as a zio progresses through the zio pipeline...
Prakash Surya
07:50 AM Feature #9929 (Closed): uts: boot console mirror with diag-device
"git commit 60cbda0dc36aea401b9a65de04800c0a8b48647f":https://github.com/illumos/illumos-gate/commit/60cbda0dc36aea40... Electric Monk
07:46 AM Feature #9929: uts: boot console mirror with diag-device
h2. Testing Notes
In a BIOS (not UEFI) virtual machine with both a framebuffer (VGA) and serial console (COM1/ttya...
Joshua Clulow
07:02 AM Bug #7119: boot should be more resilient to physical path to bootfs changing
One artefact with the prototype thus far is that while we are able to correctly open the pool even though the @/devic... Joshua Clulow
05:19 AM Bug #9992: kstat -j does not produce valid JSON
I suspect it's time we refactored the JSON emitter logic in @kstat@ to be in terms of something a bit more robust, li... Joshua Clulow
05:07 AM Bug #9992 (New): kstat -j does not produce valid JSON
The kstat command fails to produce valid JSON objects when used with a count of greater than one:... Brian Ewell
04:58 AM Bug #9985: blkdev devices can have an invalid devid
Yes, I did actually look at all of those things before filing the ticket. There is effectively identical device ID f... Joshua Clulow
12:49 AM Bug #9985: blkdev devices can have an invalid devid
Btw, anything which *assumes* a block device will have a device id is fundamentally borked. Device IDs are only su... Garrett D'Amore
12:43 AM Bug #9985: blkdev devices can have an invalid devid
Well, I might have to eat my words.
cmlb has a function for this called "cmlb_get_devid_block", but it winds up ge...
Garrett D'Amore
12:38 AM Bug #9985: blkdev devices can have an invalid devid
If this is a problem, I think it isn't in blkdev.
blkdev is intended to support *optional* device IDs, by having t...
Garrett D'Amore

2018-11-19

03:44 PM Bug #9843 (Closed): loader: pxe receive can be simpler and pxe put should check for data size
"git commit e84b53f403271e630eb5d153a42b43ad825c55e6":https://github.com/illumos/illumos-gate/commit/e84b53f403271e63... Electric Monk
10:24 AM Feature #9991 (Closed): loader: optimize for size
The current loader build is using -O2 optimize flag, switch to use -Os instead. The reason is to save space in binary... Toomas Soome
08:57 AM Feature #9928 (Closed): uts: prepare very early console on ttya
"git commit 805e8fd0e4405f1ff8b281a3eb4099a58315eb81":https://github.com/illumos/illumos-gate/commit/805e8fd0e4405f1f... Electric Monk
08:25 AM Bug #9990 (Closed): loader.efi: check the presence of WaitForKey
The issue found in FreeBSD. Note the original FreeBSD fix is slightly different, but the code idea is still the same.... Toomas Soome

2018-11-18

04:44 PM Feature #9989 (Closed): Make loader.efi dual boot, step 2: remove boot1
after 9987 and 9988, we can drop boot1.efi. Toomas Soome
03:13 PM Bug #9988 (Closed): Make loader.efi dual boot, step 1
Update from FreeBSD. This does enable loader.efi to be used directly, without boot1.efi.
https://reviews.freebsd.o...
Toomas Soome
11:46 AM Feature #9987 (Closed): loader.efi: add version support
Prepare to drop boot1.
When we activate boot environment (beadm activate, or pkg update) or install boot loader fi...
Toomas Soome
04:10 AM Bug #9986 (New): ddi_prop_lookup(9F) family should accept const property name
The "ddi_prop_lookup(9F)":https://illumos.org/man/9F/ddi_prop_lookup family of functions (e.g., @ddi_prop_lookup_stri... Joshua Clulow

2018-11-17

10:19 PM Bug #7367: blkdev: support block size larger than 512
Note that the automated commit notifications are out-of-order in the issue comments. Despite immediate appearances t... Joshua Clulow
08:46 PM Bug #9985 (New): blkdev devices can have an invalid devid
A hypervisor may expose Virtio emulated block devices to a guest. We have a driver for these devices, @vioblk@, whic... Joshua Clulow
08:24 PM Feature #9978: env: set gcc 7 as shadow compiler and do not run lint
As part of making this change, we'll need to update some of our guidance and documentation:
* https://wiki.illumos...
Joshua Clulow

2018-11-16

10:28 PM Bug #9984 (New): zil writes can get delayed in zio pipeline
Looking at the data from a dtrace script that shows the cumulative time as a zio progresses through the zio pipeline ... Brad Lewis

2018-11-15

11:04 PM Bug #9972: assertion failed: ht->ht_valid_cnt >= 0, file: ../../i86pc/vm/htable.c, line: 1204
From code observation, here is my theory on why the existing locking is not quite doing its job in this scenario:
...
Joyce McIntosh
10:32 PM Bug #9976 (Closed): boot1.efi: unused functions in zfs_module.c
"git commit 50a7e957ddabb06ba5d141a0642036371031110d":https://github.com/illumos/illumos-gate/commit/50a7e957ddabb06b... Electric Monk
09:45 PM Bug #9982 (Closed): libstand: exit on EOF in ngets
Fix from FreeBSD. We do not really use ngets() but it is good to keep things in order.
FreeBSD update: https://svn...
Toomas Soome
07:07 PM Bug #9434: Speculative prefetch is blocked by device removal code
The analysis is a little light here. I was debugging slow sequential read activity on a SmartOS machine that was runn... Kody Kantor

2018-11-14

11:07 PM Feature #7361: Improve L2ARC filling
Results (the hosted results' picture from the original post above expired) :
!https://i.postimg.cc/xjPdGz2s/illumo...
Ben RUBSON
05:59 PM Feature #9981 (Closed): loader: add set-module-path to support scripting the module load path change
The loader.conf is to assign set of environment variables defining what and how to boot, but also is describing the l... Toomas Soome
03:31 PM Feature #9979: Support python3 for in-gate tools
Review up at: https://www.illumos.org/rb/r/1283/ Andy Fiddaman
02:48 PM Feature #9979: Support python3 for in-gate tools
Except that IPS pkg dependency resolution can fail if the explicit version is not in the shebang.
I'm providing `TOO...
Andy Fiddaman
09:56 AM Feature #9979: Support python3 for in-gate tools
please use shebang like /usr/bin/python3
distributions can do symbolic links to it with correct local version
Igor Kozhukhov
09:53 AM Feature #9979 (Closed): Support python3 for in-gate tools
A number of tools in gate are written in python. With the approaching end-of-support for python2 and as distributions... Andy Fiddaman
08:12 AM Bug #7119: boot should be more resilient to physical path to bootfs changing
Rough working prototype available at: https://github.com/jclulow/illumos-gate/commit/775b85f9194457c29dbb6c8d14c2d44c... Joshua Clulow

2018-11-13

02:53 PM Feature #9978 (Closed): env: set gcc 7 as shadow compiler and do not run lint
Since we do have illumos patched gcc 7, and we did clean up our source for gcc6 & gcc 7, and we would very much like ... Toomas Soome
11:47 AM Bug #9926: Booting/Installation problem
Georgios Papadopoulos wrote:
> Toomas Soome wrote:
> > Georgios Papadopoulos wrote:
> > > Hello to all
> > >
...
Toomas Soome
01:57 AM Bug #9665 (Closed): loader: UEFI loader needs to set ISADIR based on hardware
"git commit d9256fff79245867eed7054793d48f5656f5a6d0":https://github.com/illumos/illumos-gate/commit/d9256fff79245867... Electric Monk
01:57 AM Bug #9966 (Closed): svccfg cleanup crashes on empty manifestfiles property group
"git commit 8571aeda0618a9b2db4736e7fd3461be6959c42e":https://github.com/illumos/illumos-gate/commit/8571aeda0618a9b2... Electric Monk
01:57 AM Bug #9969 (Closed): svccfg: honour PKG_INSTALL_ROOT when building hash filename
"git commit b1e7e97d3b60469b243b3b2e22c7d8cbd11c7c90":https://github.com/illumos/illumos-gate/commit/b1e7e97d3b60469b... Electric Monk
01:57 AM Bug #9970 (Closed): loader: fix EFI getchar() for multiple consoles
"git commit ffedf5deeba4b9adf8fdf31a53c23946700d648f":https://github.com/illumos/illumos-gate/commit/ffedf5deeba4b9ad... Electric Monk
01:57 AM Bug #9973 (Closed): loader: use smbios specific defines only with smbios.c
"git commit 7a19142621d2577f80e8f03a082e1e7b44c00a29":https://github.com/illumos/illumos-gate/commit/7a19142621d2577f... Electric Monk
01:57 AM Bug #9974 (Closed): loader: comconsole.c unused variable 'intbuf'
"git commit 12d65476afc93e61685ea633c371bdbada4e2300":https://github.com/illumos/illumos-gate/commit/12d65476afc93e61... Electric Monk
01:42 AM Feature #9851 (Closed): add sys/containerof.h and implement __containerof
"git commit 94c3dad2979525d0a82595f3d8350a6116aba8ed":https://github.com/illumos/illumos-gate/commit/94c3dad2979525d0... Electric Monk
01:38 AM Feature #9851: add sys/containerof.h and implement __containerof
Note that while integrating this I built it and inspected the @wsdiff@ output. The noisiest changes were in the @t4n... Joshua Clulow

2018-11-12

04:32 PM Bug #9969 (Pending RTI): svccfg: honour PKG_INSTALL_ROOT when building hash filename
Andy Fiddaman
03:52 PM Bug #9966 (Pending RTI): svccfg cleanup crashes on empty manifestfiles property group
Andy Fiddaman
06:04 AM Bug #7119: boot should be more resilient to physical path to bootfs changing
Note that the error message on boot that you get because of this problem looks like this:... Joshua Clulow

2018-11-11

11:06 PM Bug #7119: boot should be more resilient to physical path to bootfs changing
Now that #9955 has gone back, the boot loader is exposing the boot vdev GUID and pool GUID to the OS in two new prope... Joshua Clulow
09:58 AM Bug #9976 (Closed): boot1.efi: unused functions in zfs_module.c
Warnings enabled:... Toomas Soome
09:34 AM Bug #9975 (Closed): loader.efi: unused variable 'err'
Build error with warnings enabled:... Toomas Soome
09:22 AM Bug #9974 (Closed): loader: comconsole.c unused variable 'intbuf'
Build error when warnings are enabled: ... Toomas Soome
09:08 AM Bug #9973 (Closed): loader: use smbios specific defines only with smbios.c
small makefile cleanup: smbios cpp symbols should be defined only for smbios.o build. Toomas Soome

2018-11-09

10:09 PM Bug #9972: assertion failed: ht->ht_valid_cnt >= 0, file: ../../i86pc/vm/htable.c, line: 1204
I should add that this occurs during various zfs stress tests in dataset_create_write_destroy_exattr. Joyce McIntosh
10:05 PM Bug #9972 (New): assertion failed: ht->ht_valid_cnt >= 0, file: ../../i86pc/vm/htable.c, line: 1204
A few months ago we started occasionally seeing this assertion firing during our nightly zfs-test runs (on debug buil... Joyce McIntosh
10:02 PM Feature #9955 (Closed): loader: export boot pool and vdev GUID
"git commit f6dea603a339e9ce32cc78b775543b0cccbefac2":https://github.com/illumos/illumos-gate/commit/f6dea603a339e9ce... Electric Monk
10:02 PM Bug #9787 (Closed): snoop: add tftp OACK support
"git commit 5b8f338ecee33a4471924e65d685fde98134bc31":https://github.com/illumos/illumos-gate/commit/5b8f338ecee33a44... Electric Monk
09:53 PM Bug #9787: snoop: add tftp OACK support
From the RTI: "Tested by snooping illumos network boot." Dan McDonald
09:41 PM Feature #9971 (Closed): Make getrandom(2) a public interface
Several other operating systems, including Linux, FreeBSD (12), and Solaris (11.4) all support a getrandom(2) syscall... Jason King
05:38 PM Bug #9970 (Closed): loader: fix EFI getchar() for multiple consoles
Currently, efi_cons_getchar() will wait for a key. While this seems to make sense, the implementation of getchar()
i...
John Levon
03:09 PM Bug #9902 (Closed): mac: mac_soft_ring_poll should use size_t
"git commit 7ec6bfcf4280022b95218f03e28fb50217e4b6ff":https://github.com/illumos/illumos-gate/commit/7ec6bfcf4280022b... Electric Monk
03:08 PM Bug #9954 (Closed): loader: always set media size from partition.
"git commit 124619e5421ff751660c822c15c320ddf7800a5a":https://github.com/illumos/illumos-gate/commit/124619e5421ff751... Electric Monk
10:42 AM Bug #9833 (Closed): elfedit dumps core on incorrect file
"git commit 363d8186a0da4dd21c2beacec05920a71ab67022":https://github.com/illumos/illumos-gate/commit/363d8186a0da4dd2... Electric Monk
10:34 AM Bug #9944 (Closed): tools: ctf should be built early to avoid missing ctfconvert errors
"git commit 7079b4f8bb5b8643192a092af2f5e1c1d56e3b29":https://github.com/illumos/illumos-gate/commit/7079b4f8bb5b8643... Electric Monk
10:34 AM Bug #9947 (Closed): loader: Remove unnecessary include from libstand.
"git commit 0c3d39e1b503beb46fe27b646084d5e30ec0aa0a":https://github.com/illumos/illumos-gate/commit/0c3d39e1b503beb4... Electric Monk
10:34 AM Bug #9948 (Closed): PKCS#11 key handle uninitialized in crypto tests
"git commit eed3be881cd8e53fe7187245b289da7106712dea":https://github.com/illumos/illumos-gate/commit/eed3be881cd8e53f... Electric Monk
10:34 AM Bug #9964 (Closed): loader.efi: comc_ischar is broken
"git commit d656c9b545ad26cb5862cfe5f1ff953181d6d2ca":https://github.com/illumos/illumos-gate/commit/d656c9b545ad26cb... Electric Monk

2018-11-08

09:57 PM Bug #9901 (Closed): ip: rts_wput_other: this statement may fall through
"git commit a4ea78ea169e38e19fc3f41157c40f09341f4144":https://github.com/illumos/illumos-gate/commit/a4ea78ea169e38e1... Electric Monk
09:20 PM Bug #9969: svccfg: honour PKG_INSTALL_ROOT when building hash filename
https://illumos.org/rb/r/1276/ Andy Fiddaman
09:18 PM Bug #9969 (Closed): svccfg: honour PKG_INSTALL_ROOT when building hash filename
When seeding an SMF database, the paths to the imported manifests end up stored in two places within the repository d... Andy Fiddaman
01:24 PM Bug #9967 (Closed): dflt_termios and base_termios need update
The issue is that despite our "recent" improvements with console, there are defaults for termios structure, which are... Toomas Soome
11:17 AM Bug #9833 (Pending RTI): elfedit dumps core on incorrect file
Andy Fiddaman
11:17 AM Bug #9833: elfedit dumps core on incorrect file
Testing notes:
Before:...
Andy Fiddaman
11:11 AM Bug #9966: svccfg cleanup crashes on empty manifestfiles property group
Testing notes:
before:...
Andy Fiddaman
11:10 AM Bug #9966: svccfg cleanup crashes on empty manifestfiles property group
https://illumos.org/rb/r/1274/ Andy Fiddaman
11:05 AM Bug #9966 (Closed): svccfg cleanup crashes on empty manifestfiles property group
... Andy Fiddaman
02:38 AM Bug #9965 (New): O_DIRECTORY required for POSIX 2008
POSIX 2008 (SUSv7) specifies the use of O_DIRECTORY:
http://pubs.opengroup.org/onlinepubs/9699919799/functions/ope...
Garrett D'Amore

2018-11-07

09:06 PM Bug #9964 (Closed): loader.efi: comc_ischar is broken
we need to check control word, not status.
tested by checking the return values.
Toomas Soome
04:16 PM Bug #9962 (In Progress): zil_commit should omit cache thrash
Patrick Mooney
04:13 PM Bug #9962 (Closed): zil_commit should omit cache thrash
Upstream clone of "OS-7314":https://smartos.org/bugview/OS-7314 from SmartOS:
> The changes and testing required f...
Patrick Mooney
04:16 PM Feature #9963 (Closed): Seperate tunable for disabling ZIL vdev flush
As the discussion and work progressed on "9962":https://www.illumos.org/issues/9962, it became clear that it would be... Patrick Mooney
09:55 AM Feature #9961 (New): git-pbchk should have an option to ignore exception lists
To ease up the cstyle checks in otherwise ignored tree, it would be nice to have an option to disable the exception l... Toomas Soome

2018-11-06

11:12 PM Bug #9960 (New): zpool: bogus error for invalid dedupditto value
When provided with an invalid 'dedupditto' value zpool prints a misleading error message:... Ezomori Nozomu
08:19 PM Bug #9959 (Closed): pthread_mutex_init should initialize mutex appropriately for robust mutex_init
Sun mutexes expect that a mutex_t for a robust mutex be initialized to all 0 prior to mutex_init(), posix mutexes do ... Rich Lowe
07:24 PM Bug #9941 (Closed): Noise from cfgadm plugins
"git commit cf25223258f3cd568605b3e10c1432e5e93b2c5e":https://github.com/illumos/illumos-gate/commit/cf25223258f3cd56... Electric Monk
03:53 PM Bug #9941 (Pending RTI): Noise from cfgadm plugins
Andy Fiddaman
02:35 PM Bug #9941: Noise from cfgadm plugins
h3. Testing notes
After the patch from reviewboard:...
Andy Fiddaman
07:07 PM Bug #9951 (Closed): hook_stack_notify_unregister can leave stack locked
"git commit 68c34d0407d130a7e8cb7dfb5394a985db03d785":https://github.com/illumos/illumos-gate/commit/68c34d0407d130a7... Electric Monk
04:14 PM Bug #9951 (Pending RTI): hook_stack_notify_unregister can leave stack locked
Jason King
04:13 PM Bug #9948 (Pending RTI): PKCS#11 key handle uninitialized in crypto tests
Jason King
02:08 PM Bug #9833: elfedit dumps core on incorrect file
https://illumos.org/rb/r/1272/diff/1#index_header Andy Fiddaman

2018-11-05

04:27 PM Bug #9933 (Closed): libefi: Simplify the EFI delay() function by calling BS->Stall()
"git commit 0c54f6ba1331ba286857bec48422da0a9893d269":https://github.com/illumos/illumos-gate/commit/0c54f6ba1331ba28... Electric Monk
09:05 AM Bug #9956 (Closed): loader: create separate lists for fd, cd and hd, merge bioscd with biosdisk
Create unified block IO implementation in BIOS version, like it is done in UEFI side. Implement fd, disk and cd devic... Toomas Soome
07:14 AM Bug #9833: elfedit dumps core on incorrect file
I see the same thing during golang 1.10 publish phase:... Michal Nowak

2018-11-04

07:47 PM Bug #9939 (Closed): Need to stop GCC reordering functions
"git commit b6c711cc370ad66a5c9391c71936f34bb8616e93":https://github.com/illumos/illumos-gate/commit/b6c711cc370ad66a... Electric Monk
07:47 PM Bug #9927 (Closed): refetch_read_once() would like a p please bob
"git commit c540c5554db983fb615df293797142edc10b4c62":https://github.com/illumos/illumos-gate/commit/c540c5554db983fb... Electric Monk
10:08 AM Feature #9955 (Closed): loader: export boot pool and vdev GUID
We do export zfs-bootfs, bootpath and diskdevid in boot environment to support zfs boot. To support boot pool discove... Toomas Soome
 

Also available in: Atom