illumos gate

2019-01-09

11:33 PM Bug #10202 (Closed): loader: use screen-#rows to find bottom left co-ordinates

Currently loader moves the cursor to the bottom left of the screen in a variety of places using @0 25 at-xy ( positio... Andy Fiddaman

07:06 PM Bug #10201 (Closed): prototypes: happy new 2019 year

"git commit 9b40c3052b9b0d91120c568df0c5211c131c8da1":https://github.com/illumos/illumos-gate/commit/9b40c3052b9b0d91... Electric Monk

06:50 PM Bug #10201 (Closed): prototypes: happy new 2019 year

It is new year now. Toomas Soome

06:41 PM Bug #10200 (Closed): loader: spinconsole updates

This update is based on FreeBSD update:
https://svnweb.freebsd.org/base?view=revision&revision=322896 Toomas Soome

06:14 PM Bug #10199 (Closed): loader: vbe should use bio_alloc for edid info

The EDID block is 512 bytes, use bio buffer to read it, save stack space. Toomas Soome

05:59 PM Feature #10198 (Closed): dboot: signal boot loader we can do framebuffer console

Add multiboot2 header the tag to notify boot loader, we can do framebuffer console Toomas Soome

04:29 PM Bug #10197 (Closed): build smatch in parallel

We somehow lost the .PARALLEL from the smatch Makefile. John Levon

04:00 PM Bug #10196 (Closed): Add 'framebuffer?' command to loader

It would be useful to be able to easily check if the framebuffer is in use before, for example, attempting to change ... Andy Fiddaman

02:24 PM Bug #6109 (Closed): tcp(7P) should mention that socket options are in <netinet/tcp.h>

"git commit f5037cd0e0544bd22e4547ec8656b0ec49615f5d":https://github.com/illumos/illumos-gate/commit/f5037cd0e0544bd2... Electric Monk

02:24 PM Bug #10175 (Closed): Organize tcp(7P) into subsections

"git commit f5037cd0e0544bd22e4547ec8656b0ec49615f5d":https://github.com/illumos/illumos-gate/commit/f5037cd0e0544bd2... Electric Monk

02:24 PM Feature #10054 (Closed): loader: move 16KB BSS buffer from pxe to bio and use it with biosdisk

"git commit 3273f292544925d8d86f8e40935d5360aa609ef4":https://github.com/illumos/illumos-gate/commit/3273f292544925d8... Electric Monk

02:24 PM Feature #10066 (Closed): loader: Add isoboot(5) for booting BIOS systems from HDDs containing ISO images.

"git commit 64f9afd1fd6b5f36ed2c633d603a3b551da6f3d4":https://github.com/illumos/illumos-gate/commit/64f9afd1fd6b5f36... Electric Monk

02:24 PM Bug #10075 (Closed): make usr/src/tools smatch clean

"git commit 93b8872871607b3d21317283c1230b2a4a00920b":https://github.com/illumos/illumos-gate/commit/93b8872871607b3d... Electric Monk

02:24 PM Bug #10077 (Closed): usr/src/uts/ Makefile changes for smatch

"git commit b6b206fc7fb36f7b13b01acf70ed6e676e405998":https://github.com/illumos/illumos-gate/commit/b6b206fc7fb36f7b... Electric Monk

02:24 PM Bug #10076 (Closed): make usr/src/test smatch clean

"git commit dc5e7685b131559c0b7c622baee25a9a0ae50ada":https://github.com/illumos/illumos-gate/commit/dc5e7685b131559c... Electric Monk

02:24 PM Bug #10171 (Closed): biosdisk: use int13h ah=08 and ah=15 to count the floppy devices

"git commit 1fe853a05a457dfa95ddc2f2742c2421558a7c30":https://github.com/illumos/illumos-gate/commit/1fe853a05a457dfa... Electric Monk

02:24 PM Bug #10184 (Closed): loader: framebuffer command should report usage on bad command

"git commit 8d2ce326a8ec4271f68dfa69691885d8219c9bb7":https://github.com/illumos/illumos-gate/commit/8d2ce326a8ec4271... Electric Monk

02:24 PM Feature #10185 (Closed): loader: add sha1 hash calculation

"git commit a103f15bc0089ffbdb0e211871d97b6b79f59fa1":https://github.com/illumos/illumos-gate/commit/a103f15bc0089ffb... Electric Monk

11:13 AM Bug #10195 (Closed): uts: boot_keyboard should emit esc sequences for arrow keys

The early kmdb (from boot -kd) does not accept arrow keys, to fix this, we will need to generate the proper key seque... Toomas Soome

07:22 AM Bug #10194 (Closed): iscsi: this statement may fall through

Issue found by gcc 8 build:... Toomas Soome

07:14 AM Bug #10193 (Closed): ddi_intr: cast between incompatible function types

Issue found by gcc 8 build:... Toomas Soome

07:01 AM Bug #10191 (Closed): strsubs: cast between incompatible function types

Issue found by gcc 8 build:... Toomas Soome

06:34 AM Bug #10190 (Closed): aphysio: cast between incompatible function types

Issue found by gcc 8 build:... Toomas Soome

06:24 AM Bug #10189 (Closed): fdbuffer: cast between incompatible function types

Issue found by gcc 8 build:... Toomas Soome

06:17 AM Bug #10188 (Closed): libast: cast between incompatible function types

Issue found by gcc 8 build:... Toomas Soome

2019-01-08

10:07 PM Bug #10187 (Closed): ses enumerator blows chunks on US60+8

Under certain circumstances, if the ses topo enumerator module is unable to correlate a SES ARRAY_DEVICE element with... Rob Johnston

08:48 AM Bug #10186 (Closed): uts: font functions should check if the char is from the input domain

We need to verify if the requested char exists in our font map, use '?' for missing chars.
This patch is preparing... Toomas Soome

2019-01-07

03:10 PM Bug #10177 (Closed): etdump: additional cstyle cleanup and remove unused functions

"git commit 916bf6b9509e36cfde18ed64b9fa13c942d2d9bd":https://github.com/illumos/illumos-gate/commit/916bf6b9509e36cf... Electric Monk

03:04 PM Bug #10170 (Closed): ipadm: remove -Wno-unused-label and -Wno-uninitialized build options

"git commit 467e811cd2cb3b7e96cdf5621c4ed383e2b3efc8":https://github.com/illumos/illumos-gate/commit/467e811cd2cb3b7e... Electric Monk

01:45 PM Feature #10185 (Closed): loader: add sha1 hash calculation

Add sha1 digest support for loader:
1. build libcrypto with implementation
2. add -s option for lsmod to calculat... Toomas Soome

01:26 PM Bug #10184 (Closed): loader: framebuffer command should report usage on bad command

The issue was reported after RTI of 10028, framebuffer command should print usage in case of bad arguments. Issue is ... Toomas Soome

10:17 AM Feature #7784 (Closed): uts: console input should support Unicode

"git commit adc2b73db62a4506a57dfd1ce89bcadc4a60a29d":https://github.com/illumos/illumos-gate/commit/adc2b73db62a4506... Electric Monk

10:17 AM Feature #7796 (Closed): uts: ldterm default to utf-8

"git commit f33b666290305a2b2c134d23cbd1e70e06bf36fd":https://github.com/illumos/illumos-gate/commit/f33b666290305a2b... Electric Monk

10:17 AM Feature #10040 (Closed): loader: gfx use GOP Blt() function in visual_io callbacks

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10039 (Closed): loader: build rules for new font setup

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10038 (Closed): loader: replace gop and vesa with framebuffer

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10037 (Closed): loader: add illumos.png logo

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10036 (Closed): ficl: add fb-putimage

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10035 (Closed): loader: add alpha blending for gfx_fb

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10034 (Closed): loader: use term-drawrect for menu frame

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10033 (Closed): ficl: add simple gfx words

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10032 (Closed): loader: implement tem utf-8 support

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10031 (Closed): loader: import tem for loader console

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #8918 (Closed): loader.efi: add vesa edid support

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10030 (Closed): import pnglite into usr/src/common/pnglite

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10029 (Closed): common/font: create shared font.c

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

10:17 AM Feature #10028 (Closed): loader: implement framebuffer console

"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

2019-01-06

11:43 PM Bug #10183 (Closed): etdump should be smatch clean

Actually, we'll just fold this into the generic usr/src/cmd makefile changes John Levon

11:39 PM Bug #10183 (Closed): etdump should be smatch clean

We need to check the return value of fseek() John Levon

10:13 AM Feature #10182 (Closed): dd: print scaled stats

the current stats:... Toomas Soome

03:57 AM Bug #9623: zfs.1m uses wrong snapshot names in Example 15

For review:
* https://www.illumos.org/rb/r/1343/
* http://cr.illumos.org/~webrev/benjamin.gentil/9623/ Benjamin Gentil

2019-01-05

11:23 PM Bug #10178: Enable compiler warnings when building C++ code

Fix: https://www.illumos.org/rb/r/1342/ Andrew Stormont

11:13 AM Bug #10178 (Closed): Enable compiler warnings when building C++ code

We pass -xne to turn warnings into errors but never actually turn on more than the default set of warnings, which are... Andrew Stormont

09:49 PM Bug #10153 (Closed): checkpaths shouldn't check packaging exceptions

"git commit 1f5207b7604fb44407eb4342aff613f7c4508508":https://github.com/illumos/illumos-gate/commit/1f5207b7604fb444... Electric Monk

09:49 PM Bug #10063 (Closed): basic support for smatch

"git commit 1f5207b7604fb44407eb4342aff613f7c4508508":https://github.com/illumos/illumos-gate/commit/1f5207b7604fb444... Electric Monk

12:11 PM Bug #10179 (New): Race condition in fifo_open

The following script, that tests named pipes (FIFOs), breaks consistently on all SunOS kernels, including illumos, wh... Martijn Dekker

08:14 AM Bug #10177 (Closed): etdump: additional cstyle cleanup and remove unused functions

Additional cstyle cleanup suggestions were suggested after RTI. Toomas Soome

07:14 AM Bug #10176 (New): i40e: driving X722 1GbE cause hangup

The system hangs up when executing the 'ifconfig i40e0 plumb ... ' command.
The specific phenomenon is that the 'I... jing zhang

02:41 AM Bug #10064 (Closed): loader: zfs reader should not probe partitionless disks

"git commit 781f142d2ae880bb893875d2a114552171a5c3e5":https://github.com/illumos/illumos-gate/commit/781f142d2ae880bb... Electric Monk

02:41 AM Bug #10154 (Closed): zfs: cast between incompatible function types

"git commit c62757b2b8b6c26589d7704d0ff20beb107fcd9a":https://github.com/illumos/illumos-gate/commit/c62757b2b8b6c265... Electric Monk

02:41 AM Feature #9478 (Closed): etdump: Add the etdump utility for dumping El Torito boot catalog information.

"git commit c0455f334914631f42eb41177d677e2820ee6506":https://github.com/illumos/illumos-gate/commit/c0455f334914631f... Electric Monk

2019-01-04

10:39 PM Bug #10175 (Closed): Organize tcp(7P) into subsections

The tcp(7p) manual page is a bit disorganized, and would be easier to read through if the content were better present... Cody Mello

01:45 PM Bug #10162 (Closed): Sun/Solaris/Kstat: cast between incompatible function types

"git commit 9419bc2fc61b54b25a4e45211d31fcb920ff67cc":https://github.com/illumos/illumos-gate/commit/9419bc2fc61b54b2... Electric Monk

01:45 PM Bug #10159 (Closed): libc: cast between incompatible function types

"git commit adc04c2d55dd20cc6a0622f1147c0b084cdc3099":https://github.com/illumos/illumos-gate/commit/adc04c2d55dd20cc... Electric Monk

01:45 PM Bug #10158 (Closed): sgs/rtld: cast between incompatible function types

"git commit 5e90af26eb6ed2206c2a5f5131a1f3c377d6e8c4":https://github.com/illumos/illumos-gate/commit/5e90af26eb6ed220... Electric Monk

01:45 PM Bug #10157 (Closed): sgs/libld: cast between incompatible function types

"git commit c5749750a3e052f1194f65a303456224c51dea63":https://github.com/illumos/illumos-gate/commit/c5749750a3e052f1... Electric Monk

01:45 PM Bug #10155 (Closed): ip: cast between incompatible function types

"git commit 8a06b3d6467c15646e663c05086378f16288af85":https://github.com/illumos/illumos-gate/commit/8a06b3d6467c1564... Electric Monk

12:07 PM Feature #10173 (Closed): loader: support newer ZFS versions

This change did trigger my attention: https://svnweb.freebsd.org/changeset/base/342747... Toomas Soome

2019-01-03

07:10 AM Bug #10171 (Closed): biosdisk: use int13h ah=08 and ah=15 to count the floppy devices

FreeBSD issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234460
That specific BIOS does not provide drive ... Toomas Soome

2019-01-02

06:06 PM Bug #10123 (Closed): smatch fix for mbr.c

mbr.c got deleted John Levon

09:43 AM Bug #10170 (Closed): ipadm: remove -Wno-unused-label and -Wno-uninitialized build options

Clean up ipadm. Toomas Soome

2019-01-01

01:07 AM Bug #10167: unable to check out illumos-gate on Windows

>The checkout failed, due to occurrences of file names that are "illegal" for Windows -- specifically usr/src/cmd/mai... Gergő Mihály Doma

2018-12-29

11:40 PM Bug #10161 (Closed): libstand: set spa in zfs_probe

"git commit cd8e64e261b359d5d54dad750f50660d3b874238":https://github.com/illumos/illumos-gate/commit/cd8e64e261b359d5... Electric Monk

11:40 PM Bug #10164 (Closed): crle: passing argument 2 to restrict-qualified parameter aliases with argument 1

"git commit 3ab8de02e091bc75fc50aafc5cbe32c053451d88":https://github.com/illumos/illumos-gate/commit/3ab8de02e091bc75... Electric Monk

12:24 PM Bug #10167: unable to check out illumos-gate on Windows

Igor Kozhukhov wrote:
> move sendmail + mail/mailx outside illumos-gate.
> because they are both are userland apps.... Toomas Soome

2018-12-28

10:01 PM Bug #10167: unable to check out illumos-gate on Windows

If we're going to accommodate clones on Windows, we should probably add to pbchk with the full list of forbidden file... Joshua M. Clulow

09:44 PM Bug #10167: unable to check out illumos-gate on Windows

move sendmail + mail/mailx outside illumos-gate.
because they are both are userland apps.
for example: on DilOS we ... Igor Kozhukhov

09:32 PM Bug #10167 (Closed): unable to check out illumos-gate on Windows

I recently decided to try working on Windows for development, and I checked out a copy of the illumos-gate repo on Wi... Garrett D'Amore

2018-12-26

08:41 PM Feature #10166 (Closed): loader: support com.delphix:removing

There is no reason why we should not be able to boot from... Toomas Soome

2018-12-25

10:04 PM Bug #10165 (Closed): libzpool: passing argument 1 to restrict-qualified parameter aliases with argument 4

Issue found by gcc 8 build:... Toomas Soome

09:06 PM Bug #10164 (Closed): crle: passing argument 2 to restrict-qualified parameter aliases with argument 1

Issue found by gcc 8 build:... Toomas Soome

08:42 PM Bug #10163 (Closed): ufs_fsck: bitwise comparison always evaluates to false

Issue found by gcc 8 build:... Toomas Soome

10:28 AM Bug #10162 (Closed): Sun/Solaris/Kstat: cast between incompatible function types

Issue found by gcc 8 build:... Toomas Soome

09:33 AM Bug #10161 (Closed): libstand: set spa in zfs_probe

FreeBSD update https://svnweb.freebsd.org/base?view=revision&revision=337874
The warning is apparently clang speci... Toomas Soome

2018-12-23

11:07 AM Bug #10159 (Closed): libc: cast between incompatible function types

Issue found by gcc 8 build:... Toomas Soome

10:38 AM Bug #10158 (Closed): sgs/rtld: cast between incompatible function types

Issue found by gcc 8 build:... Toomas Soome

10:20 AM Bug #10157 (Closed): sgs/libld: cast between incompatible function types

Issue found by gcc8 build:... Toomas Soome

2018-12-21

08:53 PM Bug #10155 (Closed): ip: cast between incompatible function types

issue found by gcc 8 build:... Toomas Soome

08:27 PM Bug #10154 (Closed): zfs: cast between incompatible function types

Issue found by gcc 8 build:... Toomas Soome

07:01 PM Feature #10049 (Closed): mboot: mboot is no longer needed

"git commit e74ff6533275aaaa8989786dfbba24b3281e3530":https://github.com/illumos/illumos-gate/commit/e74ff6533275aaaa... Electric Monk

07:01 PM Bug #10072 (Closed): ip: timeout takes void (*)(void *) as callback

"git commit e88f57b4cab0ed8f8a773d404d6781e20a4c26d7":https://github.com/illumos/illumos-gate/commit/e88f57b4cab0ed8f... Electric Monk

06:59 PM Bug #10072: ip: timeout takes void (*)(void *) as callback

Tested by checking disassemblies of affected mi_* functions. Only noted differences were in line numbers passed to a... Dan McDonald

06:14 PM Bug #9689 (Closed): zfs range lock code should not be zpl-specific

"git commit 7931524763ef94dc16989451dddd206563d03bb4":https://github.com/illumos/illumos-gate/commit/7931524763ef94dc... Electric Monk

12:39 PM Bug #10153 (Closed): checkpaths shouldn't check packaging exceptions

protocmp already complains if an exception is missing from the proto areas, so this check is pointless, and goes wron... John Levon

12:05 AM Bug #10071 (Closed): genunix: loadable_syscall: cast between incompatible function types

"git commit 1ec00b5abd071c76e2dc0cfa7905965b6b7a89a9":https://github.com/illumos/illumos-gate/commit/1ec00b5abd071c76... Electric Monk

12:05 AM Support #1228 (Closed): Add CCM and GCM mode support to AES in pkcs11_softtoken

"git commit fb2612809ed5f2cb9109db768e63d61f6659f71b":https://github.com/illumos/illumos-gate/commit/fb2612809ed5f2cb... Electric Monk

2018-12-20

01:05 PM Bug #10152 (Closed): bge debugging always on

... Arne Jansen

09:20 AM Bug #10151 (Closed): mv_xattrs() checks for a NULL array name

In libcmdutils. Array names can't be NULL John Levon

09:00 AM Bug #10150 (Closed): smbd needs smatch fixes

Disable a couple of smatch checks in usr/src/cmd/smbsrv/smbd John Levon

2018-12-19

11:15 PM Bug #10149 (Closed): make latencytop smatch clean

Disable function return checks for latencytop smatch checks. John Levon

11:10 PM Bug #10148 (Closed): hald should skip smatch checks

It has some issues, disable smatch for now. John Levon

11:08 PM Bug #10147 (Closed): pyzfs should disable function return checks

This code is not linted, skip this check for smatch John Levon

11:06 PM Bug #10146 (Closed): core_pcbe_event_coverage() is missing an else

Found by smatch indentation checks. John Levon

07:00 PM Bug #10145 (Closed): smbios_info_boot() gets NULL check wrong

We shouldn't dereference 'stp' before we check it. John Levon

06:59 PM Bug #10144 (Closed): BZ2_bzDecompressReset() gets NULL check wrong

We shouldn't dereference 'strm' before we check it. John Levon

06:44 PM Bug #10143 (Closed): smatch fix for ttymon

Fix the source enough to allow smatch to compile it. John Levon

06:43 PM Bug #10142 (Closed): smatch fix for who

Quieten smatch. John Levon

06:43 PM Bug #10141 (Closed): smatch fix for zoneadmd

Quieten smatch. John Levon

06:43 PM Bug #10140 (Closed): notify_params.c is walking past end of array

Fix up the get_fma_tag() and get_fma_class() routines. John Levon

06:42 PM Bug #10139 (Closed): smatch fixes for usr/src/cmd/stat

Quieten smatch. John Levon

06:41 PM Bug #10138 (Closed): smatch fixes for usr/src/cmd/sgs

Fix a few smatch lint reports. John Levon

06:41 PM Bug #10137 (Closed): smatch fixes for setuname

A couple of small fixes are needed. John Levon

06:40 PM Bug #10136 (Closed): smatch fix for policykit

Keep smatch quiet. John Levon

06:40 PM Bug #10135 (Closed): picl plugins need smatch fixes

A couple of small fixes needed, found by smatch. John Levon

06:39 PM Bug #10134 (Closed): mv needs smatch fixes

Fix indenting, and a NULL check for an array name John Levon

06:38 PM Bug #10133 (Closed): smatch fixes for usr/src/cmd/fs.d

smatch identified a couple of small fixes needed in usr/src/cmd/fs.d John Levon

06:37 PM Bug #10132 (Closed): smatch fixes for MDB

smatch identified various issues with code in usr/src/cmd/mdb John Levon

06:32 PM Bug #10131 (Closed): fmtmsg is bitwise, not streetwise

Quieten smatch. John Levon

06:31 PM Bug #10130 (Closed): smatch fixes for usr/src/cmd/fm

smatch identified a couple of use after frees, and one other lint. John Levon

06:30 PM Bug #10129 (Closed): smatch fix for dtrace tests

Quieten smatch. John Levon

06:29 PM Bug #10128 (Closed): csplit should use strlcpy

smatch identified that getfile() should be using strlcpy. John Levon

06:26 PM Bug #10127 (Closed): coreadm is mis-using strcpy()

Replace the potential overflows with use of strlcpy() John Levon

06:19 PM Bug #10126 (Closed): smatch fix for kmfcfg

smatch is being a bit picky here, but let's assuage it. John Levon

06:18 PM Bug #10125 (Closed): smatch fixes for cmd-inet

Fix a few minor issues smatch found in usr/src/cmd/cmd-inet John Levon

06:16 PM Bug #10124 (Closed): smatch fixes for cryptoadm

smatch found a double free, a leak, and a bad NULL check in cryptoadm John Levon

06:15 PM Bug #10123 (Closed): smatch fix for mbr.c

Ignore close() return value. John Levon

06:13 PM Bug #10122 (Closed): beadm buffer over-run

init_hdr_cols() shouldn't write past the end of the col[] array. John Levon

06:12 PM Bug #10121 (Closed): smatch fix for auditstat

The current sparse version can't handle implicit ints. John Levon

06:09 PM Bug #10120 (Closed): smatch indenting fixes for usr/src/cmd

Enough indenting fix ups to keep smatch happy in usr/src/cmd John Levon

05:47 PM Bug #10119 (Closed): audit(1) gets NULL check wrong

is_audit_config_ok() should be checking for NULL prior to checking string[0] John Levon

05:41 PM Bug #10118 (Closed): libeti() NULL check after deref

set_max_field() uses 'f' and then checks it against NULL John Levon

05:37 PM Bug #10117 (Closed): libbe needs smatch fixes

be_get_boot_args() is not checking for asprintf() failure correctly, and be_create_menu() has a use after free. John Levon

05:34 PM Bug #10116 (Closed): mech_dh needs smatch fixes

Add a couple of casts. John Levon

05:33 PM Bug #10115 (Closed): ses topo module needs smatch fixes

We just need to cast to void some signal functions. John Levon

05:31 PM Bug #10114 (Closed): fmev_proxy_cb() doesn't need inval checks

We dereference before the NULL check, but neither check is required. John Levon

05:28 PM Bug #10113 (Closed): fmd_adm_xprt_f should return void

Nobody cares about the return value, and it's always zero. John Levon

05:20 PM Bug #10112 (Closed): cfga_sata.c needs a smatch fix

John Levon

11:52 AM Bug #10111 (Closed): dat_dictionary_create() use after free

John Levon

11:51 AM Bug #10110 (Closed): get_tz_countries shouldn't check array for NULL

Array names can't be NULL. John Levon

11:51 AM Bug #10109 (Closed): libzonecfg needs a smatch fix

Cast a function call to void. John Levon

11:50 AM Bug #10108 (Closed): libstmfproxy needs smatch fixes

Need to cast some functions to void. John Levon

11:50 AM Bug #10107 (Closed): librpcsvc needs smatch fixes

John Levon

11:50 AM Bug #10106 (Closed): libreparse needs smatch fixes

Cast a function to void. John Levon

11:49 AM Bug #10105 (Closed): libproject needs smatch fixes

Cast pool_conf_close() to void. John Levon

11:49 AM Bug #10104 (Closed): pam_set_data() dereferences pointer before checking for NULL

John Levon

11:49 AM Bug #10103 (Closed): libmlrpc needs smatch fixes

Cast a function to void. John Levon

11:49 AM Bug #10102 (Closed): libnvfru needs smatch fixes

Cast a function to void. John Levon

11:48 AM Bug #10101 (Closed): audio tools need smatch fixes

Some minor fixes in audiorecord/audioplay. John Levon

11:48 AM Bug #10100 (Closed): Illumos is confused about calloc() arguments

smatch complains about reversed calloc() arguments; fix them up. John Levon

11:47 AM Bug #10099 (Closed): libfakekernel vpanic() should cast away assfail()

We're picking up the kernel's assfail() prototype, so just cast it. John Levon

11:47 AM Bug #10098 (Closed): task_alloc() in libfakekernel gets KM_NOSLEEP test wrong

KM_SLEEP is zero, so this test was meaningless. John Levon

11:46 AM Bug #10097 (Closed): indenting fixes in usr/src/{lib,common}

Fix indenting issues that smatch complained about. John Levon

11:45 AM Bug #10096 (Closed): kstat update routines shouldn't check for NULL kstat

It can't be NULL, and we dereference it before anyway. John Levon

11:45 AM Bug #10095 (Closed): unchecked return value in segvn_pagelock()

Cast it to void. John Levon

11:44 AM Bug #10094 (Closed): i_mdi_client_free() doesn't need to check for a NULL cdip

It can't be NULL at this point. John Levon

11:44 AM Bug #10093 (Closed): kmem_log_enter() dereferences pointer before NULL check

John Levon

11:44 AM Bug #10092 (Closed): sysevent_evc_control() dereferences pointer before checking for NULL

John Levon

11:43 AM Bug #10091 (Closed): smatch fixes for ahci.c

smatch identified a couple of minor issues in ahci.c John Levon

11:40 AM Bug #10090 (Closed): rt2860_free_rx_ring doesn't need to check for NULL array

Array names can't be NULL. John Levon

11:40 AM Bug #10089 (Closed): phy_check() is bitwise, should be streetwise

mii.c was using a bitwise operation when it should be logical. By change, it happened to work the same. John Levon

11:39 AM Bug #10088 (Closed): ldterm_do_ioctl() shouldn't check for a NULL array

Array names can't be NULL. John Levon

11:39 AM Bug #10087 (Closed): atge_attach() doesn't need to check for kmem_zalloc() success

smatch noticed that it's silly to check for a NULL from a KM_SLEEP allocation. John Levon

11:38 AM Bug #10086 (Closed): ixgbe_m_propinfo() is missing an 'else'

smatch noticed the indentation seemed wrong, and identified this (harmless) issue. John Levon

11:37 AM Bug #10085 (Closed): sctp_getpeeraddrs() doesn't need to check for a NULL primary

The primary has already been dereferenced, so we shouldn't need to check. John Levon

11:35 AM Bug #10084 (Closed): fop_open() doesn't need to check for a NULL vnode

The pointer has already been dereferenced, so it cannot be NULL. John Levon

11:29 AM Bug #10083 (Closed): smatch fixes for common/fs/vfs.c

Fix a couple of minor smatch-identified issues. John Levon

11:29 AM Bug #10082 (Closed): intel_nhm is checking for NULL arrays

smatch warns for comparisons of an array name with NULL John Levon

11:28 AM Bug #10081 (Closed): smatch indenting fixes for usr/src/uts

smatch warns about strange indenting; this is all the easy fixes for usr/src/uts John Levon

11:27 AM Bug #10080 (Closed): smatch Makefile changes for usr/src/cmd

Makefile portion of the smatch noise reduction for usr/src/cmd John Levon

11:27 AM Bug #10079 (Closed): smatch Makefile changes for usr/src/lib

Makefile portion of the smatch noise reduction for usr/src/lib John Levon

11:26 AM Bug #10078 (Closed): smatch fixes for UCB

We don't care too much about UCB, so turn smatch off pretty much all over here John Levon

11:25 AM Bug #10077 (Closed): usr/src/uts/ Makefile changes for smatch

Mostly, we turn off smatch warnings, which should be evaluated later. John Levon

11:24 AM Bug #10076 (Closed): make usr/src/test smatch clean

John Levon

11:15 AM Bug #10075 (Closed): make usr/src/tools smatch clean

A few small changes are needed for smatch to be happy with usr/src/tools John Levon

2018-12-18

11:29 PM Bug #9042: multiples of tty streams modules cause weirdness

I contributed a patch to OpenSSH upstream to work around this:
https://bugzilla.mindrot.org/show_bug.cgi?id=2945 Fazal Majid

08:15 PM Bug #6493: cache-nonvolatile is not documented in sd(7D)

>This should be in the illumos-gate project, not site.
Opps, I'm late. Gergő Mihály Doma

07:13 PM Bug #10056 (Closed): 9894 broke PYTHON_VERSION

"git commit d81547170496f442be8d1f2761ffcd2781f726b2":https://github.com/illumos/illumos-gate/commit/d81547170496f442... Electric Monk

07:13 PM Bug #10061 (Closed): usr/src/lib/libc/port/gen/l3.c is unused

"git commit ae72ee9643cbd127139a2b6363b3f9c2872a5578":https://github.com/illumos/illumos-gate/commit/ae72ee9643cbd127... Electric Monk

07:13 PM Feature #10065 (Closed): exception_lists: remove some loader exceptions

"git commit a22312a2010fbc0fae7e50874e1cc393f1256887":https://github.com/illumos/illumos-gate/commit/a22312a2010fbc0f... Electric Monk

12:11 PM Bug #10072 (Closed): ip: timeout takes void (*)(void *) as callback

The issue found by gcc 8 build:... Toomas Soome

11:38 AM Bug #10071 (Closed): genunix: loadable_syscall: cast between incompatible function types

Issue reported by gcc 8 build:... Toomas Soome

08:34 AM Bug #10070 (In Progress): smbd problem on system reboot

while host is rebooting (shutting down) the following message appears in syslog:... Toomas Soome

02:12 AM Bug #5882 (Closed): Temporary pool names

"git commit 04e56356520b98d5a93c496b10f02530bb6647e0":https://github.com/illumos/illumos-gate/commit/04e56356520b98d5... Electric Monk

12:32 AM Bug #9986: ddi_prop_lookup(9F) family should accept const property name

It seems that it might be reasonable to do at least two different things:
* fix up just the @ddi_prop_lookup@ fami... Joshua M. Clulow

2018-12-17

11:11 PM Feature #10068 (Rejected): Feature request: comment field as a ZFS property

It looks like user properties fit the bill! Joshua M. Clulow

10:51 PM Feature #10068: Feature request: comment field as a ZFS property

Guenther Alka wrote:
> With ZFS storage appliances or user scripts you need to process special informations that are... Guenther Alka

10:18 PM Feature #10068: Feature request: comment field as a ZFS property

Have you looked at zfs user properties (http://illumos.org/man/1m/zfs#user-properties )? Jason King

10:02 PM Feature #10068 (Rejected): Feature request: comment field as a ZFS property

With ZFS storage appliances or user scripts you need to process special informations that are only relevant by this s... Guenther Alka

11:07 PM Bug #5541 (Closed): queue(3) man page is needed

A manual page was added in #9731: @queue.h(3HEAD)@, also available at https://illumos.org/man/3HEAD/queue.h Joshua M. Clulow

10:24 PM Feature #10058 (Closed): loader: Add an ISO9660 "partition table" type to loader.

"git commit 922a2a1681b0f92b4d65daff3cbcd841293d5778":https://github.com/illumos/illumos-gate/commit/922a2a1681b0f92b... Electric Monk

10:24 PM Bug #10060 (Closed): loader: fix DEBUG messages in disk/part interfaces

"git commit 4da7ed37ba5e1e12c0618eef16411d6fd67dd8c6":https://github.com/illumos/illumos-gate/commit/4da7ed37ba5e1e12... Electric Monk

10:24 PM Bug #10062 (Closed): illumos.sh could be re-organized

"git commit 36acdd115a7d14b9a0ffd968d084ebeac2451a7e":https://github.com/illumos/illumos-gate/commit/36acdd115a7d14b9... Electric Monk

02:54 PM Bug #10056: 9894 broke PYTHON_VERSION

Review at: https://illumos.org/rb/r/1318/
Testing notes:
Built with and without PYTHON_VERSION set in .env
wsd... Andy Fiddaman

2018-12-16

03:01 PM Bug #10067 (Closed): Miscellaneous man page typos

Another batch of typos in man pages:
calcluate - man3elf/elf32_checksum.3elf
asnchronous - man3socket/connect.3so... Peter Tribble

2018-12-15

06:03 PM Bug #3334: zonestat missing man page

I there any way zonestat man page could be legally paraphrased from old Solaris 11 express man page? Priyadarshan G.D.

02:11 AM Feature #9971 (Closed): Make getrandom(2) a public interface

"git commit de6af22ae73ba8d72672288621ff50b88f2cf5fd":https://github.com/illumos/illumos-gate/commit/de6af22ae73ba8d7... Electric Monk

01:03 AM Feature #9971: Make getrandom(2) a public interface

... Joshua M. Clulow

2018-12-14

08:06 PM Feature #10066 (Closed): loader: Add isoboot(5) for booting BIOS systems from HDDs containing ISO images.

FreeBSD update: https://svnweb.freebsd.org/base?view=revision&revision=332084
A bit changed (for our needs) descri... Toomas Soome

06:36 PM Feature #10065 (Closed): exception_lists: remove some loader exceptions

Remove some exceptions for loader tree, so we can spot issues more easily Toomas Soome

05:09 PM Bug #10064 (Closed): loader: zfs reader should not probe partitionless disks

See also: https://reviews.freebsd.org/D18558
First of all, normal setups can not boot such pools as the tools
do ... Toomas Soome

03:38 PM Bug #10063 (Closed): basic support for smatch

As described in IPD 2, let's introduce some basic support for running smatch against the Illumos source base. John Levon

03:04 PM Bug #10062 (Closed): illumos.sh could be re-organized

Currently, there's a whole bunch of things that need to be modified for a successful build
in illumos.sh. However, t... John Levon

01:46 PM Bug #10011: stop building and shipping lint libraries

In OmniOS it's:... Andy Fiddaman

2018-12-13

09:07 PM Bug #10061 (Closed): usr/src/lib/libc/port/gen/l3.c is unused

The source file
usr/src/lib/libc/port/gen/l3.c
is not referenced by any Makefiles and the code it contains (int... Peter Tribble

05:45 PM Bug #10057 (Closed): Man page misspellings: "ouput", "particuliar", and "overriden"

"git commit 03270635d68df6a0392fb8f4b7c04acad764648b":https://github.com/illumos/illumos-gate/commit/03270635d68df6a0... Electric Monk

04:21 PM Bug #10048 (Closed): fdisk: use /boot/pmbr if possible

"git commit 13b70267be56f36cbbc54ef71e13714ad820ad22":https://github.com/illumos/illumos-gate/commit/13b70267be56f36c... Electric Monk

04:18 PM Bug #9683 (Closed): Allow bypassing devid in vdev_disk_open()

"git commit 6fe4f3002ca33af5ab7123ed78d81899dadf2fbb":https://github.com/illumos/illumos-gate/commit/6fe4f3002ca33af5... Electric Monk

04:16 PM Bug #9847 (Closed): leaking dd_clones (DMU_OT_DSL_CLONES) objects

"git commit 17fb938fd6cdce3ff1bb47dafda0774f742249a3":https://github.com/illumos/illumos-gate/commit/17fb938fd6cdce3f... Electric Monk

04:15 PM Bug #9559 (Closed): zfs diff handles files on delete queue in fromsnap poorly

"git commit 20633e304b57bc98f70fdb194081b7023adf527b":https://github.com/illumos/illumos-gate/commit/20633e304b57bc98... Electric Monk

09:52 AM Bug #9986: ddi_prop_lookup(9F) family should accept const property name

I was having a look through this as a bite-size bug, however chaining through the const qualifiers in functions calls... Jeff Walsh

2018-12-12

06:57 AM Bug #10060 (Closed): loader: fix DEBUG messages in disk/part interfaces

Problems found by Gergő Mihály Doma:
use PRI* macros from inttypes.h and avoid type casts for printf arguments.
f... Toomas Soome

04:17 AM Bug #10059 (New): fdisk: removal of duplicated endian conversion macros

les(val) and lel(val) endian conversion macros aren't needed, these can be replaced with LE_* macros from <sys/byteor... Gergő Mihály Doma

2018-12-11

04:55 PM Feature #10058 (Closed): loader: Add an ISO9660 "partition table" type to loader.

Update from FreeBSD: https://svnweb.freebsd.org/base?view=revision&revision=332085
When booted via isoboot(8) load... Toomas Soome

02:57 PM Bug #10053 (Closed): loader: rework cd9660 header paths and update header

"git commit 2a6e99a0f1f7d22c0396e8b2ce9b9babbd1056cf":https://github.com/illumos/illumos-gate/commit/2a6e99a0f1f7d22c... Electric Monk