Project

General

Profile

Activity

From 2018-12-19 to 2019-01-17

2019-01-17

11:00 PM Bug #10211 (Closed): UFS freebehind can induce hat_pageunload()/htable_purge_hat() race
"git commit 9c65d7db6997bfa2730f9cdf6167f3982c9d2db6":https://github.com/illumos/illumos-gate/commit/9c65d7db6997bfa2... Electric Monk
06:33 PM Feature #7834: uts: vgatext should use gfx_private
h1. Some additional notes that Toomas put on Reviewboard:
The current illumos console does use following chain for...
Joshua M. Clulow
06:19 PM Bug #10259 (Closed): Build error for iconv_modules on sparc
Building on sparc gives many:
In file included from ../common/UTF-8_TO_ISO-2022-JP.c:32:
../common/jfp_iconv_unic...
Peter Tribble
05:19 PM Bug #10258 (Closed): Not all the qinit changes were copied to sparc
In 9903, the fields to qinit are now typed. Some sparc modules have close functions with the wrong type, leading to t... Peter Tribble
05:09 PM Bug #10257: Build on sparc calls assembler incorrectly
The question is then why -fpic is being passed.
This is coming from
pics/%.o:= CPPFLAGS += $(C_PICFLAGS) -DPIC
...
Peter Tribble
05:05 PM Bug #10257 (Closed): Build on sparc calls assembler incorrectly
Building on sparc fails with many of the follwoing in libbc:
/usr/ccs/bin/as -xregsym=no -P -D__STDC__ -DLOCORE -D...
Peter Tribble
04:07 PM Bug #10215 (Closed): lofiadm -la fails after lofiadm -a / lofiadm -d
"git commit 45ca53447fde2f014d6d62f6bbbfc0b97ae011dd":https://github.com/illumos/illumos-gate/commit/45ca53447fde2f01... Electric Monk
04:07 PM Bug #10083 (Closed): smatch fixes for common/fs/vfs.c
"git commit d6294894f9d15dfb12a0dd3a6acf8bd4a4a65408":https://github.com/illumos/illumos-gate/commit/d6294894f9d15dfb... Electric Monk
04:07 PM Bug #10082 (Closed): intel_nhm is checking for NULL arrays
"git commit 598f111b6a2800d5bd143949a1bdb1e786a92fc3":https://github.com/illumos/illumos-gate/commit/598f111b6a2800d5... Electric Monk
04:07 PM Bug #10084 (Closed): fop_open() doesn't need to check for a NULL vnode
"git commit f19903c648bc62d61c7a20de6269dc85395c965b":https://github.com/illumos/illumos-gate/commit/f19903c648bc62d6... Electric Monk
04:07 PM Bug #10085 (Closed): sctp_getpeeraddrs() doesn't need to check for a NULL primary
"git commit c1bf5ca093201aa1b43846f6bc194c780f03599e":https://github.com/illumos/illumos-gate/commit/c1bf5ca093201aa1... Electric Monk
04:07 PM Bug #10087 (Closed): atge_attach() doesn't need to check for kmem_zalloc() success
"git commit 80e3e2368f7911a78a5f2f1a961052b37f3a76d0":https://github.com/illumos/illumos-gate/commit/80e3e2368f7911a7... Electric Monk
04:07 PM Bug #10086 (Closed): ixgbe_m_propinfo() is missing an 'else'
"git commit bb54aa2057d4245bc905df8c193acb7b8b0bb74b":https://github.com/illumos/illumos-gate/commit/bb54aa2057d4245b... Electric Monk
04:07 PM Bug #10088 (Closed): ldterm_do_ioctl() shouldn't check for a NULL array
"git commit 24c5c9f44237084e2bc735b78e3c0009959de21b":https://github.com/illumos/illumos-gate/commit/24c5c9f44237084e... Electric Monk
03:58 PM Bug #10256 (New): SCTP may need to check for NULL sf_ixa
Issue #10085 removes a superfluous NULL-pointer check. The check removed, however, may need to be replaced instead w... Dan McDonald
08:48 AM Bug #10231: loader fb-putimage should support image resizing and placement
Testing:
!https://www.illumos.org/attachments/download/1742/Screenshot%202019-01-17%2008.47.52.png!
Andy Fiddaman
07:29 AM Bug #10224: memset_s() is not visible in global C++ namespace
At http://eel.is/c++draft/headers we read:... Alexander Pyhalov
12:51 AM Bug #10225 (Closed): wsdiff broken after 9979
"git commit c8cc685318cb78c62f1ff07bc561b26d65780aa3":https://github.com/illumos/illumos-gate/commit/c8cc685318cb78c6... Electric Monk

2019-01-16

11:47 PM Bug #10255: SES temperature thresholds 20 degrees too hot
Our fix (Copyright to RackTop Systems):... Garrett D'Amore
11:42 PM Bug #10255 (Closed): SES temperature thresholds 20 degrees too hot
The SES-2 specification supplies thresholds, which libses encodes in the nvlist, for temperatures.
For "bit effici...
Garrett D'Amore
11:20 PM Bug #10195 (Closed): uts: boot_keyboard should emit esc sequences for arrow keys
"git commit ead1aeb99fc825309962c1dc2f20333bdd5898f6":https://github.com/illumos/illumos-gate/commit/ead1aeb99fc82530... Electric Monk
08:37 PM Bug #10254 (Closed): Build error for dtrace_isa.c on sparc
Building on SPARC:
../../sparc/dtrace/dtrace_isa.c:945: error: conflicting types for 'dtrace_setreg'
../../common...
Peter Tribble
08:29 PM Bug #10229 (Closed): Some man pages have incorrect cross-references
"git commit 9f17ecf0b8fdc59cfa903ceb6a96046b0f2d8201":https://github.com/illumos/illumos-gate/commit/9f17ecf0b8fdc59c... Electric Monk
08:17 PM Bug #10216 (Closed): xargs does not properly detect when -P is negative
"git commit 7c71d71894ca896e2718a24b51b39b0e5f9c27e6":https://github.com/illumos/illumos-gate/commit/7c71d71894ca896e... Electric Monk
07:49 PM Bug #10225 (Pending RTI): wsdiff broken after 9979
Andy Fiddaman
06:57 PM Bug #10232 (Closed): beastie.4th manpage not shipped
"git commit 1bf8e91c2f089f0b4e9a6f705f162654aa82cfad":https://github.com/illumos/illumos-gate/commit/1bf8e91c2f089f0b... Electric Monk
10:30 AM Bug #10232 (Pending RTI): beastie.4th manpage not shipped
Review at https://illumos.org/rb/r/1371/
Testing notes:
Build, check mail_msg, onu, @man beastie.4th@
Andy Fiddaman
05:55 PM Bug #8237 (Closed): libscsi improperly translates request sense and isolate options to uscsi
"git commit 0b4d657578b8f707371421ebae5b3837023b4144":https://github.com/illumos/illumos-gate/commit/0b4d657578b8f707... Electric Monk
05:55 PM Bug #8236 (Closed): fwflash sd plugin shouldn't hardcode maximum image size
"git commit 0b4d657578b8f707371421ebae5b3837023b4144":https://github.com/illumos/illumos-gate/commit/0b4d657578b8f707... Electric Monk
05:55 PM Feature #8235 (Closed): fwflash for sd needs to handle partial writes
"git commit 0b4d657578b8f707371421ebae5b3837023b4144":https://github.com/illumos/illumos-gate/commit/0b4d657578b8f707... Electric Monk
04:21 PM Bug #10253 (New): sol_uverbs is confused about bits
... John Levon
04:18 PM Bug #10252 (New): rge_phy_update() is lop-sided over braces
... John Levon
04:11 PM Bug #10251 (New): ip_fanout gets IPsec check wrong
... John Levon
03:42 PM Bug #10250 (New): access_mask_check() has incorrect check
... John Levon
03:18 PM Bug #10249 (New): blkdev(7d): Missing documentation for tn and pn
In the blkdev(7d) man page there is this:... Marcel Telka
02:11 PM Bug #10248 (Closed): SCALL_UNLOADABLE to SCALL_NO_UNLOADABLE rename in 9057 incomplete on SPARC
The following error is given if you build on SPARC:
/usr/ccs/bin/as: "../../sparc/ml/modstubs.s", line 369: error:...
Peter Tribble
01:31 PM Bug #10247 (New): emlxs_vpi_logi_cmpl_action() gets topology change wrong
... John Levon
01:26 PM Bug #10246 (Closed): fix apic_allocate_irq() indentation
The indentation of this function is wrong, but the code is OK; fix it up for smatch John Levon
12:59 PM Bug #10245 (Closed): Build error for usr/src/uts/common/exec/elf/elf.c on sparc
On a SPARC build, we see the following error:
../../common/exec/elf/elf.c:841: error: unused variable 'fptype' [-W...
Peter Tribble
12:57 PM Bug #10244 (New): svc.startd dgraph_state_transition_notify() gets IS_ENABLED() check wrong
4713 } else if (stn_transition & stn_global &&
4714 (IS_ENABLED(v) == 1 || to == SCF_STATE_DISAB...
John Levon
12:21 AM Bug #10243 (Closed): topo_node_label_set() should take a const char* instead of char*
It's a minor issue, but it'd be preferable if topo_node_label_set() took a const char* as the type for the "label" pa... Robert Mustacchi
12:20 AM Feature #10242: Project Tiresias: USB topology
Tests:
* Verified that we see generic ACPI port mapping on various systems (NUCs, Haswell client 1s, etc.)
* Veri...
Robert Mustacchi
12:18 AM Feature #10242 (Closed): Project Tiresias: USB topology
This is a ticket that goes through and adds support for USB topology to the system. It allows for us to construct top... Robert Mustacchi

2019-01-15

09:26 PM Bug #10233 (Closed): dboot: process_module() is missing newline at the end of the string
"git commit f482e26cbeb654aaa01a12e3faae3878d6a59822":https://github.com/illumos/illumos-gate/commit/f482e26cbeb654aa... Electric Monk
08:23 PM Bug #10241 (New): ZFS not detecting faulty spares in a timely manner
This is an upstream copy of OS-6602 (https://smartos.org/bugview/OS-6602).
ZFS could be enhanced to proactively pr...
Kody Kantor
08:18 PM Bug #10240 (In Progress): "zpool import -m" could print last txg time
This is an upstream copy of OS-6417 (https://smartos.org/bugview/OS-6417).
It would be helpful if 'zpool import -m...
Kody Kantor
07:38 PM Bug #10219 (Closed): AV_386_2_AVX512VPOPCDQ elfcap name should be consistent
"git commit 161294fe5eab242f42189b33b59ebbe6ac9558f4":https://github.com/illumos/illumos-gate/commit/161294fe5eab242f... Electric Monk
07:38 PM Bug #10218 (Closed): CONV_CAP_VAL_HW2_BUFSIZE wasn't updated
"git commit 161294fe5eab242f42189b33b59ebbe6ac9558f4":https://github.com/illumos/illumos-gate/commit/161294fe5eab242f... Electric Monk
07:38 PM Bug #10217 (Closed): mdb: r9w isn't r8w
"git commit 161294fe5eab242f42189b33b59ebbe6ac9558f4":https://github.com/illumos/illumos-gate/commit/161294fe5eab242f... Electric Monk
07:57 AM Bug #10239: iwn(7D) disconnects from wifi networks at random times
... Olaf Bohlen

2019-01-14

10:10 PM Bug #10078 (Closed): smatch fixes for UCB
"git commit cadd68ea0014761eda6a293664086dfa80686d85":https://github.com/illumos/illumos-gate/commit/cadd68ea0014761e... Electric Monk
10:10 PM Bug #10081 (Closed): smatch indenting fixes for usr/src/uts
"git commit 15c07adc1c7b828006b5e3c4d528b92229d6bd23":https://github.com/illumos/illumos-gate/commit/15c07adc1c7b8280... Electric Monk
10:10 PM Bug #10197 (Closed): build smatch in parallel
"git commit c653bb4713ca694c2d16b04b65d5b76c0bb46bd4":https://github.com/illumos/illumos-gate/commit/c653bb4713ca694c... Electric Monk
10:10 PM Bug #10080 (Closed): smatch Makefile changes for usr/src/cmd
"git commit 5661bb7641e85c46713da7a3002b29ecd2c3daf0":https://github.com/illumos/illumos-gate/commit/5661bb7641e85c46... Electric Monk
10:10 PM Bug #10079 (Closed): smatch Makefile changes for usr/src/lib
"git commit 05ede3db5e3b7d540afbccdc872c735770e82ef3":https://github.com/illumos/illumos-gate/commit/05ede3db5e3b7d54... Electric Monk
10:06 PM Bug #10239 (New): iwn(7D) disconnects from wifi networks at random times
I run OI/hipster (illumos-2918c4a32d) on my ThinkPad X230 with a iwn compatible wifi card.
After random times of a w...
Olaf Bohlen
08:27 PM Bug #10238: loader: Simplify code using new n2s,s2n and getenvn words
Review at https://illumos.org/rb/r/1369/ Andy Fiddaman
08:04 PM Bug #10238 (Closed): loader: Simplify code using new n2s,s2n and getenvn words
Andy Fiddaman
07:36 PM Bug #10237 (Closed): Disable smatch for iasl
iasl is 3rd-party ACPI code; disable smatch John Levon
07:13 PM Feature #6950: ARC should cache compressed data
From the commit message in the original commit to the OpenZFS repository:
> This change covers the reading and wr...
Joshua M. Clulow
05:41 PM Feature #10236 (Closed): uts: tem get colors from early boot data
To build more consistent console, we will inherit attributes like inverses, colors and cursor position from boot load... Toomas Soome
05:34 PM Bug #10202 (Closed): loader: use screen-#rows to find bottom left co-ordinates
"git commit 1ea94c756c0bc9170021d7b570944a24f224c03f":https://github.com/illumos/illumos-gate/commit/1ea94c756c0bc917... Electric Monk
10:30 AM Bug #10202 (Pending RTI): loader: use screen-#rows to find bottom left co-ordinates
Andy Fiddaman
10:30 AM Bug #10202: loader: use screen-#rows to find bottom left co-ordinates
Testing notes
Boot and test with and without framebuffer, confirm cursor 'lives' at bottom left during autoboot co...
Andy Fiddaman
05:18 PM Feature #10235 (Closed): uts: boot needs simple tem to support mdb
boot -kd will load and drop us into kmdb and that prompt is quite unfriendly. This patch will make it a bit less unfr... Toomas Soome
05:04 PM Feature #10234 (Closed): uts: early start frame buffer console support
Build initial FB support for dboot and locore, that is, for the very early kernel. We are using the existing font sol... Toomas Soome
04:26 PM Bug #10233 (Closed): dboot: process_module() is missing newline at the end of the string
No newline means the text will be lost....
Toomas Soome
04:22 PM Bug #10232 (Closed): beastie.4th manpage not shipped
Andy Fiddaman
04:12 PM Feature #10173 (Closed): loader: support newer ZFS versions
"git commit 08487eea68a2fa501b5042131c6db068089f82e1":https://github.com/illumos/illumos-gate/commit/08487eea68a2fa50... Electric Monk
03:32 PM Bug #10231 (Closed): loader fb-putimage should support image resizing and placement
At present, the loader as a word @fb-putimage@ which draws a PNG image at the bottom right of the screen.
This word ...
Andy Fiddaman
02:26 PM Bug #10230 (Closed): zfs mishandles partial writes
The trinity fuzzer calls pwritev with an iovec that has one or more entries which point to some initial valid data an... Jerry Jelinek
01:03 AM Bug #10200 (Closed): loader: spinconsole updates
"git commit 90c559d0abd58b80b54e9bdcfab3b4382f8b68ec":https://github.com/illumos/illumos-gate/commit/90c559d0abd58b80... Electric Monk
12:49 AM Bug #10200: loader: spinconsole updates
> How was this one tested?
set console=spin,ttya and then did cause output on console (via ttya) and spinner was r...
Dan McDonald

2019-01-13

07:51 PM Bug #7441: apr and apr-util paths are hardcoded
mod_ipp removed a long ago, this issue should be closed now. Gergő Mihály Doma

2019-01-12

10:41 PM Bug #10229 (Closed): Some man pages have incorrect cross-references
It's relatively easy to pick out the cross-references (Xr) for man pages in mdoc and verify them.
The following fa...
Peter Tribble
09:14 PM Feature #10227 (Closed): Convert proc(4) manpage to mandoc
Upstream of Joyent OS-6365.
Convert proc(4) to mandoc.
Jason King
08:46 PM Bug #10067 (Closed): Miscellaneous man page typos
"git commit e61d7e85ebb4a7361eeb10639b742a92e0bf5e55":https://github.com/illumos/illumos-gate/commit/e61d7e85ebb4a736... Electric Monk
08:46 PM Bug #10186 (Closed): uts: font functions should check if the char is from the input domain
"git commit 9c7c0c4b592ecf39e7c580cc9b779c7202794a11":https://github.com/illumos/illumos-gate/commit/9c7c0c4b592ecf39... Electric Monk
04:48 PM Feature #10226 (Closed): Need support for new EPYC ISA extensions
There are a number of ISA extensions present in EPYC. We need to make sure that these are all plumbed through.
I w...
Robert Mustacchi
03:05 PM Bug #10202: loader: use screen-#rows to find bottom left co-ordinates
Review at https://illumos.org/rb/r/1363/ Andy Fiddaman
09:56 AM Bug #10225: wsdiff broken after 9979
Testing:... Andy Fiddaman
09:35 AM Bug #10225: wsdiff broken after 9979
Review at https://illumos.org/rb/r/1362/ Andy Fiddaman
09:31 AM Bug #10225 (Closed): wsdiff broken after 9979
9979 made changes to wsdiff to support running under both python2 and python3, but part of the patch was missing in t... Andy Fiddaman
08:40 AM Bug #10215: lofiadm -la fails after lofiadm -a / lofiadm -d
Alexander Pyhalov wrote:
> The following test case fails:
> [...]
I did figure out what does happen:
we have ...
Toomas Soome

2019-01-11

11:44 PM Bug #10224: memset_s() is not visible in global C++ namespace
Updated fix is here: http://buildzone.oi-build.r61.net/webrev-10224/ Alexander Pyhalov
09:13 PM Bug #10224 (Closed): memset_s() is not visible in global C++ namespace
Fix for https://www.illumos.org/issues/8548 introduced std::memset_s(), but it wasn't propagated to global namespace.... Alexander Pyhalov
07:08 PM Feature #10223 (Closed): Want topo maps for various SMCI systems
This adds topology maps for various SMCI systems and their Joyent aliases. For most of these, we're using the factory... Robert Mustacchi
06:47 PM Bug #10208 (Closed): Add x86 features for L1TF
"git commit c7749d0f58752c136e82d09f71ff14b1c2ce91f7":https://github.com/illumos/illumos-gate/commit/c7749d0f58752c13... Electric Monk
06:25 PM Bug #10213 (Closed): Typos in libproc(3lib)
"git commit 7dfe7b8b0a48ab1f37ab9fc3a51e338320621c21":https://github.com/illumos/illumos-gate/commit/7dfe7b8b0a48ab1f... Electric Monk
03:45 AM Bug #10213 (Closed): Typos in libproc(3lib)
Upstream of Joyent OS-7461:
There are a few minor typos in @libproc(3lib)@. For example:...
Jason King
05:55 PM Bug #9058 (Closed): postmortem DTrace frequently broken under vmware
"git commit 793bd7e3617ae7d3d24e8c6b7d6befe35f07ec1f":https://github.com/illumos/illumos-gate/commit/793bd7e3617ae7d3... Electric Monk
05:11 PM Bug #10196 (Closed): Add 'framebuffer?' command to loader
"git commit 33d05bc1b89915cf87dec3f6f9f2d5743fc9ea70":https://github.com/illumos/illumos-gate/commit/33d05bc1b89915cf... Electric Monk
01:51 PM Bug #10196 (Pending RTI): Add 'framebuffer?' command to loader
Andy Fiddaman
01:50 PM Bug #10196: Add 'framebuffer?' command to loader
Review: https://illumos.org/rb/r/1355/
Testing: Built, tested new command from loader prompt:...
Andy Fiddaman
04:52 PM Bug #10222 (Closed): t_bind(3NSL) could mention data types for transports
Upstream of Joyent OS-6101:
The t_bind(3NSL) manpage currently states:...
Jason King
04:38 PM Bug #10221 (New): zfs loading and unloading metaslabs at high frequency
This is Joyent bug OS-7151 (https://smartos.org/bugview/OS-7151) There is a lot of detail in that bug report. To summ... Jerry Jelinek
04:28 PM Feature #10204 (Closed): uts: add dboot map debug printf
"git commit fe4e42e2947308b70ca67636d033b989c8ab5450":https://github.com/illumos/illumos-gate/commit/fe4e42e2947308b7... Electric Monk
04:11 PM Bug #10220 (Closed): libproc ia32 Pstack_iter() should leverage ctf
libproc provides the Pstack_iter() function. When debugging i386 processes, it tries to guess the number of arguments... Robert Mustacchi
04:09 PM Bug #10219 (Closed): AV_386_2_AVX512VPOPCDQ elfcap name should be consistent
Currently the naming scheme for AV_386_2_AVX512VPOPCDQ is different in different string forms. Some use an underscore... Robert Mustacchi
04:08 PM Bug #10218 (Closed): CONV_CAP_VAL_HW2_BUFSIZE wasn't updated
While working on other matters, I was noticed something odd in elfdump of the notes section. Look at the hwcap2 entry... Robert Mustacchi
04:06 PM Bug #10217 (Closed): mdb: r9w isn't r8w
While debugging something I noticed something strange. Mainly that r9 was working in mdb but trying to use r9w was no... Robert Mustacchi
04:04 PM Bug #10216 (Closed): xargs does not properly detect when -P is negative
While testing some other changes, I noticed that the util-test test suite was failing in xargs. Specifically it was f... Robert Mustacchi
02:42 PM Bug #10215 (Closed): lofiadm -la fails after lofiadm -a / lofiadm -d
The following test case fails:... Alexander Pyhalov
11:00 AM Bug #10214: ipmi and dcmi
... Marcel Telka
11:00 AM Bug #10214 (New): ipmi and dcmi
On some boards (like Supermicro X9SCL/X9SCM) this command:... Marcel Telka
08:18 AM Bug #10205 (Closed): Mounting zfs filesystems on startup shows incorrect data
"git commit 247b7da039fd88350c50e3d7fef15bdab6bef215":https://github.com/illumos/illumos-gate/commit/247b7da039fd8835... Electric Monk
07:21 AM Bug #10205: Mounting zfs filesystems on startup shows incorrect data
Tested change by copying zfs binary to /sbin/zfs.
With new zfs binary I see
correct "Mounting ZFS filesystems (x/...
Alexander Pyhalov
01:12 AM Feature #10182 (Closed): dd: print scaled stats
"git commit b928ac841f6012f92d5aedbd7dfacf443921fee3":https://github.com/illumos/illumos-gate/commit/b928ac841f6012f9... Electric Monk
12:22 AM Feature #10212 (Closed): Autogenerate Intel pcbe values from perfmon data
Every CPU generation that Intel puts out has its own set of CPU Performance Counters that it uses for measuring vario... Robert Mustacchi
12:17 AM Feature #8886 (Closed): mdns: update to mDNSResponder-878.1.1
"git commit c65ebfc7045424bd04a6c7719a27b0ad3399ad54":https://github.com/illumos/illumos-gate/commit/c65ebfc7045424bd... Electric Monk

2019-01-10

10:33 PM Bug #9846 (Closed): nvme driver shouldn't panic from userland commands
"git commit bc586359b7d9a851391f04b06254a9ead6109d47":https://github.com/illumos/illumos-gate/commit/bc586359b7d9a851... Electric Monk
09:52 PM Feature #9822 (Closed): want iasl
"git commit bc36eafdde0c7048471866fc7cea7b93852592db":https://github.com/illumos/illumos-gate/commit/bc36eafdde0c7048... Electric Monk
09:52 PM Feature #9824 (Closed): Update ACPI to joyent/20180629
"git commit 35786f6866ae52207d0f1a25fe7ca5f652f32ce0":https://github.com/illumos/illumos-gate/commit/35786f6866ae5220... Electric Monk
09:52 PM Bug #9823 (Closed): Deadlock in ACPI Method Evaluation
"git commit 35786f6866ae52207d0f1a25fe7ca5f652f32ce0":https://github.com/illumos/illumos-gate/commit/35786f6866ae5220... Electric Monk
08:12 PM Feature #9814 (Closed): strndup() performs pathologically
"git commit 159a0043473914c03b72d9f0c70c5aae42493748":https://github.com/illumos/illumos-gate/commit/159a0043473914c0... Electric Monk
08:08 PM Bug #10211 (Closed): UFS freebehind can induce hat_pageunload()/htable_purge_hat() race
We died in a stack trace that might look familiar:... Robert Mustacchi
08:00 PM Feature #10210 (Closed): libmd should leverage SHA extensions
With the advent of the new Intel SHA instructions, we should look at what's required to add support for and leverage ... Robert Mustacchi
07:32 PM Feature #9821 (Closed): want a way to run vendor-specific commands via libscsi
"git commit b75e7d76519aa3dc2e72aa357a039a6b65372a1c":https://github.com/illumos/illumos-gate/commit/b75e7d76519aa3dc... Electric Monk
07:14 PM Bug #6200 (Closed): git-pbchk manlint regexp could be improved
Dropping this one. Toomas Soome
06:26 PM Bug #10207 (Closed): loader: libcrypto should use GNUC_ROOT
"git commit 095ab6cfee7e2f599dd04276da3a53d0e1d073fd":https://github.com/illumos/illumos-gate/commit/095ab6cfee7e2f59... Electric Monk
03:12 PM Bug #10207 (Closed): loader: libcrypto should use GNUC_ROOT
"10185 loader: add sha1 hash calculation" did add libcrypto, which does use GCC_ROOT and not GNUC_ROOT, this does hur... Toomas Soome
05:47 PM Feature #9747 (Closed): Implement CPU autoreplace based on Intel PPIN
"git commit 2a613b5974ae49c8b068a3998ff554f8c6f0f593":https://github.com/illumos/illumos-gate/commit/2a613b5974ae49c8... Electric Monk
05:04 PM Bug #10208: Add x86 features for L1TF
To make future merges easier, we'll add the L1TF-related x86 defines to our header file and cpuid feature detection. John Levon
04:56 PM Bug #10208 (Closed): Add x86 features for L1TF
John Levon
04:12 PM Feature #9979 (Closed): Support python3 for in-gate tools
"git commit ca13eaa51ee900abba73dfb6624e492f7e48863e":https://github.com/illumos/illumos-gate/commit/ca13eaa51ee900ab... Electric Monk
02:35 PM Bug #10206 (New): zpool labelclear -f <device> not working as expected
Having some rpool issues - am trying to replace drives as safely/conservatively as possible from root pool, which has... Lou Picciano
02:13 PM Bug #10205: Mounting zfs filesystems on startup shows incorrect data
Webrev: http://buildzone.oi-build.r61.net/webrev-10205/ Alexander Pyhalov
02:05 PM Bug #10205 (Closed): Mounting zfs filesystems on startup shows incorrect data
It seems we are incrementing sms->sm_done twice in share_mount_one_cb() -> report_mount_progress() in usr/src/cmd/zfs... Alexander Pyhalov
06:41 AM Feature #10204 (Closed): uts: add dboot map debug printf
Add little debugging aid, when map_debug=true, print also framebuffer map. Toomas Soome

2019-01-09

11:33 PM Bug #10202 (Closed): loader: use screen-#rows to find bottom left co-ordinates
Currently loader moves the cursor to the bottom left of the screen in a variety of places using @0 25 at-xy ( positio... Andy Fiddaman
07:06 PM Bug #10201 (Closed): prototypes: happy new 2019 year
"git commit 9b40c3052b9b0d91120c568df0c5211c131c8da1":https://github.com/illumos/illumos-gate/commit/9b40c3052b9b0d91... Electric Monk
06:50 PM Bug #10201 (Closed): prototypes: happy new 2019 year
It is new year now. Toomas Soome
06:41 PM Bug #10200 (Closed): loader: spinconsole updates
This update is based on FreeBSD update:
https://svnweb.freebsd.org/base?view=revision&revision=322896
Toomas Soome
06:14 PM Bug #10199 (Closed): loader: vbe should use bio_alloc for edid info
The EDID block is 512 bytes, use bio buffer to read it, save stack space. Toomas Soome
05:59 PM Feature #10198 (Closed): dboot: signal boot loader we can do framebuffer console
Add multiboot2 header the tag to notify boot loader, we can do framebuffer console Toomas Soome
04:29 PM Bug #10197 (Closed): build smatch in parallel
We somehow lost the .PARALLEL from the smatch Makefile. John Levon
04:00 PM Bug #10196 (Closed): Add 'framebuffer?' command to loader
It would be useful to be able to easily check if the framebuffer is in use before, for example, attempting to change ... Andy Fiddaman
02:24 PM Bug #6109 (Closed): tcp(7P) should mention that socket options are in <netinet/tcp.h>
"git commit f5037cd0e0544bd22e4547ec8656b0ec49615f5d":https://github.com/illumos/illumos-gate/commit/f5037cd0e0544bd2... Electric Monk
02:24 PM Bug #10175 (Closed): Organize tcp(7P) into subsections
"git commit f5037cd0e0544bd22e4547ec8656b0ec49615f5d":https://github.com/illumos/illumos-gate/commit/f5037cd0e0544bd2... Electric Monk
02:24 PM Feature #10054 (Closed): loader: move 16KB BSS buffer from pxe to bio and use it with biosdisk
"git commit 3273f292544925d8d86f8e40935d5360aa609ef4":https://github.com/illumos/illumos-gate/commit/3273f292544925d8... Electric Monk
02:24 PM Feature #10066 (Closed): loader: Add isoboot(5) for booting BIOS systems from HDDs containing ISO images.
"git commit 64f9afd1fd6b5f36ed2c633d603a3b551da6f3d4":https://github.com/illumos/illumos-gate/commit/64f9afd1fd6b5f36... Electric Monk
02:24 PM Bug #10075 (Closed): make usr/src/tools smatch clean
"git commit 93b8872871607b3d21317283c1230b2a4a00920b":https://github.com/illumos/illumos-gate/commit/93b8872871607b3d... Electric Monk
02:24 PM Bug #10077 (Closed): usr/src/uts/ Makefile changes for smatch
"git commit b6b206fc7fb36f7b13b01acf70ed6e676e405998":https://github.com/illumos/illumos-gate/commit/b6b206fc7fb36f7b... Electric Monk
02:24 PM Bug #10076 (Closed): make usr/src/test smatch clean
"git commit dc5e7685b131559c0b7c622baee25a9a0ae50ada":https://github.com/illumos/illumos-gate/commit/dc5e7685b131559c... Electric Monk
02:24 PM Bug #10171 (Closed): biosdisk: use int13h ah=08 and ah=15 to count the floppy devices
"git commit 1fe853a05a457dfa95ddc2f2742c2421558a7c30":https://github.com/illumos/illumos-gate/commit/1fe853a05a457dfa... Electric Monk
02:24 PM Bug #10184 (Closed): loader: framebuffer command should report usage on bad command
"git commit 8d2ce326a8ec4271f68dfa69691885d8219c9bb7":https://github.com/illumos/illumos-gate/commit/8d2ce326a8ec4271... Electric Monk
02:24 PM Feature #10185 (Closed): loader: add sha1 hash calculation
"git commit a103f15bc0089ffbdb0e211871d97b6b79f59fa1":https://github.com/illumos/illumos-gate/commit/a103f15bc0089ffb... Electric Monk
11:13 AM Bug #10195 (Closed): uts: boot_keyboard should emit esc sequences for arrow keys
The early kmdb (from boot -kd) does not accept arrow keys, to fix this, we will need to generate the proper key seque... Toomas Soome
07:22 AM Bug #10194 (Closed): iscsi: this statement may fall through
Issue found by gcc 8 build:... Toomas Soome
07:14 AM Bug #10193 (Closed): ddi_intr: cast between incompatible function types
Issue found by gcc 8 build:... Toomas Soome
07:01 AM Bug #10191 (Closed): strsubs: cast between incompatible function types
Issue found by gcc 8 build:... Toomas Soome
06:34 AM Bug #10190 (Closed): aphysio: cast between incompatible function types
Issue found by gcc 8 build:... Toomas Soome
06:24 AM Bug #10189 (Closed): fdbuffer: cast between incompatible function types
Issue found by gcc 8 build:... Toomas Soome
06:17 AM Bug #10188 (Closed): libast: cast between incompatible function types
Issue found by gcc 8 build:... Toomas Soome

2019-01-08

10:07 PM Bug #10187 (Closed): ses enumerator blows chunks on US60+8
Under certain circumstances, if the ses topo enumerator module is unable to correlate a SES ARRAY_DEVICE element with... Rob Johnston
08:48 AM Bug #10186 (Closed): uts: font functions should check if the char is from the input domain
We need to verify if the requested char exists in our font map, use '?' for missing chars.
This patch is preparing...
Toomas Soome

2019-01-07

03:10 PM Bug #10177 (Closed): etdump: additional cstyle cleanup and remove unused functions
"git commit 916bf6b9509e36cfde18ed64b9fa13c942d2d9bd":https://github.com/illumos/illumos-gate/commit/916bf6b9509e36cf... Electric Monk
03:04 PM Bug #10170 (Closed): ipadm: remove -Wno-unused-label and -Wno-uninitialized build options
"git commit 467e811cd2cb3b7e96cdf5621c4ed383e2b3efc8":https://github.com/illumos/illumos-gate/commit/467e811cd2cb3b7e... Electric Monk
01:45 PM Feature #10185 (Closed): loader: add sha1 hash calculation
Add sha1 digest support for loader:
1. build libcrypto with implementation
2. add -s option for lsmod to calculat...
Toomas Soome
01:26 PM Bug #10184 (Closed): loader: framebuffer command should report usage on bad command
The issue was reported after RTI of 10028, framebuffer command should print usage in case of bad arguments. Issue is ... Toomas Soome
10:17 AM Feature #7784 (Closed): uts: console input should support Unicode
"git commit adc2b73db62a4506a57dfd1ce89bcadc4a60a29d":https://github.com/illumos/illumos-gate/commit/adc2b73db62a4506... Electric Monk
10:17 AM Feature #7796 (Closed): uts: ldterm default to utf-8
"git commit f33b666290305a2b2c134d23cbd1e70e06bf36fd":https://github.com/illumos/illumos-gate/commit/f33b666290305a2b... Electric Monk
10:17 AM Feature #10040 (Closed): loader: gfx use GOP Blt() function in visual_io callbacks
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10039 (Closed): loader: build rules for new font setup
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10038 (Closed): loader: replace gop and vesa with framebuffer
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10037 (Closed): loader: add illumos.png logo
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10036 (Closed): ficl: add fb-putimage
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10035 (Closed): loader: add alpha blending for gfx_fb
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10034 (Closed): loader: use term-drawrect for menu frame
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10033 (Closed): ficl: add simple gfx words
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10032 (Closed): loader: implement tem utf-8 support
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10031 (Closed): loader: import tem for loader console
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #8918 (Closed): loader.efi: add vesa edid support
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10030 (Closed): import pnglite into usr/src/common/pnglite
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10029 (Closed): common/font: create shared font.c
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk
10:17 AM Feature #10028 (Closed): loader: implement framebuffer console
"git commit 9890ff8357a674572254e0be06b175a1e8eab4b0":https://github.com/illumos/illumos-gate/commit/9890ff8357a67457... Electric Monk

2019-01-06

11:43 PM Bug #10183 (Closed): etdump should be smatch clean
Actually, we'll just fold this into the generic usr/src/cmd makefile changes John Levon
11:39 PM Bug #10183 (Closed): etdump should be smatch clean
We need to check the return value of fseek() John Levon
10:13 AM Feature #10182 (Closed): dd: print scaled stats
the current stats:... Toomas Soome
03:57 AM Bug #9623: zfs.1m uses wrong snapshot names in Example 15
For review:
* https://www.illumos.org/rb/r/1343/
* http://cr.illumos.org/~webrev/benjamin.gentil/9623/
Benjamin Gentil

2019-01-05

11:23 PM Bug #10178: Enable compiler warnings when building C++ code
Fix: https://www.illumos.org/rb/r/1342/ Andrew Stormont
11:13 AM Bug #10178 (Closed): Enable compiler warnings when building C++ code
We pass -xne to turn warnings into errors but never actually turn on more than the default set of warnings, which are... Andrew Stormont
09:49 PM Bug #10153 (Closed): checkpaths shouldn't check packaging exceptions
"git commit 1f5207b7604fb44407eb4342aff613f7c4508508":https://github.com/illumos/illumos-gate/commit/1f5207b7604fb444... Electric Monk
09:49 PM Bug #10063 (Closed): basic support for smatch
"git commit 1f5207b7604fb44407eb4342aff613f7c4508508":https://github.com/illumos/illumos-gate/commit/1f5207b7604fb444... Electric Monk
12:11 PM Bug #10179 (New): Race condition in fifo_open
The following script, that tests named pipes (FIFOs), breaks consistently on all SunOS kernels, including illumos, wh... Martijn Dekker
08:14 AM Bug #10177 (Closed): etdump: additional cstyle cleanup and remove unused functions
Additional cstyle cleanup suggestions were suggested after RTI. Toomas Soome
07:14 AM Bug #10176 (New): i40e: driving X722 1GbE cause hangup
The system hangs up when executing the 'ifconfig i40e0 plumb ... ' command.
The specific phenomenon is that the 'I...
jing zhang
02:41 AM Bug #10064 (Closed): loader: zfs reader should not probe partitionless disks
"git commit 781f142d2ae880bb893875d2a114552171a5c3e5":https://github.com/illumos/illumos-gate/commit/781f142d2ae880bb... Electric Monk
02:41 AM Bug #10154 (Closed): zfs: cast between incompatible function types
"git commit c62757b2b8b6c26589d7704d0ff20beb107fcd9a":https://github.com/illumos/illumos-gate/commit/c62757b2b8b6c265... Electric Monk
02:41 AM Feature #9478 (Closed): etdump: Add the etdump utility for dumping El Torito boot catalog information.
"git commit c0455f334914631f42eb41177d677e2820ee6506":https://github.com/illumos/illumos-gate/commit/c0455f334914631f... Electric Monk

2019-01-04

10:39 PM Bug #10175 (Closed): Organize tcp(7P) into subsections
The tcp(7p) manual page is a bit disorganized, and would be easier to read through if the content were better present... Cody Mello
01:45 PM Bug #10162 (Closed): Sun/Solaris/Kstat: cast between incompatible function types
"git commit 9419bc2fc61b54b25a4e45211d31fcb920ff67cc":https://github.com/illumos/illumos-gate/commit/9419bc2fc61b54b2... Electric Monk
01:45 PM Bug #10159 (Closed): libc: cast between incompatible function types
"git commit adc04c2d55dd20cc6a0622f1147c0b084cdc3099":https://github.com/illumos/illumos-gate/commit/adc04c2d55dd20cc... Electric Monk
01:45 PM Bug #10158 (Closed): sgs/rtld: cast between incompatible function types
"git commit 5e90af26eb6ed2206c2a5f5131a1f3c377d6e8c4":https://github.com/illumos/illumos-gate/commit/5e90af26eb6ed220... Electric Monk
01:45 PM Bug #10157 (Closed): sgs/libld: cast between incompatible function types
"git commit c5749750a3e052f1194f65a303456224c51dea63":https://github.com/illumos/illumos-gate/commit/c5749750a3e052f1... Electric Monk
01:45 PM Bug #10155 (Closed): ip: cast between incompatible function types
"git commit 8a06b3d6467c15646e663c05086378f16288af85":https://github.com/illumos/illumos-gate/commit/8a06b3d6467c1564... Electric Monk
12:07 PM Feature #10173 (Closed): loader: support newer ZFS versions
This change did trigger my attention: https://svnweb.freebsd.org/changeset/base/342747... Toomas Soome

2019-01-03

07:10 AM Bug #10171 (Closed): biosdisk: use int13h ah=08 and ah=15 to count the floppy devices
FreeBSD issue: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234460
That specific BIOS does not provide drive ...
Toomas Soome

2019-01-02

06:06 PM Bug #10123 (Closed): smatch fix for mbr.c
mbr.c got deleted John Levon
09:43 AM Bug #10170 (Closed): ipadm: remove -Wno-unused-label and -Wno-uninitialized build options
Clean up ipadm. Toomas Soome

2019-01-01

01:07 AM Bug #10167: unable to check out illumos-gate on Windows
>The checkout failed, due to occurrences of file names that are "illegal" for Windows -- specifically usr/src/cmd/mai... Gergő Mihály Doma

2018-12-29

11:40 PM Bug #10161 (Closed): libstand: set spa in zfs_probe
"git commit cd8e64e261b359d5d54dad750f50660d3b874238":https://github.com/illumos/illumos-gate/commit/cd8e64e261b359d5... Electric Monk
11:40 PM Bug #10164 (Closed): crle: passing argument 2 to restrict-qualified parameter aliases with argument 1
"git commit 3ab8de02e091bc75fc50aafc5cbe32c053451d88":https://github.com/illumos/illumos-gate/commit/3ab8de02e091bc75... Electric Monk
12:24 PM Bug #10167: unable to check out illumos-gate on Windows
Igor Kozhukhov wrote:
> move sendmail + mail/mailx outside illumos-gate.
> because they are both are userland apps....
Toomas Soome

2018-12-28

10:01 PM Bug #10167: unable to check out illumos-gate on Windows
If we're going to accommodate clones on Windows, we should probably add to pbchk with the full list of forbidden file... Joshua M. Clulow
09:44 PM Bug #10167: unable to check out illumos-gate on Windows
move sendmail + mail/mailx outside illumos-gate.
because they are both are userland apps.
for example: on DilOS we ...
Igor Kozhukhov
09:32 PM Bug #10167 (Closed): unable to check out illumos-gate on Windows
I recently decided to try working on Windows for development, and I checked out a copy of the illumos-gate repo on Wi... Garrett D'Amore

2018-12-26

08:41 PM Feature #10166 (Closed): loader: support com.delphix:removing
There is no reason why we should not be able to boot from... Toomas Soome

2018-12-25

10:04 PM Bug #10165 (Closed): libzpool: passing argument 1 to restrict-qualified parameter aliases with argument 4
Issue found by gcc 8 build:... Toomas Soome
09:06 PM Bug #10164 (Closed): crle: passing argument 2 to restrict-qualified parameter aliases with argument 1
Issue found by gcc 8 build:... Toomas Soome
08:42 PM Bug #10163 (Closed): ufs_fsck: bitwise comparison always evaluates to false
Issue found by gcc 8 build:... Toomas Soome
10:28 AM Bug #10162 (Closed): Sun/Solaris/Kstat: cast between incompatible function types
Issue found by gcc 8 build:... Toomas Soome
09:33 AM Bug #10161 (Closed): libstand: set spa in zfs_probe
FreeBSD update https://svnweb.freebsd.org/base?view=revision&revision=337874
The warning is apparently clang speci...
Toomas Soome

2018-12-23

11:07 AM Bug #10159 (Closed): libc: cast between incompatible function types
Issue found by gcc 8 build:... Toomas Soome
10:38 AM Bug #10158 (Closed): sgs/rtld: cast between incompatible function types
Issue found by gcc 8 build:... Toomas Soome
10:20 AM Bug #10157 (Closed): sgs/libld: cast between incompatible function types
Issue found by gcc8 build:... Toomas Soome

2018-12-21

08:53 PM Bug #10155 (Closed): ip: cast between incompatible function types
issue found by gcc 8 build:... Toomas Soome
08:27 PM Bug #10154 (Closed): zfs: cast between incompatible function types
Issue found by gcc 8 build:... Toomas Soome
07:01 PM Feature #10049 (Closed): mboot: mboot is no longer needed
"git commit e74ff6533275aaaa8989786dfbba24b3281e3530":https://github.com/illumos/illumos-gate/commit/e74ff6533275aaaa... Electric Monk
07:01 PM Bug #10072 (Closed): ip: timeout takes void (*)(void *) as callback
"git commit e88f57b4cab0ed8f8a773d404d6781e20a4c26d7":https://github.com/illumos/illumos-gate/commit/e88f57b4cab0ed8f... Electric Monk
06:59 PM Bug #10072: ip: timeout takes void (*)(void *) as callback
Tested by checking disassemblies of affected mi_* functions. Only noted differences were in line numbers passed to a... Dan McDonald
06:14 PM Bug #9689 (Closed): zfs range lock code should not be zpl-specific
"git commit 7931524763ef94dc16989451dddd206563d03bb4":https://github.com/illumos/illumos-gate/commit/7931524763ef94dc... Electric Monk
12:39 PM Bug #10153 (Closed): checkpaths shouldn't check packaging exceptions
protocmp already complains if an exception is missing from the proto areas, so this check is pointless, and goes wron... John Levon
12:05 AM Bug #10071 (Closed): genunix: loadable_syscall: cast between incompatible function types
"git commit 1ec00b5abd071c76e2dc0cfa7905965b6b7a89a9":https://github.com/illumos/illumos-gate/commit/1ec00b5abd071c76... Electric Monk
12:05 AM Support #1228 (Closed): Add CCM and GCM mode support to AES in pkcs11_softtoken
"git commit fb2612809ed5f2cb9109db768e63d61f6659f71b":https://github.com/illumos/illumos-gate/commit/fb2612809ed5f2cb... Electric Monk

2018-12-20

01:05 PM Bug #10152 (New): bge debugging always on
... Arne Jansen
09:20 AM Bug #10151 (Closed): mv_xattrs() checks for a NULL array name
In libcmdutils. Array names can't be NULL John Levon
09:00 AM Bug #10150 (Closed): smbd needs smatch fixes
Disable a couple of smatch checks in usr/src/cmd/smbsrv/smbd John Levon

2018-12-19

11:15 PM Bug #10149 (Closed): make latencytop smatch clean
Disable function return checks for latencytop smatch checks. John Levon
11:10 PM Bug #10148 (Closed): hald should skip smatch checks
It has some issues, disable smatch for now. John Levon
11:08 PM Bug #10147 (Closed): pyzfs should disable function return checks
This code is not linted, skip this check for smatch John Levon
11:06 PM Bug #10146 (Closed): core_pcbe_event_coverage() is missing an else
Found by smatch indentation checks. John Levon
07:00 PM Bug #10145 (Closed): smbios_info_boot() gets NULL check wrong
We shouldn't dereference 'stp' before we check it. John Levon
06:59 PM Bug #10144 (Closed): BZ2_bzDecompressReset() gets NULL check wrong
We shouldn't dereference 'strm' before we check it. John Levon
06:44 PM Bug #10143 (Closed): smatch fix for ttymon
Fix the source enough to allow smatch to compile it. John Levon
06:43 PM Bug #10142 (Closed): smatch fix for who
Quieten smatch. John Levon
06:43 PM Bug #10141 (Closed): smatch fix for zoneadmd
Quieten smatch. John Levon
06:43 PM Bug #10140 (Closed): notify_params.c is walking past end of array
Fix up the get_fma_tag() and get_fma_class() routines. John Levon
06:42 PM Bug #10139 (Closed): smatch fixes for usr/src/cmd/stat
Quieten smatch. John Levon
06:41 PM Bug #10138 (Closed): smatch fixes for usr/src/cmd/sgs
Fix a few smatch lint reports. John Levon
06:41 PM Bug #10137 (Closed): smatch fixes for setuname
A couple of small fixes are needed. John Levon
06:40 PM Bug #10136 (Closed): smatch fix for policykit
Keep smatch quiet. John Levon
06:40 PM Bug #10135 (Closed): picl plugins need smatch fixes
A couple of small fixes needed, found by smatch. John Levon
06:39 PM Bug #10134 (Closed): mv needs smatch fixes
Fix indenting, and a NULL check for an array name John Levon
06:38 PM Bug #10133 (Closed): smatch fixes for usr/src/cmd/fs.d
smatch identified a couple of small fixes needed in usr/src/cmd/fs.d John Levon
06:37 PM Bug #10132 (Closed): smatch fixes for MDB
smatch identified various issues with code in usr/src/cmd/mdb John Levon
06:32 PM Bug #10131 (Closed): fmtmsg is bitwise, not streetwise
Quieten smatch. John Levon
06:31 PM Bug #10130 (Closed): smatch fixes for usr/src/cmd/fm
smatch identified a couple of use after frees, and one other lint. John Levon
06:30 PM Bug #10129 (Closed): smatch fix for dtrace tests
Quieten smatch. John Levon
06:29 PM Bug #10128 (Closed): csplit should use strlcpy
smatch identified that getfile() should be using strlcpy. John Levon
06:26 PM Bug #10127 (Closed): coreadm is mis-using strcpy()
Replace the potential overflows with use of strlcpy() John Levon
06:19 PM Bug #10126 (Closed): smatch fix for kmfcfg
smatch is being a bit picky here, but let's assuage it. John Levon
06:18 PM Bug #10125 (Closed): smatch fixes for cmd-inet
Fix a few minor issues smatch found in usr/src/cmd/cmd-inet John Levon
06:16 PM Bug #10124 (Closed): smatch fixes for cryptoadm
smatch found a double free, a leak, and a bad NULL check in cryptoadm John Levon
06:15 PM Bug #10123 (Closed): smatch fix for mbr.c
Ignore close() return value. John Levon
06:13 PM Bug #10122 (Closed): beadm buffer over-run
init_hdr_cols() shouldn't write past the end of the col[] array. John Levon
06:12 PM Bug #10121 (Closed): smatch fix for auditstat
The current sparse version can't handle implicit ints. John Levon
06:09 PM Bug #10120 (Closed): smatch indenting fixes for usr/src/cmd
Enough indenting fix ups to keep smatch happy in usr/src/cmd John Levon
05:47 PM Bug #10119 (Closed): audit(1) gets NULL check wrong
is_audit_config_ok() should be checking for NULL prior to checking string[0] John Levon
05:41 PM Bug #10118 (Closed): libeti() NULL check after deref
set_max_field() uses 'f' and then checks it against NULL John Levon
05:37 PM Bug #10117 (Closed): libbe needs smatch fixes
be_get_boot_args() is not checking for asprintf() failure correctly, and be_create_menu() has a use after free. John Levon
05:34 PM Bug #10116 (Closed): mech_dh needs smatch fixes
Add a couple of casts. John Levon
05:33 PM Bug #10115 (Closed): ses topo module needs smatch fixes
We just need to cast to void some signal functions. John Levon
05:31 PM Bug #10114 (Closed): fmev_proxy_cb() doesn't need inval checks
We dereference before the NULL check, but neither check is required. John Levon
05:28 PM Bug #10113 (Closed): fmd_adm_xprt_f should return void
Nobody cares about the return value, and it's always zero. John Levon
05:20 PM Bug #10112 (Closed): cfga_sata.c needs a smatch fix
John Levon
11:52 AM Bug #10111 (Closed): dat_dictionary_create() use after free
John Levon
11:51 AM Bug #10110 (Closed): get_tz_countries shouldn't check array for NULL
Array names can't be NULL. John Levon
11:51 AM Bug #10109 (Closed): libzonecfg needs a smatch fix
Cast a function call to void. John Levon
11:50 AM Bug #10108 (Closed): libstmfproxy needs smatch fixes
Need to cast some functions to void. John Levon
11:50 AM Bug #10107 (Closed): librpcsvc needs smatch fixes
John Levon
11:50 AM Bug #10106 (Closed): libreparse needs smatch fixes
Cast a function to void. John Levon
11:49 AM Bug #10105 (Closed): libproject needs smatch fixes
Cast pool_conf_close() to void. John Levon
11:49 AM Bug #10104 (Closed): pam_set_data() dereferences pointer before checking for NULL
John Levon
11:49 AM Bug #10103 (Closed): libmlrpc needs smatch fixes
Cast a function to void. John Levon
11:49 AM Bug #10102 (Closed): libnvfru needs smatch fixes
Cast a function to void. John Levon
11:48 AM Bug #10101 (Closed): audio tools need smatch fixes
Some minor fixes in audiorecord/audioplay. John Levon
11:48 AM Bug #10100 (Closed): Illumos is confused about calloc() arguments
smatch complains about reversed calloc() arguments; fix them up. John Levon
11:47 AM Bug #10099 (Closed): libfakekernel vpanic() should cast away assfail()
We're picking up the kernel's assfail() prototype, so just cast it. John Levon
11:47 AM Bug #10098 (Closed): task_alloc() in libfakekernel gets KM_NOSLEEP test wrong
KM_SLEEP is zero, so this test was meaningless. John Levon
11:46 AM Bug #10097 (Closed): indenting fixes in usr/src/{lib,common}
Fix indenting issues that smatch complained about. John Levon
11:45 AM Bug #10096 (Closed): kstat update routines shouldn't check for NULL kstat
It can't be NULL, and we dereference it before anyway. John Levon
11:45 AM Bug #10095 (Closed): unchecked return value in segvn_pagelock()
Cast it to void. John Levon
11:44 AM Bug #10094 (Closed): i_mdi_client_free() doesn't need to check for a NULL cdip
It can't be NULL at this point. John Levon
11:44 AM Bug #10093 (Closed): kmem_log_enter() dereferences pointer before NULL check
John Levon
11:44 AM Bug #10092 (Closed): sysevent_evc_control() dereferences pointer before checking for NULL
John Levon
11:43 AM Bug #10091 (Closed): smatch fixes for ahci.c
smatch identified a couple of minor issues in ahci.c John Levon
11:40 AM Bug #10090 (Closed): rt2860_free_rx_ring doesn't need to check for NULL array
Array names can't be NULL. John Levon
11:40 AM Bug #10089 (Closed): phy_check() is bitwise, should be streetwise
mii.c was using a bitwise operation when it should be logical. By change, it happened to work the same. John Levon
11:39 AM Bug #10088 (Closed): ldterm_do_ioctl() shouldn't check for a NULL array
Array names can't be NULL. John Levon
11:39 AM Bug #10087 (Closed): atge_attach() doesn't need to check for kmem_zalloc() success
smatch noticed that it's silly to check for a NULL from a KM_SLEEP allocation. John Levon
11:38 AM Bug #10086 (Closed): ixgbe_m_propinfo() is missing an 'else'
smatch noticed the indentation seemed wrong, and identified this (harmless) issue. John Levon
11:37 AM Bug #10085 (Closed): sctp_getpeeraddrs() doesn't need to check for a NULL primary
The primary has already been dereferenced, so we shouldn't need to check. John Levon
11:35 AM Bug #10084 (Closed): fop_open() doesn't need to check for a NULL vnode
The pointer has already been dereferenced, so it cannot be NULL. John Levon
11:29 AM Bug #10083 (Closed): smatch fixes for common/fs/vfs.c
Fix a couple of minor smatch-identified issues. John Levon
11:29 AM Bug #10082 (Closed): intel_nhm is checking for NULL arrays
smatch warns for comparisons of an array name with NULL John Levon
11:28 AM Bug #10081 (Closed): smatch indenting fixes for usr/src/uts
smatch warns about strange indenting; this is all the easy fixes for usr/src/uts John Levon
11:27 AM Bug #10080 (Closed): smatch Makefile changes for usr/src/cmd
Makefile portion of the smatch noise reduction for usr/src/cmd John Levon
11:27 AM Bug #10079 (Closed): smatch Makefile changes for usr/src/lib
Makefile portion of the smatch noise reduction for usr/src/lib John Levon
11:26 AM Bug #10078 (Closed): smatch fixes for UCB
We don't care too much about UCB, so turn smatch off pretty much all over here John Levon
11:25 AM Bug #10077 (Closed): usr/src/uts/ Makefile changes for smatch
Mostly, we turn off smatch warnings, which should be evaluated later. John Levon
11:24 AM Bug #10076 (Closed): make usr/src/test smatch clean
John Levon
11:15 AM Bug #10075 (Closed): make usr/src/tools smatch clean
A few small changes are needed for smatch to be happy with usr/src/tools John Levon
 

Also available in: Atom