Project

General

Profile

Activity

From 2020-08-16 to 2020-09-14

2020-09-14

10:32 PM Bug #13139 (Closed): bhyve bungles math for VMX ins/outs size
"git commit d92a2ce76311170b6aa244c3a22f3a3754dad613":https://github.com/illumos/illumos-gate/commit/d92a2ce76311170b... Electric Monk
09:57 PM Bug #13139: bhyve bungles math for VMX ins/outs size
There was some suspicion about an ubuntu guest tripping over this as well. I installed an ubuntu server 20.04 guest,... Patrick Mooney
08:52 PM Bug #13139: bhyve bungles math for VMX ins/outs size
I did a few things to test this. Firstly, I copied the @addrsize@ derivation logic out of the VMX code and into an i... Patrick Mooney
09:58 PM Bug #13137 (Closed): zfs: warn: inconsistent indenting
"git commit 9cfcc091666d5546e419c22f4963474d11673f5e":https://github.com/illumos/illumos-gate/commit/9cfcc091666d5546... Electric Monk
09:31 PM Bug #13164 (In Progress): loader: build with -_gcc=-Wextra -_gcc=-Werror
Once clean, enable build with -Wall -Wextra -Werror Toomas Soome
09:29 PM Bug #13163 (In Progress): loader: efi comparison between signed and unsigned integer expressions
Third part of the cleanup - the efi loader tree. Toomas Soome
09:28 PM Bug #13162 (In Progress): loader: i386 comparison between signed and unsigned integer expressions
Second part of the cleanup, the BIOS loader tree in i386. Toomas Soome
09:26 PM Bug #13161 (In Progress): loader: libstand comparison between signed and unsigned integer expressions
Clean up build warnings, phase 1 is to clean up the libstand.
 Toomas Soome
09:18 PM Feature #13160 (Closed): loader: Remove NAND and NANDFS support
Support for nand/nandfs was removed from FreeBSD:
https://svnweb.freebsd.org/base?view=revision&revision=349352
... Toomas Soome
09:15 PM Bug #13159 (Closed): loader: remove common/ufsread.c
The common/ufsread.c was originally used by stage2 (boot2) and is unused since stage2 is built against libstand.
T... Toomas Soome
08:09 PM Bug #13158 (New): mv treats target_dir/ as file if it doesn't exist
Quoting POSIX:... xto uqh
07:11 PM Bug #13157 (New): maxbw can kill link with hires tick
The new default hires tick (#11499) can cause certain maxbw values to freeze a link's Rx SRS.
The maxbw setting is... Ryan Zezeski
06:13 PM Feature #13121 (Closed): mdb smbios dmod could work for libsmbios
"git commit 8ad93a826ff9af944e63c7d84b30cba79dc36d54":https://github.com/illumos/illumos-gate/commit/8ad93a826ff9af94... Electric Monk
06:13 PM Feature #13119 (Closed): Want support for SMBIOS 3.4
"git commit c6795799963479a5ddb9b97ebb4cf6c1c97c1fba":https://github.com/illumos/illumos-gate/commit/c6795799963479a5... Electric Monk
06:13 PM Bug #13156 (New): support APIC shorthand for self-IPI
Per the architectural definition of the APIC, several shorthand notations are support for specifying IPI destination:... Patrick Mooney
05:51 PM Bug #13155 (Closed): loader: cstyle cleanup of pager.c
No functional changes at all.
Testing done:
tsoome@beastie:/code/illumos-gate/usr/src/boot$ git diff -w master
... Toomas Soome
04:35 PM Feature #13081 (Closed): add mlxcx temp sensor
"git commit 1718c31669d146508ea805e88322f5b74d892762":https://github.com/illumos/illumos-gate/commit/1718c31669d14650... Electric Monk
04:35 PM Feature #13079 (Closed): Add ksensor support for voltage and current sensors
"git commit 1045e13a248d94941f864998aa859970ae3a4154":https://github.com/illumos/illumos-gate/commit/1045e13a248d9494... Electric Monk
04:06 PM Bug #4737: dlmgtd process deadlocks.
I fixed various dls/mac deadlocks in illumos-joyent. Some of those bugs may very well exist in gate too (it's hard to... Ryan Zezeski
04:01 PM Bug #6258 (Closed): eventfd problem with NULL pointer constant and ints
Toomas Soome
03:46 PM Bug #6317 (Closed): NULL pointer constant is not an int nor unsigned int in libzfs
Toomas Soome
03:38 PM Bug #5218 (Closed): posix definition of NULL
This work was ultimately finished up by a collection of a number of different people. Toomas in particular took the c... Robert Mustacchi
03:32 PM Bug #6261 (Closed): Fix for 6198 overlooked NULL abuse in svr4pkg/libinst/mntinfo.c
Toomas Soome
03:28 PM Feature #12967 (Closed): default to apix over pcplusmp
"git commit eee178623516e461188f137dc6e5e38875967e09":https://github.com/illumos/illumos-gate/commit/eee178623516e461... Electric Monk
03:23 PM Bug #6627 (Closed): NULL pointer constant issues in cmd/sgs
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:22 PM Bug #10266 (Closed): NULL pointer constant issues in sgs/librtld_db
Toomas Soome
03:18 PM Bug #6617 (Resolved): NULL pointer constant issues in ucbcmd
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:18 PM Bug #6625 (Closed): cleanup warnings in usr/src/ucbcmd/chown
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:17 PM Bug #6636 (Closed): NULL pointer constant issues in cmd/{truss,tic,stat,refer,print,oamuser,krb5,isns}
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:16 PM Bug #6635 (Resolved): NULL pointer constant issues in cmd/{svc,picl,bnu,syseventd,rcm_daemon,hal,avs]
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:16 PM Bug #6634 (Closed): NULL pointer constant issues in cmd/{abi,ypcmd,nscd,mailx,fm,cmd-crypto}
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:16 PM Bug #6633 (Closed): diverse NULL pointer constant issues in cmd/
Robert Mustacchi
03:16 PM Bug #6633: diverse NULL pointer constant issues in cmd/
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:16 PM Bug #6632 (Closed): NULL pointer constant issues in cmd/lp
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:15 PM Bug #6631 (Closed): NULL pointer constant issues in cmd/svr4pkg
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:15 PM Bug #6629 (Closed): NULL pointer constant issues under cmd/cmd-inet
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:15 PM Bug #6628 (Closed): NULL pointer constant issues in cmd/fs.d
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:13 PM Bug #6626 (Closed): NULL pointer constant issues in cmd/mdb
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:13 PM Bug #6622 (Closed): diverse NULL pointer constant issues in lib/
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:13 PM Bug #6620 (Closed): NULL pointer constant issues in lib/libc
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:13 PM Bug #6619 (Closed): NULL pointer constant issues in lib/cfgadm_plugins
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:12 PM Bug #6618 (Closed): NULL pointer constant issues in test/
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:12 PM Bug #6616 (Closed): NULL pointer constant issues in common
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:11 PM Bug #6615 (Closed): diverse NULL pointer constant issues in uts/common/
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:11 PM Bug #6614 (Closed): NULL pointer constant issues in uts/common/io
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:11 PM Bug #6613 (Closed): NULL pointer constant issues in uts/common/os
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:11 PM Feature #13111: Want futimes(), lutimes() and timespec/timeval conversion macros
In addition to running the new tests, I also ran the libc symbol visibility tests to confirm that the new functions a... Andy Fiddaman
03:10 PM Bug #6612 (Closed): NULL pointer constant issues in uts/common/fs
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:10 PM Bug #6611 (Closed): NULL pointer constant issues in uts/i86pc
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:10 PM Bug #6609 (Closed): NULL pointer constant issues in uts/intel
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
03:09 PM Bug #6361 (Closed): NULL pointer constant issues with timerfd
All the outstanding NULL pointer vs int issues have been cleaned up for x86 and SPARC as of #12661. Robert Mustacchi
02:59 PM Bug #8633 (Duplicate): epoll should better detect fd reassignment
Patrick Mooney
02:56 PM Bug #13154 (In Progress): SMB should use single shot scatter/gather encryption/decryption
At present the SMB protocol uses partial encryption operations when encrypting or decrypting. This should be convert... Garrett D'Amore
02:34 PM Bug #13108: mlxcx fails to attach on system using pcplusmp after 12988
The affected user tested an updated driver with both the @pcplusmp@ and @apix@ modules and it worked fine.
Interru... Andy Fiddaman
02:02 PM Bug #4322 (Closed): ZFS deadlock on dp_config_rwlock
Patrick Mooney
02:01 PM Bug #3320: ZFS: kernel panic running "zfs diff" on oi_151a7
Could perhaps be related to #9329 Patrick Mooney
07:03 AM Bug #13138: Very bad SMB small file/request performance on i40e, made faster by iftop
I made some experiments with and without iftop during phases, where iftop leads to significant improvements.
 Florian Manschwetus
12:56 AM Feature #13143 (Closed): libc test suite should pass cleanly with unprivileged user
"git commit 8837b1d0891b79dc11ae1199ea4a100f3f17c7b1":https://github.com/illumos/illumos-gate/commit/8837b1d0891b79dc... Electric Monk

2020-09-13

11:15 PM Feature #13082: pageout needs a deadman
h2. Testing Notes (Supplemental)
Demonstrating that the disabled value has an effect. First, with the new default... Joshua M. Clulow
10:42 PM Feature #13082: pageout needs a deadman
h2. Testing Notes
I have a 1GB OpenIndiana VM. Things work about as expected unless there is severe memory pressu... Joshua M. Clulow
10:17 PM Feature #13121 (In Progress): mdb smbios dmod could work for libsmbios
I tested this by stopping the smbios test suite at various points, dumping the smbios data using the dcmd to a file, ... Robert Mustacchi
10:16 PM Feature #13119 (In Progress): Want support for SMBIOS 3.4
I tested this in a few ways:
* By comparing the @smbios -x@ output on my system from before and after and finding ... Robert Mustacchi
08:30 PM Feature #13153 (Closed): loader: before falling back to default, also use EDID standard timings
As we got EDID information, it may be the gfx adapter does not support the EDID suggested preferred resolution. The c... Toomas Soome
08:24 PM Feature #13152 (Closed): loader: add flat panel info query
If we get no EDID, try also VESA flatpanel extension.
I did add the flatpanel query for sake of completeness, I do... Toomas Soome
05:05 PM Bug #13151 (Closed): loader: isoboot.c: info: ignoring unreachable code.
As gptzfsboot and isoboot are both staget2 code, use the same approach in exit() -- call __exit syscall.
Testing d... Toomas Soome
12:22 AM Bug #13150 (Closed): head -v doesn't work with a single file
While working on #6782 I wrote a test suite for @head@. As a part of this I found that the original work done for add... Robert Mustacchi

2020-09-12

11:56 PM Bug #13039 (Closed): HPET on AWS EC2 may be Hazard-Prone Error Trigger
"git commit 92f7b1e23c49ac9522feadd9b58cb103a05a509b":https://github.com/illumos/illumos-gate/commit/92f7b1e23c49ac95... Electric Monk
04:26 PM Bug #13039: HPET on AWS EC2 may be Hazard-Prone Error Trigger
h2. Testing Notes
I built the changes, and then installed them to a disk image that can be booted in Amazon EC2. ... Joshua M. Clulow
11:56 PM Bug #13043 (Closed): HPET config register does not change size
"git commit 9c562f14f5af5a3d068e998a2ab674ce019cc395":https://github.com/illumos/illumos-gate/commit/9c562f14f5af5a3d... Electric Monk
04:28 PM Bug #13043: HPET config register does not change size
h2. Testing Notes
I rebooted a physical machine onto these bits and confirmed that the HPET programming informatio... Joshua M. Clulow
11:56 PM Feature #13042 (Closed): make prom_debug more useful outside startup.c
"git commit fdcca78f421670bb8f04d68bc3f2762a4b5342be":https://github.com/illumos/illumos-gate/commit/fdcca78f421670bb... Electric Monk
12:59 AM Feature #13042: make prom_debug more useful outside startup.c
h2. Testing Notes
Built the change and installed in an OpenIndiana instance where I can get on the serial console.... Joshua M. Clulow
10:44 PM Bug #13148 (In Progress): do not sq_wait unnecessarily
Patrick Mooney
10:34 PM Bug #13148 (Closed): do not sq_wait unnecessarily
Upstreaming "OS-6150":https://smartos.org/bugview/OS-6150 from SmartOS:
A member of the community reported extreme... Patrick Mooney
10:38 PM Bug #13149 (Closed): elide squeue wake-ups when prudent
Upstreaming "OS-6344":https://smartos.org/bugview/OS-6344 from SmartOS:
As part of the testing for OS-6150, I look... Patrick Mooney
10:07 PM Bug #6782: head can't handle embedded nul characters
Taking a look at this, the problem is the way that head was written and somehow predates the work done in #3682. The ... Robert Mustacchi
10:00 PM Bug #13147 (New): bhyve kernel could make more use of BITX()
As jclulow pointed out in a bhyve-related code review, BITX() is a convenient macro for extracting runs of bits from ... Patrick Mooney
08:52 PM Bug #13059: Dell R630 - X2APIC enabled cause boot hang
Apologies for not seeing this earlier. Something that might be useful here is to boot with kmdb enabled and entering ... Robert Mustacchi
08:46 PM Feature #13146 (Closed): Want a driver for AMD SMN user access
The AMD system management network (SMN) is used for certain parts of the SoC to provide services. Being able to drive... Robert Mustacchi
08:44 PM Feature #13145 (Closed): rewrite amdf17nbdf to use the ksensor framework
As part of the refactoring we're doing in #13144, we're separating @amdf17nbdf@ into a nexus driver and a separate te... Robert Mustacchi
08:41 PM Feature #13144 (Closed): refactor amdf17nbdf into a nexus
The @amdf17nbdf@ driver originally was written with dual purposes. The first was to provide a temperature sensor for ... Robert Mustacchi
06:27 PM Feature #13143: libc test suite should pass cleanly with unprivileged user
To test this I ran the libc test suite as an unprivileged user and with pfexec. Tests that used to fail as an unprivi... Robert Mustacchi
06:06 PM Feature #13143 (Closed): libc test suite should pass cleanly with unprivileged user
Due to various tests (all ironically written by me), the libc test suite cannot run as an unprivileged user and clean... Robert Mustacchi
05:49 PM Feature #12967: default to apix over pcplusmp
To test this I've worked with the broader community and done a few different classes of testing. The first set is on ... Robert Mustacchi
05:24 PM Feature #13081: add mlxcx temp sensor
To test this, Alex Wilson kindly ran this change against some of his systems with mlxcx(7D). With this we saw:
<pr... Robert Mustacchi
05:03 PM Bug #3763: Implement qsort_r(3C)
To test this I did a few things:
* I imported the OpenBDS quicksort tests and ran the libc test suite, run below.
... Robert Mustacchi
02:39 PM Bug #13142 (New): comment for BITX() is misleading
I was reaching for the @BITX()@ macro to simplify some bit manipulation, and went to read its describing comment to u... Patrick Mooney
11:58 AM Bug #13140: Typos in the manual
While fixing, also spotted:
rsh.1 rcp.1 rlogin.1 rdist.1 - prevalant, originater
rsh.1 refers to on(1) in SEE ALSO
 Peter Tribble
11:26 AM Bug #13140 (Closed): Typos in the manual
Some more man page typos:
libpicltree.3picltree extra "the" in
located in the one of the following plug-in dire... Peter Tribble
11:29 AM Bug #13141 (Closed): Man page formatting runs words together
I've spotted a number of cases where words (one formatted) run together:
td_thr_setsigpending.3c_db - 'withtd_thr_... Peter Tribble
09:37 AM Feature #13083: Enable gate builds with OpenJDK 11
In Java 11, javah is no more. It is claimed that 'javac -h' is the replacement, but this isn't quite true, as it does... Peter Tribble
04:25 AM Bug #13139 (Closed): bhyve bungles math for VMX ins/outs size
A user on the smartos-discuss mailing list reported a blown assertion:... Patrick Mooney

2020-09-11

11:06 PM Bug #13138: Very bad SMB small file/request performance on i40e, made faster by iftop
From earlier discussion in IRC it sounds like the OI file server with NVMe/i40e is not particularly busy on any CPU w... Joshua M. Clulow
10:51 PM Bug #13138: Very bad SMB small file/request performance on i40e, made faster by iftop
* Yes that is right.
* Currently Openindiana (text/server), maybe switch to omniOS
* Default windows file Copy, I m... Florian Manschwetus
10:34 PM Bug #13138: Very bad SMB small file/request performance on i40e, made faster by iftop
To be clear, you are:
* building software on Windows 10 into a ramdisk on that machine, which produces about 20k f... Joshua M. Clulow
10:03 PM Bug #13138 (New): Very bad SMB small file/request performance on i40e, made faster by iftop
Copy of a build tree (lot of small and mid size files and only some very large, 20k files, close to 6GB in sum) takes... Florian Manschwetus
10:19 PM Bug #12510 (Closed): prtvtoc columns are not wide enough for modern disks
"git commit 51706d6c808d070acc209c5894e98814aa259ba6":https://github.com/illumos/illumos-gate/commit/51706d6c808d070a... Electric Monk
07:35 PM Bug #12510: prtvtoc columns are not wide enough for modern disks
h2. Testing Notes
h3. 6TB Hard Drive
h4. Old Output... Joshua M. Clulow
09:42 PM Bug #13129 (Closed): libc: gettimeofday() error: unchecked function return
"git commit 93dc830ecbbcd243760848e27a0f901125432b04":https://github.com/illumos/illumos-gate/commit/93dc830ecbbcd243... Electric Monk
09:35 PM Bug #13137 (Closed): zfs: warn: inconsistent indenting
smatch errors:... Toomas Soome
09:15 PM Bug #13117 (Closed): zfs: variable dereferenced before check
"git commit 92db730eedd4fcf11958d5b89b6d63f99488d594":https://github.com/illumos/illumos-gate/commit/92db730eedd4fcf1... Electric Monk
09:02 PM Bug #13136 (Closed): libc: memset_s() error: unchecked function return
smatch error:... Toomas Soome
08:54 PM Bug #11499 (Closed): default to hires tick
"git commit d96925c4917df4be0de8533ddaa487c9d915b8c5":https://github.com/illumos/illumos-gate/commit/d96925c4917df4be... Electric Monk
05:13 PM Bug #13135 (In Progress): libc: str2spwd() warn: variable dereferenced before check 'instr'
smatch warning:... Toomas Soome
04:15 AM Bug #13134 (New): ip_squeue_fanout should be on by default
Currently, when a "random" IP squeue is selected, we default to using the squeue for the current CPU:... Joshua M. Clulow
03:50 AM Bug #13133 (Duplicate): SVM event injection can race in bhyve
Very similar to what is described in #13132, the event injection logic for bhyve on AMD's SVM suffers from a race whe... Patrick Mooney
03:42 AM Bug #13132 (Closed): VMX event injection can race in bhyve
As part of porting bhyve to illumos, all of its mutex usage was switched to using adaptive mutexes rather than spinlo... Patrick Mooney

2020-09-10

11:36 PM Bug #13067: Regression between Hipster-November2019 install media and 2020-07: 'ls /devices' hangs
I can't generate an NMI, but I do have a PS/2 keyboard. The instructions here:
https://illumos.org/docs/user-gui... carton .
09:24 PM Bug #13131 (Closed): libc: _fgetwc_unlocked_l() warn: was '== &fp->_state' instead of '='
smatch error:... Toomas Soome
09:03 PM Bug #13130 (In Progress): libc: load_zoneinfo() warn: was '== 268961665713336320' instead of '='
smatch warning:... Toomas Soome
08:48 PM Bug #13129 (Closed): libc: gettimeofday() error: unchecked function return
smatch errors:... Toomas Soome
08:17 PM Bug #13128 (In Progress): libc: smatch warn: impossible condition
smatch warnings:... Toomas Soome
06:42 PM Bug #13127 (Closed): libc: for statement not indented
smatch error:... Toomas Soome
06:31 PM Bug #13126 (Closed): libc: variable dereferenced before check 'found'
smatch error:... Toomas Soome
06:07 PM Bug #13125 (Closed): libc: unchecked function return 'nvfree'
smatch error:... Toomas Soome
05:38 PM Bug #13098: Low output level from audio devices
The AMD computer has two audio devices and two mixers. In my audio level tests, pulseaudio was using the correct aud... Gary Mills
05:37 PM Bug #13124 (In Progress): libc: testing array offset after use
Build errors on SPARC:... Toomas Soome
05:37 PM Bug #13110 (Closed): clean up compiler gags in bhyve kernel
"git commit db8733f5bbf6e1c41c482d70b2fe49470d1958de":https://github.com/illumos/illumos-gate/commit/db8733f5bbf6e1c4... Electric Monk
04:21 PM Bug #13110: clean up compiler gags in bhyve kernel
While this change looks like a great candidate for @wsdiff(1)@ testing, some combination of the modifications resulte... Patrick Mooney
05:07 PM Bug #13123 (In Progress): libc: variable 't' set but not used
Build error on SPARC:... Toomas Soome
03:36 PM Feature #13121 (Closed): mdb smbios dmod could work for libsmbios
"git commit fcfe1af15109d9332f8d8f6330b4eea92effb41d":https://github.com/illumos/illumos-gate/commit/fcfe1af15109d933... Electric Monk
02:47 PM Feature #13121 (Closed): mdb smbios dmod could work for libsmbios
While working on #13119 I wanted to use the smbios dmod that I wrote in #12946. The simplest way to do this is to add... Robert Mustacchi
03:36 PM Feature #13119 (Closed): Want support for SMBIOS 3.4
"git commit df8c2508aa717e719c0726c616d47f2c94a58dab":https://github.com/illumos/illumos-gate/commit/df8c2508aa717e71... Electric Monk
06:42 AM Feature #13119 (Closed): Want support for SMBIOS 3.4
SMBIOS 3.4 adds a number of definition updates and then also extends the type 17 slot data structure. We should add s... Robert Mustacchi
07:51 AM Feature #7059: disable kmem/physmem access from a zone
When Jerry put this up four years ago, there was some relatively nebulous feedback that these devices _should_ be acc... Joshua M. Clulow
07:12 AM Bug #13120: harden random pool for zones
Note that this has been in SmartOS since 2016 with no apparent ill effect, as "OS-5576":https://smartos.org/bugview/O... Joshua M. Clulow
07:11 AM Bug #13120 (Rejected): harden random pool for zones
Writing to @/dev/random@ or @/dev/urandom@ adds data to the entropy pool used to generate subsequent random numbers. ... Joshua M. Clulow
06:47 AM Bug #13118: Very slow reaping, possible deadlock in zfs_delmap
This behaviour appears to have been introduced in:... Joshua M. Clulow
06:22 AM Bug #13118 (Closed): Very slow reaping, possible deadlock in zfs_delmap
See original Joyent bug: https://smartos.org/bugview/OS-732
The missing ... Alex Wilson

2020-09-09

07:53 PM Bug #13077 (Closed): bhyve kernel should be -Wformat clean
"git commit 9dc804b9db4598936de071708cbc40525f06eb5d":https://github.com/illumos/illumos-gate/commit/9dc804b9db459893... Electric Monk
01:36 AM Bug #13077: bhyve kernel should be -Wformat clean
Given the nature of the change, testing was performed with @wsdiff(1)@. It confirmed that the only changes to the bh... Patrick Mooney
07:15 PM Bug #13115 (Closed): libc: variable 'readers' set but not used
"git commit 5d2ed7273d684a5ddeb0970c96ef9cf3ddd4e044":https://github.com/illumos/illumos-gate/commit/5d2ed7273d684a5d... Electric Monk
05:45 AM Bug #13109: usb disk dies on high IO and loader hangs on reset
... Olaf Bohlen
05:29 AM Bug #13117 (Closed): zfs: variable dereferenced before check
smatch error:... Toomas Soome
05:14 AM Bug #13105 (Closed): dnode_special_open() error: unchecked function return 'zrl_tryenter'
"git commit d061fa1f216e55ded9f2c41eb77f6aa67479a1c5":https://github.com/illumos/illumos-gate/commit/d061fa1f216e55de... Electric Monk

2020-09-08

08:49 PM Bug #13030: remove 'retu' pattern from bhyve
This was tested by booting up the usual gang of test guests:
- Windows
- Linux
- FreeBSD
- OpenBSD
- illumos
... Patrick Mooney
03:49 PM Bug #13109: usb disk dies on high IO and loader hangs on reset
... Olaf Bohlen
06:11 AM Feature #12484 (Closed): efcode: smatch errors
Toomas Soome
06:10 AM Feature #12484: efcode: smatch errors
Duplicate of 12885. Toomas Soome
05:55 AM Bug #13015 (Closed): fruaccess: comparison between pointer and zero character constant
"git commit 93d26c05275be2c44aedd16705237484fc0a0990":https://github.com/illumos/illumos-gate/commit/93d26c05275be2c4... Electric Monk
05:53 AM Bug #13011 (Closed): tsalarm: '*' in boolean context, suggest '&&' instead
"git commit ba12489a763ade223e478c59fdc4cb752fcba568":https://github.com/illumos/illumos-gate/commit/ba12489a763ade22... Electric Monk
05:50 AM Bug #12885 (Closed): efcode: smatch and build errors
"git commit 09e6639baaf32231365cb9895bf1e0ea006a2a60":https://github.com/illumos/illumos-gate/commit/09e6639baaf32231... Electric Monk
05:47 AM Bug #13104 (Closed): zfs: offset_t is signed and can not be > MAXOFFSET_T
"git commit e4af2f17fac5babc25d094f1bf22dd06515f66c7":https://github.com/illumos/illumos-gate/commit/e4af2f17fac5babc... Electric Monk
05:42 AM Bug #12974 (Closed): libc: left shift of negative value
"git commit 7aaede4825001926ae223b8c47ef9e4d0d6021ba":https://github.com/illumos/illumos-gate/commit/7aaede4825001926... Electric Monk
04:45 AM Bug #13103 (Closed): zfs: zvol_strategy() warn: unsigned 'off' is never less than zero
"git commit 712669c9fa9278704a4ccefe1d96acaf29397d36":https://github.com/illumos/illumos-gate/commit/712669c9fa927870... Electric Monk

2020-09-07

06:26 PM Bug #13115 (Closed): libc: variable 'readers' set but not used
Build error on SPARC:... Toomas Soome
04:26 PM Bug #13070: mtu option too large MTU 1728 - 1500
Dan McDonald wrote:
> In native zones, each of these tunables has the supported interface of ipadm(1M). ipadm(1M) m... gh origin
03:56 PM Bug #13077 (In Progress): bhyve kernel should be -Wformat clean
Patrick Mooney
03:55 PM Bug #12749 (Closed): gcc10 complains about vmcb_state struct packing
Fixed via #12939 Patrick Mooney
03:54 PM Bug #12960 (Closed): bhyve needs better SIPI notification
Patrick Mooney
01:00 PM Feature #13111 (Closed): Want futimes(), lutimes() and timespec/timeval conversion macros

The @futimes()@, @lutimes()@ functions and the @TIMESPEC_TO_TIMEVAL()@ and @TIMEVAL_TO_TIMESPEC()@ macros are not s... Andy Fiddaman

2020-09-06

11:57 PM Bug #13110 (Closed): clean up compiler gags in bhyve kernel
As part of porting bhyve to illumos, a number of compiler/smatch gags were added to its makefile in the interest of e... Patrick Mooney
07:08 PM Bug #12512 (Closed): dispadmin.1m manpage is missing \fB \fR around FX
"git commit e075c017fe4c71cde62297bcc90d3411c0f4ad1d":https://github.com/illumos/illumos-gate/commit/e075c017fe4c71cd... Electric Monk
02:24 PM Bug #13109: usb disk dies on high IO and loader hangs on reset
... Olaf Bohlen
10:34 AM Bug #13109: usb disk dies on high IO and loader hangs on reset
The system is a Sun X4470 running OpenIndiana hipster:... Olaf Bohlen
10:13 AM Bug #13109 (New): usb disk dies on high IO and loader hangs on reset
I was copying from an external USB disk to an NFS mount and under constant 30MB/s IO the disk dies reproducable:
<... Olaf Bohlen

2020-09-05

10:31 PM Bug #13108: mlxcx fails to attach on system using pcplusmp after 12988
I coded up an implementation for option 2 as presented by Robert. Given the constraint that the async vector needs to... Andy Fiddaman
03:15 PM Bug #13108: mlxcx fails to attach on system using pcplusmp after 12988
So, the fundamental problem here is that in the older @pcplusmp@ PSM module, the all interrupt vectors are treated as... Robert Mustacchi
03:03 PM Bug #13087 (Closed): zfs: zfs_ereport_post() and zfs_ereport_start() return values are ignored
"git commit 9b0881404678e5235132f9320785c3f5ce6e71f6":https://github.com/illumos/illumos-gate/commit/9b0881404678e523... Electric Monk
01:07 AM Bug #13097: improve VM tunables for modern systems
Peter Tribble wrote:
> Thanks.
>
> As for small memory systems, I suspect the case of interest is something like ... Rich Lowe

2020-09-04

08:39 PM Feature #7709 (Closed): hrt2ts and friends are too clever for their own good
"git commit 88b8d9620aed414dab5fb34108dee58556f060f0":https://github.com/illumos/illumos-gate/commit/88b8d9620aed414d... Electric Monk
03:17 PM Bug #13070: mtu option too large MTU 1728 - 1500
In native zones, each of these tunables has the supported interface of ipadm(1M). ipadm(1M) maintains each netstack'... Dan McDonald
05:29 AM Bug #13070: mtu option too large MTU 1728 - 1500
This fixed the network speed:
sudo ndd -set /dev/tcp tcp_wscale_always 1
sudo ndd -set /dev/tcp tcp_tstamp_if_wsc... gh origin
02:47 PM Bug #12936 (Closed): bhyve vlapic needs ability to bypass isrvec_stk
"git commit 5365b8a5984eca60a3cedc7f9f738e51fb056bec":https://github.com/illumos/illumos-gate/commit/5365b8a5984eca60... Electric Monk
03:21 AM Bug #12936: bhyve vlapic needs ability to bypass isrvec_stk
A derivative of this change was tested by a member of the FreeBSD community in their bhyve environment with a variety... Patrick Mooney
01:39 PM Feature #13018: A virtual function of a ConnectX-4 VDI attached to an IllumOS based VM (OI) is not handled correctly by mlxcx
Ok, try... Paul Winder
01:26 PM Feature #13018: A virtual function of a ConnectX-4 VDI attached to an IllumOS based VM (OI) is not handled correctly by mlxcx
... Florian Manschwetus
10:52 AM Bug #13108: mlxcx fails to attach on system using pcplusmp after 12988
For completeness, here's @::interrupts@ when booted with APIX... Andy Fiddaman
10:50 AM Bug #13108 (Closed): mlxcx fails to attach on system using pcplusmp after 12988
After updating to a driver which included the bits from 12988, an OmniOS user reported that the @mlxcx@ driver was no... Andy Fiddaman
06:54 AM Bug #13107 (Closed): pageout should use hrtime instead of lbolt
The paging routines in @uts/common/os/vm_pageout.c@ presently make use of a mixture of @ddi_get_lbolt(9F)@ and @gethr... Joshua M. Clulow
12:36 AM Feature #13079: Add ksensor support for voltage and current sensors
I tested this in a couple different ways:
* I used the ksensor os-tests and verified that they old passed, which w... Robert Mustacchi

2020-09-03

10:12 PM Feature #13102 (Closed): ptools could be built with ctf
"git commit fbfe962ed9b45c98bebaea25573c8b8f1630d482":https://github.com/illumos/illumos-gate/commit/fbfe962ed9b45c98... Electric Monk
04:04 AM Feature #13102: ptools could be built with ctf
To test this I ran ctfdump on several of the ptools and confirmed that they now had CTF data. Robert Mustacchi
03:54 AM Feature #13102 (Closed): ptools could be built with ctf
Currently the various ptools aren't built with ctf. If they had been, it'd be much easier to debug issues like #13101... Robert Mustacchi
10:12 PM Bug #13101 (Closed): pargs dumps core when it can't read argv
"git commit fbfe962ed9b45c98bebaea25573c8b8f1630d482":https://github.com/illumos/illumos-gate/commit/fbfe962ed9b45c98... Electric Monk
04:07 AM Bug #13101: pargs dumps core when it can't read argv
To test this I verified that pargs no longer dumped core on the affected core dump and that it worked correctly on se... Robert Mustacchi
03:50 AM Bug #13101 (Closed): pargs dumps core when it can't read argv
While looking at a core dump that had been truncated, pargs dumped core:... Robert Mustacchi
08:36 PM Bug #13106 (Closed): clarify PPR transitions in bhyve vLAPIC
Between the complicated conditional logic for APICv vs. non-accelerated LAPIC emulation, and the TPR shadowing change... Patrick Mooney
07:30 PM Bug #12456 (Closed): ipsec: variable may be used uninitialized
"git commit 4132743a134e253014b777399c8f8275cf71636c":https://github.com/illumos/illumos-gate/commit/4132743a134e2530... Electric Monk
11:52 AM Bug #13105 (Closed): dnode_special_open() error: unchecked function return 'zrl_tryenter'
smatch error:... Toomas Soome
10:03 AM Bug #13104 (Closed): zfs: offset_t is signed and can not be > MAXOFFSET_T
Build error with smatch:... Toomas Soome
09:39 AM Bug #13103 (Closed): zfs: zvol_strategy() warn: unsigned 'off' is never less than zero
warning from smatch:... Toomas Soome
07:42 AM Bug #13097: improve VM tunables for modern systems
Thanks.
As for small memory systems, I suspect the case of interest is something like AWS (or VirtualBox) where yo... Peter Tribble
04:33 AM Feature #12863: Make cbc_pad its own mode
A bit of history for the timing improvements:
Originally, the PKCS5/7 padding (in the context of AES they're ident... Jason King

2020-09-02

09:36 PM Bug #13097: improve VM tunables for modern systems
Peter, I have done some more testing in 512MB guests with this fix rebased on the end of the ZFS (and other) changes ... Joshua M. Clulow
09:13 AM Bug #13097: improve VM tunables for modern systems
Oh, and yes, I think a swap file of at least some size is pretty critical in a world without overcommitted memory -- ... Joshua M. Clulow
09:12 AM Bug #13097: improve VM tunables for modern systems
Those are fair questions. I'm not completely convinced that ZFS isn't doable in 512MB. There are some things that s... Joshua M. Clulow
09:03 AM Bug #13097: improve VM tunables for modern systems
So, a couple of thoughts:
How many people are using illumos with ZFS on a 512M system? I can imagine that would be... Peter Tribble
08:00 AM Bug #13097: improve VM tunables for modern systems
Notes from a block comment I intend to integrate with this change:... Joshua M. Clulow
07:58 AM Bug #13097: improve VM tunables for modern systems
Note that my current plan is to play with the values until I cannot deadlock the system just by allocating anymore --... Joshua M. Clulow
07:57 AM Bug #13097 (Closed): improve VM tunables for modern systems
Modern systems tend to be configured to swap to a ZFS zvol device. ZFS pool I/O requires a lot more (mostly transien... Joshua M. Clulow
08:32 PM Bug #12384 (Closed): update to GCC 7.5.0
This was done a while back... John Levon
08:26 PM Bug #13072 (Closed): clarify VMCB interface in bhyve
"git commit 096bb5cb663d8fa04eda9a4aceb4d82a9cbae42c":https://github.com/illumos/illumos-gate/commit/096bb5cb663d8fa0... Electric Monk
02:24 AM Bug #13072: clarify VMCB interface in bhyve
With this change in place, all of the usual suspects were booted up:
- FreeBSD
- Linux
- OpenBSD
- Windows
- Omn... Patrick Mooney
08:22 PM Bug #13100 (Closed): zdb rpool crash on raidz
attempted run of zdb rpool:... Toomas Soome
08:20 PM Feature #7709: hrt2ts and friends are too clever for their own good
This change has been present in SmartOS for years without presenting a problem. With it built on top of illumos-gate... Patrick Mooney
07:55 PM Bug #12976 (Closed): system panics with error in IP module
"git commit 2ad530425ac9cd3f429e64463a85f6f58703061c":https://github.com/illumos/illumos-gate/commit/2ad530425ac9cd3f... Electric Monk
07:36 PM Bug #12976: system panics with error in IP module
Note that the #9531 implementation is tickled by netstat(1) processes. Additional testing has demonstrated that `net... Dan McDonald
03:25 PM Bug #12976: system panics with error in IP module
Jason now has non-DEBUG production time up with this fix too, and he is happy. Dan McDonald
03:44 PM Bug #13098 (New): Low output level from audio devices
Many people have noticed this problem, but I have actual measurements that illustrate it. For measurement, I used Au... Gary Mills
07:31 AM Bug #13096 (Closed): xnf asleep at wheel while freemem smashes into the ground
The @xnf@ driver (for Xen virtual network interfaces) performs a variety of exciting allocations within @xnf_send()@.... Joshua M. Clulow
07:17 AM Bug #13095 (New): ZFS ARC minimum size is too large
The ARC will shrink in response to memory pressure, but will stop doing so once it hits @arc_c_min@. That value star... Joshua M. Clulow
07:01 AM Bug #13094 (Closed): systems have more kmem caches than they used to
The @kmem_taskq@ is used for various house keeping functions within the kernel memory allocator. One of the most imp... Joshua M. Clulow
06:48 AM Bug #13093 (New): ZFS should be more careful in low memory situations
Once more of ZFS is able to correctly use the pageout reserve pool (see #13092), we should ensure that it takes that ... Joshua M. Clulow
06:44 AM Bug #13092 (Closed): ZFS I/O pipeline should use the pageout_reserve pool
When the system is under memory pressure (@freemem@ is below @lotsfree@), the @pageout_scanner()@ begins scanning mem... Joshua M. Clulow

2020-09-01

09:10 PM Bug #13091: process contract escaped SMF
The only relevant lines in startd's log file:... David Pacheco
09:06 PM Bug #13091 (New): process contract escaped SMF
I originally saw this problem with OmniOS's "ntp" SMF service when I configured it to wait for sync at startup. I've... David Pacheco
08:44 PM Bug #13090 (Closed): junk characters in `zpool online -e` EACCES error message
Here's my /etc/os-release:... David Pacheco
08:17 PM Bug #13072: clarify VMCB interface in bhyve
As part of this change, the segment attribute/access conversion code was shuffled around a bit. That conversion code... Patrick Mooney
08:16 PM Bug #13089 (New): want segment access defines for bhyve
In bhyve, the access/attributes of the various segments (%[cdefgs]s, %ldtr, %tr) is exposed though the ioctl API from... Patrick Mooney
07:43 PM Bug #13088 (New): uniqtime() is too clever for its own good
As richlowe pointed out in the feedback for #7709, the @uniqtime()@ function also has "optimized" time conversion log... Patrick Mooney
07:02 PM Bug #13085 (Closed): fast_syscall state should be tracked
"git commit 8515d723262b57176aeeda8734edbe79fe1e7a5a":https://github.com/illumos/illumos-gate/commit/8515d723262b5717... Electric Monk
06:25 PM Bug #13085: fast_syscall state should be tracked
I repeated the above test, using the modified @ldt.c@ on an illumos-gate BE featuring the change. Before running the... Patrick Mooney
05:31 PM Bug #13084 (Closed): tl_open should handle id_space exhaustion
"git commit 1c8449e95a93a750df972545379490366b392934":https://github.com/illumos/illumos-gate/commit/1c8449e95a93a750... Electric Monk
03:51 PM Bug #13084: tl_open should handle id_space exhaustion
While I have not installed netatalk like in the original bug report, I did boot up a BE with the proposed change and ... Patrick Mooney
04:43 PM Bug #13047 (Closed): SMB server is too strict about security descriptors
"git commit d11e14a72ad0bfccf84405261d5d93e6eaafe6a7":https://github.com/illumos/illumos-gate/commit/d11e14a72ad0bfcc... Electric Monk
04:43 PM Bug #13045 (Closed): Idmap's KDC lookup override doesn't work
"git commit bdc3270f393f51a419684e0fd3d7112e9b269773":https://github.com/illumos/illumos-gate/commit/bdc3270f393f51a4... Electric Monk
03:53 PM Feature #13083: Enable gate builds with OpenJDK 11
FWIW - the OmniOS OpenJDK11 package is directly using the patches that Peter kindly provided in https://illumos.topic... Andy Fiddaman
03:15 PM Bug #13087 (Closed): zfs: zfs_ereport_post() and zfs_ereport_start() return values are ignored
use (void) to silence analyzers.
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <be... Toomas Soome
09:23 AM Feature #13018: A virtual function of a ConnectX-4 VDI attached to an IllumOS based VM (OI) is not handled correctly by mlxcx
A possible fix is "here":https://github.com/pwinder/illumos-gate/commit/d3ae8d9e9f7d6cefafc6b13206b03b340f719518#diff... Paul Winder
07:50 AM Feature #13018: A virtual function of a ConnectX-4 VDI attached to an IllumOS based VM (OI) is not handled correctly by mlxcx
If you have an environment where you can test this, can you try the following to confirm whether my theory is correct... Paul Winder
04:57 AM Bug #11499: default to hires tick
Testing:
Build, running, build with build running. Confirmed value of `hz`. Confirmed value of `hz` when `hire... Rich Lowe

2020-08-31

07:08 PM Bug #13026 (Closed): SMB and NFS use the global zone's IDMAP when they shouldn't
"git commit 526073d8a2a73617d29e806e575a271bc992905b":https://github.com/illumos/illumos-gate/commit/526073d8a2a73617... Electric Monk
05:33 PM Feature #13022 (Closed): Want method to globally disable HMA
"git commit be4662198f3d57350960479f8997432537cfd6a5":https://github.com/illumos/illumos-gate/commit/be4662198f3d5735... Electric Monk
10:18 AM Feature #13083: Enable gate builds with OpenJDK 11
Joshua M. Clulow wrote:
> Looking at the packages available in OpenIndiana, it seems that they only currently have O... Peter Tribble
10:05 AM Bug #12780 (Closed): GRUB is broken after 11479
"git commit c94be9439c4f0773ef60e2cec21d548359cfea20":https://github.com/illumos/illumos-gate/commit/c94be9439c4f0773... Electric Monk
07:05 AM Feature #7709: hrt2ts and friends are too clever for their own good
Robert Mustacchi wrote:
> Upstreaming of "OS-5655":https://smartos.org/bugview/OS-5655 from SmartOS:
>
> The fami... Toomas Soome
02:43 AM Feature #7709 (In Progress): hrt2ts and friends are too clever for their own good
Patrick Mooney
03:21 AM Bug #13085 (Closed): fast_syscall state should be tracked
Upstreaming "OS-7084":https://smartos.org/bugview/OS-7084 from SmartOS:
> The i86pc platform disables fast syscall... Patrick Mooney
03:09 AM Bug #13084 (Closed): tl_open should handle id_space exhaustion
This is uptreaming of "OS-5957":https://smartos.org/bugview/OS-5957 from SmartOS:
> Reported as "illumos-joynet#13... Patrick Mooney

2020-08-30

10:55 PM Feature #1532 (In Progress): Long-term kernel-resident processes need a way to play fair
I think it's time to fix @kpreemptpri@. It has been at 99 in SmartOS for so long that I didn't immediately even thin... Joshua M. Clulow
10:29 PM Feature #13083: Enable gate builds with OpenJDK 11
Looking at the packages available in OpenIndiana, it seems that they only currently have OpenJDK 7 & 8 under:
http... Joshua M. Clulow
06:10 PM Feature #13083 (Closed): Enable gate builds with OpenJDK 11
The Java world is moving on, and JDK8 is getting rather old.
It would be beneficial to support gate builds with a ... Peter Tribble
10:12 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
Just a heads-up that my issue appears to have been a result of my motherboard automatically setting the frequency too... Amos Hayes
08:47 PM Feature #13022: Want method to globally disable HMA
Kindly tested for me by Volker A. Brandt on an AMD machine:
"Six-Core AMD Opteron(tm) Processor 8431"
Using O... Andy Fiddaman
08:19 PM Bug #12637 (Closed): ses_facility.c topo methods are not properly terminated
"git commit ab26215b1a80ead55969e925a597044ad4185a34":https://github.com/illumos/illumos-gate/commit/ab26215b1a80ead5... Electric Monk

2020-08-29

07:37 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform

Okay, here is an update. I have a dev build joyent_20200824T192056Z running on an E5-4600. I forgot about this bug ... Jason Matthews
07:02 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
I have what seems to me to be a very similar problem where SmartOS/illumos is telling me that the cache on core 0 of ... Amos Hayes
02:40 PM Bug #12637: ses_facility.c topo methods are not properly terminated
Unfortunately, folks with the hardware who were in a best position to test weren't able to get that done. However, we... Robert Mustacchi
07:01 AM Feature #13082: pageout needs a deadman
I have a relatively simple prototype for this that works well enough that I have been able to get a few memory deadlo... Joshua M. Clulow

2020-08-28

06:32 PM Bug #13064 (Closed): bhyve should not waste extra page for VMCS
"git commit 007ca33219ffdc49281657f5f8a9ee1bbfc367ab":https://github.com/illumos/illumos-gate/commit/007ca33219ffdc49... Electric Monk
06:17 PM Bug #13064: bhyve should not waste extra page for VMCS
Testing for this was included in the testing of #13063. Dan McDonald
06:32 PM Bug #13063 (Closed): clarify VMCS interfaces in bhyve
"git commit 007ca33219ffdc49281657f5f8a9ee1bbfc367ab":https://github.com/illumos/illumos-gate/commit/007ca33219ffdc49... Electric Monk
04:19 PM Bug #12752 (Closed): getipsecprotobyname(3NSL) synopsis is incomplete
"git commit 638bc9f013400030354ab6566ae2a5726f7580fa":https://github.com/illumos/illumos-gate/commit/638bc9f013400030... Electric Monk
06:19 AM Feature #13082 (Closed): pageout needs a deadman
There are some lingering issues in low memory situations that cause the system to deadlock while paging out to ZFS po... Joshua M. Clulow
12:27 AM Feature #13081 (Closed): add mlxcx temp sensor
The mlxcx(7D) devices have support for exposing their internal temperature sensors through device registers. It would... Robert Mustacchi
12:24 AM Feature #13080 (Closed): Add support for cxgbe temp/volt sensor
The Chelsio 'cxgbe' series of parts has support for a temperature and voltage sensor on the part. It'd be great if th... Robert Mustacchi
12:24 AM Feature #13079 (Closed): Add ksensor support for voltage and current sensors
When the ksensor framework was introduced, it as designed such that we could add sensors for other types of periphera... Robert Mustacchi
12:20 AM Bug #13067: Regression between Hipster-November2019 install media and 2020-07: 'ls /devices' hangs
Do you have the ability to generate an nmi potentially? If not, we may be able to boot with kmdb and drop into a debu... Robert Mustacchi

2020-08-27

07:23 PM Bug #13034 (Closed): dnode_sync is careless with range tree
"git commit 7611ab7b771a068fbab94a90143de2afd495769f":https://github.com/illumos/illumos-gate/commit/7611ab7b771a068f... Electric Monk
05:42 PM Bug #13034: dnode_sync is careless with range tree
With the proposed patch included in a DEBUG build, the reproducer workload is no longer able to panic the machine as ... Patrick Mooney
02:34 PM Feature #13018: A virtual function of a ConnectX-4 VDI attached to an IllumOS based VM (OI) is not handled correctly by mlxcx
Is there a way to query/test this, having an illumos based system running in such an environment?
Or is there some d... Florian Manschwetus
10:15 AM Feature #13018: A virtual function of a ConnectX-4 VDI attached to an IllumOS based VM (OI) is not handled correctly by mlxcx
MLXCX_OP_CREATE_EQ is used to create event queues for asynchronous events and completion events. I *suspect* this is ... Paul Winder
06:10 AM Bug #12512 (In Progress): dispadmin.1m manpage is missing \fB \fR around FX
Sergio Aguayo
05:51 AM Bug #12752 (In Progress): getipsecprotobyname(3NSL) synopsis is incomplete
Sergio Aguayo
12:58 AM Bug #13077 (Closed): bhyve kernel should be -Wformat clean
When bhyve was ported to illumos, the printf-like warnings in the kernel were suppressed with -Wno-format. As we're ... Patrick Mooney
12:07 AM Feature #13076 (New): SMF could allow the operator to ignore failing start methods
An SMF service with the *transient* duration is, in some senses, akin to dropping something in an @/etc/rc.local@ fil... Joshua M. Clulow

2020-08-26

10:19 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
I'll need to dig a bit more to confirm, but these would appear to be correctable error events... which leads to the q... Jason King
10:14 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
... Jason Matthews
10:11 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
Sorry if I clipped something useful...
root@dba012:/root# fmdump -e | sort -k 5 | cut -d" " -f 5 |uniq -c
76 ... Jason Matthews
10:04 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
If you do 'fmdump -e' are all of the events 'ereport.cpu.intel.quickpath.mem_redundant' or are there different values? Jason King
10:01 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
... Jason Matthews
09:16 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
Actually try @fmdump -eV@ -- I found some HW errata for that CPU that might be relevant, and that should contain enou... Jason King
08:03 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform

meaning these events?
--------------- ------------------------------------ -------------- ---------
TIME ... Jason Matthews
07:56 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
Is that fmdump -evv output from an event (if not can you supply that)? Jason King
07:49 PM Bug #12920: Newer releases falsely report CPU layer 2 cache is faulty on E4-4600 platform
from another system, but same issue.
Jul 02 03:08:33.3748 ereport.cpu.intel.l2dcache_uc 0xb80d985dd162e401... Jason Matthews
06:38 PM Bug #12767 (Closed): Document '-delete' option to find(1)
"git commit d770dd109db2b92dea49c41ab80ce452e6e7064c":https://github.com/illumos/illumos-gate/commit/d770dd109db2b92d... Electric Monk
02:22 PM Bug #12988 (Closed): potential hang in mlxcx when async and ring vectors end up on same CPU
"git commit e1447ca93391f31609bda487cb922dbff9dcdef5":https://github.com/illumos/illumos-gate/commit/e1447ca93391f316... Electric Monk
02:22 PM Bug #12987 (Closed): devo_power misconfigured in mlxcx
"git commit e1447ca93391f31609bda487cb922dbff9dcdef5":https://github.com/illumos/illumos-gate/commit/e1447ca93391f316... Electric Monk
02:22 PM Bug #12980 (Closed): attempting to change MTU on mlxcx based aggregation can induce FMA event
"git commit e1447ca93391f31609bda487cb922dbff9dcdef5":https://github.com/illumos/illumos-gate/commit/e1447ca93391f316... Electric Monk
01:28 PM Bug #13075: No console messages after early boot on non-VGA graphics
When bootloader is involved, then gfx_private driver inherits frame buffer info from the bootloader, part of that is ... Paul Winder
12:24 PM Bug #13075 (Closed): No console messages after early boot on non-VGA graphics
If the console is attached to a graphics card/chipset which does not advertise it is VGA, on boot the console output ... Paul Winder
10:20 AM Bug #12818: ntpq(1m) -w flag undocumented
The @ntp@ stuff comes from the distribution, not illumos-gate.
At least OmniOS has moved to @ntpsec@ by default thes... Andy Fiddaman
07:53 AM Bug #12818: ntpq(1m) -w flag undocumented
Yes, it works. It just isn’t documented in the man page. Christoph Binner
05:12 AM Bug #12818: ntpq(1m) -w flag undocumented
ntpq -pw certainly works
bash-5.0$ ntpq -p server.lan
remote refid st t when poll reach del... John Gardner
05:46 AM Feature #12844 (Closed): Change console font to FreeBSD's style?
Toomas Soome
05:46 AM Feature #12844 (Resolved): Change console font to FreeBSD's style?
Toomas Soome
03:20 AM Feature #13040 (Closed): grep can leverage bmg in more cases
"git commit dbe930bf51e0d7458b24d30e9f25756c5da54ddf":https://github.com/illumos/illumos-gate/commit/dbe930bf51e0d745... Electric Monk
03:20 AM Feature #3546 (Closed): add support for grep -o option
"git commit 81dd18d87c3c2e198d2178dfd1f30d62a81b69ea":https://github.com/illumos/illumos-gate/commit/81dd18d87c3c2e19... Electric Monk
03:20 AM Feature #13036 (Closed): grep tests could be easier to extend
"git commit f415aa8f1340638644c6cf63e9d11d3767f4cbba":https://github.com/illumos/illumos-gate/commit/f415aa8f13406386... Electric Monk
03:20 AM Feature #13038 (Closed): grep could support --label
"git commit 8ccd021704a4fe1b4022c110d3dd497f8cd907d5":https://github.com/illumos/illumos-gate/commit/8ccd021704a4fe1b... Electric Monk
03:20 AM Feature #13037 (Closed): grep could support -L
"git commit 2e5ac464a5683c5bf11439ccad74c9f279051820":https://github.com/illumos/illumos-gate/commit/2e5ac464a5683c5b... Electric Monk

2020-08-25

09:03 PM Feature #13061 (Closed): Import sed tests from freebsd
"git commit cd94aa947d1e02a1c25259f2cf06c165d75aa4fa":https://github.com/illumos/illumos-gate/commit/cd94aa947d1e02a1... Electric Monk
02:40 PM Feature #13061: Import sed tests from freebsd
All tests pass when run using the @sed@ post 13051... Andy Fiddaman
09:03 PM Bug #13051 (Closed): sed: lastline check does not work properly with empty files
"git commit c6fc7f7b786ce47c35645054cdce73e83f39e7f3":https://github.com/illumos/illumos-gate/commit/c6fc7f7b786ce47c... Electric Monk
08:02 PM Feature #12844: Change console font to FreeBSD's style?
i'd have gone with doing a reverse-video of the SPARC console fb Rick V
07:34 PM Bug #13003 (Closed): console: multiple issues related to colors and font loading and switching
"git commit e0721d5ae1542c80097f6fcd487736fdfe601233":https://github.com/illumos/illumos-gate/commit/e0721d5ae1542c80... Electric Monk
06:34 PM Feature #12863: Make cbc_pad its own mode
To test, I ran the crypto test suite, all tests passed. Jason King
03:33 PM Bug #12780: GRUB is broken after 11479
The change I submitted here fixes the problem for me: https://code.illumos.org/c/illumos-gate/+/692 Andrew Stormont
03:14 PM Feature #13066 (Closed): Want crontab -u
"git commit 6863ede29751efd2be66ec1b48c3c0ee705d7d61":https://github.com/illumos/illumos-gate/commit/6863ede29751efd2... Electric Monk
01:32 PM Feature #13066: Want crontab -u
I tested this by building an updated @crontab@ binary and then trying combinations of options to show that previous o... Andy Fiddaman
03:06 AM Bug #13044 (Closed): Clarify parts of getopt_long(3C)
"git commit 31c9b836861e74f837a36ca29220b58f3657585a":https://github.com/illumos/illumos-gate/commit/31c9b836861e74f8... Electric Monk

2020-08-24

11:51 PM Bug #13032 (Closed): printf(3C) should talk about NULL string pointers
"git commit 9fff840dca14d75459a8240b19c931e2fec186c5":https://github.com/illumos/illumos-gate/commit/9fff840dca14d754... Electric Monk
09:03 PM Bug #13072 (Closed): clarify VMCB interface in bhyve
Similar to #13063, the in-kernel interface used by bhyve to access the VMCB on AMD hardware could be cleaned up. Fai... Patrick Mooney
07:10 AM Bug #10556: Fatal firmware error with iwn wireless
Installed hipster 2020.04 on Dell Vostro 3550 with the same wifi card.
Same issue with same messages in /var/adm/mes... Sven Schmeling
04:41 AM Bug #13071 (Closed): igb(7D) needs to mention it's GLDv3, not STREAMS
The igb(7D) man page doesn't mention GLDv3, and reads like a pre-GLDv3 STREAMS man page in some places. Dan McDonald

2020-08-23

11:42 PM Bug #13021 (Closed): Invalid state if bindtextdomain() fails during re-binding
"git commit 0a9a25a293d437b1563e1d8479fef8f3795ba817":https://github.com/illumos/illumos-gate/commit/0a9a25a293d437b1... Electric Monk
07:34 PM Bug #12767 (In Progress): Document '-delete' option to find(1)
Working on this Sergio Aguayo

2020-08-22

07:59 PM Bug #13070 (New): mtu option too large MTU 1728 - 1500
This error is printed on each boot. I'm using a Realtek Ethernet card and on Linux the MTU is always set to 1500.
... gh origin
07:59 PM Feature #13062 (Closed): loader: make env_discard() public
"git commit 5fae793b9b02afd1f3f434f3a915a64c08edc7b2":https://github.com/illumos/illumos-gate/commit/5fae793b9b02afd1... Electric Monk
07:51 PM Bug #13054: Ilumos based distros failed to install on FreeBSD's Bhyve
The issue is resolved. Please close it. Thanks. gh origin
07:48 PM Bug #13054: Ilumos based distros failed to install on FreeBSD's Bhyve
Igor Kozhukhov wrote:
> also we have fix for bhyve on DilOS where we can specify phys block to VM - it'll use correc... gh origin
04:27 AM Bug #12976: system panics with error in IP module
The bug filer, running a DEBUG kernel in his environment, has exposed a race between socket closing and the new-ish #... Dan McDonald
03:54 AM Bug #11255: After GCC 7 switch dependencies on GCC runtime packages are incorrect
We can do this if we are sure that our compilers completely ignore /usr/lib/libgcc_s.so*.
Otherwise there can be in... Alexander Pyhalov

2020-08-21

10:35 PM Bug #11255: After GCC 7 switch dependencies on GCC runtime packages are incorrect
I wonder if we should leave the libraries in version-specific directories, but use IPS mediators (which I am only jus... Joshua M. Clulow
09:29 PM Bug #11255: After GCC 7 switch dependencies on GCC runtime packages are incorrect
Seems so. Alexander Pyhalov
04:29 PM Bug #11255: After GCC 7 switch dependencies on GCC runtime packages are incorrect
That seems fair for the C++ one, I guess, though one might reasonably wonder why the incompatible one didn't end up w... Joshua M. Clulow
04:09 PM Bug #11255: After GCC 7 switch dependencies on GCC runtime packages are incorrect
We've moved gcc runtime out of /usr/lib during 4.9 => 6 migration, as GCC 5 and 6 C++ runtimes were not compatible wi... Alexander Pyhalov
03:20 PM Bug #11255: After GCC 7 switch dependencies on GCC runtime packages are incorrect
I guess this may be less true of @libstdc++@, but I'm not sure on that one. Joshua M. Clulow
03:17 PM Bug #11255: After GCC 7 switch dependencies on GCC runtime packages are incorrect
What about, instead, if distributions delivered a correct and sufficiently recent GCC runtime into @/usr/lib@? This ... Joshua M. Clulow
08:33 PM Bug #13063: clarify VMCS interfaces in bhyve
Using the proposed fix for this, I booted up the normal crew of guests:
- CentOS
- OmniOSce
- OpenBSD
- Windows
... Patrick Mooney
06:03 PM Bug #13068 (Closed): gptzfsboot: command from /boot/config should be nul terminated
"git commit b89fb824168e36795c325b5e0a4d1e71dd2d8d65":https://github.com/illumos/illumos-gate/commit/b89fb824168e3679... Electric Monk
03:09 PM Bug #13065 (Closed): log when suspending a zpool
"git commit 8548ec78d85644539a23c4262ed2b9512a47865e":https://github.com/illumos/illumos-gate/commit/8548ec78d8564453... Electric Monk
10:43 AM Bug #13065: log when suspending a zpool
I did a simple test on this by making all writes fail for a bhyve VM, and checking the message appears when the pool ... John Levon
05:06 AM Bug #12996 (Closed): bhyve kernel should be wscheck clean
"git commit 84971882a96ac0fecd538b02208054a872ff8af3":https://github.com/illumos/illumos-gate/commit/84971882a96ac0fe... Electric Monk

2020-08-20

09:31 PM Bug #13069 (New): kernel_fpu_begin() panics if used more than once with a custom context
Doing some experimenting with the kfpu interfaces (in the hopes they might be useful with the in-kernel crypto accele... Jason King
09:12 PM Bug #13068 (Closed): gptzfsboot: command from /boot/config should be nul terminated
make sure we terminate the read configuration properly.

FreeBSD update: https://svnweb.freebsd.org/changeset/b... Toomas Soome
09:01 PM Bug #12996: bhyve kernel should be wscheck clean
Since this is a whitespace-only change, I tested it with @wsdiff@. The only changes I saw, besides the normal DOF an... Patrick Mooney
07:22 PM Bug #12991 (Closed): bhyve vlapic should SIPI more carefully
"git commit e0c0d44e917080841514d0dd031a696c74e8c435":https://github.com/illumos/illumos-gate/commit/e0c0d44e91708084... Electric Monk
02:23 PM Bug #12991: bhyve vlapic should SIPI more carefully
Testing notes for this (and #12990) are written up in #12989. Patrick Mooney
07:22 PM Bug #12990 (Closed): improve interface boundary for bhyve ins/outs
"git commit e0c0d44e917080841514d0dd031a696c74e8c435":https://github.com/illumos/illumos-gate/commit/e0c0d44e91708084... Electric Monk
02:23 PM Bug #12990: improve interface boundary for bhyve ins/outs
Testing notes for this (and #12991) are written up in #12989. Patrick Mooney
07:22 PM Bug #12989 (Closed): improve interface boundary for bhyve MMIO
"git commit e0c0d44e917080841514d0dd031a696c74e8c435":https://github.com/illumos/illumos-gate/commit/e0c0d44e91708084... Electric Monk
02:43 PM Feature #13040: grep can leverage bmg in more cases
I tested this with the updated grep test suite, test run below. I also spot checked the performance of a number of di... Robert Mustacchi
02:42 PM Feature #3546: add support for grep -o option
I tested this with the updated grep test suite, test run below. This included a number of large additions to the test... Robert Mustacchi
02:42 PM Feature #13037: grep could support -L
I tested this with the updated grep test suite, test run below. I also verified ggrep had the same behavior with -L.
... Robert Mustacchi
02:42 PM Feature #13036: grep tests could be easier to extend
I tested this by running the grep test suite and verifying that everything passed. I also forced a number of failures... Robert Mustacchi
02:41 PM Feature #13038: grep could support --label
I tested this with the updated grep test suite, test run below. I also verified ggrep had the same behavior with --la... Robert Mustacchi
01:58 PM Bug #13067 (New): Regression between Hipster-November2019 install media and 2020-07: 'ls /devices' hangs
On a boot environment fresh from the standard November 2019 install media, not pkg image-update'd, the following thin... carton .
01:29 PM Feature #13066: Want crontab -u
Webrev also at http://cr.illumos.org/~webrev/citrus/ig_13066_crontab-u/
for an easier way to view the man page changes. Andy Fiddaman
01:09 PM Feature #13066 (Closed): Want crontab -u

It would be useful if the @crontab@ command supported a @-u username@ option to specify the username for the operat... Andy Fiddaman
12:02 PM Bug #13065 (Closed): log when suspending a zpool
While experimenting with ZFS I/O failures, I hit a situation where the root pool would get suspended,
and due to all... John Levon
01:38 AM Bug #13064 (Closed): bhyve should not waste extra page for VMCS
When bhyve was ported to illumos, the allocation for the VMCS was expanded for an extra page (per vCPU!) in order to ... Patrick Mooney
01:36 AM Bug #13063 (Closed): clarify VMCS interfaces in bhyve
As it was imported from FreeBSD, bhyve has an API surface for interacting with the VMCS (virtual machine control stru... Patrick Mooney

2020-08-19

09:25 PM Feature #13062 (Closed): loader: make env_discard() public
remove static from env_discard() to make it globally available. Needed to unset variable without using callback. Whil... Toomas Soome
09:13 PM Feature #13061 (Closed): Import sed tests from freebsd
The illumos sed shares its roots with the one in FreeBSD. FreeBSD has a number of tests that would be useful to add t... Andy Fiddaman
05:47 PM Bug #13059: Dell R630 - X2APIC enabled cause boot hang
Happens on Bleeding edge and Joysent SmartOS David Fox
12:21 PM Bug #13059 (New): Dell R630 - X2APIC enabled cause boot hang
After purchasing two R630 -- I've discovered that this server is non-bootable with illumos.
The error appears to ... David Fox
04:25 PM Feature #12983 (Closed): Want additional prototypes for manual pages
"git commit 76f19f5fdc974fe5be5c82a556e43a4df93f1de1":https://github.com/illumos/illumos-gate/commit/76f19f5fdc974fe5... Electric Monk
04:22 PM Bug #13044: Clarify parts of getopt_long(3C)
I tested this by looking at the new page with @man(1)@ and then I also took the new example code and copy and pasted ... Robert Mustacchi
03:33 PM Bug #13060 (Closed): loader: fb-putimage fails silently even with debug flag set
fb-putimage will fail silently when given some PNG files even with the debug flag set, such as PNG files that use fea... Andrew Stormont
07:50 AM Bug #13041 (Closed): i40e_get_available_resources() broken again for X722 part
"git commit 341c5f490806c8b3e6e31512923db4c0e1b464b1":https://github.com/illumos/illumos-gate/commit/341c5f490806c8b3... Electric Monk
02:35 AM Bug #13049 (Closed): cstyle should tolerate freebsd headers
"git commit dcbbe9e03d9d35c714d909a1f4767ce83c885e80":https://github.com/illumos/illumos-gate/commit/dcbbe9e03d9d35c7... Electric Monk
12:32 AM Bug #13058 (New): high contention on root vnode mutex during a lookup-heavy workload
The box at hand is quite old: a 2 socket * 10 cores * 2 threads Sandy Bridge. There is a lx-zone with Debian performi... Mateusz Guzik

2020-08-18

06:45 PM Bug #13057 (New): pessimal mutex behavior
This is a slightly edited copy of what I originally posted here:
https://illumos.topicbox.com/groups/discuss/T58ee93... Mateusz Guzik
06:26 PM Bug #13056 (New): pessimal rw locks behavior
While read-write locking always modifying the same cacheline suffers from fundamental scalability issues, the current... Mateusz Guzik
06:23 PM Bug #11953: PCI Fatal Error encountered on AMD B450 platform
I have an X470 chipset on an ASRock Rack X470D4U, and am seeing these sorts of errors, that now tickle FMA thanks to ... Dan McDonald
04:53 PM Bug #13033: assertion failed: size <= (1ULL << 24) (0x1189000 <= 0x1000000), file: ../../common/fs/zfs/abd.c, line: 309
Sorry Jason, I'm not on IRC. Haven't had a need until now. You can contact me by email at jcw0624@outlook.com .
I do... Jack Whitehead
03:40 PM Bug #13055 (New): zinject's range arg "-r" should accept hex values by default
zinject [-q] <-t type> [-e errno] [-l level] [-r range]
[-a] [-m] [-u] [-f freq] <object>
allows one t... Sanjay Nadkarni
03:22 PM Bug #13054: Ilumos based distros failed to install on FreeBSD's Bhyve
Igor Kozhukhov wrote:
> DilOS 2.0.2.48 iso contain GRUB1 and it's not boot on UEFI.
> i'll prepare new ISO with loa... gh origin
07:38 AM Bug #13054: Ilumos based distros failed to install on FreeBSD's Bhyve
DilOS 2.0.2.48 iso contain GRUB1 and it's not boot on UEFI.
i'll prepare new ISO with loader and it'll possible to b... Igor Kozhukhov
07:16 AM Bug #13054: Ilumos based distros failed to install on FreeBSD's Bhyve
Jason King wrote:
> What sort of disks are you providing to the VM (since it looks like the problem is with the disk... gh origin
07:13 AM Bug #13054: Ilumos based distros failed to install on FreeBSD's Bhyve
Jason King wrote:
> What sort of disks are you providing to the VM (since it looks like the problem is with the disk... gh origin

2020-08-17

08:06 PM Bug #11499 (In Progress): default to hires tick
Rich Lowe
06:20 PM Bug #13033: assertion failed: size <= (1ULL << 24) (0x1189000 <= 0x1000000), file: ../../common/fs/zfs/abd.c, line: 309
Are you on irc? I can msg you a URL to upload if you're on freenet. Otherwise, we can figure out another way to get ... Jason King
06:01 PM Bug #13054: Ilumos based distros failed to install on FreeBSD's Bhyve
What sort of disks are you providing to the VM (since it looks like the problem is with the disks)? virtio-blk device... Jason King
05:48 PM Bug #13054 (New): Ilumos based distros failed to install on FreeBSD's Bhyve
I have reported everything in details on the FreeBSD forums thread here:
https://forums.freebsd.org/threads/bhyve-... gh origin
04:29 PM Bug #13048 (Closed): Fix format issue in regex(5) man page
"git commit 0d54f452f42b98b9da0e75b9401795c3a0560297":https://github.com/illumos/illumos-gate/commit/0d54f452f42b98b9... Electric Monk
03:44 PM Bug #13049: cstyle should tolerate freebsd headers
I really really hate that our cstyle has some specific idiosyncrasies which makes it pretty much impossible to implem... Garrett D'Amore
03:39 PM Bug #13049: cstyle should tolerate freebsd headers
Prior to this change, running cstyle against files with the standard FreeBSD license header would result in the error... Patrick Mooney
02:51 PM Bug #8679: failed to attach AMD IOMMU
I see this too on a Ryzen 7 3700x attached to an ASRock Rack X470DU4. Dan McDonald
02:37 PM Bug #12755 (Closed): Double fault when booting under Amazon EC2
"git commit b445c7c6f2f09c2296534b5ccda2c05321c474b1":https://github.com/illumos/illumos-gate/commit/b445c7c6f2f09c22... Electric Monk
12:43 PM Bug #6395: cannot tune segkpsize up
Arne Jansen wrote:
> It's not possible to tune segkpsize up, the system panics with 'startup: cannot attach segkp'..... Alasdair Lumsden

2020-08-16

08:19 PM Bug #12936: bhyve vlapic needs ability to bypass isrvec_stk
I booted up Linux, FreeBSD, and OmniOS guests with the same debugging, but all of those seemed to use the APIC in suc... Patrick Mooney
08:16 PM Bug #12936: bhyve vlapic needs ability to bypass isrvec_stk
Windows Server 2019 was another test platform for nested priorities, where I saw a similar 3-deep isrvec_stk_top valu... Patrick Mooney
02:06 PM Bug #13051: sed: lastline check does not work properly with empty files
Before the changes in the attached gerrit review, some of the new tests fail:... Andy Fiddaman
12:55 PM Bug #13051 (Closed): sed: lastline check does not work properly with empty files

Sed has a bug where it does not treat a line as a 'last line' candidate if there are more files to process.
e.g.... Andy Fiddaman
 

Also available in: Atom