illumos gate

2020-12-22

07:19 PM Bug #13387 (Closed): bhyve should expose lfence serialize in DE_CFG MSR

The DE_CFG MSR on modern AMD CPUs controls, among other things, whether the lfence instruction is serializing. While... Patrick Mooney

03:25 PM Feature #13386 (New): devfsadm -Cv -c disk should remove symlinks in /dev/hotpluggable/dsk and /dev/hotpluggable/rdsk

devfsadm -Cv -c disk
removes unused/stale symlinks in
/dev/dsk and /dev/rdsk
and should also remove symlinks ... Stephan Althaus

11:47 AM Bug #8040 (Pending RTI): NFSv4 client: 3-way deadlock between nfs4_bio(), nfs4_do_delegreturn(), and nfs4_flush_pages()

Marcel Telka

05:21 AM Bug #13385 (New): revisit rdtscp exclusion on xen

When determining the means by which a TSC reading is performed, the i86pc boot logic explicitly prevents Xen systems ... Patrick Mooney

02:22 AM Bug #13384 (Closed): tsc_read() should use lfence when prudent

At startup, tsc_read() contains text which uses CPUID to serialize the instruction stream before issuing a RDTSC. On... Patrick Mooney

2020-12-21

10:28 PM Bug #13383 (Closed): generalize check for serializing LFENCE

As part of the Spectre retpoline logic, AMD chips are checked for whether their LFENCE instruction is serializing. T... Patrick Mooney

06:49 PM Bug #13381 (In Progress): support TSC offsets on AMD bhyve

Patrick Mooney

06:46 PM Bug #13381 (Closed): support TSC offsets on AMD bhyve

The logic for applying TSC offsets to bhyve guests on AMD CPUs was never wired up. This is necessary for a few reaso... Patrick Mooney

06:48 PM Feature #13382 (Closed): consolidate MSR emulation in bhyve

There is a bunch of MSR emulation which is duplicated in the SVM and VMX portions of the code.
Those parts which are... Patrick Mooney

03:18 PM Feature #13379: bhyve upstream sync 2020 Dec

h2. FreeBSD commits included:
* bhyve: allow for automatic destruction on power-off
* Prevent calling USB backe... Andy Fiddaman

11:01 AM Feature #13380 (Closed): Add virtio-9p (aka VirtFS) filesystem sharing to bhyve

FreeBSD bhyve has this feature as of this commit. ... Andy Fiddaman

06:31 AM Bug #13354: illumos should calibrate the TSC earlier in the boot process.

Also, if someone does have some info on this that would allow for better calculation of the error, please chime in --... Jason King

06:29 AM Bug #13354: illumos should calibrate the TSC earlier in the boot process.

To provide some data points, comparing the results of calibrating the APIC with the TSC vs. the PIT (looking at the r... Jason King

2020-12-20

06:29 PM Bug #13376 (Closed): fm: variable may be used uninitialized

"git commit a92282e44f968185a6bba094d1e5fece2da819cf":https://github.com/illumos/illumos-gate/commit/a92282e44f968185... Electric Monk

12:09 PM Feature #13379 (Closed): bhyve upstream sync 2020 Dec

Sync upstream activity in FreeBSD's bhyve into illumos.
Continuing to ignore save/restore, also skipping @Add virt... Andy Fiddaman

2020-12-19

10:07 PM Bug #13378 (Closed): unknown ld(1) guidance should be a warning

unknown options to ld -zguidance are currently a debug message. They should be a warning, so it's clear something wa... Rich Lowe

08:05 PM Bug #13377 (New): units should give up on exchange rates

units(1) currently has exchange rates for several currencies, last updated in 2002 for those pinned to the euro (whic... Rich Lowe

06:02 PM Bug #13354: illumos should calibrate the TSC earlier in the boot process.

> Additionally, the Local APIC can then be calibrated with the TSC instead of the PIT timer (any X86 system illumos s... Patrick Mooney

2020-12-18

09:55 PM Bug #13376 (Closed): fm: variable may be used uninitialized

Build errors on SPARC:... Toomas Soome

09:50 PM Bug #13375 (Closed): bhyve should expose invariant TSC

When bhyve was ported to illumos, the logic for exposing the invariant TSC property was skipped. A TSC is considered... Patrick Mooney

09:17 PM Bug #13367 (Closed): beadm activate -t should not promote new BE datasets

"git commit 8b1df8bf71b7b62e7e4d46fe6b457d4d6447b2b8":https://github.com/illumos/illumos-gate/commit/8b1df8bf71b7b62e... Electric Monk

07:53 PM Bug #13374 (Closed): Port L2ARC Improvements from OpenZFS

After the initial port of persistent L2ARC, there's been several improvements we should port:... Jason King

06:53 PM Bug #6729: incremental replication stream of a fs tree with lots of snapshots trips assert in zfs recv

I tested this by running the zfs test suite. The only failures were tests with known failure. Jason King

05:10 AM Bug #6729: incremental replication stream of a fs tree with lots of snapshots trips assert in zfs recv

A followup change should also be included:... Jason King

05:23 PM Bug #13317 (Closed): Decrease contention on dn_struct_rwlock

"git commit 9704bf7fb82e71b685e194a967937ff03843e73a":https://github.com/illumos/illumos-gate/commit/9704bf7fb82e71b6... Electric Monk

04:50 PM Bug #13317: Decrease contention on dn_struct_rwlock

OpenZFS issue link: https://github.com/openzfs/zfs/pull/8946 Dan McDonald

12:01 PM Feature #13373 (Closed): Import upstream improvements to bhyve VNC server

A number of improvements have recently been made to bhyve's VNC support in FreeBSD including support for the native M... Andy Fiddaman

03:18 AM Bug #12430: Our Headers break clang

Is the clang build being used defining @__STDC_HOSTED__@ as part of it's default set of macros? IIUC, that's used to ... Jason King

03:13 AM Bug #12430: Our Headers break clang

Is this another case where the compiler tries to "fix" our headers, like GCC's fixincludes/include-fixed? If so, do ... Rich Lowe

02:36 AM Bug #12430: Our Headers break clang

I would say that anywhere there is a relatively simple pre-existing guard that a common implementation (e.g., glibc, ... Joshua M. Clulow

2020-12-17

09:28 PM Bug #13317: Decrease contention on dn_struct_rwlock

To test, I ran the zfs test suite. The only failures were tests with known issues (and existing tickets filed for them). Jason King

09:20 PM Bug #13363 (Closed): ctfconvert could support more granular ignore for missing debug data

"git commit 88a08813800ed7ba7c927986421cee437f7f2233":https://github.com/illumos/illumos-gate/commit/88a08813800ed7ba... Electric Monk

10:27 AM Bug #13363: ctfconvert could support more granular ignore for missing debug data

This new option has been integrated to OmniOS for a few weeks and is being used to selectively ignore missing DWARF d... Andy Fiddaman

09:20 PM Bug #13342: ctfconvert could encode _Float128 for 32-bit objects

"git commit 3dd4cd56e7843e01a8ab147a0d102cd4f6d732c1":https://github.com/illumos/illumos-gate/commit/3dd4cd56e7843e01... Electric Monk

09:20 PM Bug #13336 (Closed): ctfconvert should be able to unconditionally attempt conversion

"git commit 73197b540cc5f0434c409b68ca9e1a514a6ce91b":https://github.com/illumos/illumos-gate/commit/73197b540cc5f043... Electric Monk

10:24 AM Bug #13336: ctfconvert should be able to unconditionally attempt conversion

Using the new @-f@ option successfully converts the @bash@ binary linked with reduced local symbols:... Andy Fiddaman

09:20 PM Feature #13280 (Closed): CTF: provide option to truncate and continue

"git commit dd4422524768709a579a2a93a10c78a88a6b0ecb":https://github.com/illumos/illumos-gate/commit/dd4422524768709a... Electric Monk

10:21 AM Feature #13280: CTF: provide option to truncate and continue

In addition to the testing noted above, I've also done a full @wsdiff@ between gate and this branch and the only diff... Andy Fiddaman

08:24 PM Bug #12956 (Duplicate): bhyve should set TMR on intr accept

Patrick Mooney

06:11 PM Bug #12430: Our Headers break clang

It seems it is only related to the (FF)/media/ffvpx/libavutil code. So, perhaps patch this code is also an option. Carsten Grzemba

04:36 PM Bug #13301 (Closed): bhyve PIT not periodic for square wave mode

"git commit 93d78aba5b32996fc2ae893a6237a0d3972f86b2":https://github.com/illumos/illumos-gate/commit/93d78aba5b32996f... Electric Monk

2020-12-16

11:17 PM Bug #13258 (Closed): remove lint from the uts build

"git commit 0aaef2f550fa500248f59b0b8a14225b5afbd198":https://github.com/illumos/illumos-gate/commit/0aaef2f550fa5002... Electric Monk

11:10 PM Bug #13371 (New): mlxcx should delay enabling intr_n vectors until attach() is complete

We should delay enabling the ... Alex Wilson

11:06 PM Bug #13370 (Closed): mlxcx_intr_n doing redundant check on mleqe_event_type

... Alex Wilson

10:24 PM Bug #13301: bhyve PIT not periodic for square wave mode

Considering this behavior has been present in bhyve since it was ported to illumos, it's highly probable that other g... Patrick Mooney

09:07 PM Bug #13301: bhyve PIT not periodic for square wave mode

Prior to this change, a stock OVMF bootrom (running under an experimental userspace) would attempt to use the PIT in ... Patrick Mooney

08:04 PM Bug #13361 (Closed): bhyve should mask RDT cpuid info

"git commit 1a5f1879be09d3de900b2510692dd12003784d84":https://github.com/illumos/illumos-gate/commit/1a5f1879be09d3de... Electric Monk

07:22 PM Bug #13361: bhyve should mask RDT cpuid info

My most modern Intel lab machine (Ivy Bridge) is too old to possess the features in question. Its CPUID leaves stop ... Patrick Mooney

07:47 PM Bug #13369 (New): bhyve should mask PQoS bits from CPUID

Modern AMD CPUs have features similar to Intel RDT, referred to as "Platform Quality of Service Extensions". Like th... Patrick Mooney

03:39 PM Feature #13368: libbe_py should support temporary BE activation

Before this change, the library can be used to activate a new BE by providing the new BE name as a string argument.
... Andy Fiddaman

03:31 PM Feature #13368 (Closed): libbe_py should support temporary BE activation

The python libbe interface has a @beActivate@ method which currently only accepts the BE name as a parameter.
This s... Andy Fiddaman

03:30 PM Bug #13367: beadm activate -t should not promote new BE datasets

There's also another bug here which this patch fixes. Dataset promotion currently even occurs even when removing a te... Andy Fiddaman

02:22 PM Bug #13222 (Closed): Increase maximum number of fanout CPUs from 128 to 256

"git commit 3714f7be8e09c39a0ea7ce7ef44cb495ce250913":https://github.com/illumos/illumos-gate/commit/3714f7be8e09c39a... Electric Monk

02:22 PM Bug #13218 (Closed): "Stack smashing detected" panic when creating vnic over aggr with 4 mlxcx links

"git commit 3714f7be8e09c39a0ea7ce7ef44cb495ce250913":https://github.com/illumos/illumos-gate/commit/3714f7be8e09c39a... Electric Monk

02:19 PM Bug #12397 (Closed): 12254 broke the zfs test suite for older python versions

"git commit cc37296fa5ddc1ddd4012e040f797164c2a5cf5d":https://github.com/illumos/illumos-gate/commit/cc37296fa5ddc1dd... Electric Monk

02:19 PM Bug #13358 (Closed): dmu_objset_upgrade_stop() needs to wait

"git commit cc37296fa5ddc1ddd4012e040f797164c2a5cf5d":https://github.com/illumos/illumos-gate/commit/cc37296fa5ddc1dd... Electric Monk

2020-12-15

04:37 PM Bug #12397: 12254 broke the zfs test suite for older python versions

You don't seem to have the proposed patch from https://code.illumos.org/c/illumos-gate/+/1102
Andy Fiddaman

04:24 PM Bug #12397: 12254 broke the zfs test suite for older python versions

It still seems to fail for me:... Andrew Stormont

11:47 AM Bug #12397: 12254 broke the zfs test suite for older python versions

I tested the change in the attached Gerrit review by running the ZFS test suite under python 2.7, 3.7 and 3.9.
It no... Andy Fiddaman

03:36 PM Feature #13349 (Closed): ctf tests should specify -fcommon when needed

"git commit 3cec98229bf077e97e442c942c2bd8768e277449":https://github.com/illumos/illumos-gate/commit/3cec98229bf077e9... Electric Monk

03:36 PM Bug #13350 (Closed): some ctf tests still rely on default compiler arch

"git commit 3cec98229bf077e97e442c942c2bd8768e277449":https://github.com/illumos/illumos-gate/commit/3cec98229bf077e9... Electric Monk

03:36 PM Feature #13348 (Closed): ctftest should skip known failures with clang

"git commit 3cec98229bf077e97e442c942c2bd8768e277449":https://github.com/illumos/illumos-gate/commit/3cec98229bf077e9... Electric Monk

03:36 PM Bug #12232 (Closed): fix clang compiler warnings in the ctf test suite

"git commit 3cec98229bf077e97e442c942c2bd8768e277449":https://github.com/illumos/illumos-gate/commit/3cec98229bf077e9... Electric Monk

03:36 PM Bug #12231 (Closed): ctf tests should not pass -h directly to clang

"git commit 3cec98229bf077e97e442c942c2bd8768e277449":https://github.com/illumos/illumos-gate/commit/3cec98229bf077e9... Electric Monk

03:36 PM Bug #12230 (Closed): clang optimizer defeats ctf test suite

"git commit 3cec98229bf077e97e442c942c2bd8768e277449":https://github.com/illumos/illumos-gate/commit/3cec98229bf077e9... Electric Monk

03:36 PM Bug #12229 (Closed): fix ctf test check-qualifiers for clang

"git commit 3cec98229bf077e97e442c942c2bd8768e277449":https://github.com/illumos/illumos-gate/commit/3cec98229bf077e9... Electric Monk

03:29 PM Bug #13367: beadm activate -t should not promote new BE datasets

Test that temporary activation does not promote the dataset and that upon reboot back into the original BE the primar... Andy Fiddaman

02:22 PM Bug #13367 (Closed): beadm activate -t should not promote new BE datasets

At present, temporary BE activation via @beadm activate -t@ promotes the boot environment datasets of the new tempora... Andy Fiddaman

02:11 PM Feature #13366 (In Progress): Add CTF tests for new features

The parent tasks for this change introduce new parameters to the @ctfconvert@ command.
The CTF testsuite should be e... Andy Fiddaman

12:06 PM Feature #13365: Add option to testrunner to re-run just failed tests

This patch also allows the creation of a new run file with just the failing tests and supporting framework for them b... Andy Fiddaman

11:50 AM Bug #13358: dmu_objset_upgrade_stop() needs to wait

I tested the proposed fix (see attached Gerrit) by verifying directly that it fixes the leaked reference using the si... Andy Fiddaman

2020-12-14

12:13 PM Feature #13365 (Closed): Add option to testrunner to re-run just failed tests

It would be really handy if @testrunner@ supported an option to only run tests which failed on the last run.
Curre... Andy Fiddaman

11:23 AM Feature #13364 (New): mdb could handle _Float128 types in 32-bit objects

ISO/IEC TS-18661-3:2015 defines several types with analogues to existing C types. However, in the i386 ABI there is n... Andy Fiddaman

11:18 AM Bug #13363 (Closed): ctfconvert could support more granular ignore for missing debug data

In order to guard against generating objects with incomplete CTF data, @ctfconvert@ currently exits with an error if ... Andy Fiddaman

2020-12-12

07:08 PM Feature #13349: ctf tests should specify -fcommon when needed

I tested this by running the CTF test suite against a number of different compilers with both -gdwarf-2 and -gdwarf-4... Robert Mustacchi

07:08 PM Bug #13350: some ctf tests still rely on default compiler arch

I tested this by running the CTF test suite against a number of different compilers with both -gdwarf-2 and -gdwarf-4... Robert Mustacchi

07:08 PM Feature #13348: ctftest should skip known failures with clang

I tested this by running the CTF test suite against a number of different compilers with both -gdwarf-2 and -gdwarf-4... Robert Mustacchi

07:08 PM Bug #12232: fix clang compiler warnings in the ctf test suite

I tested this by running the CTF test suite against a number of different compilers with both -gdwarf-2 and -gdwarf-4... Robert Mustacchi

07:07 PM Bug #12231: ctf tests should not pass -h directly to clang

I tested this by running the CTF test suite against a number of different compilers with both -gdwarf-2 and -gdwarf-4... Robert Mustacchi

07:07 PM Bug #12230: clang optimizer defeats ctf test suite

I tested this by running the CTF test suite against a number of different compilers with both -gdwarf-2 and -gdwarf-4... Robert Mustacchi

07:07 PM Bug #12229: fix ctf test check-qualifiers for clang

I tested this by running the CTF test suite against a number of different compilers with both -gdwarf-2 and -gdwarf-4... Robert Mustacchi

01:11 PM Bug #12397 (In Progress): 12254 broke the zfs test suite for older python versions

Andy Fiddaman

12:45 PM Bug #13358: dmu_objset_upgrade_stop() needs to wait

This is a reliable reproducer for me in a bhyve VM with 16 vCPUs.... Andy Fiddaman

2020-12-11

08:28 AM Bug #13357: Hot-Plugging NVMe drive to USB-C triggers system panic

Yes, Debian Linux seems to be able to reset the bus, or a part of it (?).
See attached "debian-dmesg.txt" , search... Stephan Althaus

07:57 AM Bug #13208 (Closed): Create aggr fails when underlying links have more than 128 Tx rings

"git commit 13810335a5a8384eed97a8661536eb5352f0c933":https://github.com/illumos/illumos-gate/commit/13810335a5a8384e... Electric Monk

03:22 AM Bug #13359: mlxcx_update_link_state can race against mlxcx_register_mac

Testing done so far on cr#1100, ps#2:
* Built a SmartOS PI with updated mlxcx
** Booted on a box with a connect... Alex Wilson

03:09 AM Bug #13362 (New): bhyve PIT should count square wave properly

As discovered in #13301, some corners were cut when square wave mode was implemented for the bhyve PIT. In addition ... Patrick Mooney

02:40 AM Bug #13361: bhyve should mask RDT cpuid info

An initial test of the fix shows the guest no longer attempting to perform the @wrmsr(IA32_PQR_ASSOC)@ and dmesg is f... Patrick Mooney

02:36 AM Bug #13325 (Closed): bhyve misinterprets MSI redir hint

"git commit fe17aa88307d9cacf6677bbbe955585b11920199":https://github.com/illumos/illumos-gate/commit/fe17aa88307d9cac... Electric Monk

01:26 AM Bug #13343 (Closed): some mlxcx devices don't support temperature sensors

"git commit 15174c59605d00b59ea3aae8ba85744a42aa1e96":https://github.com/illumos/illumos-gate/commit/15174c59605d00b5... Electric Monk

12:03 AM Bug #13353 (Closed): loader: 13345 did miss byte and nvlist array

"git commit 9a2cc6e2be46528f552f7ed112fed60a329cd001":https://github.com/illumos/illumos-gate/commit/9a2cc6e2be46528f... Electric Monk

2020-12-10

10:26 PM Bug #13361: bhyve should mask RDT cpuid info

Linux also lists the RDT-related flags in cpuinfo on that system (prior to a fix): @cat_l3 cdp_l3@ Patrick Mooney

10:24 PM Bug #13361 (Closed): bhyve should mask RDT cpuid info

While bhyve currently masks the RDT_A bit ( Resource Director Technology) from leaf 0x7 EBX, it has no such filter fo... Patrick Mooney

09:46 PM Bug #13357: Hot-Plugging NVMe drive to USB-C triggers system panic

Unfortunately, IIUC there is currently no support to reset the entire USB 3 bus on that port, which is why the system... Jason King

06:59 PM Bug #13347 (Closed): loader: gfx_fb_putimage 8 bit color translation is not good

"git commit 34e16b78b1d2e5f513ee90af24e76d9703518b4c":https://github.com/illumos/illumos-gate/commit/34e16b78b1d2e5f5... Electric Monk

05:49 PM Bug #13343: some mlxcx devices don't support temperature sensors

This was tested in two ways. Paul at Racktop verified that this caused us to correctly attach regardless of presence.... Robert Mustacchi

07:55 AM Feature #13360 (Closed): loader: use BGRA RBG data in gfx functions

All image data from tem and from imported images (gfx_fb_putimage()) should only operate using BGRA data format. This... Toomas Soome

06:27 AM Bug #13359 (Closed): mlxcx_update_link_state can race against mlxcx_register_mac

After the changes to make mlxcx do all the commands during attach asynchronously, we now have a much wider window for... Alex Wilson

05:28 AM Bug #13325: bhyve misinterprets MSI redir hint

The primary test case for this was an alternate bhyve userspace utilizing the OVMF bootrom. That ROM, unlike the bhy... Patrick Mooney

03:03 AM Bug #13358 (Closed): dmu_objset_upgrade_stop() needs to wait

While running the zfs test suite on a DEBUG build, it tripped the following assertion:... Jason King

2020-12-09

09:57 PM Bug #13357: Hot-Plugging NVMe drive to USB-C triggers system panic

After "fmadm repair" the devices, and "fmadm acquit" the events,
and finally a reboot the device is back in the tree... Stephan Althaus

09:36 PM Bug #13357: Hot-Plugging NVMe drive to USB-C triggers system panic

First, i had to resize my dump volume to enable savecore..
To trigger the panic i have to boot with the drive conn... Stephan Althaus

07:57 PM Bug #13345: loader: xdr_array is missing count

I tested the now-merged wad on my lab machine which had a pool affected by this. With the fix in place, loader is ab... Patrick Mooney

06:01 AM Feature #7024 (Closed): Add getgrouplist() to illumos

"git commit f2c438c5058c64b7373448f239156bf60009abcb":https://github.com/illumos/illumos-gate/commit/f2c438c5058c64b7... Electric Monk

2020-12-08

06:37 PM Bug #13207 (Closed): Creating an aggr with more than 128 Tx or Rx rings panics

"git commit adc528899caad05412c9b8d397e277900adf786b":https://github.com/illumos/illumos-gate/commit/adc528899caad054... Electric Monk

04:16 PM Bug #13357: Hot-Plugging NVMe drive to USB-C triggers system panic

What would be very helpful is the kernel coredump (vmdump.N), or at least for starters the /var/adm/messages* portion... Dan McDonald

11:11 AM Bug #13357 (New): Hot-Plugging NVMe drive to USB-C triggers system panic

Hello!
When i plug in a NVMe drive to the Thunderbolt / USB-C Port of my laptop, the system panics.
The fmadm s... Stephan Althaus

03:11 PM Bug #13356: syslog(3c) should not open syslog_door without LOG_CONS

Review: https://www.illumos.org/rb/r/2580/ Marcel Telka

10:54 AM Bug #13356: syslog(3c) should not open syslog_door without LOG_CONS

h2. *Testing*
Compile the attached @test.c@:... Marcel Telka

10:38 AM Bug #13356 (Closed): syslog(3c) should not open syslog_door without LOG_CONS

On success, the @syslog(3c)@ always tries to open @/var/run/syslog_door@ (via @syslogd_ok()@), even this is not neede... Marcel Telka

2020-12-07

05:53 PM Feature #13355 (Closed): remove topo module warning gags

Right now there are some warning gags in the topo modules around uninitialized variables and parenthesis. We should r... Robert Mustacchi

03:26 PM Bug #13354 (Closed): illumos should calibrate the TSC earlier in the boot process.

Since time immemorial, illumos has used the i8253/8254 PIT timer to do three key tasks during boot:
* Experimentally... Jason King

11:18 AM Bug #13353 (Closed): loader: 13345 did miss byte and nvlist array

While porting 13345 to FreeBSD, I figured I have missed 2 cases... fortunately no harm is done as there is no code p... Toomas Soome

07:38 AM Bug #13345 (Closed): loader: xdr_array is missing count

"git commit 0b14c19974d0288384932500f606afeadc2d6009":https://github.com/illumos/illumos-gate/commit/0b14c19974d02883... Electric Monk

2020-12-06

11:43 PM Feature #13352 (Closed): disable mdns date and time in version string

The @dns-sd@ binary generally encodes its build time in a version string. This leads to spurious wsdiff noise and mak... Robert Mustacchi

07:01 PM Bug #13351 (Closed): loader: vbe_find_mode_xydm() is using wrong safety and iteration is buggy

We are using iterate count max mode # (0x1ff) - min vbe mode (0x100) + 1 = 0x100.
If depth is unspecified, we walk... Toomas Soome

04:27 PM Bug #13350 (Closed): some ctf tests still rely on default compiler arch

There are two ctf tests, convert-no-dwarf and merge-no-ctf, which rely on the compiler and assembler having the same ... Robert Mustacchi

04:26 PM Feature #13349 (Closed): ctf tests should specify -fcommon when needed

There are a few tests that are explicitly designed to test cases around having duplicate symbols with different types... Robert Mustacchi

04:24 PM Feature #13348 (Closed): ctftest should skip known failures with clang

There are some known bugs in clang's dwarf generation -- https://bugs.llvm.org/show_bug.cgi?id=44601. As such it'd he... Robert Mustacchi

01:04 PM Bug #13347 (Closed): loader: gfx_fb_putimage 8 bit color translation is not good

as we support 256 colors, we can translate to 256 colors; the translation itself is a bit broken.
Also, as alpha ble... Toomas Soome

2020-12-04

07:40 PM Bug #13346 (Closed): diskinfo should identify lofi(7D) devices

At least when using the labelled mode of *lofi(7D)* devices, i.e., with the @-l@ option, devices show up with other d... Joshua M. Clulow

05:19 PM Bug #13341 (Closed): crt1.o _start_crt_compiler hook not what gcc expects

"git commit 4004e4c5da2fe3ad63f4ffae758da0dadafdf00d":https://github.com/illumos/illumos-gate/commit/4004e4c5da2fe3ad... Electric Monk

04:42 PM Bug #13194 (Closed): null/dangling pointer deref somewhere under dmu_objset_upgrade

"git commit a39df08cf5d40d52f3f54886012efca9796f23c8":https://github.com/illumos/illumos-gate/commit/a39df08cf5d40d52... Electric Monk

03:56 PM Bug #13344 (Closed): loader: zfs_probe_partition should skip EFI System Partition

"git commit 553cfb3f8c093d0ed24226e160562648609d7f2f":https://github.com/illumos/illumos-gate/commit/553cfb3f8c093d0e... Electric Monk

2020-12-03

10:19 PM Bug #13345 (Closed): loader: xdr_array is missing count

The integer arrays are encoded in nvlist as counted array <count, i0, i1...>, loader xdr_array() is missing the count... Toomas Soome

10:11 PM Bug #13344 (In Progress): loader: zfs_probe_partition should skip EFI System Partition

Toomas Soome

10:11 PM Bug #13344 (Closed): loader: zfs_probe_partition should skip EFI System Partition

We can skip probing ESP, there is no ZFS on ESP.
Testing done: verified with debugger, we do skip probing ESP now. Toomas Soome

05:30 AM Bug #13194: null/dangling pointer deref somewhere under dmu_objset_upgrade

I cherry-picked cr 1087 onto omnios r151034 to test it on one of our machines which was very reliable at hitting the ... Alex Wilson

2020-12-02

06:15 PM Bug #13340 (Closed): zoneadmd shouldn't rely on autofs

"git commit 8af575c0afc1d79bd23c3e1a78a546c9963e5083":https://github.com/illumos/illumos-gate/commit/8af575c0afc1d79b... Electric Monk

05:40 PM Bug #13343 (Closed): some mlxcx devices don't support temperature sensors

The Mellanox ConnectX-4 lx (15b3,1015), unlike other parts, appears not to have a built-in temperature sensor. Unfort... Robert Mustacchi

04:52 PM Bug #13333 (Closed): spellcheck1 doesn't zero table memory

"git commit 2e8cdddb340293882c888e83152059f02ec5d59b":https://github.com/illumos/illumos-gate/commit/2e8cdddb34029388... Electric Monk

2020-12-01

11:46 PM Bug #13324 (Closed): struct dk_minfo_ext size differences trigger SSP in libfdisk

"git commit 7b4214534ccdf6f8aa6e566d7501aab328c72e84":https://github.com/illumos/illumos-gate/commit/7b4214534ccdf6f8... Electric Monk

08:43 PM Bug #13324: struct dk_minfo_ext size differences trigger SSP in libfdisk

To test this I rigged up a system that had an nvme device (blkdev), a sata device (sd), a labeled lofi device (lofi),... Robert Mustacchi

09:46 PM Bug #13332 (Closed): loader: iterate consoles to draw loader menu screen

"git commit 63f9f2ff473e9cb7f455f032fe3d04a95ec4b537":https://github.com/illumos/illumos-gate/commit/63f9f2ff473e9cb7... Electric Monk

07:06 PM Bug #13333: spellcheck1 doesn't zero table memory

I tested this by checking the outputs of the hash checker and the input files and then ran several builds and verifie... Robert Mustacchi

03:42 PM Bug #13194: null/dangling pointer deref somewhere under dmu_objset_upgrade

With this change in place, I ran a full ZFS testsuite under a DEBUG kernel. The results are:... Andy Fiddaman

12:26 PM Bug #13194: null/dangling pointer deref somewhere under dmu_objset_upgrade

Details from one of my crash dumps:... Andy Fiddaman

01:12 PM Bug #13340: zoneadmd shouldn't rely on autofs

To test this, I ran it on our Racktop platform and triggered the error path during zone shutdown to reproduce the abo... Jerry Jelinek

07:17 AM Bug #13331 (Closed): loader: term_drawrect and putimage coordinates fix

"git commit 166994016fed8bc2ed47612b34708b33007a891b":https://github.com/illumos/illumos-gate/commit/166994016fed8bc2... Electric Monk

04:03 AM Bug #13050 (Closed): bhyve kernel should be cstyle clean

"git commit 2699b94cd4d1e9baf6bfcbe579328b398a9736e6":https://github.com/illumos/illumos-gate/commit/2699b94cd4d1e9ba... Electric Monk

2020-11-30

11:10 PM Bug #13050: bhyve kernel should be cstyle clean

In addition to @wsdiff(1)@ reporting no changes of significance to the program text, I ran the build artifacts throug... Patrick Mooney

08:03 PM Bug #13050: bhyve kernel should be cstyle clean

Comprised of style changes, this can mostly be tested with @wsdiff(1)@. Comparing it against a vanilla proto area, t... Patrick Mooney

08:21 PM Bug #13194: null/dangling pointer deref somewhere under dmu_objset_upgrade

A couple of other OmniOS users have recently hit this, and I think it is the same as https://github.com/openzfs/zfs/i... Andy Fiddaman

02:01 PM Bug #13342 (Closed): ctfconvert could encode _Float128 for 32-bit objects

When working on implementing CTF everywhere in OmniOS userland, some 32-bit objects that use the _Float128 type fail ... Andy Fiddaman

12:13 PM Bug #13341: crt1.o _start_crt_compiler hook not what gcc expects

In addition to testing that gcc's profiling now works as expected, I also tested what happens if the hook returns a... Andy Fiddaman

12:13 AM Bug #13341 (Closed): crt1.o _start_crt_compiler hook not what gcc expects

As can be seen in https://github.com/gcc-mirror/gcc/blob/master/libgcc/config/sol2/crtpg.c#L34 - gcc uses a hook in @... Andy Fiddaman

2020-11-28

10:06 AM Feature #13339: Add support for Hygon Dhyana Family 18h processor

Some system information:
~$ isainfo -x
amd64: clzero monitorx clflushopt fsgsbase rdseed adx avx2 fma bmi2 bmi1 rdran... Wen Pu

2020-11-27

08:36 PM Bug #13330 (Closed): SMB read hangs on Mac Big Sur

"git commit 4d2aba2f17eed4643aa996841698226ff2673205":https://github.com/illumos/illumos-gate/commit/4d2aba2f17eed464... Electric Monk

04:20 PM Bug #13330: SMB read hangs on Mac Big Sur

Thanks to Andy Fiddiman (and others) for testing this fix with Mac Big Sur clients.
Those clients no longer "hang" (i... Gordon Ross

06:40 PM Bug #13337 (Closed): ctfconvert should skip ssp_ns.c when checking for debug data

"git commit 41b57d181d0b4df0badc148a4769e9d0bf008aaa":https://github.com/illumos/illumos-gate/commit/41b57d181d0b4df0... Electric Monk

03:39 PM Bug #8151: USB3 port not working

Hi, we discovered that the problem is the same as :
https://github.com/joyent/smartos-live/issues/694
Maybe it ... paolo marcheschi

12:33 PM Bug #13340 (Closed): zoneadmd shouldn't rely on autofs

During zone filesystem unmounting, it is possible for zoneadmd to call into autofs_cleanup
which directly makes a sy... Jerry Jelinek

2020-11-26

07:12 PM Bug #13337: ctfconvert should skip ssp_ns.c when checking for debug data

Tested by running @ctfconvert@ on a 32-bit object linked with libssp_ns which previous failed:... Andy Fiddaman

06:39 PM Bug #13258: remove lint from the uts build

tested just by running repeated builds, though only two on sparc. Rich Lowe

11:49 AM Feature #13339 (Closed): Add support for Hygon Dhyana Family 18h processor

As a new x86 CPU vendor, Chengdu Haiguang IC Design Co., Ltd (Hygon)
is a joint venture between AMD and Haiguang Inf... Wen Pu

2020-11-25

07:56 PM Bug #13338 (Closed): bhyve should be able to emulate CLTS

When shadowing @%cr0@, it becomes necessary to do instruction emulation for certain @%cr0@ accesses. SVM has decodin... Patrick Mooney

06:51 PM Bug #13337 (Closed): ctfconvert should skip ssp_ns.c when checking for debug data

If a 32-bit ELF object is built with stack smashing protection (SSP) and PIC and is using the illumos native SSP su... Andy Fiddaman

03:17 PM Bug #13336 (Closed): ctfconvert should be able to unconditionally attempt conversion

On OmniOS and OpenIndiana, the @bash@ shell is linked with @-z redlocsym@, a flag which eliminates local symbols from... Andy Fiddaman

09:29 AM Bug #13060 (Closed): loader: fb-putimage fails silently even with debug flag set

"git commit d45f07cb8d28ca0e38cd96d8f00243ba58192eec":https://github.com/illumos/illumos-gate/commit/d45f07cb8d28ca0e... Electric Monk

12:58 AM Bug #13335 (New): wscons should interpret keypad plus and minus correctly

At present, it seems that depressing the keypad @+@ (plus) and @-@ (minus) keys on a PC keyboard produces an unhelpfu... Joshua M. Clulow

12:09 AM Bug #13334 (Closed): Recognize X710 10GBaseT*L Family

An OmniOS user reports that PCI ID 8086,15ff does not have i40e attach. A quick source dive confirms we do not suppo... Dan McDonald

2020-11-24

08:42 PM Bug #13133 (Duplicate): SVM event injection can race in bhyve

Patrick Mooney

08:42 PM Bug #13259 (Closed): SVM event injection can race in bhyve

"git commit c74a40a584c9d875009f725565896fd7e8ee38d6":https://github.com/illumos/illumos-gate/commit/c74a40a584c9d875... Electric Monk

06:21 AM Bug #13259: SVM event injection can race in bhyve

As noted in the description, instances of this race causing a problem have not been observed in the wild or during te... Patrick Mooney

08:42 PM Bug #13132 (Closed): VMX event injection can race in bhyve

"git commit c74a40a584c9d875009f725565896fd7e8ee38d6":https://github.com/illumos/illumos-gate/commit/c74a40a584c9d875... Electric Monk

06:21 AM Bug #13132: VMX event injection can race in bhyve

As noted in the description, instances of this race causing a problem have not been observed in the wild or during te... Patrick Mooney

08:42 PM Bug #13106 (Closed): clarify PPR transitions in bhyve vLAPIC

"git commit c74a40a584c9d875009f725565896fd7e8ee38d6":https://github.com/illumos/illumos-gate/commit/c74a40a584c9d875... Electric Monk

05:26 AM Bug #13106: clarify PPR transitions in bhyve vLAPIC

As this arose as part of the #13007 work, testing for it was covered under that wad. Patrick Mooney

08:42 PM Bug #13007 (Closed): bhyve vlapic should set TMR on intr accept

"git commit c74a40a584c9d875009f725565896fd7e8ee38d6":https://github.com/illumos/illumos-gate/commit/c74a40a584c9d875... Electric Monk

05:16 PM Bug #13007: bhyve vlapic should set TMR on intr accept

I did also confirm that the exception injection paths were exercised. Guests such as Linux typically access some MSR... Patrick Mooney

04:02 PM Bug #10525: wsdiff output is not correct for a binary file

The underlying cause of the differences in hlista and hlistb are in #13333. Robert Mustacchi

03:53 PM Bug #13333 (Closed): spellcheck1 doesn't zero table memory

Having mostly ignored the wsdiff noise that ocasionally pops up between hlista and hlistb, I decided to reverse cours... Robert Mustacchi

02:07 AM Bug #13299 (In Progress): File mtime changes twice, when file is modified using SMB server

It looks like that update (during close) was from a possibly misunderstood section from a very old version of the MS-... Gordon Ross

01:25 AM Feature #7024: Add getgrouplist() to illumos

I've put together an implementation of this.
For testing, I created a test user and added the test user to the sys... Jason King

01:00 AM Bug #13330 (In Progress): SMB read hangs on Mac Big Sur

What's actually shown in the network capture is that MacOS "Big Sur" repeatedly sends
SMB2 read requests at an offse... Gordon Ross

2020-11-23

10:54 PM Bug #13332 (Closed): loader: iterate consoles to draw loader menu screen

The current loader screen output depends on console code to write on all active consoles. This approach is flawed as ... Toomas Soome

10:47 PM Bug #13331 (Closed): loader: term_drawrect and putimage coordinates fix

While drawing on menu screen, we also do mark terminal areas, so the scroll will know to move the image areas. Unfort... Toomas Soome

07:27 PM Bug #13315 (Closed): jdk11 makes consistent javadoc generation impossible

"git commit 273d774d1d685415fd99d31224bdae55e7cfb793":https://github.com/illumos/illumos-gate/commit/273d774d1d685415... Electric Monk

07:20 PM Bug #13330 (Closed): SMB read hangs on Mac Big Sur

There have been several reports of problems with accessing illumos SMB shares from MacOS Big Sur, on both Intel and M... Andy Fiddaman

06:59 PM Bug #13007: bhyve vlapic should set TMR on intr accept

Additionally, I've been using this wad (with several others) when developing an alternative bhyve userspace implement... Patrick Mooney

05:57 PM Bug #13007: bhyve vlapic should set TMR on intr accept

I've repeated the OS smoke tests on Intel and AMD with a rebased copy of the change and it continues to behave as exp... Patrick Mooney

06:52 PM Bug #13314 (Closed): loader: make sure console variable has usable consoles

"git commit 560dcad7f6059e242335a94501511eae11b1308a":https://github.com/illumos/illumos-gate/commit/560dcad7f6059e24... Electric Monk

05:33 PM Bug #12318 (Closed): build zpool command as 64-bit binary

"git commit 18425b359c7d1e5f7f63fae3ca5245407223a45b":https://github.com/illumos/illumos-gate/commit/18425b359c7d1e5f... Electric Monk

05:28 PM Bug #13319 (Closed): Typos in some LDSTACKPROTECT macros

"git commit a39905c1c6671c3f44d52e31393ee7cdda7b4f12":https://github.com/illumos/illumos-gate/commit/a39905c1c6671c3f... Electric Monk

05:07 PM Bug #13060: loader: fb-putimage fails silently even with debug flag set

Testing: I came up with this change after seeing loader silently fail to load a PNG and not having any idea why. Wit... Andrew Stormont

04:24 PM Bug #13329 (New): rpcsec & friends need to be zone-aware

Inspired by this smartos-live filing: https://github.com/joyent/smartos-live/issues/963, I dove into the source to s... Dan McDonald

02:55 PM Bug #13326: nscd stops returning results from LDAP until it is restarted (GSSAPI)

Actually, I think this is related to a customization I had done previously:... Cullum Smith

01:21 PM Bug #13326: nscd stops returning results from LDAP until it is restarted (GSSAPI)

This is actually *not* related to GSSAPI authentication. I'm now reproducing it with anonymous authentication as well... Cullum Smith

07:46 AM Bug #13328 (New): svc:/system/svc/restarter:default is sometimes not initialized properly

Dependencies are given placeholder entries in the SMF dependency graph which are usually fleshed out when their manif... Andrew Stormont