illumos gate

2021-12-29

09:05 PM Bug #14257: Errors for ct_pr_event_get_senderct in the manual

Testing: viewed the revised page with the man utility. Peter Tribble

02:04 PM Bug #14353 (Closed): crypto_mech2id should take unlimited string argument

Build errors with gcc 11:... Toomas Soome

01:56 PM Bug #14352 (Closed): sha1: mismatched bound

Build error with gcc 11:... Toomas Soome

01:51 PM Bug #14351 (Closed): mwl: mismatched bound

Build errors with gcc 11:... Toomas Soome

01:39 PM Bug #14350 (Closed): uath: mismatched bound

Build errors with gcc 11:... Toomas Soome

01:30 PM Bug #14349 (Closed): libcrypt: mismatched bound

Build errors with gcc 11:... Toomas Soome

12:57 PM Bug #14348 (Closed): libdbm: mismatched bound

Build errors with gcc 11:... Toomas Soome

12:48 PM Bug #14347 (Closed): ed: mismatched bound

Build error with gcc 11:... Toomas Soome

12:12 PM Bug #14346 (Closed): loader: add __alloc_size2

The old version of cdefs.h and stdlib.h were using __attribute__((__alloc_size__(x))), the more recent compilers also... Toomas Soome

11:57 AM Bug #14345 (Closed): Manual titles should be upper case

Titles in manual pages are expected to be upper case. Running mandoc -Tlint -Wstyle will pick up on this amongst othe... Peter Tribble

11:53 AM Bug #14344 (Closed): libnisdb: ISO C++17 does not allow 'register' storage class specifier

Build errors with gcc 11:... Toomas Soome

11:01 AM Bug #14343 (Closed): ufs: array subscript 'struct direct[0]' is partly outside array bounds

Build error with gcc 11:... Toomas Soome

12:14 AM Bug #14342 (Closed): svccfg cleanup dumps core in create_instance_list

We are seeing the svccfg cores on a bit older systems after initial installation:... Yuri Pankov

2021-12-28

06:34 PM Bug #14341 (New): hid_set_protocol() logging arguments in wrong order

In @hid_set_protocol()@ if the request fails, the logging statement is... Jason King

05:49 PM Bug #14329: sys/atomic.h: 5066 got the order of ifdef/endif wrong

Note, the impact of this is pretty small as the ifdef in question is actually @#if defined(_KERNEL) || defined(_INT64... Robert Mustacchi

02:15 PM Bug #14340 (Closed): libbe: 'menu_fp' may be used uninitialized

Build errors with gcc 11:... Toomas Soome

04:29 AM Feature #14323: Note new PCIe caps from the PCI-SIG

I tested this by running the util tests which covers some minor pcieadm bits:... Robert Mustacchi

04:09 AM Feature #14324: December 2021 hwdata update

I tested this by verifying prtconf still showed hwdata and then running the pcidb test suite:... Robert Mustacchi

2021-12-27

11:40 PM Bug #14339 (Closed): bhyve: build errors with gcc 11

Need to suppress gcc 11, but also:... Toomas Soome

11:35 PM Bug #14338 (Closed): units: this 'if' clause does not guard...

Build errors with gcc 11:... Toomas Soome

11:30 PM Bug #14337 (Closed): tail: this 'if' clause does not guard...

Build error with gcc 11:... Toomas Soome

11:22 PM Bug #14336 (Closed): elfdump: this 'if' clause does not guard...

Build errors with gcc 11:... Toomas Soome

11:18 PM Bug #14335 (Closed): nscd: this 'if' clause does not guard...

Build error with gcc 11:... Toomas Soome

11:06 PM Bug #14334 (Closed): hal: this 'if' clause does not guard...

Build errors with gcc 11:... Toomas Soome

10:59 PM Bug #14333 (Closed): libsmedia: this 'if' clause does not guard...

Build errors with gcc 11:... Toomas Soome

10:52 PM Bug #14332 (Closed): pcfs: this 'if' clause does not guard...

Build error with gcc 11:... Toomas Soome

10:30 PM Bug #14331 (Closed): mr_sas: this 'if' clause does not guard...

Build error with gcc 11:... Toomas Soome

09:47 PM Bug #14330 (Closed): make: too few arguments to function getname_fn

Build errors with gcc 11:... Toomas Soome

06:38 PM Bug #14329 (Closed): sys/atomic.h: 5066 got the order of ifdef/endif wrong

As mentioned by r1mikey on IRC, sys/atomic.h is missing endif on line 56 and essentially all functions below are hidd... Yuri Pankov

2021-12-26

05:54 PM Bug #14313 (Closed): smbios(1) does not check for success on libsmbios calls

"git commit a7aaa5137d50ab434a012fa67192f75b383f3d48":https://github.com/illumos/illumos-gate/commit/a7aaa5137d50ab43... Electric Monk

05:54 PM Bug #14312 (Closed): bhyve smbios type 3 structure is incorrect

"git commit 058c1d469107d655c5b92e9ffb2f0d30314f9e78":https://github.com/illumos/illumos-gate/commit/058c1d469107d655... Electric Monk

2021-12-24

11:53 AM Bug #14328 (Closed): cscope-fast: this 'if' clause does not guard...

Build errors with gcc 11:... Toomas Soome

11:38 AM Bug #14327 (Closed): make: ISO C++17 does not allow 'register' storage class specifier

gcc 11/clang complains. Also done some cstyle cleanup.
Testing done: build/install/boot Toomas Soome

11:20 AM Bug #14326 (Closed): dt_unring_buf: set dtbd_oldest to the start of the first record

Work by Andriy Gapon:
It was set to the start of the buffer and that can be different from the
start of the first... Toomas Soome

2021-12-23

08:51 PM Bug #14319: ld shouldn't warn about SHF_EXCLUDE unknown sections

testing:
test suite addition, test suite run, build, wsdiff, boot, manually check with chosen objects built using ... Rich Lowe

12:19 AM Bug #14319 (Closed): ld shouldn't warn about SHF_EXCLUDE unknown sections

If we encounter a section with an unknown type in the OS specific range, we current emit a warning, but move on with ... Rich Lowe

04:40 PM Bug #14312: bhyve smbios type 3 structure is incorrect

This was tested on my behalf by Andy Fiddaman. In this case he booted an OmniOS and Debian guest and verified that th... Robert Mustacchi

04:39 PM Bug #14313: smbios(1) does not check for success on libsmbios calls

Because the smbios test suite does not use the smbios(1) command, I went through and tested this manually in a few wa... Robert Mustacchi

03:12 PM Feature #14324 (Closed): December 2021 hwdata update

We're a bit overdue to sync up with the upstream hwdata files. This goes through and does that. Robert Mustacchi

03:03 PM Feature #14323 (Closed): Note new PCIe caps from the PCI-SIG

The PIC Code and ID Assignment Specification Revision 1.14 was recently made available. This introduces a few new cap... Robert Mustacchi

02:38 PM Bug #14322 (New): Remote OmniOS SMB user/group management via Windows computermanagement not working

I have problems using Windows computermanagement to edit groups and users remotely.
What I have done (current Window... Guenther Alka

12:54 PM Bug #14321 (In Progress): loader.efi: to preserve heap space, use AllocatePages() for shadow_fb

shadow FB size could be rather large and depends on resolution,
instead of using heap, allocate dedicated space outs... Toomas Soome

12:33 PM Bug #14320 (In Progress): loader.efi: Do not use as frame buffer BLT-only GOPs.

Pulled from FreeBSD:
Author: Alexander Motin <mav@FreeBSD.org>
Kernel needs physical frame buffer address and s... Toomas Soome

2021-12-22

11:54 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

Andy Fiddaman wrote in #note-9:
> Make the idmap.d file executable and run it with that as the argument.
oh duh. ... Lee Damon

11:02 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

Make the idmap.d file executable and run it with that as the argument.... Andy Fiddaman

08:54 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

Yuri Pankov wrote in #note-7:
> Apparently you are missing the @-p `pgrep smbd`@ part in command.
Where would tha... Lee Damon

03:48 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

Lee Damon wrote in #note-6:
> [...]
Apparently you are missing the @-p `pgrep smbd`@ part in command. Yuri Pankov

03:44 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

... Lee Damon

08:49 PM Feature #14308 (Closed): discard SHF_EXCLUDE sections when linking kernel modules

"git commit c9d20e659e1e8b7bc9bd0d5c3ff5fe49be65bc6a":https://github.com/illumos/illumos-gate/commit/c9d20e659e1e8b7b... Electric Monk

08:26 PM Bug #13990: nfssrv: get rid of one crget for nfsv4

Result of testing.
For NFSv4
without fix from review for ozone workload (iozone -A -g 1g -r 64K -I) dtrace script s... Vitaliy Gusev

2021-12-21

11:17 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

Could you try running this d script?
Put it in a file such as @idmap.d@ and run as:... Andy Fiddaman

10:25 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

... Lee Damon

10:18 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

For the record, this is what I have set for idmap.... Lee Damon

10:15 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

... Lee Damon

10:09 PM Bug #14306: Can't get SID for ID=0 type=0, status=-9977

At andyf's suggestion I ran the following dtrace:... Lee Damon

04:56 PM Bug #13990: nfssrv: get rid of one crget for nfsv4

Adam Stylinski wrote in #note-2:
> Ping on this? We were seeing some NFS performance issues a while back while hitt... Vitaliy Gusev

02:57 PM Bug #13990: nfssrv: get rid of one crget for nfsv4

Ping on this? We were seeing some NFS performance issues a while back while hitting a particularly heavy random read... Adam Stylinski

06:54 AM Feature #14269: mdb could support separators in numbers

I've tested this in a few ways. With the mdb test suite:... Robert Mustacchi

2021-12-19

08:21 PM Bug #14317 (Closed): mdb misprints certain bitfields

While working through some cases, I noticed that mdb was misprinting a bitfield. Looking into the details, the proble... Robert Mustacchi

08:15 PM Feature #14316 (Closed): want means to leverage ctfconvert in one go in the build

While ctfconvert has added the ability to do a conversion of al linked object, there is no way to currently take adva... Robert Mustacchi

02:16 AM Bug #14315 (New): NFS share triggered a zero-sized sleeping allocation warning

I did share -F nfs -o rw /mnt and got the console warning about sleeping zero sized allocations
mdb says... Rich Lowe

2021-12-18

11:09 PM Bug #14264 (Closed): kstat_lookup and friends should take const strings

"git commit 617b28ccfac40348ebae033171d0643fcca18c22":https://github.com/illumos/illumos-gate/commit/617b28ccfac40348... Electric Monk

11:09 PM Bug #14271 (Closed): libkstat leaks kstat fd across exec

"git commit 92c32ccad68fb065a366d11e8f3dfcd5c6ebae94":https://github.com/illumos/illumos-gate/commit/92c32ccad68fb065... Electric Monk

11:09 PM Feature #14270 (Closed): convert man3kstat to mdoc

"git commit 0be687ea0c09cd50b4ae51df829900fea257d535":https://github.com/illumos/illumos-gate/commit/0be687ea0c09cd50... Electric Monk

10:27 PM Feature #14314 (Closed): convert 3uuid to mdoc

As part of our mandoc conversion efforts, this takes care of all pages in 3UUID. Robert Mustacchi

08:51 PM Feature #14308: discard SHF_EXCLUDE sections when linking kernel modules

testing:
Test suite additions, illumos build and boot, building a given kernel object with clang (I picked one whi... Rich Lowe

08:00 PM Bug #14302 (Closed): Makefile.lib: -h soname should be passed to linker

"git commit 73a801acfbef73aca0012eca23d6a1b842f5a104":https://github.com/illumos/illumos-gate/commit/73a801acfbef73ac... Electric Monk

07:38 PM Bug #14313 (Closed): smbios(1) does not check for success on libsmbios calls

Many libsmbios invocations from smbios(1) do not actually check for success. This was made a bit more obvious by rece... Robert Mustacchi

07:35 PM Bug #14312 (Closed): bhyve smbios type 3 structure is incorrect

bhyve has its own definition of the type 3 chassis structure as follows:... Robert Mustacchi

2021-12-17

10:38 PM Bug #14311 (Closed): yacc: clang build cleanup

while condition needs ().
While there, clean up some...
testing done. nightly run. but not just nightly; becaus... Toomas Soome

10:00 PM Bug #14310 (Closed): lex: output modern c

The immediate issue is about generating flat initializers, while more recent compilers are suggesting to use { } to g... Toomas Soome

09:56 PM Bug #14305 (Closed): Sync the tod chip following ntp_adjtime(MOD_FREQUENCY)

"git commit c538cdc56b01e46a42335d3f8d315c44ecf91ac9":https://github.com/illumos/illumos-gate/commit/c538cdc56b01e46a... Electric Monk

02:14 PM Bug #14305: Sync the tod chip following ntp_adjtime(MOD_FREQUENCY)

I've tested this change by running @ntpsec@ and @chrony@ separately on a patched system and confirming that the clock... Andy Fiddaman

08:58 PM Bug #14303 (Closed): libipadm depends on libipmp

"git commit feb562904dda8e3f95142866f81038eaef927433":https://github.com/illumos/illumos-gate/commit/feb562904dda8e3f... Electric Monk

05:20 PM Bug #14309 (New): smb(4) out of sync with cmd/smbsrv/smbd/server.xml after 1122 and 11033

smb(4) says:
signing_enabled
... Valid values are true
and false. The default valu... Bill Sommerfeld

05:06 PM Bug #14258 (Closed): The manual should follow RFC 2606

"git commit 338d6fc1b322c01b220f204edde962e843478a78":https://github.com/illumos/illumos-gate/commit/338d6fc1b322c01b... Electric Monk

04:21 PM Bug #14258: The manual should follow RFC 2606

Tested by viewing the revised pages using the man utility. Peter Tribble

04:18 PM Feature #13914: smbd encrypt_cipher property should list enabled ciphers explicitly

The changes were tested manually on omnios based system. The smb/server
smbd/encrypt_cipher property was set to diff... Alexander Stetsenko

03:59 PM Feature #14274 (Closed): fix a few broken pkg aliases

"git commit eabc1bc5e61dbfdd2fc3cb588315c864d621d500":https://github.com/illumos/illumos-gate/commit/eabc1bc5e61dbfdd... Electric Monk

02:36 PM Bug #14264: kstat_lookup and friends should take const strings

To test this I ran a @kstat -p@ before and after this change. I then opened the two files up in vimdiff. While there ... Robert Mustacchi

02:35 PM Bug #14271: libkstat leaks kstat fd across exec

To test this I reran the above test program with the fixed library and a pfiles of the resulting process no longer sh... Robert Mustacchi

02:34 PM Feature #14270: convert man3kstat to mdoc

This was tested by looking at the new pages in man. Robert Mustacchi

2021-12-16

11:34 PM Feature #14308 (Closed): discard SHF_EXCLUDE sections when linking kernel modules

As with other "final" output from the link-editor, kernel modules should not contain sections with the SHF_EXCLUDE fl... Rich Lowe

09:03 PM Bug #11679: vn_rele() and friends should VERIFY after mutex

You could look at this the other way too:
Let's assume it is expected (designed) that @v_count@ cannot become zero... Marcel Telka

07:56 PM Bug #11679: vn_rele() and friends should VERIFY after mutex

I would probably make the if an if/else and stick the VERIFY in the else arm. I can't imagine that would have a big ... Joshua M. Clulow

07:24 PM Bug #11679: vn_rele() and friends should VERIFY after mutex

Maybe the reason to have the @VERIFY()@ call outside the mutex is simply to save few cycles to make sure the mutex is... Marcel Telka

08:19 PM Bug #14307 (Closed): loader: bcache: Fix debug printf

Picked up fix from FreeBSD:
Use %j to it works on 64 and 32 bits system.
Testing done: build with #define BCACH... Toomas Soome

08:04 PM Bug #14306 (New): Can't get SID for ID=0 type=0, status=-9977

My /var/adm/messages log is filling up with these messages from sbmd. This isn't the first time this has happened and... Lee Damon

07:51 PM Bug #14260: bhyve PICs should use unsigned levels

The old (signed integer) logic dealing with interrupt pin levels did nothing when those values would overflow/underfl... Patrick Mooney

03:23 PM Bug #14301 (Closed): krtld/doreloc.c: missing field

"git commit 11793bb31eb2b286350e5fd9757d966261d0cff5":https://github.com/illumos/illumos-gate/commit/11793bb31eb2b286... Electric Monk

03:21 PM Bug #14280 (Closed): loader: use shadow framebuffer

"git commit 554e720a4cb6223d6736bd96950f9ad7d853f2a9":https://github.com/illumos/illumos-gate/commit/554e720a4cb6223d... Electric Monk

11:11 AM Bug #14305 (Closed): Sync the tod chip following ntp_adjtime(MOD_FREQUENCY)

We encountered a problem in OmniOS when using the @chrony@ (https://chrony.tuxfamily.org/) time synchronisation daemo... Andy Fiddaman

01:08 AM Bug #14304 (New): testrunner fails while handling exceptions

... Rich Lowe

2021-12-15

11:15 PM Bug #14303 (Closed): libipadm depends on libipmp

Need to add libipmp to dependency list for libipadm in usr/src/lib/Makefile.
Testing done: serial build in usr/src... Toomas Soome

06:11 PM Bug #14302 (Closed): Makefile.lib: -h soname should be passed to linker

clang does not accept -h. Just use -Wl,...
Testing done: build/install/boot (with gcc). Toomas Soome

05:07 PM Feature #14141 (Closed): build utmpd as 64-bit binary

"git commit 2c181cc4d9d2e7a92c98a12cafffc6dadff80019":https://github.com/illumos/illumos-gate/commit/2c181cc4d9d2e7a9... Electric Monk

10:42 AM Bug #14301 (Closed): krtld/doreloc.c: missing field

Build errors with clang:... Toomas Soome

07:50 AM Bug #13098: Low output level from audio devices

Some additional information regarding the topic from my perspective/case
I am happy with the output volume (laptop i... Stephan Althaus

2021-12-14

11:26 PM Bug #14300 (Closed): mbh_patch: comparison of integers of different signs

Build errors:... Toomas Soome

10:03 PM Feature #14087 (Closed): Bhyve exposes dirty page tracking interface

"git commit 8779b44894428ca4ea78d1bfe5381291f62e9c7d":https://github.com/illumos/illumos-gate/commit/8779b44894428ca4... Electric Monk

06:36 PM Feature #14087: Bhyve exposes dirty page tracking interface

(test program attached.) Dan Cross

07:01 PM Bug #14285 (Closed): check_rtime should recommend -fpic not -Kpic

"git commit 532883ab3269bdf14c55e45838bc9ae275d70ed5":https://github.com/illumos/illumos-gate/commit/532883ab3269bdf1... Electric Monk

07:01 PM Feature #14284 (Closed): check_rtime should check kernel modules

"git commit 0910f6b57d8ca5550c60180007b9cdeaabc88f1b":https://github.com/illumos/illumos-gate/commit/0910f6b57d8ca555... Electric Monk

07:01 PM Bug #14268 (Closed): kernel modules should be linked -ztype=kmod

"git commit 82d0151a507442720a3aea34c8925041894ab173":https://github.com/illumos/illumos-gate/commit/82d0151a50744272... Electric Monk

06:48 PM Bug #14299 (In Progress): in.tftpd: should not sleep before sending NAK

loading and running loader on tftpfs is very slow because attempts to read non-existing files is slowing us down. App... Toomas Soome

05:12 PM Feature #14290: cxgbe: need link speed change when autoneg is disabled

Following changes are added in the patch:
1) Rework and group link related common code to ease translating link pa... Rahul Lakkireddy

01:20 AM Feature #14274: fix a few broken pkg aliases

For testing I just did full debug and non-debug builds. Robert Mustacchi

2021-12-13

04:49 PM Bug #14296: segfault on reboot in ficlVmInnerLoop

Toomas Soome wrote in #note-2:
>
> 8037dcc/S but also, we do have ficlVmExecuteString(ficlVm *vm, ficlString s) an... Ryan Zezeski

04:33 PM Feature #14298 (Closed): snoop could know more DNS resource record types

"git commit ffe0b5fa2f11b603291b4b98b4f727bc8c8dbd9c":https://github.com/illumos/illumos-gate/commit/ffe0b5fa2f11b603... Electric Monk

02:05 PM Bug #13098: Low output level from audio devices

A slightly related bug is this one: 10619 audiohd ignores digital output pins such as HDMI/DP
Gary Mills

09:13 AM Bug #13098: Low output level from audio devices

Jeremy Andrews wrote in #note-3:
> I definitely encountered this issue, but I assumed the low level of audio output ... Joshua M. Clulow

2021-12-12

09:44 PM Bug #14283 (Closed): ldd should not complain about non-executable shared objects

"git commit 01355ae8e99e2965e664160bdd8ac9f0fdc1329c":https://github.com/illumos/illumos-gate/commit/01355ae8e99e2965... Electric Monk

04:08 PM Bug #13098: Low output level from audio devices

I definitely encountered this issue, but I assumed the low level of audio output was intentional behavior rather than... Jeremy Andrews

2021-12-11

06:18 PM Feature #14298: snoop could know more DNS resource record types

Testing:
On one terminal started @snoop port 53@
On another trigger dns queries like:... Sebastian Wiedenroth

05:44 PM Feature #14298 (Closed): snoop could know more DNS resource record types

A while ago I noticed that snoop did not know about a few record types I was interested in (specifically SRV and CAA)... Sebastian Wiedenroth

02:34 PM Bug #14296: segfault on reboot in ficlVmInnerLoop

Ryan Zezeski wrote:
> Encountered a segfault when running `reboot`. This was on a nightly build and I was trying to ... Toomas Soome

2021-12-10

08:30 PM Bug #14297 (Closed): ipmgmtd crash on zone boot

"git commit 47c607a3073a2acd65c934fe1e6967b2aa0094d8":https://github.com/illumos/illumos-gate/commit/47c607a3073a2acd... Electric Monk

04:37 PM Bug #14297: ipmgmtd crash on zone boot

With the associated fix in place, the zone boots properly and networking is up:... Andy Fiddaman

04:15 PM Bug #14297 (Closed): ipmgmtd crash on zone boot

A number of OmniOS users have reported that zone networking is not coming up properly in recent OmniOS bloody builds.... Andy Fiddaman

08:12 PM Bug #14283: ldd should not complain about non-executable shared objects

testing:
Checked no warning on non-exec shared libs now.
Checked still warning on non-exec dynamic executables Rich Lowe

08:55 AM Feature #14289: cxgbe: update firmware version to 1.26.4.0

Ryan Zezeski wrote in #note-3:
> I also went ahead and tested this against my two Chelsio NICs. I verified that it r... Rahul Lakkireddy

12:20 AM Bug #14296 (New): segfault on reboot in ficlVmInnerLoop

Encountered a segfault when running `reboot`. This was on a nightly build and I was trying to go back to the previous... Ryan Zezeski

12:17 AM Feature #14284: check_rtime should check kernel modules

testing:
Ran as part of the build and otherwise to catch -ztype=kmod errors. Rich Lowe

12:17 AM Bug #14285: check_rtime should recommend -fpic not -Kpic

testing: Just ran it Rich Lowe

2021-12-09

11:38 PM Feature #14289: cxgbe: update firmware version to 1.26.4.0

I also went ahead and tested this against my two Chelsio NICs. I verified that it reported the newer firmware and tha... Ryan Zezeski

09:51 PM Bug #5060 (Closed): Assertion failure in iprb during watchdog reset

"git commit 9ca05893faec45ccbe9cfa6b59b1a79960d9f7a7":https://github.com/illumos/illumos-gate/commit/9ca05893faec45cc... Electric Monk

07:42 PM Bug #5060: Assertion failure in iprb during watchdog reset

An OmniOS user with the same problem was able to verify that the attached patch stops the panic. The network interfac... Andy Fiddaman

08:32 PM Feature #14294: Want NVMe admin passthru command

This ticket tracks work adding a new ioctl to the nvme driver, `NVME_IOC_PASSTHRU`, and a new type to represent the p... Benjamin Naecker

07:01 PM Bug #14003: panic: zfs dbuf code destroys buffer still held by others on encrypted pool

Just a quick couple notes for anyone who comes upon this...
The above reproduction steps work practically instantl... Rich Ercolani

03:38 PM Bug #14255 (Closed): gcc10 removes symbols from genunix, impeding CTF uniquification

"git commit 3cac7b0d73edf3f2674ad0f64d1fff3d2e59ae8c":https://github.com/illumos/illumos-gate/commit/3cac7b0d73edf3f2... Electric Monk

10:18 AM Bug #14255: gcc10 removes symbols from genunix, impeding CTF uniquification

This has been running in OmniOS bloody for a couple of weeks and I've been using @mdb@ and @dtrace@ there continually... Andy Fiddaman

03:07 PM Bug #14204 (Closed): mac_rx_srs_process stack depth needs to account for harder usage

"git commit cab61dfb78becc8381714d6b7c413391d89e1669":https://github.com/illumos/illumos-gate/commit/cab61dfb78becc83... Electric Monk

02:56 PM Bug #14204: mac_rx_srs_process stack depth needs to account for harder usage

I checked that the stack size for mac_srs_worker threads has doubled as a result of this change:... Andy Fiddaman

12:32 PM Feature #14295: Allow shipping an additional libbe_py

I've tested this by doing builds on various systems with various combinations of python options:
* OmniOS r151040, w... Andy Fiddaman

12:23 PM Feature #14295 (Closed): Allow shipping an additional libbe_py

When an IPS distribution is migrating between versions of python, it becomes difficult to maintain a working @pkg@ du... Andy Fiddaman

2021-12-08

08:07 PM Feature #14294 (Closed): Want NVMe admin passthru command

Many NVMe devices support vendor-specific commands, such as telemetry or vendor-defined log pages. We'd like to provi... Benjamin Naecker

2021-12-07

08:04 PM Bug #14292 (Closed): elf-tests/tests/relocs/i386/got32x/got32x fails if compiler defaults to 64bit output

"git commit da0032e1ff1dfffa47e6c553929524ba1d62ead3":https://github.com/illumos/illumos-gate/commit/da0032e1ff1dfffa... Electric Monk

01:11 AM Bug #14292: elf-tests/tests/relocs/i386/got32x/got32x fails if compiler defaults to 64bit output

testing:
Booted in an environment where gcc produces 64bit output by default, and checked the test now passes. Rich Lowe

10:39 AM Bug #14291: cxgbe: asserts when requesting more queues than available

Tested the fix and the max Txq allocation is appropriately restricted to 100 (25 per port on 4-port T540-LP-CR) avail... Rahul Lakkireddy

10:37 AM Feature #14290: cxgbe: need link speed change when autoneg is disabled

Tested changing link speeds using dladm, as shown below.
The Chelsio T6225-SO-CR adapter's port is connected to th... Rahul Lakkireddy

10:15 AM Feature #14289: cxgbe: update firmware version to 1.26.4.0

Need to update to latest supported firmware from Chelsio (cxgbe) for the T4/T5/T6 NICs.
Tested the patch as follow... Rahul Lakkireddy

2021-12-06

10:59 PM Bug #14250 (Closed): ld should resolve discarded COMDAT symbols against their mates

"git commit 55d6cb5d63bcf69dfa47b8c41c770a2d34f169b0":https://github.com/illumos/illumos-gate/commit/55d6cb5d63bcf69d... Electric Monk

10:57 PM Bug #14292 (Closed): elf-tests/tests/relocs/i386/got32x/got32x fails if compiler defaults to 64bit output

elf-tests/tests/relocs/i386/got32x/got32x should specify -m32 when invoking gcc. Though ld(1) defaults sanely based ... Rich Lowe

08:33 PM Bug #14254: usr/src/tools is confused about what native means

https://github.com/rmustacc/illumos-gate/commit/f0d307e3313d2cf3a6abb4961090315b00522974#diff-274e018464f52ee2fe1f5b5... Rich Lowe

04:52 PM Feature #14277 (Closed): Improve shell lint checks

"git commit be548e87bcb4979e0b8a7bce5620a9916b888fdc":https://github.com/illumos/illumos-gate/commit/be548e87bcb4979e... Electric Monk

04:52 PM Bug #14262 (Closed): ntp_adjtime() should only validate constant with MOD_TIMECONST

"git commit ea3cb02b50effb9ec1ecee7e7178c14143cd2485":https://github.com/illumos/illumos-gate/commit/ea3cb02b50effb9e... Electric Monk

02:49 PM Bug #14262: ntp_adjtime() should only validate constant with MOD_TIMECONST

I tested this by building a custom version of ntpsec's @ntptime@ utility which takes an additional option which sets ... Andy Fiddaman

04:51 PM Bug #14291 (Closed): cxgbe: asserts when requesting more queues than available

Following assert is seen when trying to request more queues than available for the underlying Physical Function (PF).... Rahul Lakkireddy

04:31 PM Feature #14290 (Closed): cxgbe: need link speed change when autoneg is disabled

Need ability to change link speeds via dladm for port modules that do not support auto-negotiation or when auto-negot... Rahul Lakkireddy

04:28 PM Feature #14289 (Closed): cxgbe: update firmware version to 1.26.4.0

Need to update to latest supported firmware 1.26.4.0 from Chelsio (cxgbe) for the T4/T5/T6 NICs. Rahul Lakkireddy

2021-12-05

09:30 PM Bug #14250: ld should resolve discarded COMDAT symbols against their mates

testing:
Built and wsdiff'd illumos (no changes except the SGS version number).
Built llvm/clang (which failed ... Rich Lowe

07:57 PM Bug #14288: mdbtest finds no tests when invoked by test runner

With the updated wrapper script, we see this now works:... Robert Mustacchi

07:53 PM Bug #14288 (Closed): mdbtest finds no tests when invoked by test runner

While looking at wrapping up #14269 I found that there while the test passed, none of the tests were run by mdbtest w... Robert Mustacchi

2021-12-04

10:52 AM Bug #7694 (Closed): ksh -e continues to execute failed scripts when 'time' built-in is involved

"git commit 6ba75e2448bdf3ae62cf3d6d13895172a2b7a249":https://github.com/illumos/illumos-gate/commit/6ba75e2448bdf3ae... Electric Monk

2021-12-03

11:42 PM Bug #14286: ldd(1) of certain mdb kmods crashes when -u, -U, -r, etc. flags are used.

This is because there are bad symbol references in relocations after the kernel module has been linked into a shared ... Rich Lowe

10:15 PM Bug #14286 (New): ldd(1) of certain mdb kmods crashes when -u, -U, -r, etc. flags are used.

... Rich Lowe

11:23 PM Bug #14287 (Closed): ehci: No SOF interrupts have been received, this USB EHCI hostcontroller is unusable

On my vmware fusion, there are warnings popping:... Toomas Soome

09:05 PM Bug #14243 (Closed): sys/stddef.h: __builtin_offsetof is available from gcc 4.1

"git commit 0ed46b36ccecd85802b9c871aa442b736ec0de30":https://github.com/illumos/illumos-gate/commit/0ed46b36ccecd858... Electric Monk

08:57 PM Feature #14092 (Closed): imc(7D) should not be under i86pc

"git commit 74079a53e205d2eeb75b215833ddc684a1db3088":https://github.com/illumos/illumos-gate/commit/74079a53e205d2ee... Electric Monk

03:05 PM Feature #14092: imc(7D) should not be under i86pc

As an additional test, Patrick booted this on an Ivy Bridge system and we verified that the driver attached correctly... Robert Mustacchi

08:28 PM Bug #14285 (Closed): check_rtime should recommend -fpic not -Kpic

We should recommend the flag that people use. -fpic, not the Studio specific one. Rich Lowe

07:11 PM Feature #14284 (Closed): check_rtime should check kernel modules

check_rtime should check ET_REL objects in the proto area, to the degree it can.
This includes at least:
- chec... Rich Lowe

07:03 PM Bug #7694: ksh -e continues to execute failed scripts when 'time' built-in is involved

I did some ad-hoc tests as per the original report above, and confirmed that the new regression tests fails before an... Andy Fiddaman

02:10 AM Feature #14252 (Closed): Adjust boolean_t under __EXTENSIONS__

"git commit eb96f8f799ef5344a5736dd0f1721bc2ee59f980":https://github.com/illumos/illumos-gate/commit/eb96f8f799ef5344... Electric Monk

2021-12-02

11:12 PM Bug #14281 (Closed): bhyve bungles kstat clean-up

"git commit 6884664d1dc95e1917a534df2163ccd6f5c19b69":https://github.com/illumos/illumos-gate/commit/6884664d1dc95e19... Electric Monk

09:17 PM Bug #14281: bhyve bungles kstat clean-up

For testing, I constructed a contrived example for case 1 (deferred vm_destroy leaving lingering kstats). On an unpa... Patrick Mooney

05:46 PM Bug #14281 (Closed): bhyve bungles kstat clean-up

While playing with the bhyve kstats exposed by #13723, I hit a panic:... Patrick Mooney

09:28 PM Bug #14283 (Closed): ldd should not complain about non-executable shared objects

Currently if you run ldd(1) on a shared object which lacks executable permission, you'll see a message like so:
<pre... Rich Lowe

09:05 PM Feature #14282 (Closed): Warn when an inline function isn't

While comparing the generated code from a gcc7 primary compiler to that from gcc10, it became apparent that several f... Andy Fiddaman

08:59 PM Bug #14275 (Closed): crt object .comment sections should be string mergeable

"git commit 5e0a5eb736a773e9ab13bae98d1998788ce0f4f9":https://github.com/illumos/illumos-gate/commit/5e0a5eb736a773e9... Electric Monk

07:39 PM Bug #14268: kernel modules should be linked -ztype=kmod

testing:
illumos build
wsdiff (differences because kmods that lacked a .dynamic gain one, others gain DT_SUNW_K... Rich Lowe

05:31 PM Bug #14280 (Closed): loader: use shadow framebuffer

Make sure we do not read from FB in loader, unless we can not allocate shadow buffer. This should improve performance... Toomas Soome

12:24 PM Bug #14279: diskinfo sits quietly for up to a minute before exiting

See also https://github.com/omniosorg/illumos-omnios/commit/0307587db7989cb2ee157c6e2aeccb79e7bdb553 which was contri... Andy Fiddaman

04:54 AM Bug #14279 (New): diskinfo sits quietly for up to a minute before exiting

It would seem that libdiskmgmt responds to device addition sysevents by triggering a device tree walk to look at the ... Joshua M. Clulow

02:33 AM Feature #14206: IP interface MTU changes could emit routing socket messages

Nahum Shalman wrote in #note-8:
> I'm also unsure which function(s) would need to be updated to emit messages on int... Nahum Shalman

02:11 AM Feature #14206 (In Progress): IP interface MTU changes could emit routing socket messages

Nahum Shalman

2021-12-01

09:35 PM Bug #14275: crt object .comment sections should be string mergeable

testing:
Build and wsdiff (minor symtab, shstrtab, etc. changes because .comment is seen in objects earlier in the... Rich Lowe

08:16 PM Feature #14278 (New): report missing major number during driver module install

Recently while trying to load a module I was getting the following error.... Ryan Zezeski

08:00 PM Feature #14087: Bhyve exposes dirty page tracking interface

Testing: I wrote a one-off program to exercise the dirty-page tracking ioctl, started a VM, and ran it. I then stoppe... Dan Cross

06:42 PM Feature #14206: IP interface MTU changes could emit routing socket messages

@danmcd any thoughts on
> I'm also unsure which function(s) would need to be updated to emit messages on interface ... Nahum Shalman

12:09 PM Feature #14277: Improve shell lint checks

With the new changes, the lint output becomes:... Andy Fiddaman

11:53 AM Feature #14277 (Closed): Improve shell lint checks

https://github.com/ksh93/ksh recently pulled in some of the shell linter improvements from illumos issues #13601 and ... Andy Fiddaman

12:04 PM Bug #7694 (In Progress): ksh -e continues to execute failed scripts when 'time' built-in is involved

Andy Fiddaman

12:04 PM Bug #7694: ksh -e continues to execute failed scripts when 'time' built-in is involved

This has been fixed upstream in https://github.com/ksh93/ksh/pull/351 Andy Fiddaman

01:56 AM Bug #14159 (Closed): ahci can deadlock with sata framework

"git commit df07a22216251845ccadf35a5acc27bfa0b1a4d1":https://github.com/illumos/illumos-gate/commit/df07a22216251845... Electric Monk

01:29 AM Feature #14252: Adjust boolean_t under __EXTENSIONS__

This has been tested in a few ways:
# Toomas verified that the current clang default result in something that now ... Robert Mustacchi

2021-11-30

10:12 PM Bug #14198 (Closed): stack overflow from promisc callbacks

"git commit f1b92f9d37a4cab36f23fc8ad19e81e995b98f7a":https://github.com/illumos/illumos-gate/commit/f1b92f9d37a4cab3... Electric Monk

01:59 PM Bug #14198: stack overflow from promisc callbacks

This has been in SmartOS since 2015 and in OmniOS since 2020.
I've booted a system with these bits and confirmed tha... Andy Fiddaman

11:23 AM Bug #14255: gcc10 removes symbols from genunix, impeding CTF uniquification

This change also affects a gcc7 build and results in more types being uniquified to genunix. As an example, looking a... Andy Fiddaman

02:48 AM Feature #14276 (New): Document kmem_flags

We should document the values of kmem_flags in a man page -- some place other than in a comment in kmem.c for the ben... Jason King

02:00 AM Feature #14206: IP interface MTU changes could emit routing socket messages

The swapped fields have to do with the difference between how to parse
rt_msghdr_t vs if_msghdr_t
http://src.illum... Nahum Shalman

01:56 AM Bug #14275 (Closed): crt object .comment sections should be string mergeable

The CRT objects contain non-mergeable string .comment sections.
This is because the sections are added by mcs(1) r... Rich Lowe

01:43 AM Feature #14274 (Closed): fix a few broken pkg aliases

When we put together the changes to switch to the v2 manifests, there were a number of manifest errors that were foun... Robert Mustacchi

01:28 AM Feature #14273 (Closed): Want MAC ring manual pages

We initially documented the basics of mac in #7052. We've documented other unstable MAC properties with #8699 and #88... Robert Mustacchi

01:23 AM Feature #14272 (Closed): convert man7fs to mdoc

As part of our broader efforts to get mdoc across the system, this converts a chunk of manuals to mdoc. Robert Mustacchi

01:21 AM Bug #14271 (Closed): libkstat leaks kstat fd across exec

While working through #14264 I was updating the manual pages and saw a note about not needing clean up after an exec.... Robert Mustacchi

01:17 AM Feature #14270 (Closed): convert man3kstat to mdoc

As part of doing other work I've needed to update the kstat manuals, so we might as well go through and convert them ... Robert Mustacchi

01:14 AM Feature #14269 (Closed): mdb could support separators in numbers

Other languages, such as rust, have the ability to add separators in numbers. For example, @0x123456@ can be written ... Robert Mustacchi