Activity
From 2022-03-21 to 2022-04-19
2022-04-19
-
10:11 PM Bug #14650 (Closed): remove smatch gag from viona
- The kernel portion of viona has been building with @SMOFF += all_func_returns@.
It would be nice to fix up all of th... -
- The bhyve (kernel vmm) Makefile has gagged some smatch checks across the entire module:...
-
03:50 PM Feature #14607 (Closed): Add CONS_GETDEV so we can see which port is /dev/console
- "git commit c542a624b7efda0b8123026500f05f430ff6c770":https://github.com/illumos/illumos-gate/commit/c542a624b7efda0b...
-
02:05 PM Feature #14495: bhyve VNC server should support alternate pixel formats
- This change has been in OmniOS bloody for two months now, being exercised with a variety of VMs and VNC clients. I ha...
-
04:34 AM Bug #14418: mman.h symbol visibility is a mess
- In addition to the final versions of the symbol tests, with the help of Andy, Jonathan, and Rich I was able to verify...
2022-04-18
-
- "git commit b12aaafbf56c5a06b6cfd21655531a33e38a8ed9":https://github.com/illumos/illumos-gate/commit/b12aaafbf56c5a06...
-
09:29 PM Feature #11874 (In Progress): NFS file access audit logging
-
06:35 PM Bug #14647 (Closed): SMB: Kerberos and NTLM auth should do the same post-work
- smbd_user_auth_logon() handles NTLM authentication for the SMB server. However, it also handles adding the autohome s...
-
- vnode_valid_pn() unconditionally passes the FOLLOW flag to lookuppnvp. The only effect the FOLLOW flag has on lookupp...
-
- "git commit c74f1323689f1dfea444e7fe0627eafc8c3b9076":https://github.com/illumos/illumos-gate/commit/c74f1323689f1dfe...
2022-04-16
-
08:26 AM Bug #14641: Split ndpd from routing package
- Same thing for in.ripngd - network routing daemon for ipv6
-
- The routing package could perhaps be removed from:
oi-userland/components/meta-packages/install-types/includes/min... -
This is more of a feature request than a bug.
Would it be possible please to use a better name for
pkg:/syst...-
02:24 AM Bug #14643: ::dtrace dcmd can truncate output
- As a test of the fix, the following dtrace script was used:...
-
- The fix for this is relatively simple:
We can read the value of @panic_hrtime@ from the crash dump, and add the va... -
- Attempting to retrieve dtrace data from a crash dump, the @::dtrace@ dcmd would return no output.
Baffled, I attempt...
2022-04-15
-
10:56 PM Bug #14006 (New): ipv4-routing should not be enabled by default
-
- This is indeed effectively a duplicate of #14006.
-
- for example at the SMF level
<instance name='default' enabled='false' >
could be changed to
<instance n... -
- if network/routing would be removed from the server minimal group,
then you could actually request the opposite : ... -
- This is indeed effectively a duplicate of #14006.
-
- I've also tested that if you do:...
-
- The routing package could perhaps be removed from:...
-
- Recently, I was in a conversation where I was trying to determine whether or not use of @O_NOFOLLOW@ in open would st...
-
- Perhaps in.ndpd could be moved into its own IPS package.
in.ndpd - daemon for IPv6 autoconfiguration
Cur... -
02:20 PM Bug #14640 (Closed): bhyve VNC authentication fails with openssl3
- See https://github.com/omniosorg/illumos-omnios/pull/1157 and https://github.com/omniosorg/illumos-omnios/commit/95a2...
-
07:32 AM Feature #14639 (New): Add pkg-config support for libuuid - provide uuid.pc files
- Provide pkg-config support for libuuid, needed to support latest version of Pacemaker-2.1.2 on illumos.
Without that... -
- "git commit fb29dee06f421b37b3394b542f15f91d4dbc7046":https://github.com/illumos/illumos-gate/commit/fb29dee06f421b37...
2022-04-14
-
11:54 PM Bug #14637: various Makefiles should have more faith in Makefile.master
- testing:
wsdiff, no difference at all in resulting binaries -
- Several Makefiles, but most noticeably Makefile.cmd re-define things from Makefile.master, and make them worse.
They... -
- testing:
wsdiff, no difference at all in resulting binaries -
- Paths in Makefile.master should be canonical, rather than going through the old /usr/ccs symlinks
-
- With the proposed fix applied, all of the bundled unit tests still pass:...
-
- When bhyve was ported to illumos, an interface shim was put in place so all of the code related to mutexes could be u...
-
- See also https://github.com/conclusiveeng/lib9p/pull/18
-
- Just as #14261 strives to expose the state of devices emulated in-kernel (vlapic, pit, etc), so too should architectu...
-
12:43 AM Bug #14634 (New): useradd forgets to destroy created FS if it fails to chmod it
- Looks like we close the handle too early and forget to destroy the created FS if we fail to chmod it:
http://src.i...
2022-04-13
-
- In addition to this, @Tunlinkat@ is part of @9P2000.L@ and is expected to return error numbers consistent with a Linu...
-
- When using @unlinkat()@ with a directory opened with Linux's @O_PATH@, it succeeds, otherwise it fails:...
-
- A user reported that trying to do a recursive `rm -rf` on a directory tree on a 9p mount in a Linux guest is failing....
-
- When the guest has enabled single-stepping (via rflags.tf), the instruction emulation in bhyve needs to inject @#DB@ ...
-
- Apparently, System V didn't have ENOTEMPTY, so when Solaris-2/SunOS-5 happened, it disappeared.
Linux, BSDs, and e... -
- For a long time I have had ipf rules on mail servers to immediately reject inbound TCP connections on port 113, rathe...
-
- The ID register in the vioapic allows writes to bits 31:24. The i82093aa specification declares only bits 27:24 to b...
-
- "git commit b1bc843f030b066c3da149508c52f7306b25b8ff":https://github.com/illumos/illumos-gate/commit/b1bc843f030b066c...
2022-04-12
-
- Long ago, (prior to 'newboot' in S11 and S10u1) we booted via a real-mode bootloader that required its own special dr...
-
- "git commit 9675e051a26ceeb832dfe8df37f88667f42253e0":https://github.com/illumos/illumos-gate/commit/9675e051a26ceeb8...
-
- I've tested this with a full build, which is clean, and by changing into each of the directories under @usr/src/test/...
2022-04-11
-
- testing:
Tested on a NUC that has an sd card controller with DMA. The rest compared to the PCI SIG class assignments -
- "git commit d2f938fdf23aca7cabde8395625fdfaa2118133d":https://github.com/illumos/illumos-gate/commit/d2f938fdf23aca7c...
-
- This was addressed and tested with #14598.
-
- "git commit d2f938fdf23aca7cabde8395625fdfaa2118133d":https://github.com/illumos/illumos-gate/commit/d2f938fdf23aca7c...
-
- With the proposed patch applied to a system, all of the bhyve tests (old and new) pass:...
-
- "git commit 6de0af11ed5afd6a7c0ff23e31c1954813e3bf88":https://github.com/illumos/illumos-gate/commit/6de0af11ed5afd6a...
2022-04-08
-
03:55 PM Bug #124: uts/common/zmod/THIRDPARTYLICENSE is out-of-date
- *Testing*
Since this change affects packaging only I tested this by running nightly. -
- Toomas Soome wrote in #note-5:
> I did add the license update to my zlib patch.
Ah, sorry, I didn't notice this c...
2022-04-07
-
04:29 PM Bug #124: uts/common/zmod/THIRDPARTYLICENSE is out-of-date
- Stefano Allrath wrote:
> it contains "version 1.1.3, July 9th, 1998",
> actual zmod/zlib.h contains "version 1.2.3,... -
-
- https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-25032
Our copy of zlib is maintained in https://github.com...
2022-04-06
-
- "git commit 041297c2d66302c15134da1d1bdd91cf787a945a":https://github.com/illumos/illumos-gate/commit/041297c2d66302c1...
-
- Testing from the bug reporter(s) indicates that the fix does not induce the panic (though the race is really tight).
-
- "git commit 7271f09891bb39b64f2a58632c92c1456ed9cf31":https://github.com/illumos/illumos-gate/commit/7271f09891bb39b6...
-
- I've booted a virtual machine which uses an emulated e1000g interface under bhyve with this patch. It works and I was...
-
FreeBSD have published a security advisory relating to the emulated e1000 network adapter provided by bhyve
http...-
- We should probably just fall back to the regular instruction emulation for cases like this.
-
- A quick update.
1.) Apparently the Linux driver enables promiscuous mode using SET_DEFAULT_VSI and disabling via U... -
- Compatibility with GNU/BSD grep.
OpenZFS zfs-tests are using grep -m X quite a lot.
Testing done: used with com... -
-
- Fundamentally, the problem seems to be that the port is powered off by the driver, and bhyve does not allow it to be ...
-
- Putting bhyve's xhci emulation into debug mode produces lots of output, here is some edited content including showing...
-
- When booting an illumos distribution under bhyve, and bhyve presents an emulated USB3 tablet device to the guest, the...
2022-04-05
-
- "git commit 57cf819efa50a6a3b3a478c25a098c29722eb358":https://github.com/illumos/illumos-gate/commit/57cf819efa50a6a3...
-
- After applying the associated patch, the service comes online in a shared-ip zone, without any processes in the contr...
-
- Andy Fiddaman wrote:
SNIP!
> It's likely this pair of assignments should be wrapped in a lock on connp->conn_lo... -
- An OmniOS user experienced the following kernel panic while testing the upcoming r151042 release....
-
- The OpenZFS project is using __maybe_unused to mark variables which may be unused in some context - like variables us...
-
I hit this error while running a full gate build:...-
- Found those two cases:
http://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libdiskmgt/common/drive.c?r=bd4... -
- "git commit f7457249d2a760edca827e174adb0db578a87784":https://github.com/illumos/illumos-gate/commit/f7457249d2a760ed...
-
- Further notes:
When the SCSI LUN changes size, a DLE event was generated, always for :a - there was
a comment in ...
2022-04-04
-
11:29 PM Bug #14592: pwait(1) should never wait on its own PID
- Attached is the c program I wrote to induce this bug and test its fix.
Uses getpid() and execv() to call pwait wit... -
- The strings we use to describe the PCI class of devices haven't been updated since 2013, and were missing some bits e...
-
- "git commit 2af7a84a44750559d578033163c65829ae91c171":https://github.com/illumos/illumos-gate/commit/2af7a84a44750559...
-
- In a shared IP zone, the @network/ipmp@ services goes into maintenance, and it should not....
-
- Christoph Binner wrote:
> Sample file attached.
> @
> $ /usr/bin/dos2unix sample.txt
> ���
> %
> $ cat sampl... -
08:34 AM Bug #14616 (New): dos2unix(1) breaks BOM text files, pkgsrc version is fine
- Sample file attached.
@
$ /usr/bin/dos2unix sample.txt
���
%
$ cat sample.txt | /opt/local/bin/dos2unix
αβγδ...
2022-04-03
-
07:15 PM Bug #14541: nvme_quiesce() can hang preventing reboot
- I've dug into this and have an explanation for what's happening. I'll give the summary, then outline how I arrived he...
-
- Before patch:...
-
- Clean it up. No functional changes intended.
Testing done: used format command to partition the disk and browse th... -
- In libidmap, the idmap cache '{gid/uid}2sid_winname' contains entries that can have either a SID or winname (or both)...
2022-04-02
-
- "git commit 07a53f3dc8bc5e4d64bde9b92063de65f06dcf19":https://github.com/illumos/illumos-gate/commit/07a53f3dc8bc5e4d...
2022-04-01
-
- At least one manual page incorrectly identifies SMF as the Service Management _Framework_, when it is indeed a _Facil...
-
- The flag is very useful for HBA drivers to offload all of the mpxio interaction to the framework.
-
- The current os_console setup in options menu is assuming single value set in console variable. Since all usable devic...
-
- Update ttymon to identify serial device behind /dev/console and use ttyX-mode property value to set up the line.
T... -
- Patch developed by Joshua M. Clulow.
Add function to get back end device id for /dev/console, so we can identify i... -
- testing:
Booting on the affected system, and checking the compatible property on the serial was correctly formed
2022-03-31
-
- Electric Monk wrote in #note-4:
> "git commit 6158afa44672def05b584840435f36f75f5a291f":https://github.com/illumos/i...
2022-03-30
-
05:47 PM Bug #14605 (Closed): More incorrect cross-references in the manual
- Following the integration of IPD4, I ran a check for incorrect cross references in the manual.
This picked out man... -
- at present, serial enumerated by the BIOS as part of a workaround uses incorrectly formatted compatible properties.
... -
- "git commit 5103e761e384621c5728a6d1f4b0bfdc1be233a4":https://github.com/illumos/illumos-gate/commit/5103e761e384621c...
-
- While this was originally desired for testing instruction emulation, the first use case ended up being testing kernel...
-
- "git commit 5103e761e384621c5728a6d1f4b0bfdc1be233a4":https://github.com/illumos/illumos-gate/commit/5103e761e384621c...
-
- To test, I booted and ran the normal battery of guests on both Intel and AMD hardware. After the update, CentOS gues...
-
- "git commit db9aa506ce275f82ee72f31fc2e6e3c53d1212b7":https://github.com/illumos/illumos-gate/commit/db9aa506ce275f82...
-
- Initial testing consisted of booting and running the typical battery of guests, checking to see that their network co...
2022-03-29
-
- I tested this on OmniOS in a Gen.2 Hyper-V VM using a hv_storvsc disk, which uses an sd backend.
With this change in... -
- "git commit 899b7fc7762875c5244567fbc6bb4ccace75d6f7":https://github.com/illumos/illumos-gate/commit/899b7fc7762875c5...
-
- Testing: Viewed the modified pages with the man utility.
-
- "git commit a677d6730e287aadab3cc68d0c46fb01b25d72eb":https://github.com/illumos/illumos-gate/commit/a677d6730e287aad...
-
- An OmniOS user reported that booting a bhyve guest with an XHCI controller passed-through to it failed to boot with t...
-
- "git commit 6158afa44672def05b584840435f36f75f5a291f":https://github.com/illumos/illumos-gate/commit/6158afa44672def0...
-
- I also wrote a toy C program to compare %2x vs. %02x. I have this actual i40e fix running (along with WIP 13230) on ...
-
- Remove warning suppressions, enable smatch.
Fix prototypes and ansify.
clean up extern and globals.
cstyle cleanup... -
- > What would you expect here? What would you want?
I had no idea what to expect here, but your implementation deta... -
12:38 AM Feature #14601: want 3-argument string comparison assertions
- Dan McDonald wrote in #note-1:
> What if some grinning weirdo expects, for example:
>
> [...]
>
> to work? Ma... -
- What if some grinning weirdo expects, for example:...
-
- @ASSERT3x()@ and @VERIFY3x()@ are valuable debugging tools, but they are not useful replacements for @ASSERT(strcmp(x...
2022-03-28
-
- "git commit 7d6cab3f0d6a4cea17d062d3a93e223b15de705c":https://github.com/illumos/illumos-gate/commit/7d6cab3f0d6a4cea...
-
- h1. Testing Notes
I did an expansion in a QEMU guest, with a disk I had recently expanded by 200MB, with a @vioblk@ ... -
- As discovered in #14022 there are occasions where we would like to explicitly reload and revalidate a disk label that...
-
- "git commit fe07c600e1e51d75e87d45aef001e9d6131ecdb8":https://github.com/illumos/illumos-gate/commit/fe07c600e1e51d75...
-
- The emulation for rdmsr/wrmsr actions in bhyve is a bit hodge-podge at the moment. Emulation which handles guest act...
-
- The existing LAPIC emulation in bhyve does not allow the GUEST to make changes to the APICBASE. While we do not, at ...
-
- I haven't formally tested a fixed i40e yet because inducing filter-errors is annoying. I do know ixgbe(4D) and cxgbe(...
-
- I saw an error of this form in my messages:...
-
- Current cstyle can not handle constructs like 'for (expr; cond;)', even adding space before ')' does not help. Add ex...
-
- When @sd@ raises a dynamic LUN expansion (DLE) event, it does so for only the first partition on the disk, in contras...
-
- ...
-
- With SMT-enabled processors, psrinfo -pv does not emit the CPU's socket type even if it is known to the kernel:
<p...
2022-03-27
-
- I've decided to do something more surgical that shouldn't require extensive testing first, to stop the immediate brea...
-
- Hunting around a bit more, it seems like it would be more appropriate to introduce a new ioctl here, e.g., @DKIOCHECK...
-
- #14022 added a @DKIOSTATE@ ioctl to the @zpool online -e@ path, which appears now to reliably hang at least on AWS sy...
-
- This was backed out as it introduced #14127, since fixed.
The same testing as then applies now, in addition jperkin ... -
- "git commit ffd79eb680a8bd21d176389b06735eb297f89679":https://github.com/illumos/illumos-gate/commit/ffd79eb680a8bd21...
2022-03-25
-
- Related to #11828 , this issue tracks the bad behavior that inspired 11828.
The pid of pwait(1) itself should NEVE... -
- I am splitting this bug into two. This bug will remain as-is, and the new bug will focus on the more-of-a-bugfix not...
-
- I definitely find Andy's example easier to read -- though I may be biased as I probably wrote that code in smrt.
-
- There's an example in smrt which is a bit easier to read (same approach though, just moving the next assignment into ...
2022-03-24
-
- For background reading on 9P, there are a number of places one could look. Probably the most important thing to know...
-
- I have attached a C program that demonstrates basic usage of 9P. I shared a directory using 9P into a QEMU guest on ...
-
- Manual page:...
-
-
- This puzzled me a bit, so I have taken the following logic from @STAILQ_FOREACH_SAFE@ to safely remove specific entri...
-
- Mostly because of tem, we have some places the boolean_t is used, replace it with bool.
No functional changes.
... -
- The make(1) manual page does not document the $^ dynamic macro.
-
- ...
-
- The kernel component of bhyve and viona are not strictly specific to i86pc. They should be moved to uts/intel so tha...
2022-03-23
-
- While snooping SMB traffic, snoop is crashing:...
-
- Will B wrote in #note-25:
> Toomas Soome wrote in #note-24:
> > nono, I did not mean any fees, just that without an... -
09:15 PM Bug #13774: [OpenIndiana Hipster 2021.04] Slow then unusable video after startup menu on 2012 Mac mini
- Toomas Soome wrote in #note-24:
> nono, I did not mean any fees, just that without an access to hw, I can only try t... -
- Rasaki Temidire wrote in #note-23:
> Toomas Soome wrote in #note-22:
> > Rasaki Temidire wrote in #note-21:
> > > ... -
06:06 PM Bug #13774: [OpenIndiana Hipster 2021.04] Slow then unusable video after startup menu on 2012 Mac mini
- Toomas Soome wrote in #note-22:
> Rasaki Temidire wrote in #note-21:
> > Will B wrote in #note-20:
> > > Rasaki Te... -
- Rasaki Temidire wrote in #note-21:
> Will B wrote in #note-20:
> > Rasaki Temidire wrote in #note-19:
> > > Will a... -
- The loader console setup code is validating the console devices and removing unusable devices from console variable v...
-
- When we start kernel with console property having multiple values, kernel will happily pick up not the first device n...
2022-03-22
-
- "git commit d3477c6d12fcb86e8bb78faf6993ae16c81cbe12":https://github.com/illumos/illumos-gate/commit/d3477c6d12fcb86e...
-
- It looks like the OpenZFS change was after the original code as committed, so just hadn't been ported over yet.
-
- "git commit f43aa5faf71b05bec443dbb0af363ddeaff8ec17":https://github.com/illumos/illumos-gate/commit/f43aa5faf71b05be...
-
- Igor Kozhukhov wrote in #note-4:
> it is not a bad merge, you missed OpenZFS update:
> https://github.com/openzfs/z... -
09:57 PM Bug #14562: apparently bad merge in l2arc_write_buffers
- it is not a bad merge, you missed OpenZFS update:
https://github.com/openzfs/zfs/commit/a8f27ec6c5f89f721f0492ed7b07... -
- Or maybe we could look at it the other way: distro says what is their "main" package to get the build environment rea...
-
- Joshua M. Clulow wrote in #note-3:
> > The best approach for distributions to make sure the illumos-gate is properly... -
- > The best approach for distributions to make sure the illumos-gate is properly buildable is to provide their own way...
-
- The @developer/opensolaris/osnet@ meta-package requires several packages provided by distribution, not by the illumos...
-
- https://smartos.org/bugview/OS-8368
-
- I will file this in SmartOS, as LX is not in illumos-gate, only in two downstreams (SmartOS and OmniOS).
Also see ... -
07:51 PM Bug #14582 (Closed): lstat in Ubuntu 20.04 LX zones reporting incorrect values
- I noticed that my build zones that use ccache were filling up despite there being a configured limit to the cache siz...
-
- Will B wrote in #note-20:
> Rasaki Temidire wrote in #note-19:
> > Will and Toomas, Thanks for this discussion. I ... -
- Rasaki Temidire wrote in #note-19:
> Will and Toomas, Thanks for this discussion. I was able to get the latest Smar... -
- Will B wrote in #note-18:
> Toomas Soome wrote:
> > Also, if you do not mind to try the very latest omnios or smart... -
- "git commit 2cd877f8d788934c1ed085b214de3d345d52400b":https://github.com/illumos/illumos-gate/commit/2cd877f8d788934c...
-
- Gary Mills wrote in #note-3:
> I have this setting in /boot/loader.conf on my supermicro system:
>
> [...]
>
>... -
02:50 PM Feature #14580: loader.efi: detect console from ConOut/ConOutDev
- I have this setting in /boot/loader.conf on my supermicro system:...
-
02:36 PM Bug #14581 (Closed): ipadm could not create address after delete-addr for addrconf
- Issue 13316 probably has the same underlying cause as this issue, but they look different enough to the user that I t...
-
- With #7445 integrated this is no longer applicable.
-
-
-
-
- This is complete now. There are no more lint libraries shipped from illumos-gate.
-
-
2022-03-21
-
- Resolved in https://github.com/illumos/illumos-gate/commit/faa2068d5f60927511f588cf120b905d985371d0
-
-
- Walk devices listed in ConOut (ConOutDev) variable(s) and set up console accordingly.
We need to check both variab... -
- "git commit c4140c56306ad2a74081dd949618b4f3162dd06b":https://github.com/illumos/illumos-gate/commit/c4140c56306ad2a7...
-
- Some hypervisors (e.g., QEMU and bhyve) provide support for file sharing via the "9P":https://en.wikipedia.org/wiki/9...
-
09:12 PM Bug #13436: EPOLLET should wake up for each pipe write, even without reads
- It appears the mio crate actually has a work around for illumos
https://github.com/tokio-rs/mio/blob/e077a23a4d7fd548... -
- bahamas10 noticed that this behavior causes a rustup install to fail on lx (omnios/smartos). He distilled it down to...
-
- "git commit faa2068d5f60927511f588cf120b905d985371d0":https://github.com/illumos/illumos-gate/commit/faa2068d5f609275...
-
- Two of these are now fixed in upstream bhyve and will be incorporated in #14578
The third, in the UART code, is ill... -
- Sync upstream activity in FreeBSD's bhyve into illumos.
The following list shows the commits brought over as part ... -
- After move of this code to gfx-drm repo, #7639, and "this commit in the gfx-drm":https://github.com/illumos/gfx-drm/c...
Also available in: Atom