Project

General

Profile

Activity

From 2022-03-27 to 2022-04-25

2022-04-25

10:35 PM Bug #14651: select.3c error return value is wrong
To test this change I looked rendered the man page with mandoc and ensured that everything looked okay. Michael Zeller
08:35 PM Bug #14650: remove smatch gag from viona
Since this change should result in effectively no change, I tested with @wsdiff@. Besides the typical noise resultin... Patrick Mooney
07:28 PM Bug #14621 (Closed): Missing dependency in cores tests build
"git commit 43f863f959a7ec8a6ee3645d33997561ff808c39":https://github.com/illumos/illumos-gate/commit/43f863f959a7ec8a... Electric Monk
11:09 AM Bug #14657 (Closed): zoneadmd: remove warning gags and add ctf support
I was attempting to use mdb on zoneadmd process and found it resisting to display information. Rebuilding with CTF su... Toomas Soome

2022-04-23

09:18 PM Bug #14633 (Closed): lib9p: unlinkat() does not work on 9p share
"git commit 1e6b83029f8d7ea1ade06314dc14e2fbd0cd2bcb":https://github.com/illumos/illumos-gate/commit/1e6b83029f8d7ea1... Electric Monk
10:57 AM Bug #14633: lib9p: unlinkat() does not work on 9p share
Testing notes:
With the fix in place, each of the tests shown above succeeds. In a Linux guest, the @unlinkat@ call ...
Andy Fiddaman
09:18 PM Bug #14623 (Closed): bhyve/xhci: Connecting device on port 1 failed
"git commit 104fd2955714fa4ea6ed431b6b5cf2eb0766ecad":https://github.com/illumos/illumos-gate/commit/104fd2955714fa4e... Electric Monk
10:40 AM Bug #14623: bhyve/xhci: Connecting device on port 1 failed
Testing notes:
With this change in place, I have successfully booted Windows, FreeBSD, illumos and Linux guests with...
Andy Fiddaman
10:39 AM Bug #14623: bhyve/xhci: Connecting device on port 1 failed
After reading the relevant parts of the XHCI specification (and with some help from Robert Mustacchi on how to interp... Andy Fiddaman
06:15 PM Bug #14653 (Closed): loader: zfs: handle holes at the tail end correctly
"git commit 77570342d4bf7e1e439bf1b8008312de7f031a0a":https://github.com/illumos/illumos-gate/commit/77570342d4bf7e1e... Electric Monk
11:03 AM Bug #14640 (Closed): bhyve VNC authentication fails with openssl3
"git commit 1aa1f41fe10c6220a7fbef328fac1b72a8355a01":https://github.com/illumos/illumos-gate/commit/1aa1f41fe10c6220... Electric Monk
11:03 AM Bug #14506 (Closed): libidspace does not expose id_allocff()
"git commit 1aa1f41fe10c6220a7fbef328fac1b72a8355a01":https://github.com/illumos/illumos-gate/commit/1aa1f41fe10c6220... Electric Monk
11:03 AM Feature #14505 (Closed): libumem's umem_update thread could be named
"git commit 1aa1f41fe10c6220a7fbef328fac1b72a8355a01":https://github.com/illumos/illumos-gate/commit/1aa1f41fe10c6220... Electric Monk
11:03 AM Feature #14494 (Closed): bhyve VNC server could support multiple connections
"git commit 1aa1f41fe10c6220a7fbef328fac1b72a8355a01":https://github.com/illumos/illumos-gate/commit/1aa1f41fe10c6220... Electric Monk
11:03 AM Feature #14495 (Closed): bhyve VNC server should support alternate pixel formats
"git commit 1aa1f41fe10c6220a7fbef328fac1b72a8355a01":https://github.com/illumos/illumos-gate/commit/1aa1f41fe10c6220... Electric Monk

2022-04-22

09:04 PM Bug #14654 (Closed): blkdev softstate use after free
"git commit da00bec1e7243a6545b45e42283b8549cf19de1f":https://github.com/illumos/illumos-gate/commit/da00bec1e7243a65... Electric Monk
04:50 PM Bug #14654: blkdev softstate use after free
Testing: I've been running with these changes for a while during developing NVMe namespace management. The panics cau... Hans Rosenfeld
07:46 AM Bug #14654 (Closed): blkdev softstate use after free
During experimenting with namespace management I encountered panics when nvme called into blkdev. The blkdev handle w... Hans Rosenfeld
06:37 PM Feature #14090: ld(1) could use a normal allocator
"git commit fb12490ab4d1e87e7a63e457dd4fba1ea34c402a":https://github.com/illumos/illumos-gate/commit/fb12490ab4d1e87e... Electric Monk

2022-04-21

08:22 PM Bug #14587 (Closed): bhyve and viona belong in uts/intel
"git commit 7c8c0b8227679b4684566e408ccc96d6ef7175e9":https://github.com/illumos/illumos-gate/commit/7c8c0b8227679b46... Electric Monk
06:32 PM Bug #14587: bhyve and viona belong in uts/intel
danmcd did a test build of this change on SmartOS. The resulting platform image ran both KVM and bhyve instances as ... Patrick Mooney
06:09 PM Bug #14587: bhyve and viona belong in uts/intel
With the proposed patch in place, all of the in-gate unit tests still pass:... Patrick Mooney
08:10 PM Bug #14653 (Closed): loader: zfs: handle holes at the tail end correctly
Picked up from FreeBSD, work by Kyle Evans:... Toomas Soome
04:44 PM Bug #14652 (New): Man pages contain cross-reference errata
I have found man pages with cross-references that have incorrect sections or typos in their names. C Fraire

2022-04-20

07:28 PM Bug #14640: bhyve VNC authentication fails with openssl3
I've tested that VNC authentication is working with bhyve linked against openssl 1.0, 1.1 and 3.0 using the MacOS scr... Andy Fiddaman
07:26 PM Bug #14506: libidspace does not expose id_allocff()
This is being used by the refactored VNC server in #14495 and #14494 for assigning an ID number to each active VNC se... Andy Fiddaman
07:21 PM Feature #14505: libumem's umem_update thread could be named
With this change:... Andy Fiddaman
07:19 PM Feature #14494: bhyve VNC server could support multiple connections
I tested this part of the VNC server rewrite (see also #14495) by connecting several clients in parallel to the VNC s... Andy Fiddaman
06:45 PM Feature #14495: bhyve VNC server should support alternate pixel formats
Mike Zeller has also tested this as part of reviewing and said:
> I built and tested these bits by booting into a ga...
Andy Fiddaman
06:44 PM Bug #14418 (Closed): mman.h symbol visibility is a mess
"git commit df5cd018c34371890eeeb8c930245b9323e8aa25":https://github.com/illumos/illumos-gate/commit/df5cd018c3437189... Electric Monk
05:45 PM Bug #14531 (Closed): want nvme namespace management mutex
"git commit 34331de35882eb41acdf4f0d2065b5e12d083e82":https://github.com/illumos/illumos-gate/commit/34331de35882eb41... Electric Monk
05:21 PM Bug #14531: want nvme namespace management mutex
Testing: Apart from this having been in Tintri's code for a few months now, I have verified that operations changing ... Hans Rosenfeld
02:45 PM Bug #14530 (Closed): nvme should require exclusive open for attach, detach, and format ioctls
"git commit 353d89b0745ef752e824c1afc3f0474f66dfbd64":https://github.com/illumos/illumos-gate/commit/353d89b0745ef752... Electric Monk
09:36 AM Bug #14530: nvme should require exclusive open for attach, detach, and format ioctls
Testing: I've verified all the commands that now require exclusive opens still work as expected, on namespaces as wel... Hans Rosenfeld
05:57 AM Bug #14651 (Closed): select.3c error return value is wrong
The man page is missing the sign on the return value in the error case.... Michael Zeller

2022-04-19

10:11 PM Bug #14650 (Closed): remove smatch gag from viona
The kernel portion of viona has been building with @SMOFF += all_func_returns@.
It would be nice to fix up all of th...
Patrick Mooney
09:52 PM Bug #14649 (Closed): remove blanket smatch gag from bhyve kernel
The bhyve (kernel vmm) Makefile has gagged some smatch checks across the entire module:... Patrick Mooney
03:50 PM Feature #14607 (Closed): Add CONS_GETDEV so we can see which port is /dev/console
"git commit c542a624b7efda0b8123026500f05f430ff6c770":https://github.com/illumos/illumos-gate/commit/c542a624b7efda0b... Electric Monk
02:05 PM Feature #14495: bhyve VNC server should support alternate pixel formats
This change has been in OmniOS bloody for two months now, being exercised with a variety of VMs and VNC clients. I ha... Andy Fiddaman
04:34 AM Bug #14418: mman.h symbol visibility is a mess
In addition to the final versions of the symbol tests, with the help of Andy, Jonathan, and Rich I was able to verify... Robert Mustacchi

2022-04-18

10:59 PM Bug #14613 (Closed): format: cstyle cleanup
"git commit b12aaafbf56c5a06b6cfd21655531a33e38a8ed9":https://github.com/illumos/illumos-gate/commit/b12aaafbf56c5a06... Electric Monk
09:29 PM Feature #11874 (In Progress): NFS file access audit logging
Gordon Ross
06:35 PM Bug #14647 (Closed): SMB: Kerberos and NTLM auth should do the same post-work
smbd_user_auth_logon() handles NTLM authentication for the SMB server. However, it also handles adding the autohome s... Matt Barden
05:01 PM Bug #14646 (Closed): vnode_valid_pn() always fails for symlinks
vnode_valid_pn() unconditionally passes the FOLLOW flag to lookuppnvp. The only effect the FOLLOW flag has on lookupp... Matt Barden
04:58 PM Bug #14612 (Closed): idmap_cache_add_sid2pid() doesn't initialize winname_ttl, which can cause segfaults
"git commit c74f1323689f1dfea444e7fe0627eafc8c3b9076":https://github.com/illumos/illumos-gate/commit/c74f1323689f1dfe... Electric Monk

2022-04-16

08:26 AM Bug #14641: Split ndpd from routing package
Same thing for in.ripngd - network routing daemon for ipv6 David Stes
08:24 AM Feature #14644: Rename network/routing to dynamic-routing
The routing package could perhaps be removed from:
oi-userland/components/meta-packages/install-types/includes/min...
David Stes
08:22 AM Feature #14644 (New): Rename network/routing to dynamic-routing

This is more of a feature request than a bug.
Would it be possible please to use a better name for
pkg:/syst...
David Stes
02:24 AM Bug #14643: ::dtrace dcmd can truncate output
As a test of the fix, the following dtrace script was used:... Jason King
02:22 AM Bug #14643: ::dtrace dcmd can truncate output
The fix for this is relatively simple:
We can read the value of @panic_hrtime@ from the crash dump, and add the va...
Jason King
02:19 AM Bug #14643 (Closed): ::dtrace dcmd can truncate output
Attempting to retrieve dtrace data from a crash dump, the @::dtrace@ dcmd would return no output.
Baffled, I attempt...
Jason King

2022-04-15

10:56 PM Bug #14006 (New): ipv4-routing should not be enabled by default
Joshua M. Clulow
10:47 PM Bug #14006 (Duplicate): ipv4-routing should not be enabled by default
This is indeed effectively a duplicate of #14006. Joshua M. Clulow
04:16 PM Bug #14006: ipv4-routing should not be enabled by default
for example at the SMF level
<instance name='default' enabled='false' >
could be changed to
<instance n...
David Stes
04:14 PM Bug #14006: ipv4-routing should not be enabled by default
if network/routing would be removed from the server minimal group,
then you could actually request the opposite : ...
David Stes
10:47 PM Feature #8587 (Duplicate): svc:/network/routing/route:default usually is not needed nowadays
This is indeed effectively a duplicate of #14006. Joshua M. Clulow
03:36 PM Feature #8587: svc:/network/routing/route:default usually is not needed nowadays
I've also tested that if you do:... David Stes
03:20 PM Feature #8587: svc:/network/routing/route:default usually is not needed nowadays
The routing package could perhaps be removed from:... David Stes
07:03 PM Bug #14642 (New): open O_NOFOLLOW docs could be clearer
Recently, I was in a conversation where I was trying to determine whether or not use of @O_NOFOLLOW@ in open would st... Robert Mustacchi
03:25 PM Bug #14641 (New): Split ndpd from routing package
Perhaps in.ndpd could be moved into its own IPS package.
in.ndpd - daemon for IPv6 autoconfiguration
Cur...
David Stes
02:20 PM Bug #14640 (Closed): bhyve VNC authentication fails with openssl3
See https://github.com/omniosorg/illumos-omnios/pull/1157 and https://github.com/omniosorg/illumos-omnios/commit/95a2... Dan McDonald
07:32 AM Feature #14639 (New): Add pkg-config support for libuuid - provide uuid.pc files
Provide pkg-config support for libuuid, needed to support latest version of Pacemaker-2.1.2 on illumos.
Without that...
Klaus Ziegler
12:36 AM Bug #14636 (Closed): discard mutex shim for bhyve
"git commit fb29dee06f421b37b3394b542f15f91d4dbc7046":https://github.com/illumos/illumos-gate/commit/fb29dee06f421b37... Electric Monk

2022-04-14

11:54 PM Bug #14637: various Makefiles should have more faith in Makefile.master
testing:
wsdiff, no difference at all in resulting binaries
Rich Lowe
11:52 PM Bug #14637 (Closed): various Makefiles should have more faith in Makefile.master
Several Makefiles, but most noticeably Makefile.cmd re-define things from Makefile.master, and make them worse.
They...
Rich Lowe
11:54 PM Bug #14638: Makefile.master can forget about /usr/ccs
testing:
wsdiff, no difference at all in resulting binaries
Rich Lowe
11:53 PM Bug #14638 (Closed): Makefile.master can forget about /usr/ccs
Paths in Makefile.master should be canonical, rather than going through the old /usr/ccs symlinks Rich Lowe
11:10 PM Bug #14636: discard mutex shim for bhyve
With the proposed fix applied, all of the bundled unit tests still pass:... Patrick Mooney
02:26 AM Bug #14636 (Closed): discard mutex shim for bhyve
When bhyve was ported to illumos, an interface shim was put in place so all of the code related to mutexes could be u... Patrick Mooney
09:45 AM Bug #14633: lib9p: unlinkat() does not work on 9p share
See also https://github.com/conclusiveeng/lib9p/pull/18 Andy Fiddaman
02:20 AM Bug #14635 (Closed): bhyve should expose additional vcpu state
Just as #14261 strives to expose the state of devices emulated in-kernel (vlapic, pit, etc), so too should architectu... Patrick Mooney
12:43 AM Bug #14634 (New): useradd forgets to destroy created FS if it fails to chmod it
Looks like we close the handle too early and forget to destroy the created FS if we fail to chmod it:
http://src.i...
Yuri Pankov

2022-04-13

09:49 PM Bug #14633: lib9p: unlinkat() does not work on 9p share
In addition to this, @Tunlinkat@ is part of @9P2000.L@ and is expected to return error numbers consistent with a Linu... Andy Fiddaman
09:37 PM Bug #14633: lib9p: unlinkat() does not work on 9p share
When using @unlinkat()@ with a directory opened with Linux's @O_PATH@, it succeeds, otherwise it fails:... Andy Fiddaman
09:25 PM Bug #14633 (Closed): lib9p: unlinkat() does not work on 9p share
A user reported that trying to do a recursive `rm -rf` on a directory tree on a 9p mount in a Linux guest is failing.... Andy Fiddaman
08:17 PM Bug #14632 (New): bhyve instruction emulation should heed single-stepping
When the guest has enabled single-stepping (via rflags.tf), the instruction emulation in bhyve needs to inject @#DB@ ... Patrick Mooney
07:49 PM Feature #14631 (New): Return ENOTEMPTY to its rightful places
Apparently, System V didn't have ENOTEMPTY, so when Solaris-2/SunOS-5 happened, it disappeared.
Linux, BSDs, and e...
Dan McDonald
01:23 PM Bug #14630 (Closed): ipf return-rst does not work without IP forwarding
For a long time I have had ipf rules on mail servers to immediately reject inbound TCP connections on port 113, rathe... Andy Fiddaman
04:05 AM Bug #14629 (New): bhyve ioapic id needs masking
The ID register in the vioapic allows writes to bits 31:24. The i82093aa specification declares only bits 27:24 to b... Patrick Mooney
04:01 AM Bug #14592 (Closed): pwait(1) should never wait on its own PID
"git commit b1bc843f030b066c3da149508c52f7306b25b8ff":https://github.com/illumos/illumos-gate/commit/b1bc843f030b066c... Electric Monk

2022-04-12

08:19 PM Bug #14628 (Closed): ancient devicedb should be removed
Long ago, (prior to 'newboot' in S11 and S10u1) we booted via a real-mode bootloader that required its own special dr... Rich Lowe
07:03 PM Bug #14618 (Closed): PCI class strings need an update
"git commit 9675e051a26ceeb832dfe8df37f88667f42253e0":https://github.com/illumos/illumos-gate/commit/9675e051a26ceeb8... Electric Monk
10:49 AM Bug #14621: Missing dependency in cores tests build
I've tested this with a full build, which is clean, and by changing into each of the directories under @usr/src/test/... Andy Fiddaman

2022-04-11

09:52 PM Bug #14618: PCI class strings need an update
testing:
Tested on a NUC that has an sd card controller with DMA. The rest compared to the PCI SIG class assignments
Rich Lowe
09:21 PM Bug #14599 (Closed): simplify bhyve MSR handling
"git commit d2f938fdf23aca7cabde8395625fdfaa2118133d":https://github.com/illumos/illumos-gate/commit/d2f938fdf23aca7c... Electric Monk
08:06 PM Bug #14599: simplify bhyve MSR handling
This was addressed and tested with #14598. Patrick Mooney
09:21 PM Bug #14598 (Closed): bhyve vlapic should handle APICBASE changes
"git commit d2f938fdf23aca7cabde8395625fdfaa2118133d":https://github.com/illumos/illumos-gate/commit/d2f938fdf23aca7c... Electric Monk
08:05 PM Bug #14598: bhyve vlapic should handle APICBASE changes
With the proposed patch applied to a system, all of the bhyve tests (old and new) pass:... Patrick Mooney
05:07 PM Feature #14622 (Closed): want __maybe_unused
"git commit 6de0af11ed5afd6a7c0ff23e31c1954813e3bf88":https://github.com/illumos/illumos-gate/commit/6de0af11ed5afd6a... Electric Monk

2022-04-08

03:55 PM Bug #124: uts/common/zmod/THIRDPARTYLICENSE is out-of-date
*Testing*
Since this change affects packaging only I tested this by running nightly.
Marcel Telka
03:17 PM Bug #124: uts/common/zmod/THIRDPARTYLICENSE is out-of-date
Toomas Soome wrote in #note-5:
> I did add the license update to my zlib patch.
Ah, sorry, I didn't notice this c...
Marcel Telka

2022-04-07

04:29 PM Bug #124: uts/common/zmod/THIRDPARTYLICENSE is out-of-date
Stefano Allrath wrote:
> it contains "version 1.1.3, July 9th, 1998",
> actual zmod/zlib.h contains "version 1.2.3,...
Toomas Soome
02:49 PM Bug #124 (In Progress): uts/common/zmod/THIRDPARTYLICENSE is out-of-date
Marcel Telka
11:58 AM Bug #14626 (Closed): zlib: update to zlib-1.2.12
https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-25032
Our copy of zlib is maintained in https://github.com...
Toomas Soome

2022-04-06

09:11 PM Bug #14619 (Closed): Race between udp_activate() and conn_get_socket_info()
"git commit 041297c2d66302c15134da1d1bdd91cf787a945a":https://github.com/illumos/illumos-gate/commit/041297c2d66302c1... Electric Monk
04:03 PM Bug #14619: Race between udp_activate() and conn_get_socket_info()
Testing from the bug reporter(s) indicates that the fix does not induce the panic (though the race is really tight). Dan McDonald
05:51 PM Bug #14625 (Closed): Bhyve e82545 device emulation out-of-bounds write
"git commit 7271f09891bb39b64f2a58632c92c1456ed9cf31":https://github.com/illumos/illumos-gate/commit/7271f09891bb39b6... Electric Monk
04:54 PM Bug #14625: Bhyve e82545 device emulation out-of-bounds write
I've booted a virtual machine which uses an emulated e1000g interface under bhyve with this patch. It works and I was... Andy Fiddaman
03:39 PM Bug #14625 (Closed): Bhyve e82545 device emulation out-of-bounds write

FreeBSD have published a security advisory relating to the emulated e1000 network adapter provided by bhyve
http...
Andy Fiddaman
05:09 PM Bug #13847: bhyve should handle all APICv exits
We should probably just fall back to the regular instruction emulation for cases like this. Patrick Mooney
02:44 PM Bug #13230: i40e has duplicate traffic when used with bhyve/snoop running
A quick update.
1.) Apparently the Linux driver enables promiscuous mode using SET_DEFAULT_VSI and disabling via U...
Dan McDonald
12:42 PM Feature #14624 (In Progress): grep: add option -m
Compatibility with GNU/BSD grep.
OpenZFS zfs-tests are using grep -m X quite a lot.
Testing done: used with com...
Toomas Soome
12:37 PM Bug #14623 (In Progress): bhyve/xhci: Connecting device on port 1 failed
Andy Fiddaman
10:43 AM Bug #14623: bhyve/xhci: Connecting device on port 1 failed
Fundamentally, the problem seems to be that the port is powered off by the driver, and bhyve does not allow it to be ... Andy Fiddaman
10:02 AM Bug #14623: bhyve/xhci: Connecting device on port 1 failed
Putting bhyve's xhci emulation into debug mode produces lots of output, here is some edited content including showing... Andy Fiddaman
09:14 AM Bug #14623 (Closed): bhyve/xhci: Connecting device on port 1 failed
When booting an illumos distribution under bhyve, and bhyve presents an emulated USB3 tablet device to the guest, the... Andy Fiddaman

2022-04-05

07:33 PM Bug #14617 (Closed): svc:/network/ipmp maintenance in shared IP zone
"git commit 57cf819efa50a6a3b3a478c25a098c29722eb358":https://github.com/illumos/illumos-gate/commit/57cf819efa50a6a3... Electric Monk
12:23 PM Bug #14617: svc:/network/ipmp maintenance in shared IP zone
After applying the associated patch, the service comes online in a shared-ip zone, without any processes in the contr... Andy Fiddaman
06:55 PM Bug #14619: Race between udp_activate() and conn_get_socket_info()
Andy Fiddaman wrote:
SNIP!
> It's likely this pair of assignments should be wrapped in a lock on connp->conn_lo...
Dan McDonald
12:12 PM Bug #14619 (Closed): Race between udp_activate() and conn_get_socket_info()
An OmniOS user experienced the following kernel panic while testing the upcoming r151042 release.... Andy Fiddaman
02:27 PM Feature #14622 (Closed): want __maybe_unused
The OpenZFS project is using __maybe_unused to mark variables which may be unused in some context - like variables us... Toomas Soome
12:48 PM Bug #14621 (Closed): Missing dependency in cores tests build

I hit this error while running a full gate build:...
Andy Fiddaman
12:45 PM Bug #14620 (New): uscsi_mode_sense() seems to allocate too little of memory
Found those two cases:
http://src.illumos.org/source/xref/illumos-gate/usr/src/lib/libdiskmgt/common/drive.c?r=bd4...
Toomas Soome
10:43 AM Bug #14595 (Closed): sd DLE events should cover the first two partitions
"git commit f7457249d2a760edca827e174adb0db578a87784":https://github.com/illumos/illumos-gate/commit/f7457249d2a760ed... Electric Monk
10:42 AM Bug #14595: sd DLE events should cover the first two partitions
Further notes:
When the SCSI LUN changes size, a DLE event was generated, always for :a - there was
a comment in ...
Andy Fiddaman

2022-04-04

11:29 PM Bug #14592: pwait(1) should never wait on its own PID
Attached is the c program I wrote to induce this bug and test its fix.
Uses getpid() and execv() to call pwait wit...
Spencer Evans-Cole
07:14 PM Bug #14618 (Closed): PCI class strings need an update
The strings we use to describe the PCI class of devices haven't been updated since 2013, and were missing some bits e... Rich Lowe
03:26 PM Bug #14584 (Closed): unix: console property should only have one value
"git commit 2af7a84a44750559d578033163c65829ae91c171":https://github.com/illumos/illumos-gate/commit/2af7a84a44750559... Electric Monk
01:43 PM Bug #14617 (Closed): svc:/network/ipmp maintenance in shared IP zone
In a shared IP zone, the @network/ipmp@ services goes into maintenance, and it should not.... Andy Fiddaman
12:21 PM Bug #14616: dos2unix(1) breaks BOM text files, pkgsrc version is fine
Christoph Binner wrote:
> Sample file attached.
> @
> $ /usr/bin/dos2unix sample.txt
> ���
> %
> $ cat sampl...
Toomas Soome
08:34 AM Bug #14616 (New): dos2unix(1) breaks BOM text files, pkgsrc version is fine
Sample file attached.
@
$ /usr/bin/dos2unix sample.txt
���
%
$ cat sample.txt | /opt/local/bin/dos2unix
αβγδ...
Christoph Binner

2022-04-03

07:15 PM Bug #14541: nvme_quiesce() can hang preventing reboot
I've dug into this and have an explanation for what's happening. I'll give the summary, then outline how I arrived he... Jordan Hendricks
12:17 PM Bug #14614 (Closed): format: should recognize new nvme disk
Before patch:... Toomas Soome
12:07 PM Bug #14613 (Closed): format: cstyle cleanup
Clean it up. No functional changes intended.
Testing done: used format command to partition the disk and browse th...
Toomas Soome
05:54 AM Bug #14612 (Closed): idmap_cache_add_sid2pid() doesn't initialize winname_ttl, which can cause segfaults
In libidmap, the idmap cache '{gid/uid}2sid_winname' contains entries that can have either a SID or winname (or both)... Matt Barden

2022-04-02

09:04 PM Bug #14604 (Closed): bios enumerated serial should use 1275 compatible names
"git commit 07a53f3dc8bc5e4d64bde9b92063de65f06dcf19":https://github.com/illumos/illumos-gate/commit/07a53f3dc8bc5e4d... Electric Monk

2022-04-01

08:28 PM Bug #14611 (New): service management facility, not framework
At least one manual page incorrectly identifies SMF as the Service Management _Framework_, when it is indeed a _Facil... Joshua M. Clulow
07:43 PM Bug #14610 (New): scsi_hba_attach_setup(9f) should mention SCSI_HBA_TRAN_PHCI
The flag is very useful for HBA drivers to offload all of the mpxio interaction to the framework. Yuri Pankov
11:28 AM Bug #14609 (Closed): loader: os console in options menu should use first name from list
The current os_console setup in options menu is assuming single value set in console variable. Since all usable devic... Toomas Soome
11:24 AM Feature #14608 (Closed): ttymon should use tty-mode property
Update ttymon to identify serial device behind /dev/console and use ttyX-mode property value to set up the line.
T...
Toomas Soome
11:22 AM Feature #14607 (Closed): Add CONS_GETDEV so we can see which port is /dev/console
Patch developed by Joshua M. Clulow.
Add function to get back end device id for /dev/console, so we can identify i...
Toomas Soome
12:57 AM Bug #14604: bios enumerated serial should use 1275 compatible names
testing:
Booting on the affected system, and checking the compatible property on the serial was correctly formed
Rich Lowe

2022-03-31

09:05 PM Bug #14597: i40e debug code prints MAC addresses oddly
Electric Monk wrote in #note-4:
> "git commit 6158afa44672def05b584840435f36f75f5a291f":https://github.com/illumos/i...
Dan McDonald

2022-03-30

05:47 PM Bug #14605 (Closed): More incorrect cross-references in the manual
Following the integration of IPD4, I ran a check for incorrect cross references in the manual.
This picked out man...
Peter Tribble
05:21 PM Bug #14604 (Closed): bios enumerated serial should use 1275 compatible names
at present, serial enumerated by the BIOS as part of a workaround uses incorrectly formatted compatible properties.
...
Rich Lowe
03:56 PM Bug #14486 (Closed): bhyve needs instruction emul tests
"git commit 5103e761e384621c5728a6d1f4b0bfdc1be233a4":https://github.com/illumos/illumos-gate/commit/5103e761e384621c... Electric Monk
03:13 AM Bug #14486: bhyve needs instruction emul tests
While this was originally desired for testing instruction emulation, the first use case ended up being testing kernel... Patrick Mooney
03:56 PM Bug #14569 (Closed): bhyve should consolidate on hrtime
"git commit 5103e761e384621c5728a6d1f4b0bfdc1be233a4":https://github.com/illumos/illumos-gate/commit/5103e761e384621c... Electric Monk
02:49 AM Bug #14569: bhyve should consolidate on hrtime
To test, I booted and ran the normal battery of guests on both Intel and AMD hardware. After the update, CentOS gues... Patrick Mooney
03:51 PM Bug #13912 (Closed): viona should track held pages
"git commit db9aa506ce275f82ee72f31fc2e6e3c53d1212b7":https://github.com/illumos/illumos-gate/commit/db9aa506ce275f82... Electric Monk
12:04 AM Bug #13912: viona should track held pages
Initial testing consisted of booting and running the typical battery of guests, checking to see that their network co... Patrick Mooney

2022-03-29

10:42 PM Bug #14595: sd DLE events should cover the first two partitions
I tested this on OmniOS in a Gen.2 Hyper-V VM using a hv_storvsc disk, which uses an sd backend.
With this change in...
Andy Fiddaman
05:46 PM Bug #12315 (Closed): errors in section 4i of the manual
"git commit 899b7fc7762875c5244567fbc6bb4ccace75d6f7":https://github.com/illumos/illumos-gate/commit/899b7fc7762875c5... Electric Monk
03:18 PM Bug #12315: errors in section 4i of the manual
Testing: Viewed the modified pages with the man utility. Peter Tribble
05:33 PM Bug #14583 (Closed): developer/opensolaris/osnet requirements cleanup
"git commit a677d6730e287aadab3cc68d0c46fb01b25d72eb":https://github.com/illumos/illumos-gate/commit/a677d6730e287aad... Electric Monk
03:04 PM Bug #14603 (Closed): bhyve passthrough mishandles combined CMD/STATUS reads
An OmniOS user reported that booting a bhyve guest with an XHCI controller passed-through to it failed to boot with t... Andy Fiddaman
02:18 PM Bug #14597 (Closed): i40e debug code prints MAC addresses oddly
"git commit 6158afa44672def05b584840435f36f75f5a291f":https://github.com/illumos/illumos-gate/commit/6158afa44672def0... Electric Monk
12:55 AM Bug #14597: i40e debug code prints MAC addresses oddly
I also wrote a toy C program to compare %2x vs. %02x. I have this actual i40e fix running (along with WIP 13230) on ... Dan McDonald
11:33 AM Bug #14602 (Closed): ttymon: cleanup
Remove warning suppressions, enable smatch.
Fix prototypes and ansify.
clean up extern and globals.
cstyle cleanup...
Toomas Soome
01:06 AM Feature #14601: want 3-argument string comparison assertions
> What would you expect here? What would you want?
I had no idea what to expect here, but your implementation deta...
Dan McDonald
12:38 AM Feature #14601: want 3-argument string comparison assertions
Dan McDonald wrote in #note-1:
> What if some grinning weirdo expects, for example:
>
> [...]
>
> to work? Ma...
Thirteen Oxide
12:12 AM Feature #14601: want 3-argument string comparison assertions
What if some grinning weirdo expects, for example:... Dan McDonald
12:00 AM Feature #14601 (New): want 3-argument string comparison assertions
@ASSERT3x()@ and @VERIFY3x()@ are valuable debugging tools, but they are not useful replacements for @ASSERT(strcmp(x... Thirteen Oxide

2022-03-28

11:46 PM Bug #14593 (Closed): zpool online -e hangs forever after 14022
"git commit 7d6cab3f0d6a4cea17d062d3a93e223b15de705c":https://github.com/illumos/illumos-gate/commit/7d6cab3f0d6a4cea... Electric Monk
03:13 AM Bug #14593: zpool online -e hangs forever after 14022
h1. Testing Notes
I did an expansion in a QEMU guest, with a disk I had recently expanded by 200MB, with a @vioblk@ ...
Joshua M. Clulow
11:27 PM Feature #14600 (New): dkio(4I) needs an ioctl to re-read the disk label
As discovered in #14022 there are occasions where we would like to explicitly reload and revalidate a disk label that... Joshua M. Clulow
04:03 PM Bug #14570 (Closed): t4nex uses the wrong DDI register attributes
"git commit fe07c600e1e51d75e87d45aef001e9d6131ecdb8":https://github.com/illumos/illumos-gate/commit/fe07c600e1e51d75... Electric Monk
03:32 PM Bug #14599 (Closed): simplify bhyve MSR handling
The emulation for rdmsr/wrmsr actions in bhyve is a bit hodge-podge at the moment. Emulation which handles guest act... Patrick Mooney
03:30 PM Bug #14598 (Closed): bhyve vlapic should handle APICBASE changes
The existing LAPIC emulation in bhyve does not allow the GUEST to make changes to the APICBASE. While we do not, at ... Patrick Mooney
03:17 PM Bug #14597: i40e debug code prints MAC addresses oddly
I haven't formally tested a fixed i40e yet because inducing filter-errors is annoying. I do know ixgbe(4D) and cxgbe(... Dan McDonald
03:07 PM Bug #14597 (Closed): i40e debug code prints MAC addresses oddly
I saw an error of this form in my messages:... Dan McDonald
02:04 PM Bug #14596 (In Progress): cstyle should allow empty increment with for loop
Current cstyle can not handle constructs like 'for (expr; cond;)', even adding space before ')' does not help. Add ex... Toomas Soome
09:56 AM Bug #14595 (Closed): sd DLE events should cover the first two partitions
When @sd@ raises a dynamic LUN expansion (DLE) event, it does so for only the first partition on the disk, in contras... Andy Fiddaman
05:16 AM Bug #14594: psrinfo(1M) may fail to emit socket type
... Thirteen Oxide
02:36 AM Bug #14594 (Closed): psrinfo(1M) may fail to emit socket type
With SMT-enabled processors, psrinfo -pv does not emit the CPU's socket type even if it is known to the kernel:
<p...
Thirteen Oxide

2022-03-27

11:06 PM Bug #14593: zpool online -e hangs forever after 14022
I've decided to do something more surgical that shouldn't require extensive testing first, to stop the immediate brea... Joshua M. Clulow
05:01 AM Bug #14593: zpool online -e hangs forever after 14022
Hunting around a bit more, it seems like it would be more appropriate to introduce a new ioctl here, e.g., @DKIOCHECK... Joshua M. Clulow
04:26 AM Bug #14593 (Closed): zpool online -e hangs forever after 14022
#14022 added a @DKIOSTATE@ ioctl to the @zpool online -e@ path, which appears now to reliably hang at least on AWS sy... Joshua M. Clulow
06:30 PM Feature #14090: ld(1) could use a normal allocator
This was backed out as it introduced #14127, since fixed.
The same testing as then applies now, in addition jperkin ...
Rich Lowe
05:25 PM Bug #14590 (Closed): loader: replace boolean_t with bool in non-zfs code
"git commit ffd79eb680a8bd21d176389b06735eb297f89679":https://github.com/illumos/illumos-gate/commit/ffd79eb680a8bd21... Electric Monk
 

Also available in: Atom