9358 svc: this statement may fall through

Review Request #1005 - Created March 26, 2018 and submitted

Information
Toomas Soome
illumos-gate
9358
2e3bba7...
Reviewers
general
svccfg_xml.c:1620:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   for (p = pgs; *p; ++p) {
   ^~~
svccfg_xml.c:1629:2: note: here
  default: /* smf state transition tokens */
  ^~~~~~~

svcprop.c:388:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
    die(gettext("Invalid snapshot name.\n"));
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
svcprop.c:391:3: note: here
   case SCF_ERROR_NOT_FOUND:
   ^~~~
svcprop.c: In function 'do_wait':
svcprop.c:817:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
      die(emsg_not_found);
      ^~~~~~~~~~~~~~~~~~~
svcprop.c:821:5: note: here
     default:
     ^~~~~~~
svcprop.c:847:5: error: this statement may fall through [-Werror=implicit-fallthrough=]
     die(emsg_not_found);
     ^~~~~~~~~~~~~~~~~~~
svcprop.c:851:4: note: here
    default:
    ^~~~~~~
svcprop.c:868:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
      die(emsg_not_found);
      ^~~~~~~~~~~~~~~~~~~
svcprop.c:872:5: note: here
     default:
     ^~~~~~~
svcprop.c:896:5: error: this statement may fall through [-Werror=implicit-fallthrough=]
     die(emsg_not_found);
     ^~~~~~~~~~~~~~~~~~~
svcprop.c:898:4: note: here
    default:
    ^~~~~~~
svcprop.c:917:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
      die(emsg_not_found);
      ^~~~~~~~~~~~~~~~~~~
svcprop.c:921:5: note: here
     default:
     ^~~~~~~

svcs.c:1885:27: error: this statement may fall through [-Werror=implicit-fallthrough=]
 #define argserr(progname) print_usage(progname, stderr, B_TRUE)
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
svcs.c:3500:5: note: in expansion of macro 'argserr'
     argserr(progname);
     ^~~~~~~
svcs.c:3504:3: note: here
   case 'd':
   ^~~~
svcs.c:1885:27: error: this statement may fall through [-Werror=implicit-fallthrough=]
 #define argserr(progname) print_usage(progname, stderr, B_TRUE)
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
svcs.c:3611:4: note: in expansion of macro 'argserr'
    argserr(progname);
    ^~~~~~~
svcs.c:3614:3: note: here
   default:
   ^~~~~~~
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Andy Fiddaman
Jason King
Toomas Soome
Jason King
Toomas Soome
Andy Fiddaman
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...