9375 svr4pkg: this statement may fall through

Review Request #1018 - Created March 27, 2018 and updated

Information
Toomas Soome
illumos-gate
9375
8cec155...
Reviewers
general
pkginstall: this statement may fall through

main.c:897:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   usage();
   ^~~~~~~
main.c:899:2: note: here
  case 1: /* missing package instance */
  ^~~~
main.c:901:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   usage();
   ^~~~~~~
main.c:903:2: note: here
  case 2: /* just right! */
  ^~~~
cc1: all warnings being treated as errors

pkgremove: this statement may fall through

main.c:1311:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
   if (msg)
      ^
main.c:1313:6: note: here
      case 10:
      ^~~~
cc1: all warnings being treated as errors

pkgadm: this statement may fall through

lock.c: In function 'admin_lock':
lock.c:398:4: error: this statement may fall through [-Werror=implicit-fallthrough=]
    log_msg(LOG_MSG_ERR, MSG_MISSING_OPERAND, optopt);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
lock.c:400:3: note: here
   case '?':
   ^~~~
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Andrew Stormont
Andy Fiddaman
Toomas Soome
Review request changed

Commit:

-e9ad83d7da2cf15bc8c47036687787711abdcaf8
+8cec155c329c585c8296b8fdcbbe491028fe3331

Diff:

Revision 2 (+7 -6)

Show changes

C Fraire
Ship It!
John Levon
Ship It!
Loading...