9420 Makefile.master: introduce GCCNEXT to guard options gcc 4 doesn't understand

Reviews
Diff

- Download Diff

Information
Submitter:	Toomas Soome
Repository:	illumos-gate
Branch:
Bugs:	9420
Depends On:
Reviewers
Groups:	general
People:

Description

9420 Makefile.master: introduce GCCNEXT to guard options gcc 4 doesn't understand

Testing Done

Ship it!

Ship It!

usr/src/Makefile.master (Diff revision 1)

There must be a better way of doing this.  Something that's more flexible.  I know that there are folks that are going to hate me for saying this, but I think we should add some version specific variables.  FreeBSD does (or did) if I recall correctly.

Really what I want to see is something like this:

$(__GCCGT4)CCNOAUTOINLINE += -_gcc=-fno-ipa-icf
$(__GCCGT4)CCNOAUTOINLINE += -_gcc=-fno-clone-functions

Igor Kozhukhov April 1, 2018, 12:02 p.m.

it is NOT for gcc44, but can be related to gcc5 and next.
GCCNEXT or GCCNEW or something else - is more sutibl here.

Andrew Stormont April 9, 2018, 8:01 p.m.

__GCCGT4 meaning GCC > 4.  Sorry, thought that was obvious.

Commit:

-	8675a8c877dce02362314e151f62722913ab0210
+	9867b455c6070d8c273774ffb5f9461779efe1bb

Diff:

Revision 2 (+6)

Show changes

usr/src/Makefile.master

Do we want to introduce a next here versus using things based on the updated cw work that Rich did that let us define profiles for different compilers? 

It seems like that'll let us have what we want in terms of setting things on a per-compiler basis.

Toomas Soome April 9, 2018, 7:57 p.m.

to be really honest, I am not too sure which way is better. which is why I did decide to bring those updates up so we can think about those:)

I can only repeat what I said on the mailing list:

Wouldn't ccompile.h be the proper place for such compiler-specific settings?

Toomas Soome April 9, 2018, 7:57 p.m.

we can not provide compiler command line options in ccompile.h, can we?

Gary Mills April 9, 2018, 9:59 p.m.

The reason I suggested ccompile.h was that people might be compiling something other than illumos or other OS components. It might be useful to have various compilers work automatically.

An alternative would be the `cw' script, especially if it's translating options, rather than just adding them in certain cases.

Robert Mustacchi April 9, 2018, 10:03 p.m.

ccompile.h is for abstracting out compiler specific actions and setting it accross compilers that need to be implied by the pre-processor in source files. In this case, we're trying to set flags that make sense for the policy of illumos-gate, not creating generic infrastructure for notating items in source files.

cw should be mechansim, not policy.

Toomas Soome April 10, 2018, 5:47 a.m.

in fbsd bmake we have constructs like:
.if ${COMPILER_TYPE} != "gcc" || ${COMPILER_VERSION} >= 40500

SUBDIR.${MK_FDT}+=      fdt
SUBDIR.yes+=    libefi loader boot1

.endif # ${COMPILER_TYPE} != "gcc" || ${COMPILER_VERSION} >= 40500


And such constructs do allow setting compiler and compiler version specific settings. There was also some discussion on adding conditional statements to dmake, but I have no idea about the current state.
I actually do not like adding such magical variables, but with current dmake I do not see other solution...

You have a pending review.

Review Board 2.5.16

Screenshots

Files

Commit:

Diff:

Status: Discarded