6329 Need support for new link speeds in mac_ether 6330 Delete ETHER_STAT_ISMII macro

Review Request #107 — Created Oct. 19, 2015 and submitted

gdamore
illumos-gate
master
8735cc1...
general
6329 Need support for new link speeds in mac_ether 6330 Delete ETHER_STAT_ISMII macro

None yet apart from building. I will be testing this with 40GbE SolarFlare NICs soon. Unfortunately, I no longer have access to the systems with 2.5GbE igb -- those were backplane ports on a Supermicro microserver chassis, and while I ported illumos to that platform for Pluribus, I simply haven't got access anymore.

Testing will commence prior to RTI; this is merely to give some people a chance for early review and feedback -- I think the changes are low risk.

richlowe
  1. 
      
  2. I'm presuming that this now being true for 0 has no practical consequences?

    1. No, I don't think so.

  3. Fix this tab damage while you're here?

  4. usr/src/uts/common/sys/mac_ether.h (Diff revision 1)
     
     

    Was this just completely unused? Why did anyone need to know this?

    1. I looked it up on OpenGrok, and it was defined-but-never-used.

    2. Correct. It may have had a use in ancient days (S10), but I doubt even that is true.

  5. 
      
danmcd
  1. I'm fine with all of this. Thank you!!!

  2. 
      
trisk
  1. Looks reasonable. Reporting "2.5G" would better match convention than "2500M" but likely isn't worth the additional complexity.

  2. usr/src/uts/common/sys/mac_ether.h (Diff revision 1)
     
     

    Is there a good pattern for this that doesn't require constant updates (such as making NSTAT the last enum member)?

  3. 
      
kmays
  1. Ship It!
  2. 
      
gdamore
Review request changed

Status: Closed (submitted)

Loading...