6321 mountd: The IP to name translation is usually not needed in nfsauth_access()

Review Request #108 — Created Oct. 23, 2015 and submitted

marcel
illumos-gate
6321
general

webrev: http://cr.illumos.org/~webrev/marcel/il-mountd-notranslate/

I suggest to start the review in mountd.h by reading the struct cln declaration
and then in mountd.c at line 1068 (the CLN_CLNAMES define) till line 1199 (end
of the cln_gethost function).

I tested various known scenarios where the IP to name translation is not
needed, but it was done before.  Such cases include these sharing options:

# share -o iso8859-1=@10.0.0.1,rw=@10.0.0.1 /tmp

Without the fix both nfsauth_access() and charmap_search() asked for the IP to
name translation.  With the fix no IP to name translation was done there.

During the tests, I ran mountd with umem_debug turned on to find any possible
memory leaks.
marcel
Review request changed

Status: Closed (submitted)

Change Summary:

commit a9685eaab1313767d1d4dac672c3a468519aa899
Author:     Marcel Telka <marcel.telka@nexenta.com>
AuthorDate: Thu Oct 15 09:00:58 2015 +0200
Commit:     Robert Mustacchi <rm@joyent.com>
CommitDate: Mon Nov 2 17:56:05 2015 -0800

    6321 mountd: The IP to name translation is usually not needed in nfsauth_access()
    Reviewed by: Gordon Ross <gordon.ross@nexenta.com>
    Approved by: Robert Mustacchi <rm@joyent.com>

:100644 100644 50180d3... 150455f... M  usr/src/cmd/fs.d/nfs/mountd/mountd.c
:100644 100644 1bc7b08... 85a506e... M  usr/src/cmd/fs.d/nfs/mountd/mountd.h
:100644 100644 fba58fa... b92a862... M  usr/src/cmd/fs.d/nfs/mountd/nfs_cmd.c
:100644 100644 34a9717... fe49f91... M  usr/src/cmd/fs.d/nfs/mountd/nfsauth.c
Loading...