9625 krb5: logger.c was duplicated

Review Request #1089 - Created May 24, 2018 and updated

Information
Andrew Stormont
illumos-gate
Reviewers
general

When src/lib/kadm5/logger.c was integrated it was copied to two locations:

usr/src/lib/krb5/kadm5/clnt/logger.c
usr/src/lib/krb5/kadm5/srv/logger.c

The two files have also been modified and are now out of sync.

Tested build only.

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
Andrew Stormont
Andrew Stormont
Review request changed

Status: Re-opened

Summary:

+9625 krb5: logger.c was duplicated

Description:

  +

When src/lib/kadm5/logger.c was integrated it was copied to two locations:

  +
  +

usr/src/lib/krb5/kadm5/clnt/logger.c

  + usr/src/lib/krb5/kadm5/srv/logger.c

  +
  +

The two files have also been modified and are now out of sync.

Testing Done:

  +

Tested build only.

Diff:

Revision 1 (+20 -1180)

Andy Fiddaman
Ship It!
Gergő Mihály Doma

   
usr/src/lib/krb5/kadm5/logger.c (Diff revision 1)
 
 

The default case should be to return back with the UFO string ("???"), meaning unknown errorno supplied.

I think aborting without any notification is a bit too strict, and this modification changes the original behaviour of the code.

  1. In my reading of the code that case was basically unreachable. The "abort" is just there to keep the compiler happy.

  2. Ok.
Gergő Mihály Doma
Ship It!
Ken Mays
Ship It!
Loading...