9538 rcapd make install fails due to race in subdirs (fix isaexec)

Review Request #1098 - Created June 3, 2018 and submitted

Information
Toomas Soome
illumos-gate
9538
6982941...
Reviewers
general
The isaexec install is ensured by cmd/Makefile, having it in rcapd/Makefile
will cause isaexec reinstalled and this will break hardlink check

make install does not cause removal of isaexec:

tsoome@beastie:/code/illumos-gate/usr/src/cmd/rcap$ dmake install
/code/illumos-gate/usr/src/cmd/rcap/rcapadm
/usr/bin/rm -f /code/illumos-gate/proto/root_i386/usr/sbin/rcapadm; /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/install -s -m 0555 -f /code/illumos-gate/proto/root_i386/usr/sbin rcapadm
/code/illumos-gate/usr/src/cmd/rcap/rcapd
/code/illumos-gate/usr/src/cmd/rcap/rcapd/i386
/code/illumos-gate/usr/src/cmd/rcap/rcapd/amd64
/code/illumos-gate/usr/src/cmd/rcap/rcapd/i386
/usr/bin/rm -f /code/illumos-gate/proto/root_i386/usr/lib/rcap/i86/rcapd; /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/install -s -m 0555 -f /code/illumos-gate/proto/root_i386/usr/lib/rcap/i86 rcapd
/code/illumos-gate/usr/src/cmd/rcap/rcapd/amd64
/usr/bin/rm -f /code/illumos-gate/proto/root_i386/usr/lib/rcap/amd64/rcapd; /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/install -s -m 0555 -f /code/illumos-gate/proto/root_i386/usr/lib/rcap/amd64 rcapd
/usr/bin/rm -f /code/illumos-gate/proto/root_i386/usr/lib/rcap/rcapd
ln /code/illumos-gate/proto/root_i386/usr/lib/isaexec /code/illumos-gate/proto/root_i386/usr/lib/rcap/rcapd
/code/illumos-gate/usr/src/cmd/rcap/rcapstat
/usr/bin/rm -f /code/illumos-gate/proto/root_i386/usr/bin/rcapstat; /code/illumos-gate/usr/src/tools/proto/root_i386-nd/opt/onbld/bin/i386/install -s -m 0555 -f /code/illumos-gate/proto/root_i386/usr/bin rcapstat
tsoome@beastie:/code/illumos-gate/usr/src/cmd/rcap$

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Toomas Soome
Andrew Stormont
Yuri Pankov
Toomas Soome
Yuri Pankov
Yuri Pankov
Andrew Stormont
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...