9607 qede: this statement may fall through

Review Request #1108 - Created June 15, 2018 and updated

Information
Toomas Soome
illumos-gate
9607
9c98123...
Reviewers
general
../../common/io/qede/579xx/drivers/ecore/ecore_dev.c: In function 'ecore_hw_init':
../../common/io/qede/579xx/drivers/ecore/ecore_dev.c:2219:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
    if (rc != ECORE_SUCCESS)
       ^
../../common/io/qede/579xx/drivers/ecore/ecore_dev.c:2222:3: note: here
   case FW_MSG_CODE_DRV_LOAD_PORT:
   ^~~~
../../common/io/qede/579xx/drivers/ecore/ecore_dev.c:2225:7: error: this statement may fall through [-Werror=implicit-fallthrough=]
    if (rc != ECORE_SUCCESS)
       ^
../../common/io/qede/579xx/drivers/ecore/ecore_dev.c:2228:3: note: here
   case FW_MSG_CODE_DRV_LOAD_FUNCTION:
   ^~~~

../../common/io/qede/579xx/drivers/ecore/ecore_cxt.c: In function 'ecore_cxt_set_pf_params':
../../common/io/qede/579xx/drivers/ecore/ecore_cxt.c:2229:3: error: this statement may fall through [-Werror=implicit-fallthrough=]
   ecore_rdma_set_pf_params(p_hwfn,
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       &p_hwfn->pf_params.rdma_pf_params,
       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
       rdma_tasks);
       ~~~~~~~~~~~
../../common/io/qede/579xx/drivers/ecore/ecore_cxt.c:2235:2: note: here
  case ECORE_PCI_ETH:
  ^~~~

cc1: all warnings being treated as errors

  
Andy Fiddaman
Andrew Stormont
Yuri Pankov
Toomas Soome
Review request changed

Commit:

-57373a2e5178e949f9ea0ed1b57bbe966e99161d
+9c98123591dda927cbbed3aa437d9f2d0a760bca

Diff:

Revision 2 (+3 -4)

Show changes

Andrew Stormont
Ship It!
Ken Mays
Ship It!
Loading...