Toomas Soome got a fish trophy!

9610 qede: error: left shift of negative value

Review Request #1111 - Created June 15, 2018 and updated

Information
Toomas Soome
illumos-gate
9610
f55723d...
Reviewers
general
In file included from ../../common/io/qede/579xx/drivers/ecore/ecore_hw.h:39:0,
                 from ../../common/io/qede/579xx/drivers/ecore/ecore_init_fw_funcs.c:37:
../../common/io/qede/579xx/drivers/ecore/ecore_init_fw_funcs.c: In function 'ecore_send_qm_stop_cmd':
../../common/io/qede/579xx/drivers/ecore/ecore.h:114:27: error: left shift of negative value [-Werror=shift-negative-value]
  (value) &= ~(name##_MASK << name##_SHIFT);   \
                           ^
../../common/io/qede/579xx/drivers/ecore/ecore_init_fw_funcs.c:157:52: note: in expansion of macro 'SET_FIELD'
 #define QM_CMD_SET_FIELD(var, cmd, field, value)   SET_FIELD(var[cmd##_##field##_OFFSET], cmd##_##field, value)
                                                    ^~~~~~~~~
../../common/io/qede/579xx/drivers/ecore/ecore_init_fw_funcs.c:860:4: note: in expansion of macro 'QM_CMD_SET_FIELD'
    QM_CMD_SET_FIELD(cmd_arr, QM_STOP_CMD, PAUSE_MASK, pq_mask);
    ^
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Vitaliy Gusev
Toomas Soome
Review request changed

Change Summary:

Real fix from Anand Khoje @cavium

Commit:

-dcdb6cc51244c553a1a76544c7a706e1cb4db3b8
+f55723dd4b6fb4e6224f2286fce63b802906a6da

Diff:

Revision 2 (+3 -3)

Show changes

Loading...